LuciferYang commented on a change in pull request #29000:
URL: https://github.com/apache/spark/pull/29000#discussion_r472737943
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/PartitionedWriteSuite.scala
##
@@ -164,4 +165,48 @@ class PartitionedWriteSuite
HyukjinKwon removed a comment on pull request #29460:
URL: https://github.com/apache/spark/pull/29460#issuecomment-675390620
All tests passed (I am re-running to verify flakiness) except two tests:
- `ThriftServerQueryTestSuite`:
```
[info]
SparkQA commented on pull request #29473:
URL: https://github.com/apache/spark/pull/29473#issuecomment-675875114
**[Test build #127609 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127609/testReport)**
for PR 29473 at commit
HyukjinKwon edited a comment on pull request #29456:
URL: https://github.com/apache/spark/pull/29456#issuecomment-675874159
I merged into branch-3.0 and branch-2.4 as well. cc @zhengruifeng and
@ScrapCodes . this is test-only so should be fine.
cloud-fan commented on a change in pull request #29469:
URL: https://github.com/apache/spark/pull/29469#discussion_r472758250
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/AlreadyPlanned.scala
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software
cloud-fan commented on a change in pull request #29469:
URL: https://github.com/apache/spark/pull/29469#discussion_r472758250
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/AlreadyPlanned.scala
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software
SparkQA commented on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675880439
**[Test build #127625 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127625/testReport)**
for PR 29452 at commit
agrawaldevesh commented on pull request #29468:
URL: https://github.com/apache/spark/pull/29468#issuecomment-675883231
Thanks for updating the PR description. Now all we need is a real test to
validate that the PR is actually fixing the delay scheduling issue you pointed
out. The current
cloud-fan commented on a change in pull request #29452:
URL: https://github.com/apache/spark/pull/29452#discussion_r472767373
##
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##
@@ -926,18 +926,21 @@ private[spark] class TaskSchedulerImpl(
AmplabJenkins removed a comment on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675891103
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29437:
URL: https://github.com/apache/spark/pull/29437#issuecomment-675893274
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #29474:
URL: https://github.com/apache/spark/pull/29474#issuecomment-675893141
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #29465:
URL: https://github.com/apache/spark/pull/29465#issuecomment-675858327
**[Test build #127622 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127622/testReport)**
for PR 29465 at commit
SparkQA removed a comment on pull request #29434:
URL: https://github.com/apache/spark/pull/29434#issuecomment-675838022
**[Test build #127618 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127618/testReport)**
for PR 29434 at commit
AmplabJenkins commented on pull request #29465:
URL: https://github.com/apache/spark/pull/29465#issuecomment-675893553
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28953:
URL: https://github.com/apache/spark/pull/28953#issuecomment-675893267
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29453:
URL: https://github.com/apache/spark/pull/29453#issuecomment-675893548
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28953:
URL: https://github.com/apache/spark/pull/28953#issuecomment-675844652
**[Test build #127620 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127620/testReport)**
for PR 28953 at commit
AmplabJenkins removed a comment on pull request #29469:
URL: https://github.com/apache/spark/pull/29469#issuecomment-675893281
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #29453:
URL: https://github.com/apache/spark/pull/29453#issuecomment-675841543
**[Test build #127619 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127619/testReport)**
for PR 29453 at commit
AmplabJenkins removed a comment on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675893163
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #29437:
URL: https://github.com/apache/spark/pull/29437#issuecomment-675862392
**[Test build #127624 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127624/testReport)**
for PR 29437 at commit
SparkQA removed a comment on pull request #29469:
URL: https://github.com/apache/spark/pull/29469#issuecomment-675862342
**[Test build #127623 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127623/testReport)**
for PR 29469 at commit
SparkQA removed a comment on pull request #29474:
URL: https://github.com/apache/spark/pull/29474#issuecomment-675890659
**[Test build #127626 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127626/testReport)**
for PR 29474 at commit
AmplabJenkins commented on pull request #29474:
URL: https://github.com/apache/spark/pull/29474#issuecomment-675893141
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29437:
URL: https://github.com/apache/spark/pull/29437#issuecomment-675893102
**[Test build #127624 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127624/testReport)**
for PR 29437 at commit
SparkQA removed a comment on pull request #29460:
URL: https://github.com/apache/spark/pull/29460#issuecomment-675829698
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29469:
URL: https://github.com/apache/spark/pull/29469#issuecomment-675893281
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28953:
URL: https://github.com/apache/spark/pull/28953#issuecomment-675893267
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29465:
URL: https://github.com/apache/spark/pull/29465#issuecomment-675893100
**[Test build #127622 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127622/testReport)**
for PR 29465 at commit
AmplabJenkins commented on pull request #29437:
URL: https://github.com/apache/spark/pull/29437#issuecomment-675893274
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675893163
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28953:
URL: https://github.com/apache/spark/pull/28953#issuecomment-675893114
**[Test build #127620 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127620/testReport)**
for PR 28953 at commit
SparkQA commented on pull request #29474:
URL: https://github.com/apache/spark/pull/29474#issuecomment-675893108
**[Test build #127626 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127626/testReport)**
for PR 29474 at commit
SparkQA commented on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675893109
**[Test build #127627 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127627/testReport)**
for PR 29452 at commit
SparkQA commented on pull request #29460:
URL: https://github.com/apache/spark/pull/29460#issuecomment-675893019
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on pull request #29453:
URL: https://github.com/apache/spark/pull/29453#issuecomment-675893110
**[Test build #127619 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127619/testReport)**
for PR 29453 at commit
SparkQA commented on pull request #29469:
URL: https://github.com/apache/spark/pull/29469#issuecomment-675893101
**[Test build #127623 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127623/testReport)**
for PR 29469 at commit
SparkQA commented on pull request #29434:
URL: https://github.com/apache/spark/pull/29434#issuecomment-675893104
**[Test build #127618 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127618/testReport)**
for PR 29434 at commit
SparkQA removed a comment on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675890700
**[Test build #127627 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127627/testReport)**
for PR 29452 at commit
HyukjinKwon edited a comment on pull request #29460:
URL: https://github.com/apache/spark/pull/29460#issuecomment-675831293
Should be ready to be reviewed or go merging.
Arrow related SparkR tests which will be fixed at #29462.
AmplabJenkins commented on pull request #29473:
URL: https://github.com/apache/spark/pull/29473#issuecomment-675876095
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29473:
URL: https://github.com/apache/spark/pull/29473#issuecomment-675876095
This is an automated message from the Apache Git Service.
To respond to the message, please log on
agrawaldevesh commented on a change in pull request #29468:
URL: https://github.com/apache/spark/pull/29468#discussion_r472762189
##
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##
@@ -1062,25 +1062,36 @@ private[spark] class
AmplabJenkins removed a comment on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675881350
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
cloud-fan commented on a change in pull request #29452:
URL: https://github.com/apache/spark/pull/29452#discussion_r472769129
##
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##
@@ -1051,15 +1049,21 @@ private[spark] class TaskSetManager(
cloud-fan closed pull request #29466:
URL: https://github.com/apache/spark/pull/29466
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cloud-fan commented on pull request #29466:
URL: https://github.com/apache/spark/pull/29466#issuecomment-675888359
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the
agrawaldevesh commented on a change in pull request #29455:
URL: https://github.com/apache/spark/pull/29455#discussion_r472772355
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
##
@@ -83,15 +83,18 @@ trait
jiangxb1987 commented on pull request #29474:
URL: https://github.com/apache/spark/pull/29474#issuecomment-675889531
cc @mccheah @cloud-fan @Ngone51 @zhengruifeng
This is an automated message from the Apache Git Service.
To
HyukjinKwon commented on pull request #29456:
URL: https://github.com/apache/spark/pull/29456#issuecomment-675874159
I merged into branch-3.0 as well. cc @zhengruifeng. this is test-only so
should be fine.
This is an
SparkQA removed a comment on pull request #29473:
URL: https://github.com/apache/spark/pull/29473#issuecomment-675797404
**[Test build #127609 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127609/testReport)**
for PR 29473 at commit
agrawaldevesh commented on a change in pull request #29452:
URL: https://github.com/apache/spark/pull/29452#discussion_r472756046
##
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##
@@ -1051,15 +1049,19 @@ private[spark] class TaskSetManager(
SparkQA commented on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675881324
**[Test build #127625 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127625/testReport)**
for PR 29452 at commit
AmplabJenkins removed a comment on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675881340
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
agrawaldevesh commented on a change in pull request #29468:
URL: https://github.com/apache/spark/pull/29468#discussion_r472760587
##
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##
@@ -1062,25 +1062,36 @@ private[spark] class
AmplabJenkins commented on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675881340
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675880439
**[Test build #127625 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127625/testReport)**
for PR 29452 at commit
AmplabJenkins removed a comment on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675880787
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675880787
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jiangxb1987 opened a new pull request #29474:
URL: https://github.com/apache/spark/pull/29474
# What changes were proposed in this pull request?
The `count` in `PartitionWriterStream` should be a long value, instead of
int. The issue is introduced by apache/spark@abef84a . When the
AmplabJenkins commented on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675891086
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29474:
URL: https://github.com/apache/spark/pull/29474#issuecomment-675891005
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675891086
Merged build finished. Test PASSed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #29474:
URL: https://github.com/apache/spark/pull/29474#issuecomment-675891005
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29474:
URL: https://github.com/apache/spark/pull/29474#issuecomment-675890659
**[Test build #127626 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127626/testReport)**
for PR 29474 at commit
SparkQA commented on pull request #29452:
URL: https://github.com/apache/spark/pull/29452#issuecomment-675890700
**[Test build #127627 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127627/testReport)**
for PR 29452 at commit
AmplabJenkins commented on pull request #29434:
URL: https://github.com/apache/spark/pull/29434#issuecomment-675893688
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29434:
URL: https://github.com/apache/spark/pull/29434#issuecomment-675893688
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #28953:
URL: https://github.com/apache/spark/pull/28953#issuecomment-675893272
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins commented on pull request #29460:
URL: https://github.com/apache/spark/pull/29460#issuecomment-675893985
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29465:
URL: https://github.com/apache/spark/pull/29465#issuecomment-675893553
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #29474:
URL: https://github.com/apache/spark/pull/29474#issuecomment-675893147
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29469:
URL: https://github.com/apache/spark/pull/29469#issuecomment-675893286
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29437:
URL: https://github.com/apache/spark/pull/29437#issuecomment-675893283
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29460:
URL: https://github.com/apache/spark/pull/29460#issuecomment-675893985
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan commented on a change in pull request #29468:
URL: https://github.com/apache/spark/pull/29468#discussion_r472786561
##
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##
@@ -1062,25 +1062,36 @@ private[spark] class
AmplabJenkins removed a comment on pull request #29465:
URL: https://github.com/apache/spark/pull/29465#issuecomment-675893566
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29453:
URL: https://github.com/apache/spark/pull/29453#issuecomment-675893555
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29434:
URL: https://github.com/apache/spark/pull/29434#issuecomment-675893692
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
cloud-fan closed pull request #29418:
URL: https://github.com/apache/spark/pull/29418
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cloud-fan commented on pull request #29418:
URL: https://github.com/apache/spark/pull/29418#issuecomment-675962204
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the
LuciferYang commented on a change in pull request #29434:
URL: https://github.com/apache/spark/pull/29434#discussion_r472861979
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/StarJoinCostBasedReorderSuite.scala
##
@@ -329,7 +329,7 @@ class
wangyum opened a new pull request #29475:
URL: https://github.com/apache/spark/pull/29475
### What changes were proposed in this pull request?
Replace `Array` with `Set` in `InSubqueryExec`.
### Why are the changes needed?
Set has better performance:
Ngone51 commented on pull request #29418:
URL: https://github.com/apache/spark/pull/29418#issuecomment-675971368
thanks all!!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29475:
URL: https://github.com/apache/spark/pull/29475#issuecomment-675978958
**[Test build #127637 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127637/testReport)**
for PR 29475 at commit
AmplabJenkins commented on pull request #29475:
URL: https://github.com/apache/spark/pull/29475#issuecomment-675980722
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29475:
URL: https://github.com/apache/spark/pull/29475#issuecomment-675980722
This is an automated message from the Apache Git Service.
To respond to the message, please log on
LuciferYang commented on a change in pull request #29434:
URL: https://github.com/apache/spark/pull/29434#discussion_r472861979
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/StarJoinCostBasedReorderSuite.scala
##
@@ -329,7 +329,7 @@ class
LuciferYang commented on a change in pull request #29434:
URL: https://github.com/apache/spark/pull/29434#discussion_r472861979
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/StarJoinCostBasedReorderSuite.scala
##
@@ -329,7 +329,7 @@ class
cloud-fan commented on a change in pull request #29438:
URL: https://github.com/apache/spark/pull/29438#discussion_r472878919
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
##
@@ -330,4 +330,42 @@ class SparkSqlParserSuite
AngersZh commented on a change in pull request #29438:
URL: https://github.com/apache/spark/pull/29438#discussion_r472881479
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
##
@@ -330,4 +330,42 @@ class SparkSqlParserSuite
cloud-fan commented on a change in pull request #29434:
URL: https://github.com/apache/spark/pull/29434#discussion_r472881899
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/StarJoinCostBasedReorderSuite.scala
##
@@ -329,7 +329,7 @@ class
cloud-fan commented on pull request #29438:
URL: https://github.com/apache/spark/pull/29438#issuecomment-676005317
the fix looks good, can you resolve conflicts?
This is an automated message from the Apache Git Service.
To
HyukjinKwon commented on pull request #29465:
URL: https://github.com/apache/spark/pull/29465#issuecomment-676006546
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon removed a comment on pull request #29465:
URL: https://github.com/apache/spark/pull/29465#issuecomment-675905000
retest this please
This is an automated message from the Apache Git Service.
To respond to the
SparkQA commented on pull request #29465:
URL: https://github.com/apache/spark/pull/29465#issuecomment-676008617
**[Test build #127638 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127638/testReport)**
for PR 29465 at commit
LuciferYang commented on a change in pull request #29434:
URL: https://github.com/apache/spark/pull/29434#discussion_r472885119
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/StarJoinCostBasedReorderSuite.scala
##
@@ -329,7 +329,7 @@ class
AmplabJenkins commented on pull request #29465:
URL: https://github.com/apache/spark/pull/29465#issuecomment-676010471
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cloud-fan commented on pull request #29421:
URL: https://github.com/apache/spark/pull/29421#issuecomment-676012804
can you list the behaviors of both w/ serde and w/o serde? We need to
understand why we only need to fix the w/ serde case.
1 - 100 of 637 matches
Mail list logo