LuciferYang commented on pull request #29638:
URL: https://github.com/apache/spark/pull/29638#issuecomment-686426028
@srowen @dongjoon-hyun this issue also blocking the progress of `sql/core`
module pass all test in Scala 2.13, some test failed of
`TPCDSV2_7_PlanStabilityWithStatsSuite `
LuciferYang commented on pull request #29638:
URL: https://github.com/apache/spark/pull/29638#issuecomment-686424926
cc @srowen @cloud-fan @HyukjinKwon @dongjoon-hyun, this pr try to resolved
the problems we discuss in
[SPARK-32526](https://github.com/apache/spark/pull/29434)
AmplabJenkins commented on pull request #29638:
URL: https://github.com/apache/spark/pull/29638#issuecomment-686426159
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
cloud-fan commented on a change in pull request #29635:
URL: https://github.com/apache/spark/pull/29635#discussion_r482925854
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/IntervalUtilsSuite.scala
##
@@ -77,6 +77,19 @@ class IntervalUtilsSuite
cloud-fan commented on a change in pull request #29635:
URL: https://github.com/apache/spark/pull/29635#discussion_r482926096
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/IntervalUtilsSuite.scala
##
@@ -77,6 +77,19 @@ class IntervalUtilsSuite
LuciferYang commented on pull request #29638:
URL: https://github.com/apache/spark/pull/29638#issuecomment-686443563
There are too many conflicting files after SPARK-32755, I will resolve it
first
This is an automated
SparkQA commented on pull request #29572:
URL: https://github.com/apache/spark/pull/29572#issuecomment-686469946
**[Test build #128243 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128243/testReport)**
for PR 29572 at commit
cloud-fan commented on pull request #28754:
URL: https://github.com/apache/spark/pull/28754#issuecomment-686469919
I believe the conclusion is to manually do date average in the `summary`
method, (cast to int, run average, and cast back to date). I don't think we
should allow the
SparkQA removed a comment on pull request #29572:
URL: https://github.com/apache/spark/pull/29572#issuecomment-686322900
**[Test build #128243 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128243/testReport)**
for PR 29572 at commit
AmplabJenkins commented on pull request #29579:
URL: https://github.com/apache/spark/pull/29579#issuecomment-686480213
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Karl-WangSK commented on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-686560052
ready to merge if no other problems @LuciferYang Thanks!
This is an automated message from the Apache Git
SparkQA commented on pull request #29637:
URL: https://github.com/apache/spark/pull/29637#issuecomment-686566140
**[Test build #128253 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128253/testReport)**
for PR 29637 at commit
SparkQA removed a comment on pull request #29637:
URL: https://github.com/apache/spark/pull/29637#issuecomment-686404704
**[Test build #128253 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128253/testReport)**
for PR 29637 at commit
AmplabJenkins commented on pull request #29638:
URL: https://github.com/apache/spark/pull/29638#issuecomment-686433941
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Ngone51 commented on a change in pull request #29558:
URL: https://github.com/apache/spark/pull/29558#discussion_r482915559
##
File path: core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala
##
@@ -130,25 +130,33 @@ private[spark] class TorrentBroadcast[T:
SparkQA commented on pull request #29638:
URL: https://github.com/apache/spark/pull/29638#issuecomment-686441850
**[Test build #128257 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128257/testReport)**
for PR 29638 at commit
AmplabJenkins removed a comment on pull request #29638:
URL: https://github.com/apache/spark/pull/29638#issuecomment-686441876
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA commented on pull request #29637:
URL: https://github.com/apache/spark/pull/29637#issuecomment-686452252
**[Test build #128259 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128259/testReport)**
for PR 29637 at commit
AmplabJenkins commented on pull request #29637:
URL: https://github.com/apache/spark/pull/29637#issuecomment-686453086
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28781:
URL: https://github.com/apache/spark/pull/28781#issuecomment-686452670
**[Test build #128247 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128247/testReport)**
for PR 28781 at commit
SparkQA removed a comment on pull request #28781:
URL: https://github.com/apache/spark/pull/28781#issuecomment-686371014
**[Test build #128247 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128247/testReport)**
for PR 28781 at commit
AmplabJenkins commented on pull request #29572:
URL: https://github.com/apache/spark/pull/29572#issuecomment-686471285
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29572:
URL: https://github.com/apache/spark/pull/29572#issuecomment-686471285
This is an automated message from the Apache Git Service.
To respond to the message, please log on
HyukjinKwon commented on pull request #29639:
URL: https://github.com/apache/spark/pull/29639#issuecomment-686472391
FWIW, documenting such setup in a language dedicated page isn't a radical
approach. We're already doing it for RStudio and SparkR at
peter-toth commented on pull request #29572:
URL: https://github.com/apache/spark/pull/29572#issuecomment-686547055
Thanks for the review @cloud-fan, @maropu, @viirya.
This is an automated message from the Apache Git
SparkQA commented on pull request #29638:
URL: https://github.com/apache/spark/pull/29638#issuecomment-686433259
**[Test build #128256 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128256/testReport)**
for PR 29638 at commit
SparkQA commented on pull request #29627:
URL: https://github.com/apache/spark/pull/29627#issuecomment-686439935
**[Test build #128237 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128237/testReport)**
for PR 29627 at commit
maropu commented on a change in pull request #29637:
URL: https://github.com/apache/spark/pull/29637#discussion_r482926633
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3684,6 +3684,13 @@ class SQLQuerySuite extends QueryTest with
cloud-fan commented on a change in pull request #29580:
URL: https://github.com/apache/spark/pull/29580#discussion_r482927273
##
File path: core/src/main/scala/org/apache/spark/rpc/netty/Inbox.scala
##
@@ -200,6 +200,16 @@ private[netty] class Inbox(val endpointName: String,
SparkQA commented on pull request #29639:
URL: https://github.com/apache/spark/pull/29639#issuecomment-686456423
**[Test build #128260 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128260/testReport)**
for PR 29639 at commit
AmplabJenkins commented on pull request #29639:
URL: https://github.com/apache/spark/pull/29639#issuecomment-686456991
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
manuzhang commented on a change in pull request #29593:
URL: https://github.com/apache/spark/pull/29593#discussion_r482953408
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##
@@ -91,7 +91,11 @@ abstract class TreeNode[BaseType <:
SparkQA commented on pull request #29572:
URL: https://github.com/apache/spark/pull/29572#issuecomment-686475839
**[Test build #128242 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128242/testReport)**
for PR 29572 at commit
SparkQA removed a comment on pull request #29572:
URL: https://github.com/apache/spark/pull/29572#issuecomment-686319217
**[Test build #128242 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128242/testReport)**
for PR 29572 at commit
Ngone51 commented on pull request #29000:
URL: https://github.com/apache/spark/pull/29000#issuecomment-686486333
LGTM, cc @cloud-fan @xuanyuanking @turboFei
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29608:
URL: https://github.com/apache/spark/pull/29608#issuecomment-686500830
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29608:
URL: https://github.com/apache/spark/pull/29608#issuecomment-686375088
**[Test build #128249 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128249/testReport)**
for PR 29608 at commit
AmplabJenkins removed a comment on pull request #29608:
URL: https://github.com/apache/spark/pull/29608#issuecomment-686500845
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
WinkerDu commented on pull request #29000:
URL: https://github.com/apache/spark/pull/29000#issuecomment-686516518
Thanks @Ngone51 , gentle ping @cloud-fan @xuanyuanking for further review
This is an automated message from
SparkQA commented on pull request #29636:
URL: https://github.com/apache/spark/pull/29636#issuecomment-686535677
**[Test build #128250 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128250/testReport)**
for PR 29636 at commit
cloud-fan commented on pull request #29485:
URL: https://github.com/apache/spark/pull/29485#issuecomment-686544310
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the
cloud-fan closed pull request #29485:
URL: https://github.com/apache/spark/pull/29485
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
SparkQA removed a comment on pull request #29572:
URL: https://github.com/apache/spark/pull/29572#issuecomment-686304845
**[Test build #128238 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128238/testReport)**
for PR 29572 at commit
maropu commented on a change in pull request #29637:
URL: https://github.com/apache/spark/pull/29637#discussion_r482927828
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
##
@@ -154,9 +154,12 @@ object
SparkQA commented on pull request #29572:
URL: https://github.com/apache/spark/pull/29572#issuecomment-686444628
**[Test build #128238 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128238/testReport)**
for PR 29572 at commit
SparkQA commented on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-686444651
**[Test build #128258 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128258/testReport)**
for PR 29410 at commit
HyukjinKwon commented on pull request #28754:
URL: https://github.com/apache/spark/pull/28754#issuecomment-686469036
So will we only allow in `summary` API?
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-686444651
**[Test build #128258 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128258/testReport)**
for PR 29410 at commit
AmplabJenkins removed a comment on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-686466389
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29572:
URL: https://github.com/apache/spark/pull/29572#issuecomment-686477951
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29579:
URL: https://github.com/apache/spark/pull/29579#issuecomment-686478252
**[Test build #128251 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128251/testReport)**
for PR 29579 at commit
SparkQA removed a comment on pull request #29579:
URL: https://github.com/apache/spark/pull/29579#issuecomment-686386785
**[Test build #128251 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128251/testReport)**
for PR 29579 at commit
SparkQA commented on pull request #29626:
URL: https://github.com/apache/spark/pull/29626#issuecomment-686484035
**[Test build #128240 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128240/testReport)**
for PR 29626 at commit
SparkQA removed a comment on pull request #29626:
URL: https://github.com/apache/spark/pull/29626#issuecomment-686319171
**[Test build #128240 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128240/testReport)**
for PR 29626 at commit
srowen commented on a change in pull request #29634:
URL: https://github.com/apache/spark/pull/29634#discussion_r482980446
##
File path: python/docs/source/development/testing.rst
##
@@ -0,0 +1,61 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+or more
tgravescs commented on a change in pull request #29630:
URL: https://github.com/apache/spark/pull/29630#discussion_r482980562
##
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##
@@ -471,7 +471,7 @@ private[history] class
tgravescs commented on pull request #29629:
URL: https://github.com/apache/spark/pull/29629#issuecomment-686495293
note this is related to https://github.com/apache/spark/pull/29630 to add
support for multiple clusters to history server
wzhfy commented on pull request #29636:
URL: https://github.com/apache/spark/pull/29636#issuecomment-686513240
also cc @cloud-fan @wangyum
This is an automated message from the Apache Git Service.
To respond to the message,
LuciferYang commented on pull request #29608:
URL: https://github.com/apache/spark/pull/29608#issuecomment-686512873
@maropu ` org.apache.spark.sql.hive.thriftserver.CliSuite.*` failed... I
think It doesn't seem to be caused by this pr, can you help trigger retest?
cloud-fan commented on pull request #29572:
URL: https://github.com/apache/spark/pull/29572#issuecomment-686523440
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the
AmplabJenkins removed a comment on pull request #29636:
URL: https://github.com/apache/spark/pull/29636#issuecomment-686537290
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29635:
URL: https://github.com/apache/spark/pull/29635#issuecomment-686547718
**[Test build #128261 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128261/testReport)**
for PR 29635 at commit
yaooqinn commented on a change in pull request #29635:
URL: https://github.com/apache/spark/pull/29635#discussion_r483040796
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/IntervalUtilsSuite.scala
##
@@ -77,6 +77,19 @@ class IntervalUtilsSuite
LuciferYang commented on pull request #29608:
URL: https://github.com/apache/spark/pull/29608#issuecomment-686563956
Thx ~ @maropu
This is an automated message from the Apache Git Service.
To respond to the message,
AmplabJenkins removed a comment on pull request #29635:
URL: https://github.com/apache/spark/pull/29635#issuecomment-686574428
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29638:
URL: https://github.com/apache/spark/pull/29638#issuecomment-686426159
Can one of the admins verify this patch?
This is an automated message from the Apache Git
maropu commented on pull request #29638:
URL: https://github.com/apache/spark/pull/29638#issuecomment-686430944
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA removed a comment on pull request #29627:
URL: https://github.com/apache/spark/pull/29627#issuecomment-686301476
**[Test build #128237 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128237/testReport)**
for PR 29627 at commit
SparkQA commented on pull request #29638:
URL: https://github.com/apache/spark/pull/29638#issuecomment-686440867
**[Test build #128257 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128257/testReport)**
for PR 29638 at commit
AmplabJenkins removed a comment on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-686445346
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29572:
URL: https://github.com/apache/spark/pull/29572#issuecomment-686445718
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-686445346
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29639:
URL: https://github.com/apache/spark/pull/29639#issuecomment-686456991
This is an automated message from the Apache Git Service.
To respond to the message, please log on
maropu commented on a change in pull request #29589:
URL: https://github.com/apache/spark/pull/29589#discussion_r482989813
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##
@@ -1342,6 +1345,52 @@ abstract class
maropu commented on a change in pull request #29485:
URL: https://github.com/apache/spark/pull/29485#discussion_r483017255
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##
@@ -385,12 +408,16 @@ object TypeCoercion {
}
SparkQA removed a comment on pull request #29636:
URL: https://github.com/apache/spark/pull/29636#issuecomment-686386669
**[Test build #128250 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128250/testReport)**
for PR 29636 at commit
ibzx commented on pull request #22289:
URL: https://github.com/apache/spark/pull/22289#issuecomment-686536085
> Sorry for the lack of response, we found that adding the right files to
the inprocess spark-submit's classpath mostly does the job, so I think I'll
leave this as it is now.
AmplabJenkins removed a comment on pull request #29635:
URL: https://github.com/apache/spark/pull/29635#issuecomment-686548517
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29635:
URL: https://github.com/apache/spark/pull/29635#issuecomment-686548517
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29414:
URL: https://github.com/apache/spark/pull/29414#issuecomment-686564034
**[Test build #128252 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128252/testReport)**
for PR 29414 at commit
SparkQA removed a comment on pull request #29414:
URL: https://github.com/apache/spark/pull/29414#issuecomment-686397826
**[Test build #128252 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128252/testReport)**
for PR 29414 at commit
AmplabJenkins removed a comment on pull request #29638:
URL: https://github.com/apache/spark/pull/29638#issuecomment-686425705
Can one of the admins verify this patch?
This is an automated message from the Apache Git
hvanhovell commented on a change in pull request #29598:
URL: https://github.com/apache/spark/pull/29598#discussion_r480205472
##
File path:
sql/catalyst/src/main/scala-2.12/org/apache/spark/sql/catalyst/expressions/ExpressionSet.scala
##
@@ -53,46 +57,102 @@ object
AmplabJenkins commented on pull request #29638:
URL: https://github.com/apache/spark/pull/29638#issuecomment-686437770
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29638:
URL: https://github.com/apache/spark/pull/29638#issuecomment-686437770
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gaborgsomogyi commented on a change in pull request #29461:
URL: https://github.com/apache/spark/pull/29461#discussion_r482914280
##
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##
@@ -2525,14 +2525,19 @@ class Dataset[T] private[sql](
/**
*
cloud-fan commented on a change in pull request #29589:
URL: https://github.com/apache/spark/pull/29589#discussion_r482929915
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##
@@ -1342,6 +1345,52 @@ abstract class
AmplabJenkins commented on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-686466389
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29639:
URL: https://github.com/apache/spark/pull/29639#issuecomment-686474711
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29639:
URL: https://github.com/apache/spark/pull/29639#issuecomment-686474711
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29636:
URL: https://github.com/apache/spark/pull/29636#issuecomment-686537290
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
beliefer commented on pull request #29626:
URL: https://github.com/apache/spark/pull/29626#issuecomment-686551259
cc @cloud-fan
This is an automated message from the Apache Git Service.
To respond to the message, please log
Karl-WangSK removed a comment on pull request #29360:
URL: https://github.com/apache/spark/pull/29360#issuecomment-680740923
retest this please
This is an automated message from the Apache Git Service.
To respond to the
AmplabJenkins commented on pull request #29637:
URL: https://github.com/apache/spark/pull/29637#issuecomment-686567347
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29637:
URL: https://github.com/apache/spark/pull/29637#issuecomment-686567347
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rohitmishr1484 opened a new pull request #29640:
URL: https://github.com/apache/spark/pull/29640
# What changes were proposed in this pull request?
This PR proposes to add getting started- installation to new PySpark docs.
### Why are the changes needed?
Better documentation.
AmplabJenkins commented on pull request #29635:
URL: https://github.com/apache/spark/pull/29635#issuecomment-686574428
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29635:
URL: https://github.com/apache/spark/pull/29635#issuecomment-686404729
**[Test build #128254 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128254/testReport)**
for PR 29635 at commit
AmplabJenkins commented on pull request #29640:
URL: https://github.com/apache/spark/pull/29640#issuecomment-686579405
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29640:
URL: https://github.com/apache/spark/pull/29640#issuecomment-686578736
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
1 - 100 of 609 matches
Mail list logo