[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
dongjoon-hyun commented on a change in pull request #29776: URL: https://github.com/apache/spark/pull/29776#discussion_r489797852 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodegenExpressionCachingSuite.scala ## @@ -85,6 +85,36

[GitHub] [spark] HeartSaVioR closed pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

2020-09-16 Thread GitBox
HeartSaVioR closed pull request #25965: URL: https://github.com/apache/spark/pull/25965 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] HeartSaVioR commented on pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

2020-09-16 Thread GitBox
HeartSaVioR commented on pull request #25965: URL: https://github.com/apache/spark/pull/25965#issuecomment-693728786 Merged into master branch. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] zsxwing commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-16 Thread GitBox
zsxwing commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489825609 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala ## @@ -815,3 +815,26 @@ class

[GitHub] [spark] zsxwing commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-16 Thread GitBox
zsxwing commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r489825609 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala ## @@ -815,3 +815,26 @@ class

[GitHub] [spark] maropu edited a comment on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
maropu edited a comment on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693752944 > Another possible pattern is to make some object that encapsulates all endian-specific methods, and return a big- or little-endian implementation from a factory method.

[GitHub] [spark] SparkQA removed a comment on pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
SparkQA removed a comment on pull request #29776: URL: https://github.com/apache/spark/pull/29776#issuecomment-693652898 **[Test build #128779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128779/testReport)** for PR 29776 at commit

[GitHub] [spark] SparkQA commented on pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
SparkQA commented on pull request #29776: URL: https://github.com/apache/spark/pull/29776#issuecomment-693753224 **[Test build #128779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128779/testReport)** for PR 29776 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29587: URL: https://github.com/apache/spark/pull/29587#issuecomment-693757024 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29092: [SPARK-32295][SQL] Add not null and size > 0 filters before inner explode to benefit from predicate pushdown

2020-09-16 Thread GitBox
SparkQA commented on pull request #29092: URL: https://github.com/apache/spark/pull/29092#issuecomment-693756804 **[Test build #128783 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128783/testReport)** for PR 29092 at commit

[GitHub] [spark] SparkQA commented on pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
SparkQA commented on pull request #29587: URL: https://github.com/apache/spark/pull/29587#issuecomment-693756742 **[Test build #128782 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128782/testReport)** for PR 29587 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29092: [SPARK-32295][SQL] Add not null and size > 0 filters before inner explode to benefit from predicate pushdown

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29092: URL: https://github.com/apache/spark/pull/29092#issuecomment-693757106 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29092: [SPARK-32295][SQL] Add not null and size > 0 filters before inner explode to benefit from predicate pushdown

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29092: URL: https://github.com/apache/spark/pull/29092#issuecomment-693757106 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29587: URL: https://github.com/apache/spark/pull/29587#issuecomment-693757024 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29747: [SPARK-31848][CORE][TEST] DAGSchedulerSuite: Break down the very huge test file

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29747: URL: https://github.com/apache/spark/pull/29747#issuecomment-693767004 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29604: URL: https://github.com/apache/spark/pull/29604#issuecomment-693767074 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29604: URL: https://github.com/apache/spark/pull/29604#issuecomment-693767074 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29703: [SPARK-32017][PYTHON][BUILD] Make Pyspark Hadoop 3.2+ Variant available in PyPI

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29703: URL: https://github.com/apache/spark/pull/29703#issuecomment-693778917 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29703: [SPARK-32017][PYTHON][BUILD] Make Pyspark Hadoop 3.2+ Variant available in PyPI

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29703: URL: https://github.com/apache/spark/pull/29703#issuecomment-693778917 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29777: [SPARK-32905][Core][Yarn] ApplicationMaster fails to receive UpdateDelegationTokens message

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29777: URL: https://github.com/apache/spark/pull/29777#issuecomment-693779128 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29777: [SPARK-32905][Core][Yarn] ApplicationMaster fails to receive UpdateDelegationTokens message

2020-09-16 Thread GitBox
SparkQA commented on pull request #29777: URL: https://github.com/apache/spark/pull/29777#issuecomment-693779036 **[Test build #128788 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128788/testReport)** for PR 29777 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29777: [SPARK-32905][Core][Yarn] ApplicationMaster fails to receive UpdateDelegationTokens message

2020-09-16 Thread GitBox
SparkQA removed a comment on pull request #29777: URL: https://github.com/apache/spark/pull/29777#issuecomment-693772828 **[Test build #128788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128788/testReport)** for PR 29777 at commit

[GitHub] [spark] SparkQA commented on pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
SparkQA commented on pull request #29776: URL: https://github.com/apache/spark/pull/29776#issuecomment-693787595 **[Test build #128781 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128781/testReport)** for PR 29776 at commit

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29703: [SPARK-32017][PYTHON][BUILD] Make Pyspark Hadoop 3.2+ Variant available in PyPI

2020-09-16 Thread GitBox
HyukjinKwon commented on a change in pull request #29703: URL: https://github.com/apache/spark/pull/29703#discussion_r489952888 ## File path: python/docs/source/getting_started/installation.rst ## @@ -38,8 +38,36 @@ PySpark installation using `PyPI

[GitHub] [spark] SparkQA commented on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
SparkQA commented on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693669066 **[Test build #128780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128780/testReport)** for PR 29762 at commit

[GitHub] [spark] SparkQA commented on pull request #29591: [SPARK-32714][PYTHON] Initial pyspark-stubs port.

2020-09-16 Thread GitBox
SparkQA commented on pull request #29591: URL: https://github.com/apache/spark/pull/29591#issuecomment-693673774 **[Test build #128777 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128777/testReport)** for PR 29591 at commit

[GitHub] [spark] SparkQA commented on pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
SparkQA commented on pull request #29776: URL: https://github.com/apache/spark/pull/29776#issuecomment-693705023 **[Test build #128781 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128781/testReport)** for PR 29776 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29776: URL: https://github.com/apache/spark/pull/29776#issuecomment-693705489 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29776: URL: https://github.com/apache/spark/pull/29776#issuecomment-693705489 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun commented on pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
dongjoon-hyun commented on pull request #29776: URL: https://github.com/apache/spark/pull/29776#issuecomment-693706265 Thank you for updating, @viirya . cc @maropu and @kiszk , too. This is an automated message from the

[GitHub] [spark] AmplabJenkins commented on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693724833 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
SparkQA removed a comment on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693669066 **[Test build #128780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128780/testReport)** for PR 29762 at commit

[GitHub] [spark] SparkQA commented on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
SparkQA commented on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693724343 **[Test build #128780 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128780/testReport)** for PR 29762 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29776: URL: https://github.com/apache/spark/pull/29776#issuecomment-693753833 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29776: URL: https://github.com/apache/spark/pull/29776#issuecomment-693753833 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29776: URL: https://github.com/apache/spark/pull/29776#issuecomment-693761084 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-693761072 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29776: URL: https://github.com/apache/spark/pull/29776#issuecomment-693761084 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-09-16 Thread GitBox
SparkQA commented on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-693760768 **[Test build #128785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128785/testReport)** for PR 26935 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-693761072 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] beliefer commented on pull request #29747: [SPARK-31848][CORE][TEST] DAGSchedulerSuite: Break down the very huge test file

2020-09-16 Thread GitBox
beliefer commented on pull request #29747: URL: https://github.com/apache/spark/pull/29747#issuecomment-693765648 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] yaooqinn opened a new pull request #29777: [SPARK-32905][Core][Yarn] ApplicationMaster fails to receive UpdateDelegationTokens message

2020-09-16 Thread GitBox
yaooqinn opened a new pull request #29777: URL: https://github.com/apache/spark/pull/29777 ### What changes were proposed in this pull request? With a long-running application in kerberized mode, the AMEndpiont handles the token updating message wrong, which is a OneWayMessage that

[GitHub] [spark] maropu commented on a change in pull request #29092: [SPARK-32295][SQL] Add not null and size > 0 filters before inner explode to benefit from predicate pushdown

2020-09-16 Thread GitBox
maropu commented on a change in pull request #29092: URL: https://github.com/apache/spark/pull/29092#discussion_r489922948 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1847,3 +1848,25 @@ object OptimizeLimitZero

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29779: [SPARK-32180][PYTHON][DOCS][FOLLOW-UP] Rephrase and add some more information in installation guide

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29779: URL: https://github.com/apache/spark/pull/29779#issuecomment-693793104 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29776: URL: https://github.com/apache/spark/pull/29776#issuecomment-693653355 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29776: URL: https://github.com/apache/spark/pull/29776#issuecomment-693653355 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HeartSaVioR commented on pull request #29767: [SPARK-32896][SS] Add DataStreamWriter.table API

2020-09-16 Thread GitBox
HeartSaVioR commented on pull request #29767: URL: https://github.com/apache/spark/pull/29767#issuecomment-693700523 cc. @cloud-fan @tdas @zsxwing @gaborgsomogyi @xuanyuanking This is an automated message from the Apache

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
dongjoon-hyun commented on a change in pull request #29776: URL: https://github.com/apache/spark/pull/29776#discussion_r489790080 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodegenExpressionCachingSuite.scala ## @@ -109,3

[GitHub] [spark] maropu commented on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
maropu commented on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693752944 > Another possible pattern is to make some object that encapsulates all endian-specific methods, and return a big- or little-endian implementation from a factory method.

[GitHub] [spark] maropu commented on pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

2020-09-16 Thread GitBox
maropu commented on pull request #22626: URL: https://github.com/apache/spark/pull/22626#issuecomment-693752628 This is a new feature for 3.0, so we don't do so basically. This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
SparkQA commented on pull request #29604: URL: https://github.com/apache/spark/pull/29604#issuecomment-693766703 **[Test build #128787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128787/testReport)** for PR 29604 at commit

[GitHub] [spark] SparkQA commented on pull request #29747: [SPARK-31848][CORE][TEST] DAGSchedulerSuite: Break down the very huge test file

2020-09-16 Thread GitBox
SparkQA commented on pull request #29747: URL: https://github.com/apache/spark/pull/29747#issuecomment-693766657 **[Test build #128786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128786/testReport)** for PR 29747 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29747: [SPARK-31848][CORE][TEST] DAGSchedulerSuite: Break down the very huge test file

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29747: URL: https://github.com/apache/spark/pull/29747#issuecomment-693548265 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #29777: [SPARK-32905][Core][Yarn] ApplicationMaster fails to receive UpdateDelegationTokens message

2020-09-16 Thread GitBox
SparkQA commented on pull request #29777: URL: https://github.com/apache/spark/pull/29777#issuecomment-693772828 **[Test build #128788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128788/testReport)** for PR 29777 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29764: [SPARK-32738][CORE][2.4] Should reduce the number of active threads if fatal error happens in `Inbox.process`

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29764: URL: https://github.com/apache/spark/pull/29764#issuecomment-693781556 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29764: [SPARK-32738][CORE][2.4] Should reduce the number of active threads if fatal error happens in `Inbox.process`

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29764: URL: https://github.com/apache/spark/pull/29764#issuecomment-693781552 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
dongjoon-hyun commented on a change in pull request #29762: URL: https://github.com/apache/spark/pull/29762#discussion_r489932308 ## File path: common/sketch/src/main/java/org/apache/spark/util/sketch/Murmur3_x86_32.java ## @@ -92,8 +96,10 @@ private static int

[GitHub] [spark] AmplabJenkins commented on pull request #29779: [SPARK-32180][PYTHON][DOCS][FOLLOW-UP] Rephrase and add some more information in installation guide

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29779: URL: https://github.com/apache/spark/pull/29779#issuecomment-693793104 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] sunchao commented on pull request #29775: [SPARK-24994][SQL][FOLLOW-UP] Handle foldable, timezone and cleanup

2020-09-16 Thread GitBox
sunchao commented on pull request #29775: URL: https://github.com/apache/spark/pull/29775#issuecomment-693687162 cc @cloud-fan and @dongjoon-hyun This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29775: [SPARK-24994][SQL][FOLLOW-UP] Handle foldable, timezone and cleanup

2020-09-16 Thread GitBox
dongjoon-hyun commented on a change in pull request #29775: URL: https://github.com/apache/spark/pull/29775#discussion_r489786289 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -103,9 +103,9 @@ object

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489799141 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,168 @@ package

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489799250 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,168 @@ package

[GitHub] [spark] HeartSaVioR commented on pull request #25965: [SPARK-26425][SS] Add more constraint checks to avoid checkpoint corruption

2020-09-16 Thread GitBox
HeartSaVioR commented on pull request #25965: URL: https://github.com/apache/spark/pull/25965#issuecomment-693727696 Thanks for reviewing. This PR didn't have any valid review comments in 1 year despite of mentioning, so I don't expect more reviews. I'll go ahead merging.

[GitHub] [spark] SparkQA removed a comment on pull request #29775: [SPARK-24994][SQL][FOLLOW-UP] Handle foldable, timezone and cleanup

2020-09-16 Thread GitBox
SparkQA removed a comment on pull request #29775: URL: https://github.com/apache/spark/pull/29775#issuecomment-693606720 **[Test build #128778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128778/testReport)** for PR 29775 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29775: [SPARK-24994][SQL][FOLLOW-UP] Handle foldable, timezone and cleanup

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29775: URL: https://github.com/apache/spark/pull/29775#issuecomment-693731743 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29775: [SPARK-24994][SQL][FOLLOW-UP] Handle foldable, timezone and cleanup

2020-09-16 Thread GitBox
SparkQA commented on pull request #29775: URL: https://github.com/apache/spark/pull/29775#issuecomment-693731225 **[Test build #128778 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128778/testReport)** for PR 29775 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29775: [SPARK-24994][SQL][FOLLOW-UP] Handle foldable, timezone and cleanup

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29775: URL: https://github.com/apache/spark/pull/29775#issuecomment-693731743 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] jroof88 commented on a change in pull request #29720: [SPARK-32849][PYSPARK] Add default values for non-required keys when creating StructType

2020-09-16 Thread GitBox
jroof88 commented on a change in pull request #29720: URL: https://github.com/apache/spark/pull/29720#discussion_r489549168 ## File path: python/pyspark/sql/types.py ## @@ -305,7 +305,7 @@ def jsonValue(self): @classmethod def fromJson(cls, json): Review comment:

[GitHub] [spark] maropu commented on pull request #29774: [SPARK-32902][SQL] Logging plan changes for AQE

2020-09-16 Thread GitBox
maropu commented on pull request #29774: URL: https://github.com/apache/spark/pull/29774#issuecomment-693756122 cc: @cloud-fan @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
SparkQA commented on pull request #29776: URL: https://github.com/apache/spark/pull/29776#issuecomment-693760750 **[Test build #128784 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128784/testReport)** for PR 29776 at commit

[GitHub] [spark] yaooqinn commented on pull request #29777: [SPARK-32905][Core][Yarn] ApplicationMaster fails to receive UpdateDelegationTokens message

2020-09-16 Thread GitBox
yaooqinn commented on pull request #29777: URL: https://github.com/apache/spark/pull/29777#issuecomment-693771583 cc @cloud-fan @maropu @dongjoon-hyun thanks~ This is an automated message from the Apache Git Service. To

[GitHub] [spark] HyukjinKwon commented on pull request #29703: [SPARK-32017][PYTHON][BUILD] Make Pyspark Hadoop 3.2+ Variant available in PyPI

2020-09-16 Thread GitBox
HyukjinKwon commented on pull request #29703: URL: https://github.com/apache/spark/pull/29703#issuecomment-693777672 I proofread, tested again and fixed some docs. This is an automated message from the Apache Git Service. To

[GitHub] [spark] Ngone51 commented on pull request #29732: [SPARK-32857][CORE] Fix flaky o.a.s.s.BarrierTaskContextSuite.throw exception if the number of barrier() calls are not the same on every task

2020-09-16 Thread GitBox
Ngone51 commented on pull request #29732: URL: https://github.com/apache/spark/pull/29732#issuecomment-693777377 cc @jiangxb1987 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29703: [SPARK-32017][PYTHON][BUILD] Make Pyspark Hadoop 3.2+ Variant available in PyPI

2020-09-16 Thread GitBox
HyukjinKwon commented on a change in pull request #29703: URL: https://github.com/apache/spark/pull/29703#discussion_r489909606 ## File path: python/docs/source/getting_started/installation.rst ## @@ -38,8 +38,36 @@ PySpark installation using `PyPI

[GitHub] [spark] SparkQA commented on pull request #29764: [SPARK-32738][CORE][2.4] Should reduce the number of active threads if fatal error happens in `Inbox.process`

2020-09-16 Thread GitBox
SparkQA commented on pull request #29764: URL: https://github.com/apache/spark/pull/29764#issuecomment-693780444 **[Test build #128791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128791/testReport)** for PR 29764 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29764: [SPARK-32738][CORE][2.4] Should reduce the number of active threads if fatal error happens in `Inbox.process`

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29764: URL: https://github.com/apache/spark/pull/29764#issuecomment-693780763 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29764: [SPARK-32738][CORE][2.4] Should reduce the number of active threads if fatal error happens in `Inbox.process`

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29764: URL: https://github.com/apache/spark/pull/29764#issuecomment-693780763 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29778: [SPARK-18409][ML][FOLLOWUP] LSH approxNearestNeighbors optimization 2

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29778: URL: https://github.com/apache/spark/pull/29778#issuecomment-693780826 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29778: [SPARK-18409][ML][FOLLOWUP] LSH approxNearestNeighbors optimization 2

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29778: URL: https://github.com/apache/spark/pull/29778#issuecomment-693780826 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] viirya commented on a change in pull request #29703: [SPARK-32017][PYTHON][BUILD] Make Pyspark Hadoop 3.2+ Variant available in PyPI

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29703: URL: https://github.com/apache/spark/pull/29703#discussion_r489919482 ## File path: python/docs/source/getting_started/installation.rst ## @@ -38,8 +38,36 @@ PySpark installation using `PyPI

[GitHub] [spark] SparkQA commented on pull request #29779: [SPARK-32180][PYTHON][DOCS][FOLLOW-UP] Rephrase and add some more information in installation guide

2020-09-16 Thread GitBox
SparkQA commented on pull request #29779: URL: https://github.com/apache/spark/pull/29779#issuecomment-693792818 **[Test build #128792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128792/testReport)** for PR 29779 at commit

[GitHub] [spark] HyukjinKwon opened a new pull request #29779: [SPARK-32180][PYTHON][DOCS][FOLLOW-UP] Rephrase and add some more information in installation guide

2020-09-16 Thread GitBox
HyukjinKwon opened a new pull request #29779: URL: https://github.com/apache/spark/pull/29779 ### What changes were proposed in this pull request? This PR: - Rephrases some wordings in installation guide to avoid using the terms that can be potentially ambiguous such as

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29703: [SPARK-32017][PYTHON][BUILD] Make Pyspark Hadoop 3.2+ Variant available in PyPI

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29703: URL: https://github.com/apache/spark/pull/29703#issuecomment-693796763 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29703: [SPARK-32017][PYTHON][BUILD] Make Pyspark Hadoop 3.2+ Variant available in PyPI

2020-09-16 Thread GitBox
SparkQA commented on pull request #29703: URL: https://github.com/apache/spark/pull/29703#issuecomment-693796417 **[Test build #128793 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128793/testReport)** for PR 29703 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29703: [SPARK-32017][PYTHON][BUILD] Make Pyspark Hadoop 3.2+ Variant available in PyPI

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29703: URL: https://github.com/apache/spark/pull/29703#issuecomment-693796763 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] srowen commented on a change in pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
srowen commented on a change in pull request #29762: URL: https://github.com/apache/spark/pull/29762#discussion_r489756761 ## File path: common/sketch/src/main/java/org/apache/spark/util/sketch/Murmur3_x86_32.java ## @@ -92,8 +96,10 @@ private static int hashBytesByInt(Object

[GitHub] [spark] srowen commented on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
srowen commented on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693668479 Jenkins retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29775: [SPARK-24994][SQL][FOLLOW-UP] Handle foldable, timezone and cleanup

2020-09-16 Thread GitBox
dongjoon-hyun commented on a change in pull request #29775: URL: https://github.com/apache/spark/pull/29775#discussion_r489794434 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -103,9 +103,9 @@ object

[GitHub] [spark] viirya commented on a change in pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29776: URL: https://github.com/apache/spark/pull/29776#discussion_r489800137 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodegenExpressionCachingSuite.scala ## @@ -85,6 +85,36 @@

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-693724833 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] viirya commented on a change in pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29776: URL: https://github.com/apache/spark/pull/29776#discussion_r489861217 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodegenExpressionCachingSuite.scala ## @@ -85,6 +85,36 @@

[GitHub] [spark] maropu commented on a change in pull request #29092: [SPARK-32295][SQL] Add not null and size > 0 filters before inner explode to benefit from predicate pushdown

2020-09-16 Thread GitBox
maropu commented on a change in pull request #29092: URL: https://github.com/apache/spark/pull/29092#discussion_r489861092 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1847,3 +1848,25 @@ object OptimizeLimitZero

[GitHub] [spark] maropu commented on a change in pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
maropu commented on a change in pull request #29776: URL: https://github.com/apache/spark/pull/29776#discussion_r489861610 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodegenExpressionCachingSuite.scala ## @@ -85,6 +85,36 @@

[GitHub] [spark] maropu commented on pull request #29092: [SPARK-32295][SQL] Add not null and size > 0 filters before inner explode to benefit from predicate pushdown

2020-09-16 Thread GitBox
maropu commented on pull request #29092: URL: https://github.com/apache/spark/pull/29092#issuecomment-693755084 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29092: [SPARK-32295][SQL] Add not null and size > 0 filters before inner explode to benefit from predicate pushdown

2020-09-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29092: URL: https://github.com/apache/spark/pull/29092#issuecomment-693622669 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] HeartSaVioR commented on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-09-16 Thread GitBox
HeartSaVioR commented on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-693759260 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] viirya commented on a change in pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29776: URL: https://github.com/apache/spark/pull/29776#discussion_r489870809 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodegenExpressionCachingSuite.scala ## @@ -85,6 +85,36 @@

[GitHub] [spark] LuciferYang commented on pull request #29711: [SPARK-32808][SQL] Pass all test of sql/core module in Scala 2.13

2020-09-16 Thread GitBox
LuciferYang commented on pull request #29711: URL: https://github.com/apache/spark/pull/29711#issuecomment-693765204 @srowen @gatorsmile Is there any other problem in this pr that needs to be fixed? It seems that @cloud-fan thinks the change is safe.

[GitHub] [spark] AmplabJenkins commented on pull request #29764: [SPARK-32738][CORE][2.4] Should reduce the number of active threads if fatal error happens in `Inbox.process`

2020-09-16 Thread GitBox
AmplabJenkins commented on pull request #29764: URL: https://github.com/apache/spark/pull/29764#issuecomment-693781552 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29764: [SPARK-32738][CORE][2.4] Should reduce the number of active threads if fatal error happens in `Inbox.process`

2020-09-16 Thread GitBox
SparkQA removed a comment on pull request #29764: URL: https://github.com/apache/spark/pull/29764#issuecomment-693780444 **[Test build #128791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128791/testReport)** for PR 29764 at commit

<    2   3   4   5   6   7   8   >