dongjoon-hyun commented on a change in pull request #29776:
URL: https://github.com/apache/spark/pull/29776#discussion_r489797852
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodegenExpressionCachingSuite.scala
##
@@ -85,6 +85,36
HeartSaVioR closed pull request #25965:
URL: https://github.com/apache/spark/pull/25965
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
HeartSaVioR commented on pull request #25965:
URL: https://github.com/apache/spark/pull/25965#issuecomment-693728786
Merged into master branch.
This is an automated message from the Apache Git Service.
To respond to the
zsxwing commented on a change in pull request #29756:
URL: https://github.com/apache/spark/pull/29756#discussion_r489825609
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala
##
@@ -815,3 +815,26 @@ class
zsxwing commented on a change in pull request #29756:
URL: https://github.com/apache/spark/pull/29756#discussion_r489825609
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala
##
@@ -815,3 +815,26 @@ class
maropu edited a comment on pull request #29762:
URL: https://github.com/apache/spark/pull/29762#issuecomment-693752944
> Another possible pattern is to make some object that encapsulates all
endian-specific methods, and return a big- or little-endian implementation from
a factory method.
SparkQA removed a comment on pull request #29776:
URL: https://github.com/apache/spark/pull/29776#issuecomment-693652898
**[Test build #128779 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128779/testReport)**
for PR 29776 at commit
SparkQA commented on pull request #29776:
URL: https://github.com/apache/spark/pull/29776#issuecomment-693753224
**[Test build #128779 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128779/testReport)**
for PR 29776 at commit
AmplabJenkins commented on pull request #29587:
URL: https://github.com/apache/spark/pull/29587#issuecomment-693757024
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29092:
URL: https://github.com/apache/spark/pull/29092#issuecomment-693756804
**[Test build #128783 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128783/testReport)**
for PR 29092 at commit
SparkQA commented on pull request #29587:
URL: https://github.com/apache/spark/pull/29587#issuecomment-693756742
**[Test build #128782 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128782/testReport)**
for PR 29587 at commit
AmplabJenkins removed a comment on pull request #29092:
URL: https://github.com/apache/spark/pull/29092#issuecomment-693757106
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29092:
URL: https://github.com/apache/spark/pull/29092#issuecomment-693757106
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29587:
URL: https://github.com/apache/spark/pull/29587#issuecomment-693757024
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29747:
URL: https://github.com/apache/spark/pull/29747#issuecomment-693767004
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29604:
URL: https://github.com/apache/spark/pull/29604#issuecomment-693767074
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29604:
URL: https://github.com/apache/spark/pull/29604#issuecomment-693767074
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29703:
URL: https://github.com/apache/spark/pull/29703#issuecomment-693778917
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29703:
URL: https://github.com/apache/spark/pull/29703#issuecomment-693778917
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29777:
URL: https://github.com/apache/spark/pull/29777#issuecomment-693779128
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29777:
URL: https://github.com/apache/spark/pull/29777#issuecomment-693779036
**[Test build #128788 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128788/testReport)**
for PR 29777 at commit
SparkQA removed a comment on pull request #29777:
URL: https://github.com/apache/spark/pull/29777#issuecomment-693772828
**[Test build #128788 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128788/testReport)**
for PR 29777 at commit
SparkQA commented on pull request #29776:
URL: https://github.com/apache/spark/pull/29776#issuecomment-693787595
**[Test build #128781 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128781/testReport)**
for PR 29776 at commit
HyukjinKwon commented on a change in pull request #29703:
URL: https://github.com/apache/spark/pull/29703#discussion_r489952888
##
File path: python/docs/source/getting_started/installation.rst
##
@@ -38,8 +38,36 @@ PySpark installation using `PyPI
SparkQA commented on pull request #29762:
URL: https://github.com/apache/spark/pull/29762#issuecomment-693669066
**[Test build #128780 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128780/testReport)**
for PR 29762 at commit
SparkQA commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-693673774
**[Test build #128777 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128777/testReport)**
for PR 29591 at commit
SparkQA commented on pull request #29776:
URL: https://github.com/apache/spark/pull/29776#issuecomment-693705023
**[Test build #128781 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128781/testReport)**
for PR 29776 at commit
AmplabJenkins removed a comment on pull request #29776:
URL: https://github.com/apache/spark/pull/29776#issuecomment-693705489
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29776:
URL: https://github.com/apache/spark/pull/29776#issuecomment-693705489
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dongjoon-hyun commented on pull request #29776:
URL: https://github.com/apache/spark/pull/29776#issuecomment-693706265
Thank you for updating, @viirya .
cc @maropu and @kiszk , too.
This is an automated message from the
AmplabJenkins commented on pull request #29762:
URL: https://github.com/apache/spark/pull/29762#issuecomment-693724833
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29762:
URL: https://github.com/apache/spark/pull/29762#issuecomment-693669066
**[Test build #128780 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128780/testReport)**
for PR 29762 at commit
SparkQA commented on pull request #29762:
URL: https://github.com/apache/spark/pull/29762#issuecomment-693724343
**[Test build #128780 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128780/testReport)**
for PR 29762 at commit
AmplabJenkins commented on pull request #29776:
URL: https://github.com/apache/spark/pull/29776#issuecomment-693753833
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29776:
URL: https://github.com/apache/spark/pull/29776#issuecomment-693753833
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29776:
URL: https://github.com/apache/spark/pull/29776#issuecomment-693761084
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #26935:
URL: https://github.com/apache/spark/pull/26935#issuecomment-693761072
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29776:
URL: https://github.com/apache/spark/pull/29776#issuecomment-693761084
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #26935:
URL: https://github.com/apache/spark/pull/26935#issuecomment-693760768
**[Test build #128785 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128785/testReport)**
for PR 26935 at commit
AmplabJenkins removed a comment on pull request #26935:
URL: https://github.com/apache/spark/pull/26935#issuecomment-693761072
This is an automated message from the Apache Git Service.
To respond to the message, please log on
beliefer commented on pull request #29747:
URL: https://github.com/apache/spark/pull/29747#issuecomment-693765648
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
yaooqinn opened a new pull request #29777:
URL: https://github.com/apache/spark/pull/29777
### What changes were proposed in this pull request?
With a long-running application in kerberized mode, the AMEndpiont handles
the token updating message wrong, which is a OneWayMessage that
maropu commented on a change in pull request #29092:
URL: https://github.com/apache/spark/pull/29092#discussion_r489922948
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##
@@ -1847,3 +1848,25 @@ object OptimizeLimitZero
AmplabJenkins removed a comment on pull request #29779:
URL: https://github.com/apache/spark/pull/29779#issuecomment-693793104
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29776:
URL: https://github.com/apache/spark/pull/29776#issuecomment-693653355
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29776:
URL: https://github.com/apache/spark/pull/29776#issuecomment-693653355
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HeartSaVioR commented on pull request #29767:
URL: https://github.com/apache/spark/pull/29767#issuecomment-693700523
cc. @cloud-fan @tdas @zsxwing @gaborgsomogyi @xuanyuanking
This is an automated message from the Apache
dongjoon-hyun commented on a change in pull request #29776:
URL: https://github.com/apache/spark/pull/29776#discussion_r489790080
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodegenExpressionCachingSuite.scala
##
@@ -109,3
maropu commented on pull request #29762:
URL: https://github.com/apache/spark/pull/29762#issuecomment-693752944
> Another possible pattern is to make some object that encapsulates all
endian-specific methods, and return a big- or little-endian implementation from
a factory method.
maropu commented on pull request #22626:
URL: https://github.com/apache/spark/pull/22626#issuecomment-693752628
This is a new feature for 3.0, so we don't do so basically.
This is an automated message from the Apache Git
SparkQA commented on pull request #29604:
URL: https://github.com/apache/spark/pull/29604#issuecomment-693766703
**[Test build #128787 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128787/testReport)**
for PR 29604 at commit
SparkQA commented on pull request #29747:
URL: https://github.com/apache/spark/pull/29747#issuecomment-693766657
**[Test build #128786 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128786/testReport)**
for PR 29747 at commit
AmplabJenkins removed a comment on pull request #29747:
URL: https://github.com/apache/spark/pull/29747#issuecomment-693548265
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA commented on pull request #29777:
URL: https://github.com/apache/spark/pull/29777#issuecomment-693772828
**[Test build #128788 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128788/testReport)**
for PR 29777 at commit
AmplabJenkins removed a comment on pull request #29764:
URL: https://github.com/apache/spark/pull/29764#issuecomment-693781556
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29764:
URL: https://github.com/apache/spark/pull/29764#issuecomment-693781552
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
dongjoon-hyun commented on a change in pull request #29762:
URL: https://github.com/apache/spark/pull/29762#discussion_r489932308
##
File path:
common/sketch/src/main/java/org/apache/spark/util/sketch/Murmur3_x86_32.java
##
@@ -92,8 +96,10 @@ private static int
AmplabJenkins commented on pull request #29779:
URL: https://github.com/apache/spark/pull/29779#issuecomment-693793104
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sunchao commented on pull request #29775:
URL: https://github.com/apache/spark/pull/29775#issuecomment-693687162
cc @cloud-fan and @dongjoon-hyun
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun commented on a change in pull request #29775:
URL: https://github.com/apache/spark/pull/29775#discussion_r489786289
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala
##
@@ -103,9 +103,9 @@ object
viirya commented on a change in pull request #29587:
URL: https://github.com/apache/spark/pull/29587#discussion_r489799141
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala
##
@@ -17,29 +17,168 @@
package
viirya commented on a change in pull request #29587:
URL: https://github.com/apache/spark/pull/29587#discussion_r489799250
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala
##
@@ -17,29 +17,168 @@
package
HeartSaVioR commented on pull request #25965:
URL: https://github.com/apache/spark/pull/25965#issuecomment-693727696
Thanks for reviewing. This PR didn't have any valid review comments in 1
year despite of mentioning, so I don't expect more reviews. I'll go ahead
merging.
SparkQA removed a comment on pull request #29775:
URL: https://github.com/apache/spark/pull/29775#issuecomment-693606720
**[Test build #128778 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128778/testReport)**
for PR 29775 at commit
AmplabJenkins commented on pull request #29775:
URL: https://github.com/apache/spark/pull/29775#issuecomment-693731743
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29775:
URL: https://github.com/apache/spark/pull/29775#issuecomment-693731225
**[Test build #128778 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128778/testReport)**
for PR 29775 at commit
AmplabJenkins removed a comment on pull request #29775:
URL: https://github.com/apache/spark/pull/29775#issuecomment-693731743
This is an automated message from the Apache Git Service.
To respond to the message, please log on
jroof88 commented on a change in pull request #29720:
URL: https://github.com/apache/spark/pull/29720#discussion_r489549168
##
File path: python/pyspark/sql/types.py
##
@@ -305,7 +305,7 @@ def jsonValue(self):
@classmethod
def fromJson(cls, json):
Review comment:
maropu commented on pull request #29774:
URL: https://github.com/apache/spark/pull/29774#issuecomment-693756122
cc: @cloud-fan @HyukjinKwon
This is an automated message from the Apache Git Service.
To respond to the
SparkQA commented on pull request #29776:
URL: https://github.com/apache/spark/pull/29776#issuecomment-693760750
**[Test build #128784 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128784/testReport)**
for PR 29776 at commit
yaooqinn commented on pull request #29777:
URL: https://github.com/apache/spark/pull/29777#issuecomment-693771583
cc @cloud-fan @maropu @dongjoon-hyun thanks~
This is an automated message from the Apache Git Service.
To
HyukjinKwon commented on pull request #29703:
URL: https://github.com/apache/spark/pull/29703#issuecomment-693777672
I proofread, tested again and fixed some docs.
This is an automated message from the Apache Git Service.
To
Ngone51 commented on pull request #29732:
URL: https://github.com/apache/spark/pull/29732#issuecomment-693777377
cc @jiangxb1987
This is an automated message from the Apache Git Service.
To respond to the message, please
HyukjinKwon commented on a change in pull request #29703:
URL: https://github.com/apache/spark/pull/29703#discussion_r489909606
##
File path: python/docs/source/getting_started/installation.rst
##
@@ -38,8 +38,36 @@ PySpark installation using `PyPI
SparkQA commented on pull request #29764:
URL: https://github.com/apache/spark/pull/29764#issuecomment-693780444
**[Test build #128791 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128791/testReport)**
for PR 29764 at commit
AmplabJenkins commented on pull request #29764:
URL: https://github.com/apache/spark/pull/29764#issuecomment-693780763
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29764:
URL: https://github.com/apache/spark/pull/29764#issuecomment-693780763
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29778:
URL: https://github.com/apache/spark/pull/29778#issuecomment-693780826
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29778:
URL: https://github.com/apache/spark/pull/29778#issuecomment-693780826
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
viirya commented on a change in pull request #29703:
URL: https://github.com/apache/spark/pull/29703#discussion_r489919482
##
File path: python/docs/source/getting_started/installation.rst
##
@@ -38,8 +38,36 @@ PySpark installation using `PyPI
SparkQA commented on pull request #29779:
URL: https://github.com/apache/spark/pull/29779#issuecomment-693792818
**[Test build #128792 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128792/testReport)**
for PR 29779 at commit
HyukjinKwon opened a new pull request #29779:
URL: https://github.com/apache/spark/pull/29779
### What changes were proposed in this pull request?
This PR:
- Rephrases some wordings in installation guide to avoid using the terms
that can be potentially ambiguous such as
AmplabJenkins removed a comment on pull request #29703:
URL: https://github.com/apache/spark/pull/29703#issuecomment-693796763
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29703:
URL: https://github.com/apache/spark/pull/29703#issuecomment-693796417
**[Test build #128793 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128793/testReport)**
for PR 29703 at commit
AmplabJenkins commented on pull request #29703:
URL: https://github.com/apache/spark/pull/29703#issuecomment-693796763
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
srowen commented on a change in pull request #29762:
URL: https://github.com/apache/spark/pull/29762#discussion_r489756761
##
File path:
common/sketch/src/main/java/org/apache/spark/util/sketch/Murmur3_x86_32.java
##
@@ -92,8 +96,10 @@ private static int hashBytesByInt(Object
srowen commented on pull request #29762:
URL: https://github.com/apache/spark/pull/29762#issuecomment-693668479
Jenkins retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
dongjoon-hyun commented on a change in pull request #29775:
URL: https://github.com/apache/spark/pull/29775#discussion_r489794434
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala
##
@@ -103,9 +103,9 @@ object
viirya commented on a change in pull request #29776:
URL: https://github.com/apache/spark/pull/29776#discussion_r489800137
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodegenExpressionCachingSuite.scala
##
@@ -85,6 +85,36 @@
AmplabJenkins removed a comment on pull request #29762:
URL: https://github.com/apache/spark/pull/29762#issuecomment-693724833
This is an automated message from the Apache Git Service.
To respond to the message, please log on
viirya commented on a change in pull request #29776:
URL: https://github.com/apache/spark/pull/29776#discussion_r489861217
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodegenExpressionCachingSuite.scala
##
@@ -85,6 +85,36 @@
maropu commented on a change in pull request #29092:
URL: https://github.com/apache/spark/pull/29092#discussion_r489861092
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##
@@ -1847,3 +1848,25 @@ object OptimizeLimitZero
maropu commented on a change in pull request #29776:
URL: https://github.com/apache/spark/pull/29776#discussion_r489861610
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodegenExpressionCachingSuite.scala
##
@@ -85,6 +85,36 @@
maropu commented on pull request #29092:
URL: https://github.com/apache/spark/pull/29092#issuecomment-693755084
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29092:
URL: https://github.com/apache/spark/pull/29092#issuecomment-693622669
Can one of the admins verify this patch?
This is an automated message from the Apache Git
HeartSaVioR commented on pull request #26935:
URL: https://github.com/apache/spark/pull/26935#issuecomment-693759260
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
viirya commented on a change in pull request #29776:
URL: https://github.com/apache/spark/pull/29776#discussion_r489870809
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodegenExpressionCachingSuite.scala
##
@@ -85,6 +85,36 @@
LuciferYang commented on pull request #29711:
URL: https://github.com/apache/spark/pull/29711#issuecomment-693765204
@srowen @gatorsmile Is there any other problem in this pr that needs to be
fixed? It seems that @cloud-fan thinks the change is safe.
AmplabJenkins commented on pull request #29764:
URL: https://github.com/apache/spark/pull/29764#issuecomment-693781552
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29764:
URL: https://github.com/apache/spark/pull/29764#issuecomment-693780444
**[Test build #128791 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128791/testReport)**
for PR 29764 at commit
601 - 700 of 703 matches
Mail list logo