[GitHub] [spark] mridulm commented on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
mridulm commented on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697962451 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] sunchao commented on a change in pull request #29843: [WIP][SPARK-29250] Upgrade to Hadoop 3.2.1 and move to shaded client

2020-09-23 Thread GitBox
sunchao commented on a change in pull request #29843: URL: https://github.com/apache/spark/pull/29843#discussion_r493888402 ## File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ## @@ -308,7 +307,7 @@ private[spark] class

[GitHub] [spark] srowen commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0

2020-09-23 Thread GitBox
srowen commented on pull request #28585: URL: https://github.com/apache/spark/pull/28585#issuecomment-697711108 Shoot. If this is non-essential, I think we can just revert it. Or .. just lose this test? let me comment on the other PR.

[GitHub] [spark] holdenk opened a new pull request #29854: [WIP][SPARK-32979][K8S] Fix decom tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
holdenk opened a new pull request #29854: URL: https://github.com/apache/spark/pull/29854 ### What changes were proposed in this pull request? Fixes the log strings the decom integration tests looks for and add comments reminding people to run the K8s integration tests when changing

[GitHub] [spark] holdenk commented on a change in pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
holdenk commented on a change in pull request #29846: URL: https://github.com/apache/spark/pull/29846#discussion_r493778976 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala ## @@ -323,4 +323,22 @@ private[spark]

[GitHub] [spark] holdenk commented on pull request #29471: [SPARK-32381][CORE][SQL] Move and refactor parallel listing & non-location sensitive listing to core

2020-09-23 Thread GitBox
holdenk commented on pull request #29471: URL: https://github.com/apache/spark/pull/29471#issuecomment-697829255 Looks like we've reached a lazy consesus here I'll merge this today :) This is an automated message from the

[GitHub] [spark] holdenk commented on pull request #28921: [SPARK-32086][YARN]Bug fix for RemoveBroadcast RPC failed after executor is shutdown

2020-09-23 Thread GitBox
holdenk commented on pull request #28921: URL: https://github.com/apache/spark/pull/28921#issuecomment-697829881 Jenkins ok to test. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] gemelen commented on pull request #29286: [WIP][SPARK-21708][BUILD] Migrate build to sbt 1.x

2020-09-23 Thread GitBox
gemelen commented on pull request #29286: URL: https://github.com/apache/spark/pull/29286#issuecomment-697886553 Nice. At least on Jenkins this passes as a whole and that promises that tests should succeeded on GH as well, as soon as doc generation phase would be fixed.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29798: [SPARK-32931][SQL] Unevaluable Expressions are not Foldable

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29798: URL: https://github.com/apache/spark/pull/29798#issuecomment-697924790 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] MaxGekk commented on pull request #29339: [Spark-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-09-23 Thread GitBox
MaxGekk commented on pull request #29339: URL: https://github.com/apache/spark/pull/29339#issuecomment-697940610 General comments: - Please, change PR's title to `[SPARK-32512][SQL] ...` - There is special section `Why` in PR description template for `There are no partition command

[GitHub] [spark] AmplabJenkins commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697958769 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
SparkQA commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697957673 **[Test build #129040 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129040/testReport)** for PR 29854 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29853: [SPARK-SQL][SPARK-32977] Fix JavaDoc on Default Save Mode

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29853: URL: https://github.com/apache/spark/pull/29853#issuecomment-697979195 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29853: [SPARK-SQL][SPARK-32977] Fix JavaDoc on Default Save Mode

2020-09-23 Thread GitBox
SparkQA removed a comment on pull request #29853: URL: https://github.com/apache/spark/pull/29853#issuecomment-697656590 **[Test build #129037 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129037/testReport)** for PR 29853 at commit

[GitHub] [spark] mridulm commented on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
mridulm commented on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697978318 +CC @tgravescs This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
SparkQA commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697985907 **[Test build #129048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129048/testReport)** for PR 29854 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #29856: [SPARK-32981][BUILD] Remove hive-1.2/hadoop-2.7 from Apache Spark 3.1 distribution

2020-09-23 Thread GitBox
dongjoon-hyun commented on pull request #29856: URL: https://github.com/apache/spark/pull/29856#issuecomment-698005804 Thank you, @srowen ! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] zero323 commented on a change in pull request #29806: [SPARK-32187][PYTHON][DOCS] Doc on Python packaging

2020-09-23 Thread GitBox
zero323 commented on a change in pull request #29806: URL: https://github.com/apache/spark/pull/29806#discussion_r493945020 ## File path: python/docs/source/user_guide/python_packaging.rst ## @@ -0,0 +1,220 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [spark] AmplabJenkins commented on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-698027137 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-698027137 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
SparkQA removed a comment on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697980048 **[Test build #129046 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129046/testReport)** for PR 29855 at commit

[GitHub] [spark] SparkQA commented on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
SparkQA commented on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-698042528 **[Test build #129046 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129046/testReport)** for PR 29855 at commit

[GitHub] [spark] maropu commented on a change in pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-23 Thread GitBox
maropu commented on a change in pull request #29585: URL: https://github.com/apache/spark/pull/29585#discussion_r493977794 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -18,17 +18,34 @@ package

[GitHub] [spark] huaxingao commented on pull request #29850: [SPARK-32974][ML] FeatureHasher transform optimization

2020-09-23 Thread GitBox
huaxingao commented on pull request #29850: URL: https://github.com/apache/spark/pull/29850#issuecomment-698052224 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-23 Thread GitBox
maropu commented on a change in pull request #29804: URL: https://github.com/apache/spark/pull/29804#discussion_r493984368 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala ## @@ -348,20 +352,22 @@ case class FileSourceScanExec(

[GitHub] [spark] zhengruifeng commented on pull request #29850: [SPARK-32974][ML] FeatureHasher transform optimization

2020-09-23 Thread GitBox
zhengruifeng commented on pull request #29850: URL: https://github.com/apache/spark/pull/29850#issuecomment-698054895 @srowen This output vector irrelevant to the order of input columns, because the output index of a feature is only determined by input columns name and input value(for cat

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29857: [SPARK-32972][ML] Fix UTs of `mllib` module in Scala 2.13 except RandomForestRegressorSuite

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29857: URL: https://github.com/apache/spark/pull/29857#issuecomment-698070617 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29054: [SPARK-32243][SQL]HiveSessionCatalog call super.makeFunctionExpression should show error message

2020-09-23 Thread GitBox
AngersZh commented on a change in pull request #29054: URL: https://github.com/apache/spark/pull/29054#discussion_r493999752 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ## @@ -69,7 +69,11 @@ private[sql] class

[GitHub] [spark] HyukjinKwon commented on pull request #29827: [SPARK-32957][INFRA] Add a GitHub Actions job to run WebUI tests with Chrome

2020-09-23 Thread GitBox
HyukjinKwon commented on pull request #29827: URL: https://github.com/apache/spark/pull/29827#issuecomment-698075428 +1 for @dongjoon-hyun's... This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun commented on pull request #29859: [SPARK-32971][K8S][FOLLOWUP] Add `.toSeq` for Scala 2.13 compilation

2020-09-23 Thread GitBox
dongjoon-hyun commented on pull request #29859: URL: https://github.com/apache/spark/pull/29859#issuecomment-698075649 Could you review this, @viirya ? This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] Ngone51 commented on a change in pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-23 Thread GitBox
Ngone51 commented on a change in pull request #29817: URL: https://github.com/apache/spark/pull/29817#discussion_r494003752 ## File path: core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala ## @@ -61,13 +61,34 @@ private[deploy] object DeployMessages { }

[GitHub] [spark] dongjoon-hyun opened a new pull request #29859: [SPARK-32971][K8S][FOLLOWUP] Add `.toSeq` for Scala 2.13 compilation

2020-09-23 Thread GitBox
dongjoon-hyun opened a new pull request #29859: URL: https://github.com/apache/spark/pull/29859 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

[GitHub] [spark] Ngone51 commented on a change in pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-23 Thread GitBox
Ngone51 commented on a change in pull request #29817: URL: https://github.com/apache/spark/pull/29817#discussion_r494003455 ## File path: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala ## @@ -213,9 +207,17 @@ private[spark] class

[GitHub] [spark] SparkQA commented on pull request #29860: [SPARK-32984][TESTS][SQL] Improve showing the differences between approved and actual plans of PlanStabilitySuite

2020-09-23 Thread GitBox
SparkQA commented on pull request #29860: URL: https://github.com/apache/spark/pull/29860#issuecomment-698090510 **[Test build #129060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129060/testReport)** for PR 29860 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29860: [SPARK-32984][TESTS][SQL] Improve showing the differences between approved and actual plans of PlanStabilitySuite

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29860: URL: https://github.com/apache/spark/pull/29860#issuecomment-698090732 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29860: [SPARK-32984][TESTS][SQL] Improve showing the differences between approved and actual plans of PlanStabilitySuite

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29860: URL: https://github.com/apache/spark/pull/29860#issuecomment-698090732 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29824: [SPARK-32954][YARN][TEST][test-hadoop2.7][test-maven] Add jakarta.servlet-api test dependency to yarn module to avoid UTs badcase

2020-09-23 Thread GitBox
SparkQA commented on pull request #29824: URL: https://github.com/apache/spark/pull/29824#issuecomment-697992447 **[Test build #129032 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129032/testReport)** for PR 29824 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #29856: [SPARK-32981][BUILD] Remove hive-1.2/hadoop-2.7 from Apache Spark 3.1 distribution

2020-09-23 Thread GitBox
dongjoon-hyun commented on pull request #29856: URL: https://github.com/apache/spark/pull/29856#issuecomment-698003841 cc @srowen , @HyukjinKwon ,@gatorsmile , @liancheng This is an automated message from the Apache Git

[GitHub] [spark] holdenk commented on pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-23 Thread GitBox
holdenk commented on pull request #29817: URL: https://github.com/apache/spark/pull/29817#issuecomment-698024268 I really like the idea of simplifying the RPC message flow, thanks for taking this on @Ngone51 and I'm sorry the code here is so brittle to these types of changes (the K8s

[GitHub] [spark] SparkQA commented on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
SparkQA commented on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-698024864 **[Test build #129045 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129045/testReport)** for PR 29855 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
SparkQA removed a comment on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697953562 **[Test build #129043 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129043/testReport)** for PR 29854 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
HyukjinKwon commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-698038747 Thanks @holdenk and @dongjoon-hyun This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-698043224 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-698043224 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-698046662 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on a change in pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-23 Thread GitBox
maropu commented on a change in pull request #29585: URL: https://github.com/apache/spark/pull/29585#discussion_r493980221 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala ## @@ -201,11 +201,6 @@ abstract class QueryPlan[PlanType

[GitHub] [spark] Ngone51 commented on pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-23 Thread GitBox
Ngone51 commented on pull request #29817: URL: https://github.com/apache/spark/pull/29817#issuecomment-698071835 > This PR in its original broke another one of the conditions. Except for the breaking of the log(like you just fixed), what other conditions this PR breaks?

[GitHub] [spark] Ngone51 edited a comment on pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-23 Thread GitBox
Ngone51 edited a comment on pull request #29817: URL: https://github.com/apache/spark/pull/29817#issuecomment-698071835 > This PR in its original broke another one of the conditions. Except for the breaking of the log(like you just fixed), what other conditions does this PR break?

[GitHub] [spark] SparkQA commented on pull request #29859: [SPARK-32971][K8S][FOLLOWUP] Add `.toSeq` for Scala 2.13 compilation

2020-09-23 Thread GitBox
SparkQA commented on pull request #29859: URL: https://github.com/apache/spark/pull/29859#issuecomment-698075792 **[Test build #129056 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129056/testReport)** for PR 29859 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
dongjoon-hyun commented on pull request #29846: URL: https://github.com/apache/spark/pull/29846#issuecomment-698075783 The follow-up PR is ready, https://github.com/apache/spark/pull/29859 . This is an automated message from

[GitHub] [spark] HyukjinKwon commented on pull request #29858: [SPARK-32981][BUILD][FOLLOW-UP] Remove hive-1.2 profiles in PIP installation option

2020-09-23 Thread GitBox
HyukjinKwon commented on pull request #29858: URL: https://github.com/apache/spark/pull/29858#issuecomment-698075993 @dongjoon-hyun, this affects end users, not the dev people who will use `hive-1.2` profile. I can file a separate JIRA but whenever the release distributions are

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29054: [SPARK-32243][SQL]HiveSessionCatalog call super.makeFunctionExpression should throw earlier when got Spark UDAF Invalid argumen

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29054: URL: https://github.com/apache/spark/pull/29054#issuecomment-698077888 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29859: [SPARK-32971][K8S][FOLLOWUP] Add `.toSeq` for Scala 2.13 compilation

2020-09-23 Thread GitBox
SparkQA commented on pull request #29859: URL: https://github.com/apache/spark/pull/29859#issuecomment-698093811 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33677/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29859: [SPARK-32971][K8S][FOLLOWUP] Add `.toSeq` for Scala 2.13 compilation

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29859: URL: https://github.com/apache/spark/pull/29859#issuecomment-698093835 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #29859: [SPARK-32971][K8S][FOLLOWUP] Add `.toSeq` for Scala 2.13 compilation

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29859: URL: https://github.com/apache/spark/pull/29859#issuecomment-698093830 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29859: [SPARK-32971][K8S][FOLLOWUP] Add `.toSeq` for Scala 2.13 compilation

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29859: URL: https://github.com/apache/spark/pull/29859#issuecomment-698093830 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] Victsm edited a comment on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
Victsm edited a comment on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697939630 A few clarifications on this PR: The entire netty RPC layer change for push-based shuffle is ~4000 LOC in our current implementation. We plan to break it down into 3

[GitHub] [spark] zero323 removed a comment on pull request #29591: [SPARK-32714][PYTHON] Initial pyspark-stubs port.

2020-09-23 Thread GitBox
zero323 removed a comment on pull request #29591: URL: https://github.com/apache/spark/pull/29591#issuecomment-697980912 Jenkins, retest this please. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
SparkQA commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697983109 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33665/

[GitHub] [spark] holdenk commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
holdenk commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697982974 jenkins retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697983126 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29591: [SPARK-32714][PYTHON] Initial pyspark-stubs port.

2020-09-23 Thread GitBox
SparkQA commented on pull request #29591: URL: https://github.com/apache/spark/pull/29591#issuecomment-697983153 **[Test build #129047 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129047/testReport)** for PR 29591 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697983134 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697983126 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29828: URL: https://github.com/apache/spark/pull/29828#issuecomment-697995262 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29828: URL: https://github.com/apache/spark/pull/29828#issuecomment-697995262 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-23 Thread GitBox
SparkQA removed a comment on pull request #29828: URL: https://github.com/apache/spark/pull/29828#issuecomment-697707135 **[Test build #129039 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129039/testReport)** for PR 29828 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
dongjoon-hyun commented on pull request #29846: URL: https://github.com/apache/spark/pull/29846#issuecomment-698008622 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
SparkQA commented on pull request #29846: URL: https://github.com/apache/spark/pull/29846#issuecomment-698010893 **[Test build #129050 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129050/testReport)** for PR 29846 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
SparkQA removed a comment on pull request #29846: URL: https://github.com/apache/spark/pull/29846#issuecomment-698010893 **[Test build #129050 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129050/testReport)** for PR 29846 at commit

[GitHub] [spark] SparkQA commented on pull request #29533: [SPARK-24266][K8S][3.0] Restart the watcher when we receive a version changed from k8s

2020-09-23 Thread GitBox
SparkQA commented on pull request #29533: URL: https://github.com/apache/spark/pull/29533#issuecomment-698015366 **[Test build #129051 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129051/testReport)** for PR 29533 at commit

[GitHub] [spark] SparkQA commented on pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
SparkQA commented on pull request #29846: URL: https://github.com/apache/spark/pull/29846#issuecomment-698015143 **[Test build #129050 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129050/testReport)** for PR 29846 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29846: URL: https://github.com/apache/spark/pull/29846#issuecomment-698015255 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29846: URL: https://github.com/apache/spark/pull/29846#issuecomment-698015255 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] holdenk commented on a change in pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-23 Thread GitBox
holdenk commented on a change in pull request #29817: URL: https://github.com/apache/spark/pull/29817#discussion_r493940745 ## File path: core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala ## @@ -61,13 +61,34 @@ private[deploy] object DeployMessages { }

[GitHub] [spark] viirya commented on a change in pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
viirya commented on a change in pull request #29846: URL: https://github.com/apache/spark/pull/29846#discussion_r493947730 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesVolumeSpec.scala ## @@ -21,7 +21,10 @@

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-698025365 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
SparkQA removed a comment on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697963914 **[Test build #129045 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129045/testReport)** for PR 29855 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-698025357 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-698025357 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29846: URL: https://github.com/apache/spark/pull/29846#issuecomment-698028783 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun closed pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
dongjoon-hyun closed pull request #29846: URL: https://github.com/apache/spark/pull/29846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] SparkQA commented on pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
SparkQA commented on pull request #29846: URL: https://github.com/apache/spark/pull/29846#issuecomment-698028773 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33671/

[GitHub] [spark] dongjoon-hyun commented on pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
dongjoon-hyun commented on pull request #29846: URL: https://github.com/apache/spark/pull/29846#issuecomment-698028969 All tests passed. Merged to master for Apache Spark 3.1.0 on December 2020. This is an automated message

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29846: URL: https://github.com/apache/spark/pull/29846#issuecomment-698028783 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29533: [SPARK-24266][K8S][3.0] Restart the watcher when we receive a version changed from k8s

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29533: URL: https://github.com/apache/spark/pull/29533#issuecomment-698036269 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29533: [SPARK-24266][K8S][3.0] Restart the watcher when we receive a version changed from k8s

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29533: URL: https://github.com/apache/spark/pull/29533#issuecomment-698036258 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29533: [SPARK-24266][K8S][3.0] Restart the watcher when we receive a version changed from k8s

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29533: URL: https://github.com/apache/spark/pull/29533#issuecomment-698036258 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-23 Thread GitBox
SparkQA commented on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-698046398 **[Test build #129052 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129052/testReport)** for PR 29585 at commit

[GitHub] [spark] github-actions[bot] commented on pull request #27604: [SPARK-30849][CORE][SHUFFLE]Fix application failed due to failed to get MapStatuses broadcast block

2020-09-23 Thread GitBox
github-actions[bot] commented on pull request #27604: URL: https://github.com/apache/spark/pull/27604#issuecomment-698046347 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] github-actions[bot] commented on pull request #28642: [SPARK-31809][SQL] Infer IsNotNull for non null intolerant child of null intolerant in join condition

2020-09-23 Thread GitBox
github-actions[bot] commented on pull request #28642: URL: https://github.com/apache/spark/pull/28642#issuecomment-698046330 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] AmplabJenkins commented on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-698046662 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] holdenk commented on pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-23 Thread GitBox
holdenk commented on pull request #29817: URL: https://github.com/apache/spark/pull/29817#issuecomment-698064084 I’m not joking. The test has multiple conditions. Another PR broke one of the conditions. This PR in its original broke another one of the conditions. It was reported in the

[GitHub] [spark] SparkQA removed a comment on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-23 Thread GitBox
SparkQA removed a comment on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-698053324 **[Test build #129053 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129053/testReport)** for PR 29585 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #29858: [SPARK-32981][BUILD][FOLLOW-UP] Remove hive-1.2 profiles in PIP installation option

2020-09-23 Thread GitBox
dongjoon-hyun commented on pull request #29858: URL: https://github.com/apache/spark/pull/29858#issuecomment-698077311 Thank you~ This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] Ngone51 commented on a change in pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-23 Thread GitBox
Ngone51 commented on a change in pull request #29817: URL: https://github.com/apache/spark/pull/29817#discussion_r494005838 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1809,7 +1809,9 @@ private[spark] class BlockManager(

[GitHub] [spark] HyukjinKwon commented on pull request #29858: [SPARK-32981][BUILD][FOLLOW-UP] Remove hive-1.2 profiles in PIP installation option

2020-09-23 Thread GitBox
HyukjinKwon commented on pull request #29858: URL: https://github.com/apache/spark/pull/29858#issuecomment-698077240 Sure, filing a separate JIRA is fine by me. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29054: [SPARK-32243][SQL]HiveSessionCatalog call super.makeFunctionExpression should throw earlier when got Spark UDAF Invalid arguments numbe

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29054: URL: https://github.com/apache/spark/pull/29054#issuecomment-698077888 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29054: [SPARK-32243][SQL]HiveSessionCatalog call super.makeFunctionExpression should throw earlier when got Spark UDAF Invalid arguments number erro

2020-09-23 Thread GitBox
SparkQA commented on pull request #29054: URL: https://github.com/apache/spark/pull/29054#issuecomment-698077548 **[Test build #129057 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129057/testReport)** for PR 29054 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #29853: [SPARK-SQL][SPARK-32977] Fix JavaDoc on Default Save Mode

2020-09-23 Thread GitBox
HyukjinKwon commented on pull request #29853: URL: https://github.com/apache/spark/pull/29853#issuecomment-698080155 It would have been better if we keep [the PR template](https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE) though.

<    1   2   3   4   5   6   7   8   >