mridulm commented on pull request #29855:
URL: https://github.com/apache/spark/pull/29855#issuecomment-697962451
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on
sunchao commented on a change in pull request #29843:
URL: https://github.com/apache/spark/pull/29843#discussion_r493888402
##
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
##
@@ -308,7 +307,7 @@ private[spark] class
srowen commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-697711108
Shoot. If this is non-essential, I think we can just revert it.
Or .. just lose this test? let me comment on the other PR.
holdenk opened a new pull request #29854:
URL: https://github.com/apache/spark/pull/29854
### What changes were proposed in this pull request?
Fixes the log strings the decom integration tests looks for and add comments
reminding people to run the K8s integration tests when changing
holdenk commented on a change in pull request #29846:
URL: https://github.com/apache/spark/pull/29846#discussion_r493778976
##
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
##
@@ -323,4 +323,22 @@ private[spark]
holdenk commented on pull request #29471:
URL: https://github.com/apache/spark/pull/29471#issuecomment-697829255
Looks like we've reached a lazy consesus here I'll merge this today :)
This is an automated message from the
holdenk commented on pull request #28921:
URL: https://github.com/apache/spark/pull/28921#issuecomment-697829881
Jenkins ok to test.
This is an automated message from the Apache Git Service.
To respond to the message, please
gemelen commented on pull request #29286:
URL: https://github.com/apache/spark/pull/29286#issuecomment-697886553
Nice. At least on Jenkins this passes as a whole and that promises that
tests should succeeded on GH as well, as soon as doc generation phase would be
fixed.
AmplabJenkins removed a comment on pull request #29798:
URL: https://github.com/apache/spark/pull/29798#issuecomment-697924790
This is an automated message from the Apache Git Service.
To respond to the message, please log on
MaxGekk commented on pull request #29339:
URL: https://github.com/apache/spark/pull/29339#issuecomment-697940610
General comments:
- Please, change PR's title to `[SPARK-32512][SQL] ...`
- There is special section `Why` in PR description template for `There are
no partition command
AmplabJenkins commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697958769
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697957673
**[Test build #129040 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129040/testReport)**
for PR 29854 at commit
AmplabJenkins commented on pull request #29853:
URL: https://github.com/apache/spark/pull/29853#issuecomment-697979195
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29853:
URL: https://github.com/apache/spark/pull/29853#issuecomment-697656590
**[Test build #129037 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129037/testReport)**
for PR 29853 at commit
mridulm commented on pull request #29855:
URL: https://github.com/apache/spark/pull/29855#issuecomment-697978318
+CC @tgravescs
This is an automated message from the Apache Git Service.
To respond to the message, please log
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697985907
**[Test build #129048 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129048/testReport)**
for PR 29854 at commit
dongjoon-hyun commented on pull request #29856:
URL: https://github.com/apache/spark/pull/29856#issuecomment-698005804
Thank you, @srowen !
This is an automated message from the Apache Git Service.
To respond to the message,
zero323 commented on a change in pull request #29806:
URL: https://github.com/apache/spark/pull/29806#discussion_r493945020
##
File path: python/docs/source/user_guide/python_packaging.rst
##
@@ -0,0 +1,220 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+
AmplabJenkins commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698027137
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698027137
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #29855:
URL: https://github.com/apache/spark/pull/29855#issuecomment-697980048
**[Test build #129046 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129046/testReport)**
for PR 29855 at commit
SparkQA commented on pull request #29855:
URL: https://github.com/apache/spark/pull/29855#issuecomment-698042528
**[Test build #129046 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129046/testReport)**
for PR 29855 at commit
maropu commented on a change in pull request #29585:
URL: https://github.com/apache/spark/pull/29585#discussion_r493977794
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala
##
@@ -18,17 +18,34 @@
package
huaxingao commented on pull request #29850:
URL: https://github.com/apache/spark/pull/29850#issuecomment-698052224
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
maropu commented on a change in pull request #29804:
URL: https://github.com/apache/spark/pull/29804#discussion_r493984368
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##
@@ -348,20 +352,22 @@ case class FileSourceScanExec(
zhengruifeng commented on pull request #29850:
URL: https://github.com/apache/spark/pull/29850#issuecomment-698054895
@srowen This output vector irrelevant to the order of input columns, because
the output index of a feature is only determined by input columns name and
input value(for cat
AmplabJenkins removed a comment on pull request #29857:
URL: https://github.com/apache/spark/pull/29857#issuecomment-698070617
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
AngersZh commented on a change in pull request #29054:
URL: https://github.com/apache/spark/pull/29054#discussion_r493999752
##
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
##
@@ -69,7 +69,11 @@ private[sql] class
HyukjinKwon commented on pull request #29827:
URL: https://github.com/apache/spark/pull/29827#issuecomment-698075428
+1 for @dongjoon-hyun's...
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun commented on pull request #29859:
URL: https://github.com/apache/spark/pull/29859#issuecomment-698075649
Could you review this, @viirya ?
This is an automated message from the Apache Git Service.
To respond to
Ngone51 commented on a change in pull request #29817:
URL: https://github.com/apache/spark/pull/29817#discussion_r494003752
##
File path: core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala
##
@@ -61,13 +61,34 @@ private[deploy] object DeployMessages {
}
dongjoon-hyun opened a new pull request #29859:
URL: https://github.com/apache/spark/pull/29859
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
###
Ngone51 commented on a change in pull request #29817:
URL: https://github.com/apache/spark/pull/29817#discussion_r494003455
##
File path:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
##
@@ -213,9 +207,17 @@ private[spark] class
SparkQA commented on pull request #29860:
URL: https://github.com/apache/spark/pull/29860#issuecomment-698090510
**[Test build #129060 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129060/testReport)**
for PR 29860 at commit
AmplabJenkins commented on pull request #29860:
URL: https://github.com/apache/spark/pull/29860#issuecomment-698090732
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29860:
URL: https://github.com/apache/spark/pull/29860#issuecomment-698090732
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29824:
URL: https://github.com/apache/spark/pull/29824#issuecomment-697992447
**[Test build #129032 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129032/testReport)**
for PR 29824 at commit
dongjoon-hyun commented on pull request #29856:
URL: https://github.com/apache/spark/pull/29856#issuecomment-698003841
cc @srowen , @HyukjinKwon ,@gatorsmile , @liancheng
This is an automated message from the Apache Git
holdenk commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-698024268
I really like the idea of simplifying the RPC message flow, thanks for
taking this on @Ngone51 and I'm sorry the code here is so brittle to these
types of changes (the K8s
SparkQA commented on pull request #29855:
URL: https://github.com/apache/spark/pull/29855#issuecomment-698024864
**[Test build #129045 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129045/testReport)**
for PR 29855 at commit
SparkQA removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697953562
**[Test build #129043 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129043/testReport)**
for PR 29854 at commit
HyukjinKwon commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698038747
Thanks @holdenk and @dongjoon-hyun
This is an automated message from the Apache Git Service.
To respond to
AmplabJenkins removed a comment on pull request #29855:
URL: https://github.com/apache/spark/pull/29855#issuecomment-698043224
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29855:
URL: https://github.com/apache/spark/pull/29855#issuecomment-698043224
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29585:
URL: https://github.com/apache/spark/pull/29585#issuecomment-698046662
This is an automated message from the Apache Git Service.
To respond to the message, please log on
maropu commented on a change in pull request #29585:
URL: https://github.com/apache/spark/pull/29585#discussion_r493980221
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##
@@ -201,11 +201,6 @@ abstract class QueryPlan[PlanType
Ngone51 commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-698071835
> This PR in its original broke another one of the conditions.
Except for the breaking of the log(like you just fixed), what other
conditions this PR breaks?
Ngone51 edited a comment on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-698071835
> This PR in its original broke another one of the conditions.
Except for the breaking of the log(like you just fixed), what other
conditions does this PR break?
SparkQA commented on pull request #29859:
URL: https://github.com/apache/spark/pull/29859#issuecomment-698075792
**[Test build #129056 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129056/testReport)**
for PR 29859 at commit
dongjoon-hyun commented on pull request #29846:
URL: https://github.com/apache/spark/pull/29846#issuecomment-698075783
The follow-up PR is ready, https://github.com/apache/spark/pull/29859 .
This is an automated message from
HyukjinKwon commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698075993
@dongjoon-hyun, this affects end users, not the dev people who will use
`hive-1.2` profile.
I can file a separate JIRA but whenever the release distributions are
AmplabJenkins removed a comment on pull request #29054:
URL: https://github.com/apache/spark/pull/29054#issuecomment-698077888
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29859:
URL: https://github.com/apache/spark/pull/29859#issuecomment-698093811
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33677/
AmplabJenkins removed a comment on pull request #29859:
URL: https://github.com/apache/spark/pull/29859#issuecomment-698093835
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins commented on pull request #29859:
URL: https://github.com/apache/spark/pull/29859#issuecomment-698093830
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29859:
URL: https://github.com/apache/spark/pull/29859#issuecomment-698093830
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
Victsm edited a comment on pull request #29855:
URL: https://github.com/apache/spark/pull/29855#issuecomment-697939630
A few clarifications on this PR:
The entire netty RPC layer change for push-based shuffle is ~4000 LOC in our
current implementation. We plan to break it down into 3
zero323 removed a comment on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-697980912
Jenkins, retest this please.
This is an automated message from the Apache Git Service.
To respond to
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697983109
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33665/
holdenk commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697982974
jenkins retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
AmplabJenkins commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697983126
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-697983153
**[Test build #129047 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129047/testReport)**
for PR 29591 at commit
AmplabJenkins removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697983134
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697983126
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29828:
URL: https://github.com/apache/spark/pull/29828#issuecomment-697995262
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29828:
URL: https://github.com/apache/spark/pull/29828#issuecomment-697995262
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #29828:
URL: https://github.com/apache/spark/pull/29828#issuecomment-697707135
**[Test build #129039 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129039/testReport)**
for PR 29828 at commit
dongjoon-hyun commented on pull request #29846:
URL: https://github.com/apache/spark/pull/29846#issuecomment-698008622
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message,
SparkQA commented on pull request #29846:
URL: https://github.com/apache/spark/pull/29846#issuecomment-698010893
**[Test build #129050 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129050/testReport)**
for PR 29846 at commit
SparkQA removed a comment on pull request #29846:
URL: https://github.com/apache/spark/pull/29846#issuecomment-698010893
**[Test build #129050 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129050/testReport)**
for PR 29846 at commit
SparkQA commented on pull request #29533:
URL: https://github.com/apache/spark/pull/29533#issuecomment-698015366
**[Test build #129051 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129051/testReport)**
for PR 29533 at commit
SparkQA commented on pull request #29846:
URL: https://github.com/apache/spark/pull/29846#issuecomment-698015143
**[Test build #129050 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129050/testReport)**
for PR 29846 at commit
AmplabJenkins removed a comment on pull request #29846:
URL: https://github.com/apache/spark/pull/29846#issuecomment-698015255
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29846:
URL: https://github.com/apache/spark/pull/29846#issuecomment-698015255
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
holdenk commented on a change in pull request #29817:
URL: https://github.com/apache/spark/pull/29817#discussion_r493940745
##
File path: core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala
##
@@ -61,13 +61,34 @@ private[deploy] object DeployMessages {
}
viirya commented on a change in pull request #29846:
URL: https://github.com/apache/spark/pull/29846#discussion_r493947730
##
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesVolumeSpec.scala
##
@@ -21,7 +21,10 @@
AmplabJenkins removed a comment on pull request #29855:
URL: https://github.com/apache/spark/pull/29855#issuecomment-698025365
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA removed a comment on pull request #29855:
URL: https://github.com/apache/spark/pull/29855#issuecomment-697963914
**[Test build #129045 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129045/testReport)**
for PR 29855 at commit
AmplabJenkins commented on pull request #29855:
URL: https://github.com/apache/spark/pull/29855#issuecomment-698025357
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29855:
URL: https://github.com/apache/spark/pull/29855#issuecomment-698025357
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29846:
URL: https://github.com/apache/spark/pull/29846#issuecomment-698028783
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dongjoon-hyun closed pull request #29846:
URL: https://github.com/apache/spark/pull/29846
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
SparkQA commented on pull request #29846:
URL: https://github.com/apache/spark/pull/29846#issuecomment-698028773
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33671/
dongjoon-hyun commented on pull request #29846:
URL: https://github.com/apache/spark/pull/29846#issuecomment-698028969
All tests passed. Merged to master for Apache Spark 3.1.0 on December 2020.
This is an automated message
AmplabJenkins removed a comment on pull request #29846:
URL: https://github.com/apache/spark/pull/29846#issuecomment-698028783
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29533:
URL: https://github.com/apache/spark/pull/29533#issuecomment-698036269
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29533:
URL: https://github.com/apache/spark/pull/29533#issuecomment-698036258
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29533:
URL: https://github.com/apache/spark/pull/29533#issuecomment-698036258
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29585:
URL: https://github.com/apache/spark/pull/29585#issuecomment-698046398
**[Test build #129052 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129052/testReport)**
for PR 29585 at commit
github-actions[bot] commented on pull request #27604:
URL: https://github.com/apache/spark/pull/27604#issuecomment-698046347
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue
github-actions[bot] commented on pull request #28642:
URL: https://github.com/apache/spark/pull/28642#issuecomment-698046330
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue
AmplabJenkins commented on pull request #29585:
URL: https://github.com/apache/spark/pull/29585#issuecomment-698046662
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
holdenk commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-698064084
I’m not joking. The test has multiple conditions. Another PR broke one of
the conditions. This PR in its original broke another one of the conditions. It
was reported in the
SparkQA removed a comment on pull request #29585:
URL: https://github.com/apache/spark/pull/29585#issuecomment-698053324
**[Test build #129053 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129053/testReport)**
for PR 29585 at commit
dongjoon-hyun commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698077311
Thank you~
This is an automated message from the Apache Git Service.
To respond to the message, please
Ngone51 commented on a change in pull request #29817:
URL: https://github.com/apache/spark/pull/29817#discussion_r494005838
##
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##
@@ -1809,7 +1809,9 @@ private[spark] class BlockManager(
HyukjinKwon commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698077240
Sure, filing a separate JIRA is fine by me.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29054:
URL: https://github.com/apache/spark/pull/29054#issuecomment-698077888
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29054:
URL: https://github.com/apache/spark/pull/29054#issuecomment-698077548
**[Test build #129057 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129057/testReport)**
for PR 29054 at commit
HyukjinKwon commented on pull request #29853:
URL: https://github.com/apache/spark/pull/29853#issuecomment-698080155
It would have been better if we keep [the PR
template](https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE)
though.
201 - 300 of 705 matches
Mail list logo