[GitHub] [spark] SparkQA commented on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

SparkQA commented on pull request #30053: URL: https://github.com/apache/spark/pull/30053#issuecomment-709870468 **[Test build #129881 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129881/testReport)** for PR 30053 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

cloud-fan commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506112213 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala ## @@ -139,20 +142,22 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

cloud-fan commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506112571 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala ## @@ -139,20 +142,22 @@ class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29891: [SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

AmplabJenkins removed a comment on pull request #29891: URL: https://github.com/apache/spark/pull/29891#issuecomment-709959004 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29891: [SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

AmplabJenkins removed a comment on pull request #29891: URL: https://github.com/apache/spark/pull/29891#issuecomment-709959012 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30035: [SPARK-33145] [WEBUI] Fix when `Succeeded Jobs` has many child url elements,they will extend over the edge of the page.

AmplabJenkins removed a comment on pull request #30035: URL: https://github.com/apache/spark/pull/30035#issuecomment-708602303 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] turboFei edited a comment on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

turboFei edited a comment on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-709978338 Seems the bracketedCommentLevel could handle this case: ``` /* /* */ */ ```

[GitHub] [spark] cloud-fan commented on a change in pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

cloud-fan commented on a change in pull request #30045: URL: https://github.com/apache/spark/pull/30045#discussion_r506298572 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/SetCommand.scala ## @@ -172,7 +172,7 @@ object SetCommand { case class

[GitHub] [spark] gengliangwang commented on pull request #30035: [SPARK-33145] [WEBUI] Fix when `Succeeded Jobs` has many child url elements,they will extend over the edge of the page.

gengliangwang commented on pull request #30035: URL: https://github.com/apache/spark/pull/30035#issuecomment-709978946 @akiyamaneko Thanks for the improvement! Could you add the screenshot after fix in the PR description?

[GitHub] [spark] turboFei edited a comment on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

turboFei edited a comment on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-709978338 Seems the bracketedCommentLevel could handle this case: ``` /* /* */ */ ```

[GitHub] [spark] SparkQA commented on pull request #29999: [SPARK-33045][SQL] Support build-in function like_all and fix StackOverflowError issue.

SparkQA commented on pull request #2: URL: https://github.com/apache/spark/pull/2#issuecomment-709984040 **[Test build #129884 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129884/testReport)** for PR 2 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29999: [SPARK-33045][SQL] Support build-in function like_all and fix StackOverflowError issue.

SparkQA removed a comment on pull request #2: URL: https://github.com/apache/spark/pull/2#issuecomment-709890593 **[Test build #129884 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129884/testReport)** for PR 2 at commit

[GitHub] [spark] beliefer commented on pull request #30023: [SPARK-33126][SQL] Simplify offset window function(Remove direction field)

beliefer commented on pull request #30023: URL: https://github.com/apache/spark/pull/30023#issuecomment-709983930 @cloud-fan Thanks for your help! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #29891: [SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

SparkQA commented on pull request #29891: URL: https://github.com/apache/spark/pull/29891#issuecomment-709983886 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34496/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

AmplabJenkins removed a comment on pull request #30045: URL: https://github.com/apache/spark/pull/30045#issuecomment-709985348 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on a change in pull request #29881: [SPARK-32852][SQL] spark.sql.hive.metastore.jars support HDFS location

cloud-fan commented on a change in pull request #29881: URL: https://github.com/apache/spark/pull/29881#discussion_r506311033 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala ## @@ -80,20 +81,41 @@ private[spark] object HiveUtils extends Logging

[GitHub] [spark] beliefer commented on pull request #29999: [SPARK-33045][SQL] Support build-in function like_all and fix StackOverflowError issue.

beliefer commented on pull request #2: URL: https://github.com/apache/spark/pull/2#issuecomment-709985924 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] cloud-fan commented on a change in pull request #29881: [SPARK-32852][SQL] spark.sql.hive.metastore.jars support HDFS location

cloud-fan commented on a change in pull request #29881: URL: https://github.com/apache/spark/pull/29881#discussion_r506311427 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala ## @@ -80,20 +81,41 @@ private[spark] object HiveUtils extends Logging

[GitHub] [spark] akiyamaneko edited a comment on pull request #30035: [SPARK-33145] [WEBUI] Fix when `Succeeded Jobs` has many child url elements,they will extend over the edge of the page.

akiyamaneko edited a comment on pull request #30035: URL: https://github.com/apache/spark/pull/30035#issuecomment-709997845 I have attached the screenshot, or you can visit this:

[GitHub] [spark] SparkQA commented on pull request #30035: [SPARK-33145] [WEBUI] Fix when `Succeeded Jobs` has many child url elements,they will extend over the edge of the page.

SparkQA commented on pull request #30035: URL: https://github.com/apache/spark/pull/30035#issuecomment-709997808 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34497/

[GitHub] [spark] akiyamaneko commented on pull request #30035: [SPARK-33145] [WEBUI] Fix when `Succeeded Jobs` has many child url elements,they will extend over the edge of the page.

akiyamaneko commented on pull request #30035: URL: https://github.com/apache/spark/pull/30035#issuecomment-709997845 I have attached the screenshot, or you can vist [fix-screenshot](https://user-images.githubusercontent.com/52202080/95977319-50734600-0e4b-11eb-93c0-b8deb565bcd8.png)

[GitHub] [spark] yaooqinn commented on a change in pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

yaooqinn commented on a change in pull request #30045: URL: https://github.com/apache/spark/pull/30045#discussion_r506354101 ## File path: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ## @@ -55,10 +55,11 @@ private[sql] class SharedState(

[GitHub] [spark] beliefer commented on a change in pull request #29999: [SPARK-33045][SQL] Support build-in function like_all and fix StackOverflowError issue.

beliefer commented on a change in pull request #2: URL: https://github.com/apache/spark/pull/2#discussion_r506142456 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ## @@ -176,6 +177,125 @@ case class

[GitHub] [spark] SparkQA commented on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

SparkQA commented on pull request #30053: URL: https://github.com/apache/spark/pull/30053#issuecomment-709895901 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34486/

[GitHub] [spark] AmplabJenkins commented on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

AmplabJenkins commented on pull request #30053: URL: https://github.com/apache/spark/pull/30053#issuecomment-709895923 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

AmplabJenkins removed a comment on pull request #30053: URL: https://github.com/apache/spark/pull/30053#issuecomment-709895923 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

AmplabJenkins removed a comment on pull request #30053: URL: https://github.com/apache/spark/pull/30053#issuecomment-709895941 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

AmplabJenkins removed a comment on pull request #30045: URL: https://github.com/apache/spark/pull/30045#issuecomment-709909596 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30023: [SPARK-33126][SQL] Simplify offset window function(Remove direction field)

SparkQA commented on pull request #30023: URL: https://github.com/apache/spark/pull/30023#issuecomment-709929939 **[Test build #129889 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129889/testReport)** for PR 30023 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28938: [SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

AmplabJenkins removed a comment on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-709928778 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30009: [SPARK-32907][ML] adaptively blockify instances - LinearSVC

AmplabJenkins removed a comment on pull request #30009: URL: https://github.com/apache/spark/pull/30009#issuecomment-709937564 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #30009: [SPARK-32907][ML] adaptively blockify instances - LinearSVC

SparkQA removed a comment on pull request #30009: URL: https://github.com/apache/spark/pull/30009#issuecomment-709903604 **[Test build #129886 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129886/testReport)** for PR 30009 at commit

[GitHub] [spark] turboFei commented on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

turboFei commented on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-709978338 Seems the bracketedCommentLevel could handle this case: ``` /* /* */ */ ``` This is an automated

[GitHub] [spark] cloud-fan commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

cloud-fan commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506295439 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/InsertTableWithDynamicPartitionsBenchmark.scala ## @@ -0,0 +1,138 @@

[GitHub] [spark] gengliangwang commented on pull request #30035: [SPARK-33145] [WEBUI] Fix when `Succeeded Jobs` has many child url elements,they will extend over the edge of the page.

gengliangwang commented on pull request #30035: URL: https://github.com/apache/spark/pull/30035#issuecomment-709978616 ok to test This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA commented on pull request #30035: [SPARK-33145] [WEBUI] Fix when `Succeeded Jobs` has many child url elements,they will extend over the edge of the page.

SparkQA commented on pull request #30035: URL: https://github.com/apache/spark/pull/30035#issuecomment-709980869 **[Test build #129892 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129892/testReport)** for PR 30035 at commit

[GitHub] [spark] SparkQA commented on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

SparkQA commented on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-709984531 **[Test build #129893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129893/testReport)** for PR 29982 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29999: [SPARK-33045][SQL] Support build-in function like_all and fix StackOverflowError issue.

AmplabJenkins commented on pull request #2: URL: https://github.com/apache/spark/pull/2#issuecomment-709984475 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

SparkQA commented on pull request #30045: URL: https://github.com/apache/spark/pull/30045#issuecomment-709984802 **[Test build #129883 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129883/testReport)** for PR 30045 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29999: [SPARK-33045][SQL] Support build-in function like_all and fix StackOverflowError issue.

AmplabJenkins removed a comment on pull request #2: URL: https://github.com/apache/spark/pull/2#issuecomment-709984478 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29999: [SPARK-33045][SQL] Support build-in function like_all and fix StackOverflowError issue.

AmplabJenkins removed a comment on pull request #2: URL: https://github.com/apache/spark/pull/2#issuecomment-709984475 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

AmplabJenkins removed a comment on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-70394 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

SparkQA removed a comment on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-709984531 **[Test build #129893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129893/testReport)** for PR 29982 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

AmplabJenkins commented on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-70394 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

AmplabJenkins removed a comment on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-710014843 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] srowen commented on pull request #30034: [SPARK-33111][ML][Follow-Up] aft transform optimization - predictQuantiles

srowen commented on pull request #30034: URL: https://github.com/apache/spark/pull/30034#issuecomment-710029484 It seems OK ; out of curiosity does this help much? This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

SparkQA commented on pull request #30053: URL: https://github.com/apache/spark/pull/30053#issuecomment-709874931 **[Test build #129882 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129882/testReport)** for PR 30053 at commit

[GitHub] [spark] SparkQA commented on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

SparkQA commented on pull request #30053: URL: https://github.com/apache/spark/pull/30053#issuecomment-709884964 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34486/

[GitHub] [spark] SparkQA commented on pull request #30025: [SPARK-33095][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: add, update type and nullability of columns (MySQL dialect)

SparkQA commented on pull request #30025: URL: https://github.com/apache/spark/pull/30025#issuecomment-709883799 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34485/

[GitHub] [spark] LuciferYang commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

LuciferYang commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506148242 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala ## @@ -139,20 +142,22 @@ class

[GitHub] [spark] gemelen commented on pull request #29995: [SPARK-33080][BUILD] Replace fatal warnings snippet

gemelen commented on pull request #29995: URL: https://github.com/apache/spark/pull/29995#issuecomment-709904229 @srowen thanks a lot for your efforts to pass this changeset This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #30009: [SPARK-32907][ML] adaptively blockify instances - LinearSVC

SparkQA commented on pull request #30009: URL: https://github.com/apache/spark/pull/30009#issuecomment-709903604 **[Test build #129886 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129886/testReport)** for PR 30009 at commit

[GitHub] [spark] SparkQA commented on pull request #28938: [SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

SparkQA commented on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-709903663 **[Test build #129887 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129887/testReport)** for PR 28938 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

AmplabJenkins commented on pull request #30053: URL: https://github.com/apache/spark/pull/30053#issuecomment-709925199 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

SparkQA commented on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-709925226 **[Test build #129888 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129888/testReport)** for PR 29982 at commit

[GitHub] [spark] SparkQA commented on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

SparkQA commented on pull request #30053: URL: https://github.com/apache/spark/pull/30053#issuecomment-709924924 **[Test build #129881 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129881/testReport)** for PR 30053 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

SparkQA removed a comment on pull request #30053: URL: https://github.com/apache/spark/pull/30053#issuecomment-709870468 **[Test build #129881 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129881/testReport)** for PR 30053 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

AmplabJenkins removed a comment on pull request #30053: URL: https://github.com/apache/spark/pull/30053#issuecomment-709925199 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

AmplabJenkins removed a comment on pull request #30026: URL: https://github.com/apache/spark/pull/30026#issuecomment-709932719 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

SparkQA commented on pull request #30026: URL: https://github.com/apache/spark/pull/30026#issuecomment-709932689 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34490/

[GitHub] [spark] AmplabJenkins commented on pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

AmplabJenkins commented on pull request #30026: URL: https://github.com/apache/spark/pull/30026#issuecomment-709932719 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] beliefer commented on pull request #29891: [SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

beliefer commented on pull request #29891: URL: https://github.com/apache/spark/pull/29891#issuecomment-709964682 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] cloud-fan commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

cloud-fan commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506291180 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala ## @@ -76,7 +79,7 @@ class

[GitHub] [spark] ScrapCodes commented on a change in pull request #30025: [SPARK-33095][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: add, update type and nullability of columns (MySQL dialect)

ScrapCodes commented on a change in pull request #30025: URL: https://github.com/apache/spark/pull/30025#discussion_r506320770 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala ## @@ -48,4 +48,26 @@ private case object MySQLDialect extends

[GitHub] [spark] yaooqinn commented on a change in pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

yaooqinn commented on a change in pull request #30045: URL: https://github.com/apache/spark/pull/30045#discussion_r506343027 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/SetCommand.scala ## @@ -172,7 +172,7 @@ object SetCommand { case class

[GitHub] [spark] SparkQA commented on pull request #29999: [SPARK-33045][SQL] Support build-in function like_all and fix StackOverflowError issue.

SparkQA commented on pull request #2: URL: https://github.com/apache/spark/pull/2#issuecomment-710011513 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34499/

[GitHub] [spark] AmplabJenkins commented on pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

AmplabJenkins commented on pull request #30026: URL: https://github.com/apache/spark/pull/30026#issuecomment-710011549 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

AmplabJenkins removed a comment on pull request #30026: URL: https://github.com/apache/spark/pull/30026#issuecomment-710011549 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

SparkQA commented on pull request #30045: URL: https://github.com/apache/spark/pull/30045#issuecomment-709878764 **[Test build #129883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129883/testReport)** for PR 30045 at commit

[GitHub] [spark] LuciferYang commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

LuciferYang commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506147287 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala ## @@ -76,7 +79,7 @@ class

[GitHub] [spark] SparkQA commented on pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

SparkQA commented on pull request #30045: URL: https://github.com/apache/spark/pull/30045#issuecomment-709900599 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34488/

[GitHub] [spark] beliefer commented on a change in pull request #29891: [SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

beliefer commented on a change in pull request #29891: URL: https://github.com/apache/spark/pull/29891#discussion_r506217898 ## File path: sql/core/src/test/resources/sql-tests/inputs/regexp-functions.sql ## @@ -31,3 +31,14 @@ SELECT regexp_extract_all('1a 2b 14m',

[GitHub] [spark] beliefer commented on a change in pull request #29891: [SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

beliefer commented on a change in pull request #29891: URL: https://github.com/apache/spark/pull/29891#discussion_r506217520 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ## @@ -318,16 +320,46 @@ case class

[GitHub] [spark] AmplabJenkins commented on pull request #30009: [SPARK-32907][ML] adaptively blockify instances - LinearSVC

AmplabJenkins commented on pull request #30009: URL: https://github.com/apache/spark/pull/30009#issuecomment-709937564 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30009: [SPARK-32907][ML] adaptively blockify instances - LinearSVC

SparkQA commented on pull request #30009: URL: https://github.com/apache/spark/pull/30009#issuecomment-709937125 **[Test build #129886 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129886/testReport)** for PR 30009 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

AmplabJenkins removed a comment on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-709942664 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

AmplabJenkins commented on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-709942655 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

SparkQA removed a comment on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-709925226 **[Test build #129888 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129888/testReport)** for PR 29982 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30009: [SPARK-32907][ML] adaptively blockify instances - LinearSVC

AmplabJenkins commented on pull request #30009: URL: https://github.com/apache/spark/pull/30009#issuecomment-709943526 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30009: [SPARK-32907][ML] adaptively blockify instances - LinearSVC

SparkQA commented on pull request #30009: URL: https://github.com/apache/spark/pull/30009#issuecomment-709943505 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34492/

[GitHub] [spark] AmplabJenkins commented on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

AmplabJenkins commented on pull request #30053: URL: https://github.com/apache/spark/pull/30053#issuecomment-709943463 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

SparkQA removed a comment on pull request #30053: URL: https://github.com/apache/spark/pull/30053#issuecomment-709874931 **[Test build #129882 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129882/testReport)** for PR 30053 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

AmplabJenkins removed a comment on pull request #30053: URL: https://github.com/apache/spark/pull/30053#issuecomment-709943475 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

SparkQA commented on pull request #30053: URL: https://github.com/apache/spark/pull/30053#issuecomment-709943267 **[Test build #129882 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129882/testReport)** for PR 30053 at commit

[GitHub] [spark] SparkQA commented on pull request #30023: [SPARK-33126][SQL] Simplify offset window function(Remove direction field)

SparkQA commented on pull request #30023: URL: https://github.com/apache/spark/pull/30023#issuecomment-709949211 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34494/

[GitHub] [spark] SparkQA commented on pull request #30023: [SPARK-33126][SQL] Simplify offset window function(Remove direction field)

SparkQA commented on pull request #30023: URL: https://github.com/apache/spark/pull/30023#issuecomment-709957614 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34494/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30023: [SPARK-33126][SQL] Simplify offset window function(Remove direction field)

AmplabJenkins removed a comment on pull request #30023: URL: https://github.com/apache/spark/pull/30023#issuecomment-709957634 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30023: [SPARK-33126][SQL] Simplify offset window function(Remove direction field)

AmplabJenkins commented on pull request #30023: URL: https://github.com/apache/spark/pull/30023#issuecomment-709957634 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on pull request #30029: [SPARK-33131][SQL] Fix grouping sets with having clause can not resolve qualified col name

cloud-fan commented on pull request #30029: URL: https://github.com/apache/spark/pull/30029#issuecomment-709988668 GA passed, thanks, merging to master! This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] cloud-fan closed pull request #30029: [SPARK-33131][SQL] Fix grouping sets with having clause can not resolve qualified col name

cloud-fan closed pull request #30029: URL: https://github.com/apache/spark/pull/30029 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #30029: [SPARK-33131][SQL] Fix grouping sets with having clause can not resolve qualified col name

cloud-fan commented on pull request #30029: URL: https://github.com/apache/spark/pull/30029#issuecomment-709989015 @ulysses-you can you send backport PRs for 3.0 and 2.4? thanks! This is an automated message from the Apache

[GitHub] [spark] yaooqinn commented on a change in pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

yaooqinn commented on a change in pull request #30045: URL: https://github.com/apache/spark/pull/30045#discussion_r506352466 ## File path: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ## @@ -55,10 +55,11 @@ private[sql] class SharedState(

[GitHub] [spark] SparkQA commented on pull request #30018: [SPARK-33122][SQL] Remove redundant aggregates in the Optimzier

SparkQA commented on pull request #30018: URL: https://github.com/apache/spark/pull/30018#issuecomment-710024768 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34500/

[GitHub] [spark] cloud-fan commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

cloud-fan commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506111562 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala ## @@ -76,7 +79,7 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

cloud-fan commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506110093 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala ## @@ -30,12 +32,13 @@ import

[GitHub] [spark] LuciferYang commented on a change in pull request #30026: [SPARK-32978][SQL] Make sure the number of dynamic part metric is correct

LuciferYang commented on a change in pull request #30026: URL: https://github.com/apache/spark/pull/30026#discussion_r506151340 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala ## @@ -139,20 +142,22 @@ class

[GitHub] [spark] SparkQA commented on pull request #28938: [SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

SparkQA commented on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-709919948 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34491/

[GitHub] [spark] beliefer commented on a change in pull request #30023: [SPARK-33126][SQL] Simplify offset window function(Remove direction field)

beliefer commented on a change in pull request #30023: URL: https://github.com/apache/spark/pull/30023#discussion_r506204707 ## File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/window_part1.sql.out ## @@ -202,7 +202,7 @@ struct +struct Review comment:

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28938: [SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

AmplabJenkins removed a comment on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-709935310 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

SparkQA commented on pull request #29982: URL: https://github.com/apache/spark/pull/29982#issuecomment-709942293 **[Test build #129888 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129888/testReport)** for PR 29982 at commit

  1   2   3   4   5   6   7   8   9   >