[GitHub] [spark] HyukjinKwon commented on a change in pull request #28026: [SPARK-31257][SQL] Unify create table syntax

2020-10-27 Thread GitBox
HyukjinKwon commented on a change in pull request #28026: URL: https://github.com/apache/spark/pull/28026#discussion_r513197469 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala ## @@ -295,18 +295,61 @@ private[sql] object

[GitHub] [spark] HeartSaVioR edited a comment on pull request #30167: [SPARK-33240][SQL][3.0] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
HeartSaVioR edited a comment on pull request #30167: URL: https://github.com/apache/spark/pull/30167#issuecomment-717716130 Isn't it declared as "incorrect" behavior in discussion thread in dev. mailing list? If that's not a bug what exactly we fix for master branch? I think it's a kind

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #30162: URL: https://github.com/apache/spark/pull/30162#issuecomment-717714917 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30167: [SPARK-33240][SQL][3.0] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #30167: URL: https://github.com/apache/spark/pull/30167#issuecomment-717714930 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-10-27 Thread GitBox
SparkQA commented on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-717716376 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34957/

[GitHub] [spark] HeartSaVioR commented on pull request #30167: [SPARK-33240][SQL][3.0] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
HeartSaVioR commented on pull request #30167: URL: https://github.com/apache/spark/pull/30167#issuecomment-717716130 Isn't it declared as "incorrect" behavior in discussion thread in dev. mailing list? If that's not a bug what exactly we fix for master branch? I think it's a kind of

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30167: [SPARK-33240][SQL][3.0] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #30167: URL: https://github.com/apache/spark/pull/30167#issuecomment-717714926 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30147: [SPARK-33240][SQL] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #30147: URL: https://github.com/apache/spark/pull/30147#issuecomment-717708872 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #30162: URL: https://github.com/apache/spark/pull/30162#issuecomment-717714910 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #30147: [SPARK-33240][SQL] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
SparkQA removed a comment on pull request #30147: URL: https://github.com/apache/spark/pull/30147#issuecomment-717631159 **[Test build #130343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130343/testReport)** for PR 30147 at commit

[GitHub] [spark] cloud-fan commented on pull request #30093: [SPARK-33183][SQL] Fix Optimizer rule EliminateSorts and add a physical rule to remove redundant sorts

2020-10-27 Thread GitBox
cloud-fan commented on pull request #30093: URL: https://github.com/apache/spark/pull/30093#issuecomment-717715392 @viirya @maropu what do you think about backporting? Shall we backport without the new rule or with it? This

[GitHub] [spark] cloud-fan closed pull request #30093: [SPARK-33183][SQL] Fix Optimizer rule EliminateSorts and add a physical rule to remove redundant sorts

2020-10-27 Thread GitBox
cloud-fan closed pull request #30093: URL: https://github.com/apache/spark/pull/30093 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] SparkQA commented on pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
SparkQA commented on pull request #30162: URL: https://github.com/apache/spark/pull/30162#issuecomment-717714903 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34953/

[GitHub] [spark] SparkQA commented on pull request #30167: [SPARK-33240][SQL][3.0] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
SparkQA commented on pull request #30167: URL: https://github.com/apache/spark/pull/30167#issuecomment-717714913 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34955/

[GitHub] [spark] AmplabJenkins commented on pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
AmplabJenkins commented on pull request #30162: URL: https://github.com/apache/spark/pull/30162#issuecomment-717714910 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #30167: [SPARK-33240][SQL][3.0] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
AmplabJenkins commented on pull request #30167: URL: https://github.com/apache/spark/pull/30167#issuecomment-717714926 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on pull request #30093: [SPARK-33183][SQL] Fix Optimizer rule EliminateSorts and add a physical rule to remove redundant sorts

2020-10-27 Thread GitBox
cloud-fan commented on pull request #30093: URL: https://github.com/apache/spark/pull/30093#issuecomment-717715051 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-10-27 Thread GitBox
SparkQA commented on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-717713671 **[Test build #130355 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130355/testReport)** for PR 30166 at commit

[GitHub] [spark] cloud-fan closed pull request #30079: [SPARK-33174][SQL] Migrate DROP TABLE to use UnresolvedTableOrView to resolve the identifier

2020-10-27 Thread GitBox
cloud-fan closed pull request #30079: URL: https://github.com/apache/spark/pull/30079 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #30079: [SPARK-33174][SQL] Migrate DROP TABLE to use UnresolvedTableOrView to resolve the identifier

2020-10-27 Thread GitBox
cloud-fan commented on pull request #30079: URL: https://github.com/apache/spark/pull/30079#issuecomment-717712906 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on a change in pull request #30079: [SPARK-33174][SQL] Migrate DROP TABLE to use UnresolvedTableOrView to resolve the identifier

2020-10-27 Thread GitBox
cloud-fan commented on a change in pull request #30079: URL: https://github.com/apache/spark/pull/30079#discussion_r513193419 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -367,9 +367,17 @@ class

[GitHub] [spark] SparkQA commented on pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
SparkQA commented on pull request #30162: URL: https://github.com/apache/spark/pull/30162#issuecomment-717711223 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34954/

[GitHub] [spark] HyukjinKwon commented on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-10-27 Thread GitBox
HyukjinKwon commented on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-717711256 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #29247: [SPARK-32446][SHS] Add new executor metrics summary REST APIs

2020-10-27 Thread GitBox
SparkQA commented on pull request #29247: URL: https://github.com/apache/spark/pull/29247#issuecomment-717710315 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34956/

[GitHub] [spark] SparkQA commented on pull request #30167: [SPARK-33240][SQL][3.0] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
SparkQA commented on pull request #30167: URL: https://github.com/apache/spark/pull/30167#issuecomment-717709003 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34955/

[GitHub] [spark] AmplabJenkins commented on pull request #30147: [SPARK-33240][SQL] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
AmplabJenkins commented on pull request #30147: URL: https://github.com/apache/spark/pull/30147#issuecomment-717708872 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30147: [SPARK-33240][SQL] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
SparkQA commented on pull request #30147: URL: https://github.com/apache/spark/pull/30147#issuecomment-717708073 **[Test build #130343 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130343/testReport)** for PR 30147 at commit

[GitHub] [spark] HyukjinKwon edited a comment on pull request #30167: [SPARK-33240][SQL][3.0] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
HyukjinKwon edited a comment on pull request #30167: URL: https://github.com/apache/spark/pull/30167#issuecomment-717706506 Hm, is it something we should port back? I think it's hard to call it a bug. Maintenance release shouldn't have such behaviour changes in general according to semver

[GitHub] [spark] SparkQA commented on pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
SparkQA commented on pull request #30162: URL: https://github.com/apache/spark/pull/30162#issuecomment-717706418 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34953/

[GitHub] [spark] HyukjinKwon commented on pull request #30167: [SPARK-33240][SQL][3.0] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
HyukjinKwon commented on pull request #30167: URL: https://github.com/apache/spark/pull/30167#issuecomment-717706506 Hm, is it something we should port back? I think it's hard to call it a bug. Maintenance release shouldn't have such behaviour changes in general according to semver though

[GitHub] [spark] otterc commented on a change in pull request #30062: [SPARK-32916][SHUFFLE] Implementation of shuffle service that leverages push-based shuffle in YARN deployment mode

2020-10-27 Thread GitBox
otterc commented on a change in pull request #30062: URL: https://github.com/apache/spark/pull/30062#discussion_r513185051 ## File path: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java ## @@ -94,6 +95,9 @@ static final String

[GitHub] [spark] SparkQA commented on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-10-27 Thread GitBox
SparkQA commented on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-717702143 **[Test build #130354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130354/testReport)** for PR 26935 at commit

[GitHub] [spark] HeartSaVioR commented on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-10-27 Thread GitBox
HeartSaVioR commented on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-717701730 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] otterc commented on a change in pull request #30062: [SPARK-32916][SHUFFLE] Implementation of shuffle service that leverages push-based shuffle in YARN deployment mode

2020-10-27 Thread GitBox
otterc commented on a change in pull request #30062: URL: https://github.com/apache/spark/pull/30062#discussion_r513182393 ## File path: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java ## @@ -279,6 +287,7 @@ public void

[GitHub] [spark] otterc commented on a change in pull request #30062: [SPARK-32916][SHUFFLE] Implementation of shuffle service that leverages push-based shuffle in YARN deployment mode

2020-10-27 Thread GitBox
otterc commented on a change in pull request #30062: URL: https://github.com/apache/spark/pull/30062#discussion_r513180854 ## File path: common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RemoteBlockPushResolverSuite.java ## @@ -0,0 +1,462 @@ +/* + *

[GitHub] [spark] HeartSaVioR commented on a change in pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
HeartSaVioR commented on a change in pull request #30162: URL: https://github.com/apache/spark/pull/30162#discussion_r513180738 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/OffsetSeq.scala ## @@ -89,10 +89,15 @@ case class OffsetSeqMetadata(

[GitHub] [spark] SparkQA commented on pull request #29247: [SPARK-32446][SHS] Add new executor metrics summary REST APIs

2020-10-27 Thread GitBox
SparkQA commented on pull request #29247: URL: https://github.com/apache/spark/pull/29247#issuecomment-717694392 **[Test build #130353 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130353/testReport)** for PR 29247 at commit

[GitHub] [spark] SparkQA commented on pull request #30167: [SPARK-33240][SQL][3.0] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
SparkQA commented on pull request #30167: URL: https://github.com/apache/spark/pull/30167#issuecomment-717694405 **[Test build #130352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130352/testReport)** for PR 30167 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29247: [SPARK-32446][SHS] Add new executor metrics summary REST APIs

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29247: URL: https://github.com/apache/spark/pull/29247#issuecomment-664032815 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] gengliangwang commented on pull request #29247: [SPARK-32446][SHS] Add new executor metrics summary REST APIs

2020-10-27 Thread GitBox
gengliangwang commented on pull request #29247: URL: https://github.com/apache/spark/pull/29247#issuecomment-717693646 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HeartSaVioR opened a new pull request #30167: [SPARK-33240][SQL][3.0] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
HeartSaVioR opened a new pull request #30167: URL: https://github.com/apache/spark/pull/30167 ### What changes were proposed in this pull request? This patch proposes to change the behavior on failing fast when Spark fails to instantiate configured v2 session catalog. ### Why

[GitHub] [spark] HeartSaVioR commented on pull request #30147: [SPARK-33240][SQL] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
HeartSaVioR commented on pull request #30147: URL: https://github.com/apache/spark/pull/30147#issuecomment-717692702 I'll submit a PR for 3.0 branch as well. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
SparkQA commented on pull request #30162: URL: https://github.com/apache/spark/pull/30162#issuecomment-717692390 **[Test build #130351 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130351/testReport)** for PR 30162 at commit

[GitHub] [spark] viirya commented on a change in pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
viirya commented on a change in pull request #30162: URL: https://github.com/apache/spark/pull/30162#discussion_r513177486 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/OffsetSeq.scala ## @@ -89,10 +89,15 @@ case class OffsetSeqMetadata(

[GitHub] [spark] HeartSaVioR commented on pull request #30148: [SPARK-33244][SQL] Unify the code paths for spark.table and spark.read.table

2020-10-27 Thread GitBox
HeartSaVioR commented on pull request #30148: URL: https://github.com/apache/spark/pull/30148#issuecomment-717690813 Let's fix it to remove any confusion then - let's ensure both `spark.read.table` and `spark.table` can't deal with streaming table (even it is from temp view) so end users

[GitHub] [spark] viirya commented on pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
viirya commented on pull request #30162: URL: https://github.com/apache/spark/pull/30162#issuecomment-717689524 @HeartSaVioR Make sense. Looks like we need to put the config into `relevantSQLConfs`. This is an automated

[GitHub] [spark] HeartSaVioR commented on pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
HeartSaVioR commented on pull request #30162: URL: https://github.com/apache/spark/pull/30162#issuecomment-717687791 @dongjoon-hyun @viirya The problem isn't something about changing the config during the single run. The problem is something about changing the config during the new run

[GitHub] [spark] viirya commented on pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
viirya commented on pull request #30162: URL: https://github.com/apache/spark/pull/30162#issuecomment-717685222 > https://github.com/apache/spark/blob/fcf8aa59b5025dde9b4af36953146894659967e2/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/OffsetSeq.scala#L92-L115 >

[GitHub] [spark] viirya commented on pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
viirya commented on pull request #30162: URL: https://github.com/apache/spark/pull/30162#issuecomment-717684847 > @viirya and @HeartSaVioR . > Shall we put the new config into `StaticSQLConf.scala` instead of `SQLConf.scala`? I think that is enough. Yes, that is also what I

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-717682965 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HeartSaVioR commented on pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
HeartSaVioR commented on pull request #30162: URL: https://github.com/apache/spark/pull/30162#issuecomment-717683158 https://github.com/apache/spark/blob/fcf8aa59b5025dde9b4af36953146894659967e2/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/OffsetSeq.scala#L92-L115

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
dongjoon-hyun commented on a change in pull request #30162: URL: https://github.com/apache/spark/pull/30162#discussion_r513168650 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1324,6 +1324,16 @@ object SQLConf { .intConf

[GitHub] [spark] AmplabJenkins commented on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-10-27 Thread GitBox
AmplabJenkins commented on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-717682955 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
dongjoon-hyun commented on a change in pull request #30162: URL: https://github.com/apache/spark/pull/30162#discussion_r513168650 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1324,6 +1324,16 @@ object SQLConf { .intConf

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-717682955 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
dongjoon-hyun commented on pull request #30162: URL: https://github.com/apache/spark/pull/30162#issuecomment-717682587 @viirya and @HeartSaVioR . Shall we put the new config into `StaticSQLConf.scala` instead of `SQLConf.scala`? I think that is enough.

[GitHub] [spark] SparkQA commented on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-10-27 Thread GitBox
SparkQA commented on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-717682590 **[Test build #130346 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130346/testReport)** for PR 30166 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-10-27 Thread GitBox
SparkQA removed a comment on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-717645869 **[Test build #130346 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130346/testReport)** for PR 30166 at commit

[GitHub] [spark] HeartSaVioR commented on pull request #30147: [SPARK-33240][SQL] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
HeartSaVioR commented on pull request #30147: URL: https://github.com/apache/spark/pull/30147#issuecomment-717681783 Thanks for reviewing and merging! This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less th

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-717681498 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schem

2020-10-27 Thread GitBox
AmplabJenkins commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-717681498 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schema size

2020-10-27 Thread GitBox
SparkQA commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-717681485 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34951/

[GitHub] [spark] AmplabJenkins commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schem

2020-10-27 Thread GitBox
AmplabJenkins commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-717680723 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less th

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-717680723 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29800: URL: https://github.com/apache/spark/pull/29800#issuecomment-717674157 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29800: URL: https://github.com/apache/spark/pull/29800#issuecomment-717674160 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schema size

2020-10-27 Thread GitBox
SparkQA commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-717680708 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34952/

[GitHub] [spark] SparkQA commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schema size

2020-10-27 Thread GitBox
SparkQA commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-717675078 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34952/

[GitHub] [spark] AmplabJenkins commented on pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

2020-10-27 Thread GitBox
AmplabJenkins commented on pull request #29800: URL: https://github.com/apache/spark/pull/29800#issuecomment-717674157 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

2020-10-27 Thread GitBox
SparkQA commented on pull request #29800: URL: https://github.com/apache/spark/pull/29800#issuecomment-717674144 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34950/

[GitHub] [spark] cloud-fan closed pull request #30147: [SPARK-33240][SQL] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
cloud-fan closed pull request #30147: URL: https://github.com/apache/spark/pull/30147 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #30147: [SPARK-33240][SQL] Fail fast when fails to instantiate configured v2 session catalog

2020-10-27 Thread GitBox
cloud-fan commented on pull request #30147: URL: https://github.com/apache/spark/pull/30147#issuecomment-717673091 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schema size

2020-10-27 Thread GitBox
SparkQA commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-717672685 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34951/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29677: [SPARK-32820][SQL] Remove redundant shuffle exchanges inserted by EnsureRequirements

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29677: URL: https://github.com/apache/spark/pull/29677#issuecomment-717668190 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29677: [SPARK-32820][SQL] Remove redundant shuffle exchanges inserted by EnsureRequirements

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #29677: URL: https://github.com/apache/spark/pull/29677#issuecomment-717668186 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29677: [SPARK-32820][SQL] Remove redundant shuffle exchanges inserted by EnsureRequirements

2020-10-27 Thread GitBox
AmplabJenkins commented on pull request #29677: URL: https://github.com/apache/spark/pull/29677#issuecomment-717668186 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29677: [SPARK-32820][SQL] Remove redundant shuffle exchanges inserted by EnsureRequirements

2020-10-27 Thread GitBox
SparkQA commented on pull request #29677: URL: https://github.com/apache/spark/pull/29677#issuecomment-717668172 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34949/

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

2020-10-27 Thread GitBox
beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r513153232 ## File path: sql/core/src/test/resources/sql-tests/results/window.sql.out ## @@ -479,6 +479,38 @@ Anthony Bow6627Gerard Bondur Leslie

[GitHub] [spark] SparkQA commented on pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

2020-10-27 Thread GitBox
SparkQA commented on pull request #29800: URL: https://github.com/apache/spark/pull/29800#issuecomment-71702 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34950/

[GitHub] [spark] viirya commented on pull request #30162: [SPARK-33263][SS] Configurable StateStore compression codec

2020-10-27 Thread GitBox
viirya commented on pull request #30162: URL: https://github.com/apache/spark/pull/30162#issuecomment-717666167 > either 1) make it as a configuration but prevent the value to be changed after the query starts (like we do in state store formats) Btw, out of curiosity, I check two

[GitHub] [spark] SparkQA commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schema size

2020-10-27 Thread GitBox
SparkQA commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-717664437 **[Test build #130350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130350/testReport)** for PR 30156 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-717662046 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-717662042 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schema size

2020-10-27 Thread GitBox
SparkQA commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-717662099 **[Test build #130349 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130349/testReport)** for PR 30156 at commit

[GitHub] [spark] SparkQA commented on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-10-27 Thread GitBox
SparkQA commented on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-717662031 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34948/

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less

2020-10-27 Thread GitBox
AngersZh commented on a change in pull request #30156: URL: https://github.com/apache/spark/pull/30156#discussion_r513148800 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2748,6 +2748,16 @@ object SQLConf {

[GitHub] [spark] AmplabJenkins commented on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-10-27 Thread GitBox
AmplabJenkins commented on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-717662042 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less

2020-10-27 Thread GitBox
AngersZh commented on a change in pull request #30156: URL: https://github.com/apache/spark/pull/30156#discussion_r513148844 ## File path: docs/sql-migration-guide.md ## @@ -49,6 +49,8 @@ license: | - In Spark 3.1, we remove the built-in Hive 1.2. You need to migrate

[GitHub] [spark] SparkQA commented on pull request #29677: [SPARK-32820][SQL] Remove redundant shuffle exchanges inserted by EnsureRequirements

2020-10-27 Thread GitBox
SparkQA commented on pull request #29677: URL: https://github.com/apache/spark/pull/29677#issuecomment-717661324 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34949/

[GitHub] [spark] SparkQA commented on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-10-27 Thread GitBox
SparkQA commented on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-717659086 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34948/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717658158 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

2020-10-27 Thread GitBox
AmplabJenkins commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717658158 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

2020-10-27 Thread GitBox
SparkQA removed a comment on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717606710 **[Test build #130342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130342/testReport)** for PR 30139 at commit

[GitHub] [spark] SparkQA commented on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

2020-10-27 Thread GitBox
SparkQA commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717657234 **[Test build #130342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130342/testReport)** for PR 30139 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-717652952 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] maropu commented on pull request #30165: [SPARK-33264][SQL][DOCS] Add a dedicated page for SQL-on-file in SQL documents

2020-10-27 Thread GitBox
maropu commented on pull request #30165: URL: https://github.com/apache/spark/pull/30165#issuecomment-717653139 Thanks! Merged to master/3.0. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins commented on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-10-27 Thread GitBox
AmplabJenkins commented on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-717652945 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

2020-10-27 Thread GitBox
SparkQA commented on pull request #29800: URL: https://github.com/apache/spark/pull/29800#issuecomment-717652916 **[Test build #130348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130348/testReport)** for PR 29800 at commit

[GitHub] [spark] maropu closed pull request #30165: [SPARK-33264][SQL][DOCS] Add a dedicated page for SQL-on-file in SQL documents

2020-10-27 Thread GitBox
maropu closed pull request #30165: URL: https://github.com/apache/spark/pull/30165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-10-27 Thread GitBox
AmplabJenkins removed a comment on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-717652945 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

  1   2   3   4   5   6   >