[GitHub] [spark] yaooqinn commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

2020-11-25 Thread GitBox
yaooqinn commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r530538735 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -299,13 +301,16 @@ class AstBuilder extends SqlBas

[GitHub] [spark] SparkQA commented on pull request #30501: [SPARK-33563][PYTHON][R][SQL] Expose inverse hyperbolic trig functions in PySpark and SparkR

2020-11-25 Thread GitBox
SparkQA commented on pull request #30501: URL: https://github.com/apache/spark/pull/30501#issuecomment-733846763 **[Test build #131787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131787/testReport)** for PR 30501 at commit [`d1c7cf8`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #30501: [SPARK-33563][PYTHON][R][SQL] Expose inverse hyperbolic trig functions in PySpark and SparkR

2020-11-25 Thread GitBox
SparkQA removed a comment on pull request #30501: URL: https://github.com/apache/spark/pull/30501#issuecomment-733835059 **[Test build #131787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131787/testReport)** for PR 30501 at commit [`d1c7cf8`](https://gi

[GitHub] [spark] yaooqinn commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

2020-11-25 Thread GitBox
yaooqinn commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r530540006 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3104,6 +3106,66 @@ class Analyzer(override val ca

[GitHub] [spark] rdblue commented on pull request #30502: [SPARK-31257][SPARK-33561][SQL][FOLLOWUP] Fix Scala 2.13 compilation

2020-11-25 Thread GitBox
rdblue commented on pull request #30502: URL: https://github.com/apache/spark/pull/30502#issuecomment-733847487 Thank you for fixing this, @dongjoon-hyun! Looks good to me, assuming that tests will pass. This is an automated

[GitHub] [spark] yaooqinn commented on pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

2020-11-25 Thread GitBox
yaooqinn commented on pull request #29893: URL: https://github.com/apache/spark/pull/29893#issuecomment-733848715 I will address the comment for the main code change first but leave the test part tomorrow. It’s too late now :) --

[GitHub] [spark] otterc commented on a change in pull request #30312: [SPARK-32917][SHUFFLE][CORE] Adds support for executors to push shuffle blocks after successful map task completion

2020-11-25 Thread GitBox
otterc commented on a change in pull request #30312: URL: https://github.com/apache/spark/pull/30312#discussion_r530542443 ## File path: core/src/test/scala/org/apache/spark/shuffle/ShuffleBlockPusherSuite.scala ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] otterc commented on a change in pull request #30312: [SPARK-32917][SHUFFLE][CORE] Adds support for executors to push shuffle blocks after successful map task completion

2020-11-25 Thread GitBox
otterc commented on a change in pull request #30312: URL: https://github.com/apache/spark/pull/30312#discussion_r530542443 ## File path: core/src/test/scala/org/apache/spark/shuffle/ShuffleBlockPusherSuite.scala ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] dongjoon-hyun commented on pull request #30502: [SPARK-31257][SPARK-33561][SQL][FOLLOWUP] Fix Scala 2.13 compilation

2020-11-25 Thread GitBox
dongjoon-hyun commented on pull request #30502: URL: https://github.com/apache/spark/pull/30502#issuecomment-733850262 Thank you, @rdblue ! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] yaooqinn commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

2020-11-25 Thread GitBox
yaooqinn commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r530542829 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statements.scala ## @@ -290,6 +291,7 @@ case class DropViewStateme

[GitHub] [spark] otterc commented on a change in pull request #30312: [SPARK-32917][SHUFFLE][CORE] Adds support for executors to push shuffle blocks after successful map task completion

2020-11-25 Thread GitBox
otterc commented on a change in pull request #30312: URL: https://github.com/apache/spark/pull/30312#discussion_r530543005 ## File path: core/src/test/scala/org/apache/spark/shuffle/ShuffleBlockPusherSuite.scala ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] SparkQA commented on pull request #30483: [WIP][SPARK-33449][SQL] Add File Metadata cache support for Parquet and Orc

2020-11-25 Thread GitBox
SparkQA commented on pull request #30483: URL: https://github.com/apache/spark/pull/30483#issuecomment-733853728 **[Test build #131775 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131775/testReport)** for PR 30483 at commit [`44ca052`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #30483: [WIP][SPARK-33449][SQL] Add File Metadata cache support for Parquet and Orc

2020-11-25 Thread GitBox
SparkQA removed a comment on pull request #30483: URL: https://github.com/apache/spark/pull/30483#issuecomment-733695990 **[Test build #131775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131775/testReport)** for PR 30483 at commit [`44ca052`](https://gi

[GitHub] [spark] Victsm commented on a change in pull request #30480: [SPARK-32921][SHUFFLE][test-maven][test-hadoop2.7] MapOutputTracker extensions to support push-based shuffle

2020-11-25 Thread GitBox
Victsm commented on a change in pull request #30480: URL: https://github.com/apache/spark/pull/30480#discussion_r530549266 ## File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ## @@ -1011,4 +1333,47 @@ private[spark] object MapOutputTracker extends Logging

[GitHub] [spark] SparkQA commented on pull request #28026: [SPARK-31257][SPARK-33561][SQL] Unify create table syntax

2020-11-25 Thread GitBox
SparkQA commented on pull request #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-733857998 **[Test build #131784 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131784/testReport)** for PR 28026 at commit [`25ec746`](https://github.co

[GitHub] [spark] viirya commented on pull request #30497: [SPARK-33540][SQL] Subexpression elimination for interpreted predicate

2020-11-25 Thread GitBox
viirya commented on pull request #30497: URL: https://github.com/apache/spark/pull/30497#issuecomment-733858099 Thanks @dongjoon-hyun @HyukjinKwon @maropu This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] SparkQA removed a comment on pull request #28026: [SPARK-31257][SPARK-33561][SQL] Unify create table syntax

2020-11-25 Thread GitBox
SparkQA removed a comment on pull request #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-733764803 **[Test build #131784 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131784/testReport)** for PR 28026 at commit [`25ec746`](https://gi

[GitHub] [spark] dongjoon-hyun commented on pull request #30502: [SPARK-31257][SPARK-33561][SQL][FOLLOWUP] Fix Scala 2.13 compilation

2020-11-25 Thread GitBox
dongjoon-hyun commented on pull request #30502: URL: https://github.com/apache/spark/pull/30502#issuecomment-733860314 Thank you, @srowen ! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun commented on pull request #30502: [SPARK-31257][SPARK-33561][SQL][FOLLOWUP] Fix Scala 2.13 compilation

2020-11-25 Thread GitBox
dongjoon-hyun commented on pull request #30502: URL: https://github.com/apache/spark/pull/30502#issuecomment-733860557 Scala 2.13 passed. I'll merge this. https://user-images.githubusercontent.com/9700541/100264943-5ce7c580-2f04-11eb-8d18-c6362c4089e8.png";>

[GitHub] [spark] dongjoon-hyun closed pull request #30502: [SPARK-31257][SPARK-33561][SQL][FOLLOWUP] Fix Scala 2.13 compilation

2020-11-25 Thread GitBox
dongjoon-hyun closed pull request #30502: URL: https://github.com/apache/spark/pull/30502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] AmplabJenkins commented on pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #29729: URL: https://github.com/apache/spark/pull/29729#issuecomment-733865434 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29950: [SPARK-32945][SQL] Avoid collapsing projects if reaching max allowed common exprs

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #29950: URL: https://github.com/apache/spark/pull/29950#issuecomment-733865440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #30497: [SPARK-33540][SQL] Subexpression elimination for interpreted predicate

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #30497: URL: https://github.com/apache/spark/pull/30497#issuecomment-733865435 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #30483: [WIP][SPARK-33449][SQL] Add File Metadata cache support for Parquet and Orc

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #30483: URL: https://github.com/apache/spark/pull/30483#issuecomment-733865432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #30501: [SPARK-33563][PYTHON][R][SQL] Expose inverse hyperbolic trig functions in PySpark and SparkR

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #30501: URL: https://github.com/apache/spark/pull/30501#issuecomment-733865439 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #30488: [SPARK-33071][SPARK-33536][SQL] Avoid changing dataset_id of LogicalPlan in join() to not break DetectAmbiguousSelfJoin

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #30488: URL: https://github.com/apache/spark/pull/30488#issuecomment-733865437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28026: [SPARK-31257][SPARK-33561][SQL] Unify create table syntax

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-733865444 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30501: [SPARK-33563][PYTHON][R][SQL] Expose inverse hyperbolic trig functions in PySpark and SparkR

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #30501: URL: https://github.com/apache/spark/pull/30501#issuecomment-733865439 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30497: [SPARK-33540][SQL] Subexpression elimination for interpreted predicate

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #30497: URL: https://github.com/apache/spark/pull/30497#issuecomment-733833290 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30488: [SPARK-33071][SPARK-33536][SQL] Avoid changing dataset_id of LogicalPlan in join() to not break DetectAmbiguousSelfJoin

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #30488: URL: https://github.com/apache/spark/pull/30488#issuecomment-733865437 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28026: [SPARK-31257][SPARK-33561][SQL] Unify create table syntax

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-733774484 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #29729: URL: https://github.com/apache/spark/pull/29729#issuecomment-733833288 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30483: [WIP][SPARK-33449][SQL] Add File Metadata cache support for Parquet and Orc

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #30483: URL: https://github.com/apache/spark/pull/30483#issuecomment-733840003 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29950: [SPARK-32945][SQL] Avoid collapsing projects if reaching max allowed common exprs

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #29950: URL: https://github.com/apache/spark/pull/29950#issuecomment-733865440 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28026: [SPARK-31257][SPARK-33561][SQL] Unify create table syntax

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-733866206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] dongjoon-hyun commented on pull request #30492: [SPARK-33545][CORE] Support Fallback Storage during Worker decommission

2020-11-25 Thread GitBox
dongjoon-hyun commented on pull request #30492: URL: https://github.com/apache/spark/pull/30492#issuecomment-733866284 Could you review this PR once more please, @viirya ? This is an automated message from the Apache Git Serv

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28026: [SPARK-31257][SPARK-33561][SQL] Unify create table syntax

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-733866206 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] Victsm commented on pull request #30480: [SPARK-32921][SHUFFLE][test-maven][test-hadoop2.7] MapOutputTracker extensions to support push-based shuffle

2020-11-25 Thread GitBox
Victsm commented on pull request #30480: URL: https://github.com/apache/spark/pull/30480#issuecomment-733866872 The javadoc issues leading to the build failures are not related to files changed in this patch. ``` [error] /home/runner/work/spark/spark/mllib/target/java/org/apache/spar

[GitHub] [spark] SparkQA commented on pull request #30480: [SPARK-32921][SHUFFLE][test-maven][test-hadoop2.7] MapOutputTracker extensions to support push-based shuffle

2020-11-25 Thread GitBox
SparkQA commented on pull request #30480: URL: https://github.com/apache/spark/pull/30480#issuecomment-733867663 **[Test build #131792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131792/testReport)** for PR 30480 at commit [`384baed`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #30398: [SPARK-33452][SQL] Support v2 SHOW PARTITIONS

2020-11-25 Thread GitBox
SparkQA commented on pull request #30398: URL: https://github.com/apache/spark/pull/30398#issuecomment-733867823 **[Test build #131794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131794/testReport)** for PR 30398 at commit [`9db9923`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-25 Thread GitBox
SparkQA commented on pull request #30403: URL: https://github.com/apache/spark/pull/30403#issuecomment-733867985 **[Test build #131793 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131793/testReport)** for PR 30403 at commit [`4c2d5e2`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #30312: [SPARK-32917][SHUFFLE][CORE] Adds support for executors to push shuffle blocks after successful map task completion

2020-11-25 Thread GitBox
SparkQA commented on pull request #30312: URL: https://github.com/apache/spark/pull/30312#issuecomment-733868083 **[Test build #131795 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131795/testReport)** for PR 30312 at commit [`faa55f3`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

2020-11-25 Thread GitBox
SparkQA commented on pull request #29893: URL: https://github.com/apache/spark/pull/29893#issuecomment-733868465 **[Test build #131796 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131796/testReport)** for PR 29893 at commit [`86d0032`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #30412: [SPARK-33480][SQL] Support char/varchar type

2020-11-25 Thread GitBox
SparkQA commented on pull request #30412: URL: https://github.com/apache/spark/pull/30412#issuecomment-733870653 **[Test build #131797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131797/testReport)** for PR 30412 at commit [`662f297`](https://github.com

[GitHub] [spark] Victsm commented on a change in pull request #30433: [SPARK-32916][SHUFFLE][test-maven][test-hadoop2.7] Ensure the number of chunks in meta file and index file are equal

2020-11-25 Thread GitBox
Victsm commented on a change in pull request #30433: URL: https://github.com/apache/spark/pull/30433#discussion_r530564551 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java ## @@ -827,13 +833,16 @@ void resetChunkT

[GitHub] [spark] AmplabJenkins commented on pull request #30398: [SPARK-33452][SQL] Support v2 SHOW PARTITIONS

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #30398: URL: https://github.com/apache/spark/pull/30398#issuecomment-733872041 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #30398: [SPARK-33452][SQL] Support v2 SHOW PARTITIONS

2020-11-25 Thread GitBox
SparkQA commented on pull request #30398: URL: https://github.com/apache/spark/pull/30398#issuecomment-733872003 **[Test build #131794 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131794/testReport)** for PR 30398 at commit [`9db9923`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-25 Thread GitBox
SparkQA commented on pull request #30403: URL: https://github.com/apache/spark/pull/30403#issuecomment-733873132 **[Test build #131799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131799/testReport)** for PR 30403 at commit [`3c4a0cf`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #30398: [SPARK-33452][SQL] Support v2 SHOW PARTITIONS

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #30398: URL: https://github.com/apache/spark/pull/30398#issuecomment-733873303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #30412: [SPARK-33480][SQL] Support char/varchar type

2020-11-25 Thread GitBox
SparkQA commented on pull request #30412: URL: https://github.com/apache/spark/pull/30412#issuecomment-733873411 **[Test build #131798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131798/testReport)** for PR 30412 at commit [`8f05eee`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-25 Thread GitBox
SparkQA commented on pull request #30403: URL: https://github.com/apache/spark/pull/30403#issuecomment-733874871 **[Test build #131793 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131793/testReport)** for PR 30403 at commit [`4c2d5e2`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #30403: URL: https://github.com/apache/spark/pull/30403#issuecomment-733874890 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #30398: [SPARK-33452][SQL] Support v2 SHOW PARTITIONS

2020-11-25 Thread GitBox
SparkQA removed a comment on pull request #30398: URL: https://github.com/apache/spark/pull/30398#issuecomment-733867823 **[Test build #131794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131794/testReport)** for PR 30398 at commit [`9db9923`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-25 Thread GitBox
SparkQA removed a comment on pull request #30403: URL: https://github.com/apache/spark/pull/30403#issuecomment-733867985 **[Test build #131793 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131793/testReport)** for PR 30403 at commit [`4c2d5e2`](https://gi

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-25 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r530571035 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/CachedTableSuite.scala ## @@ -421,7 +421,7 @@ class CachedTableSuite extends QueryTest w

[GitHub] [spark] imback82 commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView

2020-11-25 Thread GitBox
imback82 commented on pull request #30475: URL: https://github.com/apache/spark/pull/30475#issuecomment-733881455 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA commented on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

2020-11-25 Thread GitBox
SparkQA commented on pull request #30499: URL: https://github.com/apache/spark/pull/30499#issuecomment-733882455 **[Test build #131781 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131781/testReport)** for PR 30499 at commit [`665d7d8`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

2020-11-25 Thread GitBox
SparkQA removed a comment on pull request #30499: URL: https://github.com/apache/spark/pull/30499#issuecomment-733736073 **[Test build #131781 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131781/testReport)** for PR 30499 at commit [`665d7d8`](https://gi

[GitHub] [spark] Victsm commented on a change in pull request #30312: [SPARK-32917][SHUFFLE][CORE] Adds support for executors to push shuffle blocks after successful map task completion

2020-11-25 Thread GitBox
Victsm commented on a change in pull request #30312: URL: https://github.com/apache/spark/pull/30312#discussion_r530575752 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1992,4 +1992,32 @@ package object config { .version("3.1.0")

[GitHub] [spark] SparkQA commented on pull request #30483: [WIP][SPARK-33449][SQL] Add File Metadata cache support for Parquet and Orc

2020-11-25 Thread GitBox
SparkQA commented on pull request #30483: URL: https://github.com/apache/spark/pull/30483#issuecomment-733887554 **[Test build #131782 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131782/testReport)** for PR 30483 at commit [`bc25c4e`](https://github.co

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30492: [SPARK-33545][CORE] Support Fallback Storage during Worker decommission

2020-11-25 Thread GitBox
dongjoon-hyun edited a comment on pull request #30492: URL: https://github.com/apache/spark/pull/30492#issuecomment-733866284 Could you review this PR once more please, @viirya and @mridulm ? This is an automated message from

[GitHub] [spark] SparkQA removed a comment on pull request #30483: [WIP][SPARK-33449][SQL] Add File Metadata cache support for Parquet and Orc

2020-11-25 Thread GitBox
SparkQA removed a comment on pull request #30483: URL: https://github.com/apache/spark/pull/30483#issuecomment-733763576 **[Test build #131782 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131782/testReport)** for PR 30483 at commit [`bc25c4e`](https://gi

[GitHub] [spark] SparkQA commented on pull request #30488: [SPARK-33071][SPARK-33536][SQL] Avoid changing dataset_id of LogicalPlan in join() to not break DetectAmbiguousSelfJoin

2020-11-25 Thread GitBox
SparkQA commented on pull request #30488: URL: https://github.com/apache/spark/pull/30488#issuecomment-733888552 **[Test build #131778 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131778/testReport)** for PR 30488 at commit [`5cff25f`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #30488: [SPARK-33071][SPARK-33536][SQL] Avoid changing dataset_id of LogicalPlan in join() to not break DetectAmbiguousSelfJoin

2020-11-25 Thread GitBox
SparkQA removed a comment on pull request #30488: URL: https://github.com/apache/spark/pull/30488#issuecomment-733728016 **[Test build #131778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131778/testReport)** for PR 30488 at commit [`5cff25f`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29950: [SPARK-32945][SQL] Avoid collapsing projects if reaching max allowed common exprs

2020-11-25 Thread GitBox
SparkQA commented on pull request #29950: URL: https://github.com/apache/spark/pull/29950#issuecomment-733890894 **[Test build #131780 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131780/testReport)** for PR 29950 at commit [`bbaae3e`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #29950: [SPARK-32945][SQL] Avoid collapsing projects if reaching max allowed common exprs

2020-11-25 Thread GitBox
SparkQA removed a comment on pull request #29950: URL: https://github.com/apache/spark/pull/29950#issuecomment-733728541 **[Test build #131780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131780/testReport)** for PR 29950 at commit [`bbaae3e`](https://gi

[GitHub] [spark] SparkQA commented on pull request #30483: [WIP][SPARK-33449][SQL] Add File Metadata cache support for Parquet and Orc

2020-11-25 Thread GitBox
SparkQA commented on pull request #30483: URL: https://github.com/apache/spark/pull/30483#issuecomment-733891485 **[Test build #131779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131779/testReport)** for PR 30483 at commit [`7254d88`](https://github.co

[GitHub] [spark] Victsm commented on a change in pull request #30312: [SPARK-32917][SHUFFLE][CORE] Adds support for executors to push shuffle blocks after successful map task completion

2020-11-25 Thread GitBox
Victsm commented on a change in pull request #30312: URL: https://github.com/apache/spark/pull/30312#discussion_r530583302 ## File path: core/src/main/scala/org/apache/spark/shuffle/ShuffleBlockPusher.scala ## @@ -0,0 +1,462 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [spark] SparkQA removed a comment on pull request #30483: [WIP][SPARK-33449][SQL] Add File Metadata cache support for Parquet and Orc

2020-11-25 Thread GitBox
SparkQA removed a comment on pull request #30483: URL: https://github.com/apache/spark/pull/30483#issuecomment-733728143 **[Test build #131779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131779/testReport)** for PR 30483 at commit [`7254d88`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #29950: [SPARK-32945][SQL] Avoid collapsing projects if reaching max allowed common exprs

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #29950: URL: https://github.com/apache/spark/pull/29950#issuecomment-733897186 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #30483: [WIP][SPARK-33449][SQL] Add File Metadata cache support for Parquet and Orc

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #30483: URL: https://github.com/apache/spark/pull/30483#issuecomment-733897174 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #30430: [SPARK-33503][SQL] Refactor SortOrder class to allow multiple childrens

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #30430: URL: https://github.com/apache/spark/pull/30430#issuecomment-733897179 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #30502: [SPARK-31257][SPARK-33561][SQL][FOLLOWUP] Fix Scala 2.13 compilation

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #30502: URL: https://github.com/apache/spark/pull/30502#issuecomment-733897240 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #30499: URL: https://github.com/apache/spark/pull/30499#issuecomment-733897173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #30488: [SPARK-33071][SPARK-33536][SQL] Avoid changing dataset_id of LogicalPlan in join() to not break DetectAmbiguousSelfJoin

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #30488: URL: https://github.com/apache/spark/pull/30488#issuecomment-733897175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] dongjoon-hyun opened a new pull request #30503: [SPARK-26645][PYTHON] Support decimals with negative scale when parsing datatype

2020-11-25 Thread GitBox
dongjoon-hyun opened a new pull request #30503: URL: https://github.com/apache/spark/pull/30503 ## What changes were proposed in this pull request? This is a backport of #23575 When parsing datatypes from the json internal representation, PySpark doesn't support decimals with

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30483: [WIP][SPARK-33449][SQL] Add File Metadata cache support for Parquet and Orc

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #30483: URL: https://github.com/apache/spark/pull/30483#issuecomment-733897170 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30499: [WIP][SPARK-33558][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. PARTITION tests

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #30499: URL: https://github.com/apache/spark/pull/30499#issuecomment-733833289 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30430: [SPARK-33503][SQL] Refactor SortOrder class to allow multiple childrens

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #30430: URL: https://github.com/apache/spark/pull/30430#issuecomment-733897179 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30488: [SPARK-33071][SPARK-33536][SQL] Avoid changing dataset_id of LogicalPlan in join() to not break DetectAmbiguousSelfJoin

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #30488: URL: https://github.com/apache/spark/pull/30488#issuecomment-733897175 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30502: [SPARK-31257][SPARK-33561][SQL][FOLLOWUP] Fix Scala 2.13 compilation

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #30502: URL: https://github.com/apache/spark/pull/30502#issuecomment-733897240 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30398: [SPARK-33452][SQL] Support v2 SHOW PARTITIONS

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #30398: URL: https://github.com/apache/spark/pull/30398#issuecomment-733872041 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29950: [SPARK-32945][SQL] Avoid collapsing projects if reaching max allowed common exprs

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #29950: URL: https://github.com/apache/spark/pull/29950#issuecomment-733897168 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30494: [SPARK-33551][SQL] Do not use custom shuffle reader for repartition

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #30494: URL: https://github.com/apache/spark/pull/30494#issuecomment-733897718 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30494: [SPARK-33551][SQL] Do not use custom shuffle reader for repartition

2020-11-25 Thread GitBox
AmplabJenkins removed a comment on pull request #30494: URL: https://github.com/apache/spark/pull/30494#issuecomment-733897718 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView

2020-11-25 Thread GitBox
SparkQA commented on pull request #30475: URL: https://github.com/apache/spark/pull/30475#issuecomment-733899176 **[Test build #131802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131802/testReport)** for PR 30475 at commit [`68ee277`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #30503: [SPARK-26645][PYTHON][2.4] Support decimals with negative scale when parsing datatype

2020-11-25 Thread GitBox
SparkQA commented on pull request #30503: URL: https://github.com/apache/spark/pull/30503#issuecomment-733899149 **[Test build #131800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131800/testReport)** for PR 30503 at commit [`1f1592e`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

2020-11-25 Thread GitBox
SparkQA commented on pull request #29893: URL: https://github.com/apache/spark/pull/29893#issuecomment-733899147 **[Test build #131796 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131796/testReport)** for PR 29893 at commit [`86d0032`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-25 Thread GitBox
SparkQA commented on pull request #30403: URL: https://github.com/apache/spark/pull/30403#issuecomment-733899162 **[Test build #131804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131804/testReport)** for PR 30403 at commit [`7f5a0b2`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #30412: [SPARK-33480][SQL] Support char/varchar type

2020-11-25 Thread GitBox
SparkQA commented on pull request #30412: URL: https://github.com/apache/spark/pull/30412#issuecomment-733899128 **[Test build #131803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131803/testReport)** for PR 30412 at commit [`9850d38`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #30501: [SPARK-33563][PYTHON][R][SQL] Expose inverse hyperbolic trig functions in PySpark and SparkR

2020-11-25 Thread GitBox
SparkQA commented on pull request #30501: URL: https://github.com/apache/spark/pull/30501#issuecomment-733899204 **[Test build #131801 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131801/testReport)** for PR 30501 at commit [`6165ba3`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #29893: URL: https://github.com/apache/spark/pull/29893#issuecomment-733899415 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #30398: [SPARK-33452][SQL] Support v2 SHOW PARTITIONS

2020-11-25 Thread GitBox
SparkQA commented on pull request #30398: URL: https://github.com/apache/spark/pull/30398#issuecomment-733899393 **[Test build #131805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131805/testReport)** for PR 30398 at commit [`1cd1e34`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView

2020-11-25 Thread GitBox
AmplabJenkins commented on pull request #30475: URL: https://github.com/apache/spark/pull/30475#issuecomment-733901113 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView

2020-11-25 Thread GitBox
SparkQA commented on pull request #30475: URL: https://github.com/apache/spark/pull/30475#issuecomment-733901098 **[Test build #131802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131802/testReport)** for PR 30475 at commit [`68ee277`](https://github.co

[GitHub] [spark] Victsm commented on a change in pull request #30312: [SPARK-32917][SHUFFLE][CORE] Adds support for executors to push shuffle blocks after successful map task completion

2020-11-25 Thread GitBox
Victsm commented on a change in pull request #30312: URL: https://github.com/apache/spark/pull/30312#discussion_r530593070 ## File path: core/src/main/scala/org/apache/spark/shuffle/ShuffleWriter.scala ## @@ -17,18 +17,466 @@ package org.apache.spark.shuffle -import java.i

[GitHub] [spark] tgravescs opened a new pull request #30504: [SPARK-33544][SQL] Optimizer should not insert filter when when explode with CreateArray/CreateMap

2020-11-25 Thread GitBox
tgravescs opened a new pull request #30504: URL: https://github.com/apache/spark/pull/30504 ### What changes were proposed in this pull request? https://issues.apache.org/jira/browse/SPARK-32295 added in an optimization to insert a filter for not null and size > 0 when using inne

[GitHub] [spark] tgravescs commented on pull request #30504: [SPARK-33544][SQL] Optimizer should not insert filter when when explode with CreateArray/CreateMap

2020-11-25 Thread GitBox
tgravescs commented on pull request #30504: URL: https://github.com/apache/spark/pull/30504#issuecomment-733902491 @viirya @cloud-fan @tanelk thoughts on this, since you were involved in original change This is an automated

[GitHub] [spark] Victsm commented on a change in pull request #30312: [SPARK-32917][SHUFFLE][CORE] Adds support for executors to push shuffle blocks after successful map task completion

2020-11-25 Thread GitBox
Victsm commented on a change in pull request #30312: URL: https://github.com/apache/spark/pull/30312#discussion_r530575752 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1992,4 +1992,32 @@ package object config { .version("3.1.0")

[GitHub] [spark] SparkQA commented on pull request #30504: [SPARK-33544][SQL] Optimizer should not insert filter when when explode with CreateArray/CreateMap

2020-11-25 Thread GitBox
SparkQA commented on pull request #30504: URL: https://github.com/apache/spark/pull/30504#issuecomment-733902999 **[Test build #131806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131806/testReport)** for PR 30504 at commit [`581d77f`](https://github.com

<    1   2   3   4   5   6   7   8   9   >