[GitHub] spark pull request: [SPARK-9835] [PySpark] fix install pylint

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7721#issuecomment-125475844 Note that the code to actually run the PyLint checks is still commented out, so you might want to revert that commit as part of this PR if you're trying to re-enable t

[GitHub] spark pull request: [Hotfix][Examples] fix a Javadoc of a preforma...

2015-07-27 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/7708#issuecomment-125475153 Hm, I do see many more uses of `{@code }` in the project than `` for this purpose, which is good. It would be reasonable to fix, at least, all the Java examples in one go

[GitHub] spark pull request: [SPARK-9835] [PySpark] fix install pylint

2015-07-27 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/7721 [SPARK-9835] [PySpark] fix install pylint You can merge this pull request into a Git repository by running: $ git pull https://github.com/davies/spark fix_install_pylint Alternatively you can

[GitHub] spark pull request: [SPARK-9835] [PySpark] fix install pylint

2015-07-27 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/7721#issuecomment-125475355 cc @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark pull request: [SPARK-9335][Tests]Enable Kinesis tests only w...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7711#discussion_r35618667 --- Diff: dev/sparktestsupport/modules.py --- @@ -29,7 +29,7 @@ class Module(object): changed. """ -def __init__(self, name,

[GitHub] spark pull request: [SPARK-8206][SQL][WIP]Add function round

2015-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6836 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9335][Tests]Enable Kinesis tests only w...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7711#issuecomment-125474257 After a cursory glance this seems reasonable to me; thanks for adding such detailed code comments to explain what's going on here. I'm cool with merging this b

[GitHub] spark pull request: [SPARK-8231][SQL][WIP] Add array_contains

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7580#issuecomment-125473405 [Test build #38662 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38662/console) for PR 7580 at commit [`c4e6e43`](https://github.

[GitHub] spark pull request: [Hotfix][Examples] fix a Javadoc of a preforma...

2015-07-27 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/7708#issuecomment-125471931 @srowen how about changing all the `` to `{@code...}`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-8196][SQL] Fix null handling & document...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7718#issuecomment-125472010 [Test build #38675 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38675/consoleFull) for PR 7718 at commit [`616a425`](https://gith

[GitHub] spark pull request: [SPARK-8881][SPARK-9260] Fix algorithm for sch...

2015-07-27 Thread nishkamravi2
Github user nishkamravi2 commented on the pull request: https://github.com/apache/spark/pull/7274#issuecomment-125471627 Hey @andrewor14, thanks for taking care of this! Sorry, couldn't respond sooner, was out for a couple of days. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-9373][SQL] follow up for StructType sup...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7720#issuecomment-125471286 [Test build #1216 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1216/consoleFull) for PR 7720 at commit [`d9757f5`](https://git

[GitHub] spark pull request: [SPARK-9225] [MLlib] LDASuite needs unit tests...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7620#issuecomment-125470862 [Test build #38676 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38676/consoleFull) for PR 7620 at commit [`ad55665`](https://gith

[GitHub] spark pull request: [SPARK-8850] [SQL] [WIP] Enable Unsafe mode by...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7564#issuecomment-125470413 [Test build #38677 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38677/consoleFull) for PR 7564 at commit [`7f463f8`](https://gith

[GitHub] spark pull request: [SPARK-9225] [MLlib] LDASuite needs unit tests...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7620#issuecomment-125470117 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8850] [SQL] [WIP] Enable Unsafe mode by...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7564#issuecomment-125470071 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8850] [SQL] [WIP] Enable Unsafe mode by...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7564#issuecomment-125470118 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9225] [MLlib] LDASuite needs unit tests...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7620#issuecomment-125470063 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8196][SQL] Fix null handling & document...

2015-07-27 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7718#issuecomment-125469955 OK I deleted that too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-9373][SQL] follow up for StructType sup...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7720#issuecomment-125470087 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8196][SQL] Fix null handling & document...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7718#issuecomment-125470050 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8100][UI]Make able to refer lost execut...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6644#issuecomment-125469952 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8196][SQL] Fix null handling & document...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7718#issuecomment-125470099 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8100][UI]Make able to refer lost execut...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6644#issuecomment-125469705 [Test build #132 has started](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/132/consoleFull) for PR 6644 at commit [`d94a716`](https://gith

[GitHub] spark pull request: [SPARK-8100][UI]Make able to refer lost execut...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6644#issuecomment-125469560 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9225] [MLlib] LDASuite needs unit tests...

2015-07-27 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7620#issuecomment-125469429 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-8100][UI]Make able to refer lost execut...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6644#issuecomment-125469505 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [Hotfix][Examples] fix a Javadoc of a preforma...

2015-07-27 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/7708#issuecomment-125469263 Agree, this is not a fix. The modern way to write code javadoc is ... ``` {@code val foo = ... } ``` ... but for consistency with other ja

[GitHub] spark pull request: [SPARK-9388] [yarn] Make executor info log mes...

2015-07-27 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/7706#issuecomment-125468830 Looks OK to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-9393] [SQL] Fix several error-handling ...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7710#discussion_r35618064 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -874,15 +874,15 @@ https://cwiki.apache.org/confluence/display/Hive/Enhanced

[GitHub] spark pull request: [SPARK-8196][SQL] Fix null handling & document...

2015-07-27 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/7718#issuecomment-125468536 There's another sql.DatetimeExpressionsSuite, should be moved to sql.DateFunctionsSuite. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-8003][SQL] Added virtual column support...

2015-07-27 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7478#discussion_r35618076 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -140,7 +142,14 @@ class SQLContext(@transient val sparkContext: SparkContext)

[GitHub] spark pull request: [SPARK-8100][UI]Make able to refer lost execut...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6644#issuecomment-125468461 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8100][UI]Make able to refer lost execut...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6644#issuecomment-125468479 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9393] [SQL] Fix several error-handling ...

2015-07-27 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7710#discussion_r35618000 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala --- @@ -68,9 +71,44 @@ case class ScriptTransformation(

[GitHub] spark pull request: [SPARK-8100][UI]Make able to refer lost execut...

2015-07-27 Thread suyanNone
Github user suyanNone commented on the pull request: https://github.com/apache/spark/pull/6644#issuecomment-125468342 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9335][Tests]Enable Kinesis tests only w...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7711#issuecomment-125467977 [Test build #38673 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38673/consoleFull) for PR 7711 at commit [`ef84a08`](https://gith

[GitHub] spark pull request: [SPARK-9335][Tests]Enable Kinesis tests only w...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7711#issuecomment-125467679 [Test build #1215 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1215/consoleFull) for PR 7711 at commit [`ef84a08`](https://git

[GitHub] spark pull request: [WIP][SPARK-9202] capping maximum number of ex...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7714#issuecomment-125467607 The basic approach looks okay to me, so this is on the right track. Thanks for choosing to work on this! --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [WIP][SPARK-9202] capping maximum number of ex...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7714#discussion_r35617836 --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala --- @@ -614,6 +621,22 @@ private[worker] class Worker( webUi.stop()

[GitHub] spark pull request: [WIP][SPARK-9202] capping maximum number of ex...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7714#discussion_r35617851 --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala --- @@ -614,6 +621,22 @@ private[worker] class Worker( webUi.stop()

[GitHub] spark pull request: [SPARK-9335][Tests]Enable Kinesis tests only w...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7711#issuecomment-125467508 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9335][Tests]Enable Kinesis tests only w...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7711#issuecomment-125467492 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [WIP][SPARK-9202] capping maximum number of ex...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7714#issuecomment-125467324 In principle, doesn't the Master also have similar problems with retained applications? --- If your project is set up for it, you can reply to this email and have you

[GitHub] spark pull request: [SPARK-9335][Tests]Enable Kinesis tests only w...

2015-07-27 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/7711#issuecomment-125467341 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9335][Streaming][Tests]Make sure the te...

2015-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7663 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9397] DataFrame should provide an API t...

2015-07-27 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7717#discussion_r35617769 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala --- @@ -1546,6 +1547,21 @@ class DataFrame private[sql]( } } + /

[GitHub] spark pull request: [SPARK-7575][ml][doc] Example code for OneVsRe...

2015-07-27 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/6115#discussion_r35617723 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaOneVsRestExample.java --- @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9393] [SQL] Fix several error-handling ...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7710#discussion_r35617688 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala --- @@ -68,9 +71,44 @@ case class ScriptTransformation(

[GitHub] spark pull request: [SPARK-9399] Minor performance optimizations i...

2015-07-27 Thread JoshRosen
Github user JoshRosen closed the pull request at: https://github.com/apache/spark/pull/7719 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] spark pull request: [SPARK-9373][SQL] follow up for StructType sup...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7720#issuecomment-125466905 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9373][SQL] follow up for StructType sup...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7720#issuecomment-125466910 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9399] Minor performance optimizations i...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7719#issuecomment-125466862 Actually, I change my mind on this; there's no way that the `Option` can have any significant overhead given that it's always going to return `None`. Going to close t

[GitHub] spark pull request: [SPARK-2016][WebUI]RDD partition table paginat...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7692#issuecomment-125466750 [Test build #131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/131/consoleFull) for PR 7692 at commit [`612c18c`](https://gith

[GitHub] spark pull request: [SPARK-2016][WebUI]RDD partition table paginat...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7692#issuecomment-125466892 [Test build #38671 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38671/consoleFull) for PR 7692 at commit [`612c18c`](https://gith

[GitHub] spark pull request: [SPARK-2016][WebUI]RDD partition table paginat...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7692#issuecomment-125466707 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9399] Minor performance optimizations i...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7719#issuecomment-125466771 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9373][SQL] follow up for StructType sup...

2015-07-27 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7720#issuecomment-125466682 cc @JoshRosen this should fix all the problems you mentioned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request: [SPARK-9393] [SQL] Fix several error-handling ...

2015-07-27 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7710#discussion_r35617644 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/ScriptTransformationSuite.scala --- @@ -0,0 +1,123 @@ +/* + * Licensed to the Ap

[GitHub] spark pull request: [SPARK-9373][SQL] follow up for StructType sup...

2015-07-27 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/7720 [SPARK-9373][SQL] follow up for StructType support in Tungsten projection. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rxin/spark struct-follow

[GitHub] spark pull request: [SPARK-2016][WebUI]RDD partition table paginat...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7692#issuecomment-125466688 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9335][Streaming][Tests]Make sure the te...

2015-07-27 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/7663#issuecomment-125466561 I am merging this fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-9393] [SQL] Fix several error-handling ...

2015-07-27 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7710#discussion_r35617564 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala --- @@ -68,9 +71,44 @@ case class ScriptTransformation(

[GitHub] spark pull request: [SPARK-9393] [SQL] Fix several error-handling ...

2015-07-27 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7710#discussion_r35617474 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -874,15 +874,15 @@ https://cwiki.apache.org/confluence/display/Hive/Enhanced+Ag

[GitHub] spark pull request: [SPARK-2016][WebUI]RDD partition table paginat...

2015-07-27 Thread carsonwang
Github user carsonwang commented on the pull request: https://github.com/apache/spark/pull/7692#issuecomment-125466146 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9399] Minor performance optimizations i...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7719#issuecomment-125466205 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9399] Minor performance optimizations i...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7719#issuecomment-125466217 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9393] [SQL] Fix several error-handling ...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7710#discussion_r35617428 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanTest.scala --- @@ -98,7 +100,7 @@ class SparkPlanTest extends SparkFunSuite {

[GitHub] spark pull request: [SPARK-2016][WebUI]RDD partition table paginat...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7692#issuecomment-125466225 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2016][WebUI]RDD partition table paginat...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7692#issuecomment-125466209 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9393] [SQL] Fix several error-handling ...

2015-07-27 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7710#discussion_r35617380 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanTest.scala --- @@ -98,7 +100,7 @@ class SparkPlanTest extends SparkFunSuite {

[GitHub] spark pull request: [SPARK-8196][SQL] Fix null handling & document...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7718#issuecomment-125465865 [Test build #38669 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38669/consoleFull) for PR 7718 at commit [`faa78cf`](https://gith

[GitHub] spark pull request: [SPARK-9394][SQL] Handle parentheses in CodeFo...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7712#issuecomment-125465630 [Test build #1214 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1214/consoleFull) for PR 7712 at commit [`c2b1c5f`](https://git

[GitHub] spark pull request: [SPARK-8196][SQL] Fix null handling & document...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7718#issuecomment-125465377 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8196][SQL] Fix null handling & document...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7718#issuecomment-125465336 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9399] Minor performance optimizations i...

2015-07-27 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/7719 [SPARK-9399] Minor performance optimizations in PythonRDD This patch implements three trivial performance optimizations in PythonRDD: - Replace a .`foreach()` call with a while() loop.

[GitHub] spark pull request: [SPARK-8196][SQL] Fix null handling & document...

2015-07-27 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7718#issuecomment-125465150 cc @adrian-wang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-8232][SQL] Add sort_array support

2015-07-27 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7581#discussion_r35617061 --- Diff: python/pyspark/sql/functions.py --- @@ -840,6 +841,20 @@ def size(col): return Column(sc._jvm.functions.size(_to_java_column(col)))

[GitHub] spark pull request: [SPARK-8196][SQL] Fix null handling & document...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7718#issuecomment-125464826 [Test build #38668 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38668/consoleFull) for PR 7718 at commit [`6c4fb6a`](https://gith

[GitHub] spark pull request: [SPARK-8850] [SQL] [WIP] Enable Unsafe mode by...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7564#issuecomment-125464710 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8100][UI]Make able to refer lost execut...

2015-07-27 Thread suyanNone
Github user suyanNone commented on a diff in the pull request: https://github.com/apache/spark/pull/6644#discussion_r35617005 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -60,7 +60,8 @@ class ExecutorSummary private[spark]( val totalShuffleR

[GitHub] spark pull request: [SPARK-8850] [SQL] [WIP] Enable Unsafe mode by...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7564#issuecomment-125464538 [Test build #38667 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38667/consoleFull) for PR 7564 at commit [`8946cb9`](https://gith

[GitHub] spark pull request: [SPARK-8196][SQL] Fix null handling & document...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7718#issuecomment-125464692 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8196][SQL] Fix null handling & document...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7718#issuecomment-125464673 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8196][SQL] Fix null handling & document...

2015-07-27 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/7718 [SPARK-8196][SQL] Fix null handling & documentation for next_day. The original patch didn't handle nulls correctly for next_day. You can merge this pull request into a Git repository by running: $

[GitHub] spark pull request: [SPARK-8850] [SQL] [WIP] Enable Unsafe mode by...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7564#issuecomment-125463318 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9225] [MLlib] LDASuite needs unit tests...

2015-07-27 Thread rotationsymmetry
Github user rotationsymmetry commented on the pull request: https://github.com/apache/spark/pull/7620#issuecomment-125463408 @mengxr Thank you for OK to test. I checked the Jerkins log. The failure is caused by git unable to fetch the repo. Anything on my end to fix it?

[GitHub] spark pull request: [SPARK-8850] [SQL] [WIP] Enable Unsafe mode by...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7564#issuecomment-125463378 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8232][SQL] Add sort_array support

2015-07-27 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7581#discussion_r35616625 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -35,3 +36,45 @@ case class Size(child: Expre

[GitHub] spark pull request: [SPARK-8232][SQL] Add sort_array support

2015-07-27 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7581#discussion_r35616590 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -35,3 +36,45 @@ case class Size(child: Expre

[GitHub] spark pull request: [SPARK-9335][Tests]Enable Kinesis tests only w...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7711#issuecomment-125461403 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9335][Tests]Enable Kinesis tests only w...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7711#issuecomment-125461335 **[Test build #38646 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38646/console)** for PR 7711 at commit [`f691028`](https://github

[GitHub] spark pull request: [SPARK-9393] [SQL] Fix several error-handling ...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7710#issuecomment-125460983 @davies, it might be good to have you take a look at this given the similarity of this code to PySpark's similar error-handling techniques. --- If your project is set

[GitHub] spark pull request: [MINOR][SQL]Support mutable expression unit te...

2015-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7566 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-8850] [SQL] [WIP] Enable Unsafe mode by...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7564#issuecomment-125460683 Lots of changes are temporarily merged in here while I test on top of Reynold's struct type patch. --- If your project is set up for it, you can reply to this email a

[GitHub] spark pull request: [SPARK-8850] [SQL] [WIP] Enable Unsafe mode by...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7564#issuecomment-125460656 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8850] [SQL] [WIP] Enable Unsafe mode by...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7564#issuecomment-125460669 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MINOR][SQL]Support mutable expression unit te...

2015-07-27 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/7566#issuecomment-125460646 Merged into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9397] DataFrame should provide an API t...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7717#issuecomment-125460590 [Test build #38665 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38665/consoleFull) for PR 7717 at commit [`0acd3ad`](https://gith

[GitHub] spark pull request: [SPARK-9368][SQL] Support get(ordinal, dataTyp...

2015-07-27 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7682#discussion_r35616321 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java --- @@ -236,6 +236,41 @@ public Object get(int ordinal) {

  1   2   3   4   5   6   7   8   9   10   >