[GitHub] spark pull request: [SPARK-12608][Streaming]Remove submitJobThread...

2016-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10560 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12580][SQL] Remove string concatenation...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10524#issuecomment-168770758 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12580][SQL] Remove string concatenation...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10524#issuecomment-168770762 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12463][SPARK-12464][SPARK-12465][SPARK-...

2016-01-04 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/10057#issuecomment-168780176 @andrewor14 Can you take a look at this PR sometime this week? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-12604] [CORE] Java count(AprroxDistinct...

2016-01-04 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10554#issuecomment-168790343 @srowen If this doesn't change any signature, I think it actually makes things slower by adding another layer of iterators. Maybe it'd make more sense to just change the

[GitHub] spark pull request: [SPARK-3873] [examples] Import ordering fixes.

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10575#issuecomment-168792868 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3873] [examples] Import ordering fixes.

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10575#issuecomment-168792866 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10553 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12616] [SQL] Adding a New Logical Opera...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10577#issuecomment-168802650 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12438][SQL] Add SQLUserDefinedType supp...

2016-01-04 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10390#discussion_r48780302 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -94,6 +99,9 @@ class UserDefinedTypeSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10573#issuecomment-168806897 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12438][SQL] Add SQLUserDefinedType supp...

2016-01-04 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10390#discussion_r48780378 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala --- @@ -242,6 +242,16 @@ class

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10573#issuecomment-168806900 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12541] [SQL] support cube/rollup as fun...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10522#issuecomment-168769152 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10749][MESOS] Support multiple roles wi...

2016-01-04 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/8872#issuecomment-168781103 @andrewor14 @dragos I think we figured out the testing problem at this point, I've tested this locally myself so @dragos if you like to try it out let me know,

[GitHub] spark pull request: [SPARK-12615] Remove some deprecated APIs in R...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10569#issuecomment-168783538 **[Test build #2313 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2313/consoleFull)** for PR 10569 at commit

[GitHub] spark pull request: [SPARK-9622] [ML] DecisionTreeRegressor: provi...

2016-01-04 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8866#discussion_r48772445 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala --- @@ -129,6 +136,22 @@ final class DecisionTreeRegressionModel

[GitHub] spark pull request: [SPARK-12614][Core]Don't throw non fatal excep...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10568#issuecomment-168788609 **[Test build #48672 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48672/consoleFull)** for PR 10568 at commit

[GitHub] spark pull request: [SPARK-3873] [examples] Import ordering fixes.

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10575#issuecomment-168789012 **[Test build #48681 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48681/consoleFull)** for PR 10575 at commit

[GitHub] spark pull request: [SPARK-12600][SQL] Remove deprecated methods i...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10559#issuecomment-168793261 **[Test build #48684 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48684/consoleFull)** for PR 10559 at commit

[GitHub] spark pull request: [SPARK-12541] [SQL] support cube/rollup as fun...

2016-01-04 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/10522#issuecomment-168797333 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2016-01-04 Thread ajbozarth
Github user ajbozarth commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-168800557 Can someone get this to retest? Also @JoshRosen any opinions on the current commit? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-12560][SQL] SqlTestUtils.stripSparkFilt...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10510#issuecomment-168805424 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12560][SQL] SqlTestUtils.stripSparkFilt...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10510#issuecomment-168805429 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12448][SQL] Add UserDefinedType support...

2016-01-04 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10410#issuecomment-168807149 We can just merge the other PR once comments are addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10519 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12412] [SQL] Support LIKE in the JDBCRD...

2016-01-04 Thread bomeng
Github user bomeng closed the pull request at: https://github.com/apache/spark/pull/10364 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12580][SQL] Remove string concatenation...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10524#issuecomment-168770085 **[Test build #48670 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48670/consoleFull)** for PR 10524 at commit

[GitHub] spark pull request: [SPARK-12541] [SQL] support cube/rollup as fun...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10522#issuecomment-168774152 **[Test build #2312 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2312/consoleFull)** for PR 10522 at commit

[GitHub] spark pull request: [SPARKR][DOC] minor doc update for version in ...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10574#issuecomment-168774061 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12614][Core]Don't throw non fatal excep...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10568#issuecomment-168789205 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12614][Core]Don't throw non fatal excep...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10568#issuecomment-168789204 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10573#issuecomment-168794836 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12616] [SQL] Adding a New Logical Opera...

2016-01-04 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10577#issuecomment-168795397 @rxin Could you check if this implementation is what you expects? Thanks! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-12589][SQL] Fix UnsafeRowParquetRecordR...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10576#issuecomment-168795394 **[Test build #48683 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48683/consoleFull)** for PR 10576 at commit

[GitHub] spark pull request: [SPARK-12616] [SQL] Adding a New Logical Opera...

2016-01-04 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10577#issuecomment-168795624 Maybe we should just remove the old Union and call the new one Union? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-12616] [SQL] Adding a New Logical Opera...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10577#issuecomment-168802645 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10573#issuecomment-168764396 **[Test build #48675 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48675/consoleFull)** for PR 10573 at commit

[GitHub] spark pull request: [SPARK-12470] [SQL] Fix size reduction calcula...

2016-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10421 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12470] [SQL] Fix size reduction calcula...

2016-01-04 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10421#issuecomment-168765217 Merged into master and 1.6 branch, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-168765294 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-168765290 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10573#issuecomment-168774124 **[Test build #48678 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48678/consoleFull)** for PR 10573 at commit

[GitHub] spark pull request: [SPARKR][DOC] minor doc update for version in ...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10574#issuecomment-168774063 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12331][ML] R^2 for regression through t...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10384#issuecomment-168778083 **[Test build #48680 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48680/consoleFull)** for PR 10384 at commit

[GitHub] spark pull request: [SPARK-3873] [examples] Import ordering fixes.

2016-01-04 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/10575 [SPARK-3873] [examples] Import ordering fixes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vanzin/spark SPARK-3873-examples Alternatively

[GitHub] spark pull request: [SPARKR][DOC] minor doc update for version in ...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10574#issuecomment-168787054 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARKR][DOC] minor doc update for version in ...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10574#issuecomment-168786648 **[Test build #48679 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48679/consoleFull)** for PR 10574 at commit

[GitHub] spark pull request: [SPARKR][DOC] minor doc update for version in ...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10574#issuecomment-168787059 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10573#issuecomment-168794523 **[Test build #48675 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48675/consoleFull)** for PR 10573 at commit

[GitHub] spark pull request: [DOC] Adjust coverage for partitionBy()

2016-01-04 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10499#issuecomment-168800225 Thanks, merged to master and 1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12421][SQL] Prevent Internal/External r...

2016-01-04 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10553#issuecomment-168800925 Thanks, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARKR][DOC] minor doc update for version in ...

2016-01-04 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/10574 [SPARKR][DOC] minor doc update for version in migration guide checked that the change is in Spark 1.6.0. @shivaram You can merge this pull request into a Git repository by running: $

[GitHub] spark pull request: [SPARK-12580][SQL] Remove string concatenation...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10524#issuecomment-168778438 **[Test build #48671 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48671/consoleFull)** for PR 10524 at commit

[GitHub] spark pull request: [SPARKR][DOC] minor doc update for version in ...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10574#issuecomment-168780422 **[Test build #48679 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48679/consoleFull)** for PR 10574 at commit

[GitHub] spark pull request: [SPARK-12611][SQL][PYSPARK][TESTS] Fix test_in...

2016-01-04 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10564#issuecomment-168784148 FYI I filed https://issues.apache.org/jira/browse/SPARK-12624 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12600][SQL] Remove deprecated methods i...

2016-01-04 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10559#discussion_r48775567 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -126,6 +115,16 @@ class DataFrameReader private[sql](sqlContext:

[GitHub] spark pull request: [SPARK-12589][SQL] Fix UnsafeRowParquetRecordR...

2016-01-04 Thread nongli
GitHub user nongli opened a pull request: https://github.com/apache/spark/pull/10576 [SPARK-12589][SQL] Fix UnsafeRowParquetRecordReader to properly set the row length. The reader was previously not setting the row length meaning it was wrong if there were variable length

[GitHub] spark pull request: [SPARK-12616] [SQL] Adding a New Logical Opera...

2016-01-04 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/10577 [SPARK-12616] [SQL] Adding a New Logical Operator Unions `Union` logical operator only supports two children. Thus, adding a new logical operator `Unions` which can have arbitrary number of

[GitHub] spark pull request: [SPARK-12541] [SQL] support cube/rollup as fun...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10522#issuecomment-168800846 **[Test build #2312 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2312/consoleFull)** for PR 10522 at commit

[GitHub] spark pull request: [SPARK-12560][SQL] SqlTestUtils.stripSparkFilt...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10510#issuecomment-168808013 **[Test build #48687 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48687/consoleFull)** for PR 10510 at commit

[GitHub] spark pull request: [SPARK-12604] [CORE] Java count(AprroxDistinct...

2016-01-04 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10554#issuecomment-168807831 Yeah that's a good point -- let me see if I can understand that better. At some level, it has to be an `Object` and not a `long` in order to be part of a

[GitHub] spark pull request: [SPARK-11638] [Mesos + Docker Bridge networkin...

2016-01-04 Thread tnachen
Github user tnachen commented on a diff in the pull request: https://github.com/apache/spark/pull/9608#discussion_r48770592 --- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala --- @@ -245,10 +245,19 @@ object SparkEnv extends Logging { val securityManager =

[GitHub] spark pull request: [SPARK-7675][ML][PYSpark] sparkml params type ...

2016-01-04 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/9581#discussion_r48774100 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -247,7 +248,27 @@ def _set(self, **kwargs): Sets user-supplied params. """

[GitHub] spark pull request: [SPARK-9843][SQL] Make catalyst optimizer pass...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10210#issuecomment-168789642 **[Test build #48682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48682/consoleFull)** for PR 10210 at commit

[GitHub] spark pull request: [SPARK-12600][SQL] Remove deprecated methods i...

2016-01-04 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10559#issuecomment-168791597 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [Minor][Build] Set lib directory for antlr

2016-01-04 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10571#issuecomment-168791764 We should definitely have a JIRA ticket for this under the parser umbrella ticket. Even though the change is small, if indeed a problem the impact is large.

[GitHub] spark pull request: [SPARK-12616] [SQL] Adding a New Logical Opera...

2016-01-04 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10577#issuecomment-168795851 Yeah, it will be better. Will do the change tonight. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-11624][SPARK-11972][SQL]fix commands th...

2016-01-04 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9589#discussion_r48777449 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala --- @@ -151,29 +152,34 @@ private[hive] class ClientWrapper(

[GitHub] spark pull request: [DOC] Adjust coverage for partitionBy()

2016-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10499 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3873] [core] Import ordering fixes.

2016-01-04 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/10578 [SPARK-3873] [core] Import ordering fixes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vanzin/spark SPARK-3873-core Alternatively you can

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-04 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/10573 [SPARK-3873] [sql] Import ordering fixes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vanzin/spark SPARK-3873-sql Alternatively you can

[GitHub] spark pull request: [SPARK-12486] Worker should kill the executors...

2016-01-04 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10438#issuecomment-168762487 Merging into master 1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12608][Streaming]Remove submitJobThread...

2016-01-04 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10560#issuecomment-168769332 Merging to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARKR][DOC] minor doc update for version in ...

2016-01-04 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/10574#issuecomment-168776591 jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [Spark-7780][MLLIB] Intercept in logisticregre...

2016-01-04 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/6386#issuecomment-168781424 @dbtsai @holdenk I don't think we currently have the bandwidth to review this, but if @dbtsai does, then it'd be nice to merge. But I don't think it's critical since

[GitHub] spark pull request: [SPARK-12331][ML] R^2 for regression through t...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10384#issuecomment-168791849 **[Test build #48680 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48680/consoleFull)** for PR 10384 at commit

[GitHub] spark pull request: [SPARK-12331][ML] R^2 for regression through t...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10384#issuecomment-168792027 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168801707 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-12604] [CORE] Java count(AprroxDistinct...

2016-01-04 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10554#issuecomment-168801616 One thing I don't understand is how can these methods return scala types at the bytecode level? Scala Long is just a primitive long. All the places you find are generics,

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48778819 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -177,3 +179,44 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10573#issuecomment-168806579 **[Test build #48678 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48678/consoleFull)** for PR 10573 at commit

[GitHub] spark pull request: [SPARK-12560][SQL] SqlTestUtils.stripSparkFilt...

2016-01-04 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/10510#issuecomment-168806632 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7689][WIP] Remove TTL-based metadata cl...

2016-01-04 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10534#issuecomment-168763031 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-168762994 Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12486] Worker should kill the executors...

2016-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10438 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-168764660 Also merging to branch 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5673] [MLlib] Implement Streaming wrapp...

2016-01-04 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4456#issuecomment-168780601 @catap Apologies for the slow review. We've needed to focus on some other issues recently, but please feel free to (a) submit your work as a Spark package and (b)

[GitHub] spark pull request: [SPARK-3873] [examples] Import ordering fixes.

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10575#issuecomment-168792746 **[Test build #48681 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48681/consoleFull)** for PR 10575 at commit

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10573#issuecomment-168794833 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12604] [CORE] Java count(AprroxDistinct...

2016-01-04 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10554#issuecomment-168794854 It doesn't compile that way though since the values are Scala Longs and the signature says Java Longs. One way or the other, such a conversion has to happen somewhere.

[GitHub] spark pull request: [SPARK-12600][SQL] Remove deprecated methods i...

2016-01-04 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10559#discussion_r48776741 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala --- @@ -20,25 +20,10 @@ package org.apache.spark.sql.types import

[GitHub] spark pull request: [SPARK-12616] [SQL] Adding a New Logical Opera...

2016-01-04 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10577#issuecomment-168795855 +1, I'd prefer if there is only one operator that performs unions --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-12512][SQL] support column name with do...

2016-01-04 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10500#issuecomment-168798579 Thanks, merging to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-168762943 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-12580][SQL] Remove string concatenation...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10524#issuecomment-168778764 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12580][SQL] Remove string concatenation...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10524#issuecomment-168778765 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11638] [Mesos + Docker Bridge networkin...

2016-01-04 Thread tnachen
Github user tnachen commented on a diff in the pull request: https://github.com/apache/spark/pull/9608#discussion_r48771144 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -854,7 +854,8 @@ private[spark] object Utils extends Logging { * Get the local

[GitHub] spark pull request: [SPARK-11638] [Mesos + Docker Bridge networkin...

2016-01-04 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/9608#issuecomment-168780854 I think it's also note documenting this of how it can possibly work with bridge mode. Also I think it's worth noting that user must explicitly map the ports before hand

[GitHub] spark pull request: [SPARK-12593][SQL][WIP] Converts resolved logi...

2016-01-04 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10541#issuecomment-168781095 @liancheng One thing about testing infrastructure: It is a good idea to use the existing Hive compatibility tests to bootstrap your test coverage. However, for

  1   2   3   4   5   6   7   8   >