[GitHub] spark pull request: [SPARK-12997][SQL] Use cast expression to perf...

2016-02-21 Thread falaki
Github user falaki commented on a diff in the pull request: https://github.com/apache/spark/pull/10980#discussion_r53594660 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVRelation.scala --- @@ -226,11 +227,17 @@ object CSVRelation extends

[GitHub] spark pull request: [SPARK-13139][SQL] Create native DDL commands

2016-02-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11048#discussion_r53594561 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands/parsers.scala --- @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12617][PySpark]Move Py4jCallbackConnect...

2016-02-21 Thread sarathj
Github user sarathj commented on the pull request: https://github.com/apache/spark/pull/10621#issuecomment-187058482 @zsxwing With 1.6 also I ran into the same exception -` java.io.IOException: py4j.Py4JException: Cannot obtain a new communication`. I would like to

[GitHub] spark pull request: [SPARK-13139][SQL] Create native DDL commands

2016-02-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11048#discussion_r53593980 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands/parsers.scala --- @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-8000][SQL] Support for auto-detecting d...

2016-02-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11270#discussion_r53593587 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ResolvedDataSource.scala --- @@ -130,7 +131,28 @@ object ResolvedDataSource

[GitHub] spark pull request: [SPARK-13139][SQL] Create native DDL commands

2016-02-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11048#discussion_r53593420 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands/parsers.scala --- @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13139][SQL] Create native DDL commands

2016-02-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11048#discussion_r53593393 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands/parsers.scala --- @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [MINOR][DOCS] Fix all typos in markdown files ...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11300#issuecomment-187055449 **[Test build #2565 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2565/consoleFull)** for PR 11300 at commit

[GitHub] spark pull request: [SPARK-13139][SQL] Create native DDL commands

2016-02-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11048#discussion_r53593184 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands/parsers.scala --- @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-21 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53592740 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,356 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13139][SQL] Create native DDL commands

2016-02-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11048#discussion_r53592672 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands/parsers.scala --- @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-21 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/11136#discussion_r53592447 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -0,0 +1,547 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-13033][ML][PySpark] Add import/export f...

2016-02-21 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/11000#issuecomment-187047801 @yanboliang I complete this pr, please take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [MINOR][DOCS] Fix all typos in markdown files ...

2016-02-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11300#issuecomment-187046857 Hi, @rxin . I finished reviewing all files under the `docs` module and related stuff. I think it's all typos for now. Thank you again. --- If your

[GitHub] spark pull request: [SPARK-12720] [SQL] SQL Generation Support for...

2016-02-21 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11283#issuecomment-187045768 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13236] SQL Generation for Set Operation...

2016-02-21 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11195#issuecomment-187045685 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13263] [SQL] SQL Generation Support for...

2016-02-21 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11148#issuecomment-187045605 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [MINOR][DOCS] Fix all typos in markdown files ...

2016-02-21 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11300 [MINOR][DOCS] Fix all typos in markdown files of `doc` and similar patterns in other comments ## What changes were proposed in this pull request? This PR tries to fix all typos in

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-21 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11260#issuecomment-187040244 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-8000][SQL] Support for auto-detecting d...

2016-02-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/11270#issuecomment-187032665 I submitted some more commits. In summary, 1. Added a `DataSourceDetect` class separatly. 2. Now, it only picks a single file. If the given path is

[GitHub] spark pull request: [SPARK-8000][SQL] Support for auto-detecting d...

2016-02-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/11270#issuecomment-187031347 I submitted some more commits. In summary, 1. Added a `DataSourceDetect` class separatly. 2. Now, it only picks a single file. If the given path is

[GitHub] spark pull request: [SPARK-13428] [SQL] Pushing Down Aggregate Exp...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11298#issuecomment-187031165 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-8000][SQL] Support for auto-detecting d...

2016-02-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/11270#issuecomment-187031213 I submitted some more commits. In summary, 1. Added a `DataSourceDetect` class separatly. 2. Now, it only picks a single file. If the given path is

[GitHub] spark pull request: [SPARK-13428] [SQL] Pushing Down Aggregate Exp...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11298#issuecomment-187031164 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-21 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53589538 --- Diff: core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala --- @@ -127,16 +127,23 @@ private[spark] class TorrentBroadcast[T:

[GitHub] spark pull request: [SPARK-13429] [MLlib] Unify Logistic Regressio...

2016-02-21 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/11299 [SPARK-13429] [MLlib] Unify Logistic Regression convergence tolerance of ML & MLlib ## What changes were proposed in this pull request? In order to provide better and consistent result,

[GitHub] spark pull request: [SPARK-13428] [SQL] Pushing Down Aggregate Exp...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11298#issuecomment-187030953 **[Test build #51658 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51658/consoleFull)** for PR 11298 at commit

[GitHub] spark pull request: [SPARK-8000][SQL] Support for auto-detecting d...

2016-02-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/11270#issuecomment-187030511 I submitted some more commits. In summary, 1. Added a `DataSourceDetect` class separatly. 2. Now, it only picks a single file. If the given path is

[GitHub] spark pull request: [SPARK-13426][Core] Remove the support of SIMR

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11296#issuecomment-187028985 **[Test build #2564 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2564/consoleFull)** for PR 11296 at commit

[GitHub] spark pull request: [SPARK-13426][Core] Remove the support of SIMR

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11296#issuecomment-187026346 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13426][Core] Remove the support of SIMR

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11296#issuecomment-187026349 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12988][SQL] Can't drop columns that con...

2016-02-21 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/10943#issuecomment-187018074 @cloud-fan Hi Wenchen, can you please advice on what is the next step for this PR ? I am thinking that it may require more discussion to decide if we need top keep

[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...

2016-02-21 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-187017636 @dbtsai Thanks! I will send another PR for consistent convergence tolerance. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-13427][SQL] Support USING clause in JOI...

2016-02-21 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/11297#issuecomment-187014299 @rxin @adrian-wang Can you please review the implementation and let me know your comments.Thanks !! --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11260#issuecomment-187011421 **[Test build #51659 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51659/consoleFull)** for PR 11260 at commit

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11260#issuecomment-187011434 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11260#issuecomment-187011428 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11260#issuecomment-187010823 **[Test build #51659 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51659/consoleFull)** for PR 11260 at commit

[GitHub] spark pull request: [SPARK-13428] [SQL] Pushing Down Aggregate Exp...

2016-02-21 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11298#issuecomment-187009069 cc @davies @cloud-fan . This PR is like an incremental patch with few lines of code changes. I am not sure if the whole rewrite is worthy for resolving the above

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11293#discussion_r53585835 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveCatalog.scala --- @@ -0,0 +1,293 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-13428] [SQL] Pushing Down Aggregate Exp...

2016-02-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11298#discussion_r53585798 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -607,14 +607,21 @@ class Analyzer( def

[GitHub] spark pull request: [SPARK-13428] [SQL] Pushing Down Aggregate Exp...

2016-02-21 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11298#issuecomment-187005048 # Issue 2: mixture of aliases and real columns in order by clause ```SQL SELECT key as k, value as v, sum(value) FROM src GROUP BY key, value ORDER BY k,

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-21 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11260#issuecomment-187005053 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-187005041 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-187005038 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-187004772 **[Test build #51652 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51652/consoleFull)** for PR 7 at commit

[GitHub] spark pull request: [SPARK-13426][Core] Remove the support of SIMR

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11296#issuecomment-187002198 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13426][Core] Remove the support of SIMR

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11296#issuecomment-187002350 You need to update mima. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13426][Core] Remove the support of SIMR

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11296#issuecomment-187002203 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13426][Core] Remove the support of SIMR

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11296#issuecomment-187002073 **[Test build #51655 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51655/consoleFull)** for PR 11296 at commit

[GitHub] spark pull request: [SPARK-13389] [SparkR] SparkR support first/la...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11267#issuecomment-187001699 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11260#issuecomment-187001554 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13389] [SparkR] SparkR support first/la...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11267#issuecomment-187001694 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13389] [SparkR] SparkR support first/la...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11267#issuecomment-187001455 **[Test build #51656 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51656/consoleFull)** for PR 11267 at commit

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11260#issuecomment-187001550 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13428] [SQL] Pushing Down Aggregate Exp...

2016-02-21 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11298#issuecomment-187001189 # Issue 1: ```SQL SELECT MAX(value) FROM src GROUP BY key + 1 ORDER BY key + 1 ``` `key + 1` is not an aggregated function, but we still need to

[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...

2016-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11258 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13428] [SQL] Pushing Down Aggregate Exp...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11298#issuecomment-186998813 **[Test build #51658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51658/consoleFull)** for PR 11298 at commit

[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...

2016-02-21 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186998722 LGTM. Merged into master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11260#discussion_r53585015 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -260,6 +260,20 @@ case class Join(

[GitHub] spark pull request: [SPARK-13428] [SQL] Pushing Down Aggregate Exp...

2016-02-21 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11298#issuecomment-186996652 This PR is an incremental fix based on the previous solution for resolving missing attributes in Sort. This is not a clean fix, I like. However, to do a clean fix,

[GitHub] spark pull request: [SPARK-13426][Core] Remove the support of SIMR

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11296#issuecomment-186996654 **[Test build #51655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51655/consoleFull)** for PR 11296 at commit

[GitHub] spark pull request: [SPARK-13428] [SQL] Pushing Down Aggregate Exp...

2016-02-21 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/11298 [SPARK-13428] [SQL] Pushing Down Aggregate Expressions in Sort into Aggregate ## What changes were proposed in this pull request? When there exists the other operators between Sort and

[GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...

2016-02-21 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11293#issuecomment-186995812 I didn't review the core parts of this PR yet, hopefully @rxin had done that. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-13389] [SparkR] SparkR support first/la...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11267#issuecomment-186995268 **[Test build #51656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51656/consoleFull)** for PR 11267 at commit

[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...

2016-02-21 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186994891 The default value in R's GLMNET is `1E-7`, and the default value in original LBFGS implementation is `1E-8`. In order to provide better and consistent result, let's

[GitHub] spark pull request: [SPARK-13426][Core] Remove the support of SIMR

2016-02-21 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/11296#issuecomment-186994352 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12864][YARN] initialize executorIdCount...

2016-02-21 Thread zhonghaihua
Github user zhonghaihua commented on the pull request: https://github.com/apache/spark/pull/10794#issuecomment-186993839 Hi @andrewor14 , the reason of test failed seems `GitException`. Could you retest it ? Thanks a lot. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-13426][Core] Remove the support of SIMR

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11296#issuecomment-186993681 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13426][Core] Remove the support of SIMR

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11296#issuecomment-186993684 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13389] [SparkR] SparkR support first/la...

2016-02-21 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/11267#discussion_r53583948 --- Diff: R/pkg/R/functions.R --- @@ -536,15 +536,27 @@ setMethod("factorial", #' #' Aggregate function: returns the first value in a group.

[GitHub] spark pull request: [SPARK-13389] [SparkR] SparkR support first/la...

2016-02-21 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11267#issuecomment-186993289 @shivaram Several R packages have similar function such as [first](http://www.inside-r.org/packages/cran/pastecs/docs/first),

[GitHub] spark pull request: [SPARK-13220][Core]deprecate yarn-client and y...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11229#issuecomment-186993223 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13220][Core]deprecate yarn-client and y...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11229#issuecomment-186993224 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12864][YARN] initialize executorIdCount...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10794#issuecomment-186993136 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12864][YARN] initialize executorIdCount...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10794#issuecomment-186993134 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13220][Core]deprecate yarn-client and y...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11229#issuecomment-186992965 **[Test build #51650 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51650/consoleFull)** for PR 11229 at commit

[GitHub] spark pull request: [SPARK-13427][SQL] Support USING clause in JOI...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11297#issuecomment-186992843 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13427][SQL] Support USING clause in JOI...

2016-02-21 Thread dilipbiswal
GitHub user dilipbiswal opened a pull request: https://github.com/apache/spark/pull/11297 [SPARK-13427][SQL] Support USING clause in JOIN. ## What changes were proposed in this pull request? Support queries that JOIN tables with USING clause. SELECT * from table1 JOIN

[GitHub] spark pull request: [SPARK-13426][Core] Remove the support of SIMR

2016-02-21 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/11296 [SPARK-13426][Core] Remove the support of SIMR ## What changes were proposed in this pull request? This PR removes the support of SIMR, since SIMR is not actively used and maintained

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186986677 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186986680 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186986183 **[Test build #51651 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51651/consoleFull)** for PR 11262 at commit

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in ML doc

2016-02-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11295#issuecomment-186980619 Thank you for your advice, @rxin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in ML doc

2016-02-21 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/11295 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13321][SQL] Support nested UNION in par...

2016-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11204 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186980335 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13321][SQL] Support nested UNION in par...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11204#issuecomment-186980183 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11260#discussion_r53582665 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -260,6 +260,20 @@ case class Join(

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in ML doc

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11295#issuecomment-186980067 Sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [MINOR][DOCS] Fix typos in ML doc

2016-02-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11295#issuecomment-186979478 Oh, sure! Then, I will close this and make another PR after reviewing all md files in docs. Is it okay for you? --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-186976616 **[Test build #51652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51652/consoleFull)** for PR 7 at commit

[GitHub] spark pull request: [SPARK-13249][SQL] Add Filter checking nullabi...

2016-02-21 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11235#issuecomment-186975972 cc @davies @marmbrus @liancheng @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11260#discussion_r53581769 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -260,6 +260,20 @@ case class Join(

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11260#discussion_r53581679 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -260,6 +260,20 @@ case class Join(

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11260#discussion_r53581595 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -260,6 +260,20 @@ case class Join(

[GitHub] spark pull request: [SPARK-13321][SQL] Support nested UNION in par...

2016-02-21 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11204#issuecomment-186974334 cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...

2016-02-21 Thread maropu
Github user maropu closed the pull request at: https://github.com/apache/spark/pull/11269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186973763 **[Test build #2563 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2563/consoleFull)** for PR 11262 at commit

  1   2   3   4   5   >