[GitHub] spark issue #16454: [SPARK-19055][SQL][PySpark] Fix SparkSession initializat...

2017-01-11 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16454 `SparkContext` is not associated with `SparkSession` because `SparkSession` is a SQL-only class. So I think it is not good to import sql's `SparkSession` to `SparkContext` and to modify its value.

[GitHub] spark issue #16558: Fix missing close-parens for In filter's toString

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16558 **[Test build #71249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71249/testReport)** for PR 16558 at commit

[GitHub] spark issue #16454: [SPARK-19055][SQL][PySpark] Fix SparkSession initializat...

2017-01-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16454 how about we set `_instantiatedSession` to None in `SparkContext.stop`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #16558: Fix missing close-parens for In filter's toString

2017-01-11 Thread ash211
GitHub user ash211 opened a pull request: https://github.com/apache/spark/pull/16558 Fix missing close-parens for In filter's toString Otherwise the open parentheses isn't closed in query plan descriptions of batch scans. PushedFilters: [In(COL_A,

[GitHub] spark issue #16547: [SPARK-19168][Structured Streaming] Improvement: filter ...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16547 **[Test build #71248 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71248/testReport)** for PR 16547 at commit

[GitHub] spark pull request #16549: [SPARK-19151][SQL]DataFrameWriter.saveAsTable sup...

2017-01-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16549#discussion_r95738880 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -383,14 +383,19 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2017-01-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16404 Since Hive and postgres have same behavior on this, I'd like to follow them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2017-01-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r95738554 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #16512: [SPARK-18335][SPARKR] createDataFrame to support ...

2017-01-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16512#discussion_r95738253 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -196,6 +196,12 @@ test_that("create DataFrame from RDD", { expect_equal(dtypes(df),

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2017-01-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r95735905 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95732892 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #15505: [SPARK-18890][CORE] Move task serialization from ...

2017-01-11 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r95732717 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -245,6 +245,16 @@ class

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95732577 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark issue #16539: [SPARK-8855][MLlib][PySpark] Python API for Association ...

2017-01-11 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/16539 I think the mllib in the python side is also in maintenance mode, and we should only fix bugs for it. @yanboliang am I right? For this pr, I think it's reasonable to wait for the porting of

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2017-01-11 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r95731778 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #15505: [SPARK-18890][CORE] Move task serialization from ...

2017-01-11 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r95731120 --- Diff: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala --- @@ -517,6 +518,32 @@ class DAGSchedulerSuite extends SparkFunSuite with

[GitHub] spark pull request #15505: [SPARK-18890][CORE] Move task serialization from ...

2017-01-11 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r95731056 --- Diff: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala --- @@ -517,6 +518,32 @@ class DAGSchedulerSuite extends SparkFunSuite with

[GitHub] spark issue #16557: [SPARK-18693][ML][MLLIB][WIP] ML Evaluators should use w...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16557 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16557: [SPARK-18693][ML][MLLIB][WIP] ML Evaluators should use w...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16557 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71247/ Test FAILed. ---

[GitHub] spark issue #16557: [SPARK-18693][ML][MLLIB][WIP] ML Evaluators should use w...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16557 **[Test build #71247 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71247/testReport)** for PR 16557 at commit

[GitHub] spark issue #16557: [SPARK-18693][ML][MLLIB][WIP] ML Evaluators should use w...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16557 **[Test build #71247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71247/testReport)** for PR 16557 at commit

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16404 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71244/ Test PASSed. ---

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16404 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16557: [SPARK-18693][ML][MLLIB][WIP] ML Evaluators shoul...

2017-01-11 Thread imatiach-msft
GitHub user imatiach-msft opened a pull request: https://github.com/apache/spark/pull/16557 [SPARK-18693][ML][MLLIB][WIP] ML Evaluators should use weight column ## What changes were proposed in this pull request? The evaluators BinaryClassificationEvaluator,

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16404 **[Test build #71244 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71244/testReport)** for PR 16404 at commit

[GitHub] spark issue #16549: [SPARK-19151][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16549 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71246/ Test FAILed. ---

[GitHub] spark issue #16549: [SPARK-19151][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16549 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16549: [SPARK-19151][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16549 **[Test build #71246 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71246/testReport)** for PR 16549 at commit

[GitHub] spark issue #16549: [SPARK-19151][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16549 **[Test build #71246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71246/testReport)** for PR 16549 at commit

[GitHub] spark pull request #16454: [SPARK-19055][SQL][PySpark] Fix SparkSession init...

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16454#discussion_r95729251 --- Diff: python/pyspark/sql/session.py --- @@ -214,8 +214,12 @@ def __init__(self, sparkContext, jsparkSession=None): self._wrapped =

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2017-01-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16404 It sounds like different RDBMS have different behaviors. Have we decided which way we should follow? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #16503: [SPARK-18113] Use ask to replace askWithRetry in canComm...

2017-01-11 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16503 ping @zsxwing @vanzin Could you give another look at this please ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...

2017-01-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16550 Be careful: the Chinese input `'–1'` is different from the English input `'-1'`. It is hard to distinguish. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...

2017-01-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16550 Could you add the following test cases? ```SQL SELECT CAST('' AS int); -> NULL SELECT CAST('' AS long); -> NULL SELECT CAST(NULL AS int); -> NULL SELECT

[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16550 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71241/ Test PASSed. ---

[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16550 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16550 **[Test build #71241 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71241/testReport)** for PR 16550 at commit

[GitHub] spark issue #14451: [SPARK-16848][SQL] Check schema validation for user-spec...

2017-01-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14451 Thank you @gatorsmile! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #16395: [SPARK-17075][SQL] implemented filter estimation

2017-01-11 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16395#discussion_r95726607 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -0,0 +1,555 @@ +/* + *

[GitHub] spark pull request #14451: [SPARK-16848][SQL] Check schema validation for us...

2017-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14451 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15837: [SPARK-18395][SQL] Evaluate common subexpression like la...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15837 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15837: [SPARK-18395][SQL] Evaluate common subexpression like la...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15837 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71240/ Test PASSed. ---

[GitHub] spark issue #16346: [SPARK-16654][CORE] Add UI coverage for Application Leve...

2017-01-11 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/16346 cc @ajbozarth as you were interested in this earlier --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #16346: [SPARK-16654][CORE] Add UI coverage for Applicati...

2017-01-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/16346#discussion_r95724900 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -88,6 +88,86 @@ class BlacklistTrackerSuite extends SparkFunSuite

[GitHub] spark pull request #16346: [SPARK-16654][CORE] Add UI coverage for Applicati...

2017-01-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/16346#discussion_r95724311 --- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsTab.scala --- @@ -157,4 +158,42 @@ class ExecutorsListener(storageStatusListener:

[GitHub] spark issue #15837: [SPARK-18395][SQL] Evaluate common subexpression like la...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15837 **[Test build #71240 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71240/testReport)** for PR 15837 at commit

[GitHub] spark pull request #16346: [SPARK-16654][CORE] Add UI coverage for Applicati...

2017-01-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/16346#discussion_r95725456 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -88,6 +88,86 @@ class BlacklistTrackerSuite extends SparkFunSuite

[GitHub] spark issue #14451: [SPARK-16848][SQL] Check schema validation for user-spec...

2017-01-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14451 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #12064: [SPARK-14272][ML] Evaluate GaussianMixtureModel with Log...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12064 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16549: [SPARK-19151][SQL]DataFrameWriter.saveAsTable sup...

2017-01-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16549#discussion_r95725235 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -383,14 +383,19 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark issue #12064: [SPARK-14272][ML] Evaluate GaussianMixtureModel with Log...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12064 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71245/ Test PASSed. ---

[GitHub] spark pull request #16549: [SPARK-19151][SQL]DataFrameWriter.saveAsTable sup...

2017-01-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16549#discussion_r95725199 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala --- @@ -49,8 +49,7 @@ private[hive] case class MetastoreRelation(

[GitHub] spark issue #12064: [SPARK-14272][ML] Evaluate GaussianMixtureModel with Log...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12064 **[Test build #71245 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71245/testReport)** for PR 12064 at commit

[GitHub] spark pull request #16454: [SPARK-19055][SQL][PySpark] Fix SparkSession init...

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16454#discussion_r95725013 --- Diff: python/pyspark/sql/session.py --- @@ -214,8 +214,12 @@ def __init__(self, sparkContext, jsparkSession=None): self._wrapped =

[GitHub] spark pull request #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter...

2017-01-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16481#discussion_r95724792 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -413,17 +413,22 @@ case class DataSource(

[GitHub] spark pull request #16454: [SPARK-19055][SQL][PySpark] Fix SparkSession init...

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16454#discussion_r95724518 --- Diff: python/pyspark/sql/session.py --- @@ -161,8 +161,8 @@ def getOrCreate(self): with self._lock: from

[GitHub] spark pull request #16454: [SPARK-19055][SQL][PySpark] Fix SparkSession init...

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16454#discussion_r95724228 --- Diff: python/pyspark/sql/session.py --- @@ -161,8 +161,8 @@ def getOrCreate(self): with self._lock: from

[GitHub] spark pull request #16454: [SPARK-19055][SQL][PySpark] Fix SparkSession init...

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16454#discussion_r95724161 --- Diff: python/pyspark/sql/session.py --- @@ -161,8 +161,8 @@ def getOrCreate(self): with self._lock: from

[GitHub] spark issue #15730: [SPARK-18218][ML][MLLib] Reduce shuffled data size of Bl...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15730 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2017-01-11 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r95723547 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #15730: [SPARK-18218][ML][MLLib] Reduce shuffled data size of Bl...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15730 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71242/ Test PASSed. ---

[GitHub] spark pull request #15505: [SPARK-18890][CORE] Move task serialization from ...

2017-01-11 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/15505#discussion_r95723533 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskDescription.scala --- @@ -52,7 +55,36 @@ private[spark] class TaskDescription( val

[GitHub] spark issue #15730: [SPARK-18218][ML][MLLib] Reduce shuffled data size of Bl...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15730 **[Test build #71242 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71242/testReport)** for PR 15730 at commit

[GitHub] spark pull request #16543: [SPARK-19133][SPARKR][ML][BACKPORT-2.0] fix glm f...

2017-01-11 Thread felixcheung
Github user felixcheung closed the pull request at: https://github.com/apache/spark/pull/16543 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #16543: [SPARK-19133][SPARKR][ML][BACKPORT-2.0] fix glm for Gamm...

2017-01-11 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16543 master to branch-2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16552: [WIP][SPARK-19152][SQL]DataFrameWriter.saveAsTable suppo...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16552 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71239/ Test FAILed. ---

[GitHub] spark issue #16552: [WIP][SPARK-19152][SQL]DataFrameWriter.saveAsTable suppo...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16552 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16552: [WIP][SPARK-19152][SQL]DataFrameWriter.saveAsTable suppo...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16552 **[Test build #71239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71239/testReport)** for PR 16552 at commit

[GitHub] spark issue #16554: [SPARK-19183] [SQL] Add deleteWithJob hook to internal c...

2017-01-11 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/16554 These are tests broken when you swap out the file commit protocol for our internal implementation. On Wed, Jan 11, 2017, 7:41 PM Wenchen Fan wrote: >

[GitHub] spark issue #12064: [SPARK-14272][ML] Evaluate GaussianMixtureModel with Log...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12064 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #12064: [SPARK-14272][ML] Evaluate GaussianMixtureModel with Log...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12064 **[Test build #71243 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71243/testReport)** for PR 12064 at commit

[GitHub] spark issue #12064: [SPARK-14272][ML] Evaluate GaussianMixtureModel with Log...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12064 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71243/ Test FAILed. ---

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95721703 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark issue #12064: [SPARK-14272][ML] Evaluate GaussianMixtureModel with Log...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12064 **[Test build #71245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71245/testReport)** for PR 12064 at commit

[GitHub] spark issue #16554: [SPARK-19183] [SQL] Add deleteWithJob hook to internal c...

2017-01-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16554 @ericl why did we pass all tests before? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95720884 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16404 **[Test build #71244 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71244/testReport)** for PR 16404 at commit

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2017-01-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16404 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #16395: [SPARK-17075][SQL] implemented filter estimation

2017-01-11 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/16395#discussion_r95720653 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -0,0 +1,555 @@ +/* +

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2017-01-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16404 how about we fix this in follow-up PR? Looks like the fix is not trivial. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14451: [SPARK-16848][SQL] Check schema validation for user-spec...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14451 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14451: [SPARK-16848][SQL] Check schema validation for user-spec...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14451 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71237/ Test PASSed. ---

[GitHub] spark issue #14451: [SPARK-16848][SQL] Check schema validation for user-spec...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14451 **[Test build #71237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71237/testReport)** for PR 14451 at commit

[GitHub] spark issue #16554: [SPARK-19183] [SQL] Add deleteWithJob hook to internal c...

2017-01-11 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/16554 The test was not properly ignoring hidden files, e.g. _SUCCESS markers. On Wed, Jan 11, 2017, 7:09 PM UCB AMPLab wrote: > Merged build finished. Test

[GitHub] spark pull request #16395: [SPARK-17075][SQL] implemented filter estimation

2017-01-11 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/16395#discussion_r95720309 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/Range.scala --- @@ -0,0 +1,75 @@ +/* + * Licensed

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95720330 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala --- @@ -17,11 +17,13 @@ package org.apache.spark.sql

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95720313 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala --- @@ -17,11 +17,13 @@ package org.apache.spark.sql

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2017-01-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16404 postgres handles `rand` in aggregate specially ``` cloud=# select random(), random(); random | random ---+---

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95719439 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark issue #12064: [SPARK-14272][ML] Evaluate GaussianMixtureModel with Log...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12064 **[Test build #71243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71243/testReport)** for PR 12064 at commit

[GitHub] spark pull request #16395: [SPARK-17075][SQL] implemented filter estimation

2017-01-11 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/16395#discussion_r95719350 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -0,0 +1,555 @@ +/* +

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95719293 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #16395: [SPARK-17075][SQL] implemented filter estimation

2017-01-11 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/16395#discussion_r95719141 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -0,0 +1,555 @@ +/* +

[GitHub] spark issue #15730: [SPARK-18218][ML][MLLib] Reduce shuffled data size of Bl...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15730 **[Test build #71242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71242/testReport)** for PR 15730 at commit

[GitHub] spark pull request #16395: [SPARK-17075][SQL] implemented filter estimation

2017-01-11 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/16395#discussion_r95718997 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -0,0 +1,555 @@ +/* +

[GitHub] spark pull request #16395: [SPARK-17075][SQL] implemented filter estimation

2017-01-11 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/16395#discussion_r95718952 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -0,0 +1,555 @@ +/* +

[GitHub] spark issue #16554: [SPARK-19183] [SQL] Add deleteWithJob hook to internal c...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16554 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71234/ Test PASSed. ---

[GitHub] spark issue #16554: [SPARK-19183] [SQL] Add deleteWithJob hook to internal c...

2017-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16554 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15730: [SPARK-18218][ML][MLLib] Reduce shuffled data size of Bl...

2017-01-11 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/15730 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16554: [SPARK-19183] [SQL] Add deleteWithJob hook to internal c...

2017-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16554 **[Test build #71234 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71234/testReport)** for PR 16554 at commit

  1   2   3   4   5   >