[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18320 Does it fail by running just gapply and nothing else? From what you have found in your investigations and the code you pointed to, I suspect this isn't limited to gapply. I think

[GitHub] spark issue #17451: [SPARK-19866][ML][PySpark] Add local version of Word2Vec...

2017-06-15 Thread keypointt
Github user keypointt commented on the issue: https://github.com/apache/spark/pull/17451 no worries Holden, totally understood thank you for the input and I'll try it out 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #18231: [SPARK-20994] Remove redundant characters in OpenBlocks ...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18231 **[Test build #78157 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78157/testReport)** for PR 18231 at commit

[GitHub] spark pull request #18231: [SPARK-20994] Remove redundant characters in Open...

2017-06-15 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/18231#discussion_r122367121 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -209,4 +190,51 @@ private

[GitHub] spark pull request #18231: [SPARK-20994] Remove redundant characters in Open...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18231#discussion_r122366821 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -209,4 +190,51 @@ private

[GitHub] spark issue #18284: [SPARK-21072][SQL] TreeNode.mapChildren should only appl...

2017-06-15 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/18284 thanks everyone for reviewing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17702: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17702 **[Test build #78156 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78156/testReport)** for PR 17702 at commit

[GitHub] spark issue #18239: [SPARK-19462] fix bug in Exchange--pass in a tmp "newPar...

2017-06-15 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18239 @cloud-fan Thanks a lot for reply. Yes, I'm also hesitate to backport branch-1.6; But I think this bug is too obvious -- with `spark.sql.adaptive.enabled=true`, any rerunning of

[GitHub] spark pull request #18321: [SPARK-12552][FOLLOWUP] Fix flaky test for "o.a.s...

2017-06-15 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18321#discussion_r122365295 --- Diff: core/src/test/scala/org/apache/spark/deploy/master/MasterSuite.scala --- @@ -214,7 +214,7 @@ class MasterSuite extends SparkFunSuite

[GitHub] spark issue #18268: [SPARK-21054] [SQL] Reset Command support reset specific...

2017-06-15 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/18268 Hive supports reset multiple keys like: `reset config1 config2`, should we also support that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #18231: [SPARK-20994] Remove redundant characters in OpenBlocks ...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18231 **[Test build #78155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78155/testReport)** for PR 18231 at commit

[GitHub] spark issue #18231: [SPARK-20994] Remove redundant characters in OpenBlocks ...

2017-06-15 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18231 @cloud-fan Thanks a lot for taking time review this. I refined accordingly :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request #17702: [SPARK-20408][SQL] Get the glob path in parallel ...

2017-06-15 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/17702#discussion_r122364493 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -389,6 +389,23 @@ case class DataSource(

[GitHub] spark pull request #18319: [SPARK-21114] [TEST] [2.1] Fix test failure in Sp...

2017-06-15 Thread gatorsmile
Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/18319 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18320 @felixcheung, BTW, is it okay as a PR alone as is? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #18318: [SPARK-21112] [SQL] ALTER TABLE SET TBLPROPERTIES...

2017-06-15 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/18318#discussion_r122363898 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -235,7 +235,7 @@ case class AlterTableSetPropertiesCommand(

[GitHub] spark pull request #18162: [SPARK-20923] turn tracking of TaskMetrics._updat...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18162#discussion_r122363701 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -528,7 +528,13 @@ class JobProgressListener(conf: SparkConf)

[GitHub] spark issue #18303: [SPARK-19824][Core] Update JsonProtocol to keep consiste...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18303 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18285: [SPARK-20338][CORE]Spaces in spark.eventLog.dir are not ...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18285 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18285: [SPARK-20338][CORE]Spaces in spark.eventLog.dir are not ...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18285 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78144/ Test PASSed. ---

[GitHub] spark issue #18285: [SPARK-20338][CORE]Spaces in spark.eventLog.dir are not ...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18285 **[Test build #78144 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78144/testReport)** for PR 18285 at commit

[GitHub] spark issue #18303: [SPARK-19824][Core] Update JsonProtocol to keep consiste...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18303 **[Test build #78154 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78154/testReport)** for PR 18303 at commit

[GitHub] spark issue #18303: [SPARK-19824][Core] Update JsonProtocol to keep consiste...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18303 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18320 I suspect this is an issue in R. I will raise this issue in R community soon and share it. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #18239: [SPARK-19462] fix bug in Exchange--pass in a tmp "newPar...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18239 I can hardly remember the code of Spark 1.6 and I'm not sure when is the next release of the 1.6 branch. BTW this bug can be worked around by turning off `spark.sql.adaptive.enabled`, do we

[GitHub] spark issue #17758: [SPARK-20460][SQL] Make it more consistent to handle col...

2017-06-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17758 @wzhfy Applied. Could u check again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #18025: [SPARK-20889][SparkR] Grouped documentation for A...

2017-06-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18025#discussion_r122362550 --- Diff: R/pkg/R/generics.R --- @@ -919,10 +920,9 @@ setGeneric("array_contains", function(x, value) { standardGeneric("array_contain #' @export

[GitHub] spark issue #18231: [SPARK-20994] Remove redundant characters in OpenBlocks ...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18231 LGTM except some minor comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #18231: [SPARK-20994] Remove redundant characters in Open...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18231#discussion_r122362155 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -209,4 +190,51 @@ private

[GitHub] spark issue #18025: [SPARK-20889][SparkR] Grouped documentation for AGGREGAT...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18025 **[Test build #78153 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78153/testReport)** for PR 18025 at commit

[GitHub] spark issue #18025: [SPARK-20889][SparkR] Grouped documentation for AGGREGAT...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18025 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #18231: [SPARK-20994] Remove redundant characters in Open...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18231#discussion_r122361985 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -209,4 +190,51 @@ private

[GitHub] spark issue #18025: [SPARK-20889][SparkR] Grouped documentation for AGGREGAT...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18025 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78153/ Test FAILed. ---

[GitHub] spark pull request #18231: [SPARK-20994] Remove redundant characters in Open...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18231#discussion_r122361955 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -209,4 +190,51 @@ private

[GitHub] spark issue #18025: [SPARK-20889][SparkR] Grouped documentation for AGGREGAT...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18025 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18320 Yes, I guess it will pass if we reduce `spark.sql.shuffle.partitions` (< I didn't look carefully and test this either). Just to make sure (and to share what I investigated ...), from my code

[GitHub] spark issue #18025: [SPARK-20889][SparkR] Grouped documentation for AGGREGAT...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18025 **[Test build #78152 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78152/testReport)** for PR 18025 at commit

[GitHub] spark issue #18025: [SPARK-20889][SparkR] Grouped documentation for AGGREGAT...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18025 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78152/ Test FAILed. ---

[GitHub] spark issue #18319: [SPARK-21114] [TEST] [2.1] Fix test failure in Spark 2.1...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18319 thanks, merging to 2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #18268: [SPARK-21054] [SQL] Reset Command support reset s...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18268#discussion_r122361086 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala --- @@ -301,4 +301,10 @@ class SparkSqlParserSuite extends

[GitHub] spark issue #18319: [SPARK-21114] [TEST] [2.1] Fix test failure in Spark 2.1...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18319 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78143/ Test PASSed. ---

[GitHub] spark issue #18319: [SPARK-21114] [TEST] [2.1] Fix test failure in Spark 2.1...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18319 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18319: [SPARK-21114] [TEST] [2.1] Fix test failure in Spark 2.1...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18319 **[Test build #78143 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78143/testReport)** for PR 18319 at commit

[GitHub] spark pull request #18284: [SPARK-21072][SQL] TreeNode.mapChildren should on...

2017-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18284 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18284: [SPARK-21072][SQL] TreeNode.mapChildren should only appl...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18284 thanks, merging to master/2.2/2.1! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18321: [SPARK-12552][FOLLOWUP] Fix flaky test for "o.a.s.deploy...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18321 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18320 that's very interesting. that code has been around for 2 years - to be honest I'm not 100% sure about what it is doing. perhaps this could also be fixed with a lower number of partitions?

[GitHub] spark issue #18318: [SPARK-21112] [SQL] ALTER TABLE SET TBLPROPERTIES should...

2017-06-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18318 Only the master branch has such an issue. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #18318: [SPARK-21112] [SQL] ALTER TABLE SET TBLPROPERTIES...

2017-06-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18318#discussion_r122359957 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -235,7 +235,7 @@ case class AlterTableSetPropertiesCommand(

[GitHub] spark pull request #15821: [SPARK-13534][PySpark] Using Apache Arrow to incr...

2017-06-15 Thread leifwalsh
Github user leifwalsh commented on a diff in the pull request: https://github.com/apache/spark/pull/15821#discussion_r122359928 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1648,8 +1650,30 @@ def toPandas(self): 02 Alice 15Bob

[GitHub] spark issue #18025: [SPARK-20889][SparkR] Grouped documentation for AGGREGAT...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18025 **[Test build #78149 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78149/testReport)** for PR 18025 at commit

[GitHub] spark issue #18025: [SPARK-20889][SparkR] Grouped documentation for AGGREGAT...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18025 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78149/ Test PASSed. ---

[GitHub] spark issue #18025: [SPARK-20889][SparkR] Grouped documentation for AGGREGAT...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18025 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15821: [SPARK-13534][PySpark] Using Apache Arrow to increase pe...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15821 yea I think it's fine to keep `ArrowPayload` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18283: [TEST][SPARKR][CORE] Fix broken SparkSubmitSuite

2017-06-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18283 @shaneknapp right - this script (install-dev.sh) has been assuming it can find `jar` without checking for JAVA_HOME, so I was saying it could be improved that way; but yea this script hasn't

[GitHub] spark pull request #15821: [SPARK-13534][PySpark] Using Apache Arrow to incr...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15821#discussion_r122359743 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala --- @@ -0,0 +1,423 @@ +/* +* Licensed to the Apache

[GitHub] spark pull request #15821: [SPARK-13534][PySpark] Using Apache Arrow to incr...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15821#discussion_r122359727 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala --- @@ -0,0 +1,1218 @@ +/* + * Licensed to the

[GitHub] spark issue #18249: [SPARK-19937] Collect metrics for remote bytes read to d...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18249 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78140/ Test PASSed. ---

[GitHub] spark issue #18249: [SPARK-19937] Collect metrics for remote bytes read to d...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18249 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15821: [SPARK-13534][PySpark] Using Apache Arrow to incr...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15821#discussion_r122359492 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala --- @@ -0,0 +1,423 @@ +/* +* Licensed to the Apache

[GitHub] spark issue #18249: [SPARK-19937] Collect metrics for remote bytes read to d...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18249 **[Test build #78140 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78140/testReport)** for PR 18249 at commit

[GitHub] spark issue #18025: [SPARK-20889][SparkR] Grouped documentation for AGGREGAT...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18025 **[Test build #78153 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78153/testReport)** for PR 18025 at commit

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18320 For normal usecases, I carefully suspect it might be fine because I executed 200 * ~10 tasks in a single machine quickly but I don't know if it happens frequently when it runs slowly in a

[GitHub] spark pull request #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Con...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18075#discussion_r122359345 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -233,10 +222,124 @@ class

[GitHub] spark pull request #18321: [SPARK-12552][FOLLOWUP] Fix flaky test for "o.a.s...

2017-06-15 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18321#discussion_r122359325 --- Diff: core/src/test/scala/org/apache/spark/deploy/master/MasterSuite.scala --- @@ -214,7 +214,7 @@ class MasterSuite extends SparkFunSuite

[GitHub] spark pull request #18321: [SPARK-12552][FOLLOWUP] Fix flaky test for "o.a.s...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18321#discussion_r122359276 --- Diff: core/src/test/scala/org/apache/spark/deploy/master/MasterSuite.scala --- @@ -214,7 +214,7 @@ class MasterSuite extends SparkFunSuite

[GitHub] spark pull request #18301: [SPARK-21052][SQL] Add hash map metrics to join

2017-06-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18301#discussion_r122359244 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala --- @@ -74,6 +80,19 @@ object SQLMetrics { private val

[GitHub] spark issue #18025: [SPARK-20889][SparkR] Grouped documentation for AGGREGAT...

2017-06-15 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/18025 @felixcheung Your comments are all addressed now. Please let me know if there is anything else needed. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #17758: [SPARK-20460][SQL] Make it more consistent to handle col...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17758 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78142/ Test PASSed. ---

[GitHub] spark issue #17758: [SPARK-20460][SQL] Make it more consistent to handle col...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17758 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #18301: [SPARK-21052][SQL] Add hash map metrics to join

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18301#discussion_r122359108 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala --- @@ -74,6 +80,19 @@ object SQLMetrics { private val

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18320 Yes, there is still the issue and this only fixes (avoid) the test failure. I believe running the codes should reproduce the issue for both Mac and CentOS. What I don't get it, when

[GitHub] spark issue #17758: [SPARK-20460][SQL] Make it more consistent to handle col...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17758 **[Test build #78142 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78142/testReport)** for PR 17758 at commit

[GitHub] spark issue #18025: [SPARK-20889][SparkR] Grouped documentation for AGGREGAT...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18025 **[Test build #78152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78152/testReport)** for PR 18025 at commit

[GitHub] spark issue #18092: [SPARK-20640][CORE]Make rpc timeout and retry for shuffl...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18092 **[Test build #78151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78151/testReport)** for PR 18092 at commit

[GitHub] spark pull request #18025: [SPARK-20889][SparkR] Grouped documentation for A...

2017-06-15 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/18025#discussion_r122358689 --- Diff: R/pkg/R/generics.R --- @@ -919,10 +920,9 @@ setGeneric("array_contains", function(x, value) { standardGeneric("array_contain #' @export

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-15 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18308 > I wonder if whether executor is completely gone or whether executor is still there but has no cached RDD, if both scenarios return false. Yes, that's the case, we cannot differentiate

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18320 thx - I think more importantly, does the issue manifest when someone manually call gapply in a similar way on RHEL/CentOS? We could workaround the test failure, but if user can use into this in

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18320 **[Test build #78148 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78148/testReport)** for PR 18320 at commit

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78148/ Test PASSed. ---

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18320 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18321: [SPARK-12552][FOLLOWUP] Fix flaky test for "o.a.s.deploy...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18321 **[Test build #78150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78150/testReport)** for PR 18321 at commit

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18320 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78147/ Test PASSed. ---

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18320 **[Test build #78147 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78147/testReport)** for PR 18320 at commit

[GitHub] spark pull request #18321: [SPARK-12552][FOLLOWUP] Fix flaky test for "o.a.s...

2017-06-15 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/18321 [SPARK-12552][FOLLOWUP] Fix flaky test for "o.a.s.deploy.master.MasterSuite.master correctly recover the application" ## What changes were proposed in this pull request? Due to the RPC

[GitHub] spark issue #18025: [SPARK-20889][SparkR] Grouped documentation for AGGREGAT...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18025 **[Test build #78149 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78149/testReport)** for PR 18025 at commit

[GitHub] spark pull request #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Con...

2017-06-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18075#discussion_r122356960 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -233,10 +222,118 @@ class CodegenContext

[GitHub] spark pull request #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Con...

2017-06-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18075#discussion_r122356982 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -233,10 +222,118 @@ class CodegenContext

[GitHub] spark pull request #18025: [SPARK-20889][SparkR] Grouped documentation for A...

2017-06-15 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/18025#discussion_r122356625 --- Diff: R/pkg/R/generics.R --- @@ -1403,20 +1416,25 @@ setGeneric("unix_timestamp", function(x, format) { standardGeneric("unix_timesta #'

[GitHub] spark pull request #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Con...

2017-06-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18075#discussion_r122356214 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -233,10 +222,124 @@ class CodegenContext

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18320 **[Test build #78148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78148/testReport)** for PR 18320 at commit

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18320 Yes, I believe you are correct and the daemon is already running but it avoids to use the problematic daemon -

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18320 Yes, I believe you are correct but the daemon is already running but it avoids to use the problematic daemon -

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18320 Hmm I'm not sure - I'm pretty sure the session / spark context is already initialized when this test is run and changing the setting here does it affect the existing daemon process already

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18320 **[Test build #78147 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78147/testReport)** for PR 18320 at commit

[GitHub] spark pull request #17702: [SPARK-20408][SQL] Get the glob path in parallel ...

2017-06-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17702#discussion_r122354359 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -389,6 +389,23 @@ case class DataSource( }

[GitHub] spark issue #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/ga...

2017-06-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18320 cc @felixcheung, @shivaram and @MLnick. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #18320: [SPARK-21093][R] Avoid mcfork in R's daemon in ga...

2017-06-15 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/18320 [SPARK-21093][R] Avoid mcfork in R's daemon in gapply/gapplyCollect tests ## What changes were proposed in this pull request? `mcfork` in R looks opening a pipe ahead but the existing

[GitHub] spark issue #17702: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17702 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

  1   2   3   4   5   6   >