[GitHub] spark pull request #18421: [SPARK-21213][SQL] Support collecting partition-l...

2017-07-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18421#discussion_r128166394 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala --- @@ -112,4 +112,29 @@ object CommandUtils extends Logging

[GitHub] spark issue #18554: [SPARK-21306][ML] OneVsRest should support setWeightCol

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18554 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18554: [SPARK-21306][ML] OneVsRest should support setWeightCol

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18554 **[Test build #79740 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79740/testReport)** for PR 18554 at commit [`9ba0e2b`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #18554: [SPARK-21306][ML] OneVsRest should support setWeightCol

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18554 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79740/ Test PASSed. ---

[GitHub] spark issue #18468: [SPARK-20873][SQL] Creat CachedBatchColumnVector to abst...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18468 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79739/ Test PASSed. ---

[GitHub] spark issue #18468: [SPARK-20873][SQL] Creat CachedBatchColumnVector to abst...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18468 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18468: [SPARK-20873][SQL] Creat CachedBatchColumnVector to abst...

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18468 **[Test build #79739 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79739/testReport)** for PR 18468 at commit [`b83dedb`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-07-18 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18444 Btw, now I'm wondering Python 3 can handle array like `array('L', [9223372036854775807])`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-07-18 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18444 Yea, it's related to typecode `'L'` in pypy environment. We might need to handle it as the same as we did for typecode `'c'` or override `constructLongArrayFromUInt64()`. --- If your project is

[GitHub] spark issue #18656: [SPARK-21441][SQL]Incorrect Codegen in SortMergeJoinExec...

2017-07-18 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18656 LGTM for the code change. But I think we better to have a test for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark issue #18656: [SPARK-21441][SQL]Incorrect Codegen in SortMergeJoinExec...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18656 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79738/ Test PASSed. ---

[GitHub] spark issue #18656: [SPARK-21441][SQL]Incorrect Codegen in SortMergeJoinExec...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18656 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18656: [SPARK-21441][SQL]Incorrect Codegen in SortMergeJoinExec...

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18656 **[Test build #79738 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79738/testReport)** for PR 18656 at commit [`1161ffd`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18655 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18655 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79737/ Test PASSed. ---

[GitHub] spark issue #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and...

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18655 **[Test build #79737 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79737/testReport)** for PR 18655 at commit [`b5988f9`](https://github.com/apache/spark/commit/b

[GitHub] spark pull request #17848: [SPARK-20586] [SQL] Add deterministic to ScalaUDF...

2017-07-18 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/17848#discussion_r128162324 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala --- @@ -103,4 +110,19 @@ case class UserDefinedFunction protected

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18444 Sounds actually related: ``` == ERROR: test_array_types (pyspark.sql.tests.SQLTests) -

[GitHub] spark pull request #17848: [SPARK-20586] [SQL] Add deterministic to ScalaUDF...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17848#discussion_r128161850 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala --- @@ -103,4 +110,19 @@ case class UserDefinedFunction prot

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-07-18 Thread zasdfgbnm
Github user zasdfgbnm commented on the issue: https://github.com/apache/spark/pull/18444 Looks to be an unrelated error. _Sent from my OnePlus ONEPLUS A3000 using [FastHub](https://play.google.com/store/apps/details?id=com.fastaccess.github)_ --- If your project is set up fo

[GitHub] spark issue #18421: [SPARK-21213][SQL] Support collecting partition-level st...

2017-07-18 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18421 Is that possible the partition-level row counts is larger than the table-level row counts after running this new command? --- If your project is set up for it, you can reply to this email and ha

[GitHub] spark issue #18462: [SPARK-21333][Docs] Removed invalid joinTypes from javad...

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18462 **[Test build #79742 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79742/testReport)** for PR 18462 at commit [`9aee54a`](https://github.com/apache/spark/commit/9a

[GitHub] spark pull request #17848: [SPARK-20586] [SQL] Add deterministic to ScalaUDF...

2017-07-18 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/17848#discussion_r128159939 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala --- @@ -103,4 +110,19 @@ case class UserDefinedFunction protected

[GitHub] spark pull request #17848: [SPARK-20586] [SQL] Add deterministic to ScalaUDF...

2017-07-18 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/17848#discussion_r128159874 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala --- @@ -103,4 +110,19 @@ case class UserDefinedFunction protected

[GitHub] spark pull request #17848: [SPARK-20586] [SQL] Add deterministic to ScalaUDF...

2017-07-18 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/17848#discussion_r128159780 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala --- @@ -58,6 +55,13 @@ case class UserDefinedFunction protected[s

[GitHub] spark issue #18462: [SPARK-21333][Docs] Removed invalid joinTypes from javad...

2017-07-18 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18462 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] spark issue #18462: [SPARK-21333][Docs] Removed invalid joinTypes from javad...

2017-07-18 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18462 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #18462: [SPARK-21333][Docs] Removed invalid joinTypes from javad...

2017-07-18 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18462 sorry, I forgot it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and...

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18655 **[Test build #79741 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79741/testReport)** for PR 18655 at commit [`a50a271`](https://github.com/apache/spark/commit/a5

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18444 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18444 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79736/ Test FAILed. ---

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18444 **[Test build #79736 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79736/testReport)** for PR 18444 at commit [`88091ea`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #18554: [SPARK-21306][ML] OneVsRest should support setWeightCol

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18554 **[Test build #79740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79740/testReport)** for PR 18554 at commit [`9ba0e2b`](https://github.com/apache/spark/commit/9b

[GitHub] spark pull request #18554: [SPARK-21306][ML] OneVsRest should support setWei...

2017-07-18 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/18554#discussion_r128158473 --- Diff: python/pyspark/ml/tests.py --- @@ -1255,6 +1255,17 @@ def test_output_columns(self): output = model.transform(df) self.ass

[GitHub] spark pull request #18468: [SPARK-20873][SQL] Creat CachedBatchColumnVector ...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18468#discussion_r128156883 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala --- @@ -326,6 +329,84 @@ class ColumnarBatchSuite ex

[GitHub] spark pull request #18503: [SPARK-21271][SQL] Ensure Unsafe.sizeInBytes is a...

2017-07-18 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18503#discussion_r128156305 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala --- @@ -479,6 +479,61 @@ class StreamSuite extends StreamTest {

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-07-18 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18444 LGTM, too. pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18444 Okay. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark pull request #18468: [SPARK-20873][SQL] Creat CachedBatchColumnVector ...

2017-07-18 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18468#discussion_r128152848 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/CachedBatchColumnVector.java --- @@ -0,0 +1,416 @@ +/* + * Licensed to the

[GitHub] spark pull request #18468: [SPARK-20873][SQL] Creat CachedBatchColumnVector ...

2017-07-18 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18468#discussion_r128152870 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/CachedBatchColumnVector.java --- @@ -0,0 +1,416 @@ +/* + * Licensed to the

[GitHub] spark issue #18468: [SPARK-20873][SQL] Creat CachedBatchColumnVector to abst...

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18468 **[Test build #79739 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79739/testReport)** for PR 18468 at commit [`b83dedb`](https://github.com/apache/spark/commit/b8

[GitHub] spark pull request #18388: [SPARK-21175] Reject OpenBlocks when memory short...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18388#discussion_r128151097 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java --- @@ -25,6 +25,9 @@ import com.goo

[GitHub] spark pull request #18388: [SPARK-21175] Reject OpenBlocks when memory short...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18388#discussion_r128151076 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java --- @@ -139,6 +153,32 @@ public void checkAutho

[GitHub] spark pull request #18468: [SPARK-20873][SQL] Creat CachedBatchColumnVector ...

2017-07-18 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18468#discussion_r128149909 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/CachedBatchColumnVector.java --- @@ -0,0 +1,416 @@ +/* + * Licensed to the

[GitHub] spark pull request #18388: [SPARK-21175] Reject OpenBlocks when memory short...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18388#discussion_r128149914 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java --- @@ -53,9 +56,13 @@ // that the cal

[GitHub] spark issue #18656: [SPARK-21441][SQL]Incorrect Codegen in SortMergeJoinExec...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18656 LGTM, can you update the PR description? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18656: [SPARK-21441][SQL]Incorrect Codegen in SortMergeJoinExec...

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18656 **[Test build #79738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79738/testReport)** for PR 18656 at commit [`1161ffd`](https://github.com/apache/spark/commit/11

[GitHub] spark issue #18656: [SPARK-21441][SQL]Incorrect Codegen in SortMergeJoinExec...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18656 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] spark issue #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and...

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18655 **[Test build #79737 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79737/testReport)** for PR 18655 at commit [`b5988f9`](https://github.com/apache/spark/commit/b5

[GitHub] spark issue #18678: [SPARK-21464][SS] Minimize deprecation warnings caused b...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18678 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79735/ Test PASSed. ---

[GitHub] spark issue #18678: [SPARK-21464][SS] Minimize deprecation warnings caused b...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18678 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18678: [SPARK-21464][SS] Minimize deprecation warnings caused b...

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18678 **[Test build #79735 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79735/testReport)** for PR 18678 at commit [`41d550f`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and...

2017-07-18 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18655 I see, I'll move files back to `arrow` package. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConvert...

2017-07-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/18655#discussion_r128146875 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala --- @@ -391,6 +392,85 @@ class ArrowConvertersSuite extend

[GitHub] spark pull request #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConvert...

2017-07-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/18655#discussion_r128146851 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala --- @@ -55,145 +51,55 @@ private[sql] class ArrowPayload privat

[GitHub] spark pull request #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConvert...

2017-07-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/18655#discussion_r128146856 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/vectorized/ArrowWriter.scala --- @@ -0,0 +1,405 @@ +/* + * Licensed to the Apache S

[GitHub] spark pull request #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConvert...

2017-07-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/18655#discussion_r128146843 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala --- @@ -55,145 +51,55 @@ private[sql] class ArrowPayload privat

[GitHub] spark issue #18670: [SPARK-21455][CORE]RpcFailure should be call on RpcRespo...

2017-07-18 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18670 @ConeyLiu the network layer doesn't know how to serialize Throwable, or in other words, it cannot use JavaSerializer in Spark core. --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18444 **[Test build #79736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79736/testReport)** for PR 18444 at commit [`88091ea`](https://github.com/apache/spark/commit/88

[GitHub] spark issue #18656: [SPARK-21441][SQL]Incorrect Codegen in SortMergeJoinExec...

2017-07-18 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18656 @cloud-fan Can you help trigger the jenkins test for this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-07-18 Thread zasdfgbnm
Github user zasdfgbnm commented on the issue: https://github.com/apache/spark/pull/18444 @HyukjinKwon Take a look at my newest commit. I think I find a better way to solve the problem that keeps all the hacking code for `SPARK-21465` in a single place, making it easier to be removed

[GitHub] spark pull request #18487: [SPARK-21243][Core] Limit no. of map outputs in a...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18487#discussion_r128145633 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -321,6 +321,17 @@ package object config { .intConf

[GitHub] spark issue #18670: [SPARK-21455][CORE]RpcFailure should be call on RpcRespo...

2017-07-18 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/18670 Ok, thanks for the answer. I think we can use `ByteBuffer` to solve the wire compatibility problem, maybe I'm wrong. I think we should change this, because we also using `onFaliure` to send fa

[GitHub] spark pull request #18468: [SPARK-20873][SQL] Creat CachedBatchColumnVector ...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18468#discussion_r128144943 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/CachedBatchColumnVector.java --- @@ -0,0 +1,416 @@ +/* + * Licensed to

[GitHub] spark pull request #18468: [SPARK-20873][SQL] Creat CachedBatchColumnVector ...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18468#discussion_r128144719 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/CachedBatchColumnVector.java --- @@ -0,0 +1,416 @@ +/* + * Licensed to

[GitHub] spark pull request #18651: [SPARK-21383][Core] Fix the YarnAllocator allocat...

2017-07-18 Thread djvulee
Github user djvulee commented on a diff in the pull request: https://github.com/apache/spark/pull/18651#discussion_r128144194 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -505,32 +508,37 @@ private[yarn] class YarnAllocato

[GitHub] spark pull request #18651: [SPARK-21383][Core] Fix the YarnAllocator allocat...

2017-07-18 Thread djvulee
Github user djvulee commented on a diff in the pull request: https://github.com/apache/spark/pull/18651#discussion_r128143898 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -82,6 +82,8 @@ private[yarn] class YarnAllocator(

[GitHub] spark issue #18656: [SPARK-21441][SQL]Incorrect Codegen in SortMergeJoinExec...

2017-07-18 Thread DonnyZone
Github user DonnyZone commented on the issue: https://github.com/apache/spark/pull/18656 Thanks for reviewing, I will add a test later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark issue #18649: [SPARK-21395][SQL] Spark SQL hive-thriftserver doesn't r...

2017-07-18 Thread debugger87
Github user debugger87 commented on the issue: https://github.com/apache/spark/pull/18649 @gatorsmile Could you please help me review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #18468: [SPARK-20873][SQL] Creat CachedBatchColumnVector ...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18468#discussion_r128143583 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/CachedBatchColumnVector.java --- @@ -0,0 +1,416 @@ +/* + * Licensed to

[GitHub] spark pull request #18677: [SPARK-21273][SQL][Follow-up] Propagate logical p...

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18677 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r128143343 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -404,6 +404,13 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark issue #18677: [SPARK-21273][SQL][Follow-up] Propagate logical plan sta...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18677 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] spark issue #18677: [SPARK-21273][SQL][Follow-up] Propagate logical plan sta...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79733/ Test PASSed. ---

[GitHub] spark issue #18677: [SPARK-21273][SQL][Follow-up] Propagate logical plan sta...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18677 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18677: [SPARK-21273][SQL][Follow-up] Propagate logical plan sta...

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18677 **[Test build #79733 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79733/testReport)** for PR 18677 at commit [`bc8257c`](https://github.com/apache/spark/commit/b

[GitHub] spark pull request #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types ...

2017-07-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/18444#discussion_r128142573 --- Diff: python/pyspark/sql/types.py --- @@ -938,12 +1016,17 @@ def _infer_type(obj): return MapType(_infer_type(key), _infer_type(value

[GitHub] spark pull request #18656: [SPARK-21441][SQL]Incorrect Codegen in SortMergeJ...

2017-07-18 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18656#discussion_r128142552 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -489,13 +489,13 @@ case class CollapseCodegenStages(conf

[GitHub] spark pull request #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types ...

2017-07-18 Thread zasdfgbnm
Github user zasdfgbnm commented on a diff in the pull request: https://github.com/apache/spark/pull/18444#discussion_r128142511 --- Diff: python/pyspark/sql/types.py --- @@ -938,12 +1016,17 @@ def _infer_type(obj): return MapType(_infer_type(key), _infer_type(va

[GitHub] spark pull request #18656: [SPARK-21441]Incorrect Codegen in SortMergeJoinEx...

2017-07-18 Thread DonnyZone
Github user DonnyZone commented on a diff in the pull request: https://github.com/apache/spark/pull/18656#discussion_r128142467 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -489,13 +489,13 @@ case class CollapseCodegenStages(c

[GitHub] spark issue #18677: [SPARK-21273][SQL][Follow-up] Propagate logical plan sta...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18677 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18677: [SPARK-21273][SQL][Follow-up] Propagate logical plan sta...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79732/ Test PASSed. ---

[GitHub] spark issue #18677: [SPARK-21273][SQL][Follow-up] Propagate logical plan sta...

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18677 **[Test build #79732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79732/testReport)** for PR 18677 at commit [`0834050`](https://github.com/apache/spark/commit/0

[GitHub] spark pull request #18656: [SPARK-21441]Incorrect Codegen in SortMergeJoinEx...

2017-07-18 Thread DonnyZone
Github user DonnyZone commented on a diff in the pull request: https://github.com/apache/spark/pull/18656#discussion_r128142370 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -489,13 +489,13 @@ case class CollapseCodegenStages(c

[GitHub] spark issue #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties from s...

2017-07-18 Thread yaooqinn
Github user yaooqinn commented on the issue: https://github.com/apache/spark/pull/18668 ping @cloud-fan @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] spark pull request #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame t...

2017-07-18 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/18634#discussion_r128142152 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala --- @@ -356,6 +356,42 @@ class SQLWindowFunctionSuite exten

[GitHub] spark issue #18649: [SPARK-21395][SQL] Spark SQL hive-thriftserver doesn't r...

2017-07-18 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18649 Sorry I'm not familiar with this part, I cannot give you a valid comment, you could ask others to help reviewing your patch 😄 . --- If your project is set up for it, you can reply to this emai

[GitHub] spark issue #18673: [SPARK-21447][WEB UI] Spark history server fails to rend...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18673 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #17848: [SPARK-20586] [SQL] Add deterministic to ScalaUDF...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17848#discussion_r128141710 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala --- @@ -104,21 +104,35 @@ class UDFRegistration private[sql] (functionRegistr

[GitHub] spark issue #18673: [SPARK-21447][WEB UI] Spark history server fails to rend...

2017-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18673 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79731/ Test PASSed. ---

[GitHub] spark pull request #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types ...

2017-07-18 Thread zasdfgbnm
Github user zasdfgbnm commented on a diff in the pull request: https://github.com/apache/spark/pull/18444#discussion_r128141018 --- Diff: python/pyspark/sql/types.py --- @@ -938,12 +1016,17 @@ def _infer_type(obj): return MapType(_infer_type(key), _infer_type(va

[GitHub] spark issue #18673: [SPARK-21447][WEB UI] Spark history server fails to rend...

2017-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18673 **[Test build #79731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79731/testReport)** for PR 18673 at commit [`b82847e`](https://github.com/apache/spark/commit/b

[GitHub] spark pull request #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types ...

2017-07-18 Thread zasdfgbnm
Github user zasdfgbnm commented on a diff in the pull request: https://github.com/apache/spark/pull/18444#discussion_r128141384 --- Diff: python/pyspark/sql/types.py --- @@ -938,12 +1016,17 @@ def _infer_type(obj): return MapType(_infer_type(key), _infer_type(va

[GitHub] spark pull request #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types ...

2017-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18444#discussion_r128141295 --- Diff: python/pyspark/sql/types.py --- @@ -938,12 +1016,17 @@ def _infer_type(obj): return MapType(_infer_type(key), _infer_type(

[GitHub] spark issue #18649: [SPARK-21395][SQL] Spark SQL hive-thriftserver doesn't r...

2017-07-18 Thread debugger87
Github user debugger87 commented on the issue: https://github.com/apache/spark/pull/18649 @jerryshao Yes, it's just copied from SQLOperation in Hive. However, those code lines are the key point that HiveServer2 can return operation log to client via `TFetchResultsReq` which fetchType

[GitHub] spark issue #18677: [SPARK-21273][SQL][Follow-up] Propagate logical plan sta...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18677 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] spark pull request #18654: [SPARK-21435][SQL] Empty files should be skipped ...

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18654 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #18670: [SPARK-21455][CORE]RpcFailure should be call on RpcRespo...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18670 +1 to keep wire compatibility. Just for curious, if we can re-design it, shall we use `RpcFailure` to send exception? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] spark issue #18656: [SPARK-21441]Incorrect Codegen in SortMergeJoinExec resu...

2017-07-18 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18656 Btw, can you also add a test for this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark issue #18654: [SPARK-21435][SQL] Empty files should be skipped while w...

2017-07-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18654 LGTM, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

  1   2   3   4   5   >