[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-29 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19083 LGTM except one comment --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19083: [SPARK-21871][SQL] Check actual bytecode size whe...

2017-09-29 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19083#discussion_r141998362 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -1074,13 +1078,30 @@ object CodeGenerator

[GitHub] spark issue #19290: [SPARK-22063][R] Upgrades lintr to latest commit sha1 ID

2017-09-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19290 Ah, thank you @shaneknapp. The command below: ``` Rscript -e "devtools::install_github('jimhester/lintr@5431140')" ``` should upgrades `lintr` to the desired version

[GitHub] spark pull request #19392: [SPARK-22169][SQL] table name with numbers and ch...

2017-09-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19392#discussion_r141998045 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -510,11 +510,15 @@ rowFormat ;

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19344 ok, thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19344 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19344 These modified test cases are not following the standards. Impala added extra (partition) predicates. The perf results are misleading. ---

[GitHub] spark pull request #19344: [SPARK-22122][SQL] Use analyzed logical plans to ...

2017-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19344 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19380: [SPARK-22157] [SQL] The uniux_timestamp method handles t...

2017-09-29 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19380 This itself is certainly not a bug. The type is on purpose and certainly the answer is correct given the type. You are arguing for a new function called something else but you can also do this with

[GitHub] spark issue #19380: [SPARK-22157] [SQL] The uniux_timestamp method handles t...

2017-09-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19380 Currently, we are following Hive for these built-in functions. See https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF Maybe we can wait and see whether more users have

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-09-29 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19083 @gatorsmile if you get time, could you check this? Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19344 btw, could we also add add `tpcds-modifiedQueries` here? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19344 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82341/ Test PASSed. ---

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19344 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19344 **[Test build #82341 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82341/testReport)** for PR 19344 at commit

[GitHub] spark issue #19327: [SPARK-22136][SS] Implement stream-stream outer joins.

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19327 **[Test build #82342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82342/testReport)** for PR 19327 at commit

[GitHub] spark issue #19396: [SPARK-22172][CORE] Worker hangs when the external shuff...

2017-09-29 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19396 IMO I think it might be better to throw an exception instead of shifting to another shuffle. Since user want to use external shuffle explicitly, letting user to know the issues and fix the issue

[GitHub] spark issue #19399: [SPARK-22175][WEB-UI] Add status column to history page

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19399 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19399: [SPARK-22175][WEB-UI] Add status column to histor...

2017-09-29 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/19399 [SPARK-22175][WEB-UI] Add status column to history page ## What changes were proposed in this pull request? Currently, the history page has no status column which represent the status of

[GitHub] spark issue #19398: [SPARK-22174][CORE]Support to automatically create the d...

2017-09-29 Thread zuotingbing
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/19398 Got it, thanks all. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19398: [SPARK-22174][CORE]Support to automatically creat...

2017-09-29 Thread zuotingbing
Github user zuotingbing closed the pull request at: https://github.com/apache/spark/pull/19398 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19398: [SPARK-22174][CORE]Support to automatically create the d...

2017-09-29 Thread zuotingbing
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/19398 Do you know what is the reason to choice to manually create? What about changing it to create it automatically? Thanks. ---

[GitHub] spark issue #19398: [SPARK-22174][CORE]Support to automatically create the d...

2017-09-29 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19398 See bug update. Please close this PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19344 LGTM pending Jenkins --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19117: [SPARK-21904] [SQL] Rename tempTables to tempView...

2017-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19117 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19117: [SPARK-21904] [SQL] Rename tempTables to tempViews in Se...

2017-09-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19117 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

2017-09-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19370 what is this python console scripts idea, @jsnowacki ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #19393: [SPARK-21644][SQL] LocalLimit.maxRows is defined incorre...

2017-09-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19393 cc @rxin @JoshRosen @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19395: [SPARK-22171] [SQL] Describe Table Extended Faile...

2017-09-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19395#discussion_r141995486 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/CatalogSuite.scala --- @@ -0,0 +1,37 @@ +/* + * Licensed to the

[GitHub] spark issue #19395: [SPARK-22171] [SQL] Describe Table Extended Failed when ...

2017-09-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19395 The Hive might be too old --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19398: [SPARK-22174][CORE]Support to automatically create the d...

2017-09-29 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19398 AFAIK, this is a by-design choice to manually create event log directory. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19398: [SPARK-22174][CORE]Support to automatically create the d...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19398 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19398: [SPARK-22174][CORE]Support to automatically creat...

2017-09-29 Thread zuotingbing
GitHub user zuotingbing opened a pull request: https://github.com/apache/spark/pull/19398 [SPARK-22174][CORE]Support to automatically create the directory where the event logs go (`spark.eventLog.dir`) ## What changes were proposed in this pull request? `2017-09-30

[GitHub] spark issue #19117: [SPARK-21904] [SQL] Rename tempTables to tempViews in Se...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19117 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82337/ Test PASSed. ---

[GitHub] spark issue #19117: [SPARK-21904] [SQL] Rename tempTables to tempViews in Se...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19117 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19117: [SPARK-21904] [SQL] Rename tempTables to tempViews in Se...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19117 **[Test build #82337 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82337/testReport)** for PR 19117 at commit

[GitHub] spark issue #19394: [SPARK-22170][SQL] Reduce memory consumption in broadcas...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19394 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19394: [SPARK-22170][SQL] Reduce memory consumption in broadcas...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19394 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82338/ Test FAILed. ---

[GitHub] spark issue #19394: [SPARK-22170][SQL] Reduce memory consumption in broadcas...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19394 **[Test build #82338 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82338/testReport)** for PR 19394 at commit

[GitHub] spark issue #19397: [SPARK-22173] Table CSS style needs to be adjusted in Hi...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19397 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19397: [SPARK-22173] Table CSS style needs to be adjuste...

2017-09-29 Thread guoxiaolongzte
GitHub user guoxiaolongzte opened a pull request: https://github.com/apache/spark/pull/19397 [SPARK-22173] Table CSS style needs to be adjusted in History Page and in Executors Page. ## What changes were proposed in this pull request? There is a problem with table CSS

[GitHub] spark issue #19395: [SPARK-22171] [SQL] Describe Table Extended Failed when ...

2017-09-29 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/19395 Just curious about how would this happen? Is it due to a data corruption in database? --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19395: [SPARK-22171] [SQL] Describe Table Extended Faile...

2017-09-29 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/19395#discussion_r141994085 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/CatalogSuite.scala --- @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19344 **[Test build #82341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82341/testReport)** for PR 19344 at commit

[GitHub] spark issue #19396: [SPARK-22172][CORE] Worker hangs when the external shuff...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19396 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19396: [SPARK-22172][CORE] Worker hangs when the externa...

2017-09-29 Thread devaraj-kavali
GitHub user devaraj-kavali opened a pull request: https://github.com/apache/spark/pull/19396 [SPARK-22172][CORE] Worker hangs when the external shuffle service port is already in use ## What changes were proposed in this pull request? Handling the NonFatal exceptions while

[GitHub] spark issue #19380: [SPARK-22157] [SQL] The uniux_timestamp method handles t...

2017-09-29 Thread httfighter
Github user httfighter commented on the issue: https://github.com/apache/spark/pull/19380 I understand everyone's worries.But i hava few thoughts. Firstly, the native unix_timestamp itself supports the "-MM-dd HH:mm:ss.SSS" form of the date, but the result is lost in

[GitHub] spark issue #19383: [SPARK-20643][core] Add listener implementation to colle...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19383 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82333/ Test PASSed. ---

[GitHub] spark issue #19383: [SPARK-20643][core] Add listener implementation to colle...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19383 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19383: [SPARK-20643][core] Add listener implementation to colle...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19383 **[Test build #82333 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82333/testReport)** for PR 19383 at commit

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19344 **[Test build #82340 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82340/testReport)** for PR 19344 at commit

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19344 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82340/ Test FAILed. ---

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19344 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19393: [SPARK-21644][SQL] LocalLimit.maxRows is defined incorre...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19393 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82334/ Test PASSed. ---

[GitHub] spark issue #19393: [SPARK-21644][SQL] LocalLimit.maxRows is defined incorre...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19393 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19393: [SPARK-21644][SQL] LocalLimit.maxRows is defined incorre...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19393 **[Test build #82334 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82334/testReport)** for PR 19393 at commit

[GitHub] spark issue #19395: [SPARK-22171] [SQL] Describe Table Extended Failed when ...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19395 **[Test build #82339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82339/testReport)** for PR 19395 at commit

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19344 **[Test build #82340 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82340/testReport)** for PR 19344 at commit

[GitHub] spark pull request #19395: [SPARK-22171] [SQL] Describe Table Extended Faile...

2017-09-29 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/19395 [SPARK-22171] [SQL] Describe Table Extended Failed when Table Owner is Empty ## What changes were proposed in this pull request? Users could hit `java.lang.NullPointerException` when

[GitHub] spark issue #19395: [SPARK-22171] [SQL] Describe Table Extended Failed when ...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19395 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19395: [SPARK-22171] [SQL] Describe Table Extended Failed when ...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19395 **[Test build #82339 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82339/testReport)** for PR 19395 at commit

[GitHub] spark issue #19395: [SPARK-22171] [SQL] Describe Table Extended Failed when ...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19395 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82339/ Test FAILed. ---

[GitHub] spark pull request #19344: [SPARK-22122][SQL] Use analyzed logical plans to ...

2017-09-29 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19344#discussion_r141990530 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala --- @@ -66,24 +64,11 @@ object TPCDSQueryBenchmark

[GitHub] spark issue #19394: [SPARK-22170][SQL] Reduce memory consumption in broadcas...

2017-09-29 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/19394 Ideally, this would also use a TaskMemoryManager so the driver can spill results to disk instead of dying with an OOM. Is there any plan to add a memory manager for the driver? ---

[GitHub] spark issue #19394: [SPARK-22170][SQL] Reduce memory consumption in broadcas...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19394 **[Test build #82338 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82338/testReport)** for PR 19394 at commit

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

2017-09-29 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141989504 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala --- @@ -133,242 +134,6 @@ object

[GitHub] spark pull request #19394: SPARK-22170: Reduce memory consumption in broadca...

2017-09-29 Thread rdblue
GitHub user rdblue opened a pull request: https://github.com/apache/spark/pull/19394 SPARK-22170: Reduce memory consumption in broadcast joins. This updates the broadcast join code path to lazily decompress pages and iterate through UnsafeRows to prevent all rows from being held

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

2017-09-29 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141987778 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -207,31 +221,108 @@ case class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

2017-09-29 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141987664 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -207,31 +221,108 @@ case class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

2017-09-29 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141986897 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -207,31 +221,108 @@ case class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

2017-09-29 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141986865 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -207,31 +221,108 @@ case class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

2017-09-29 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141986696 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala --- @@ -413,36 +414,103 @@ class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

2017-09-29 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141986708 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala --- @@ -413,36 +414,103 @@ class

[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-09-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19309 Will review it this weekend. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

2017-09-29 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141986634 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala --- @@ -413,36 +414,103 @@ class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

2017-09-29 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141986168 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala --- @@ -413,36 +414,103 @@ class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

2017-09-29 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141986227 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala --- @@ -413,36 +414,103 @@ class

[GitHub] spark issue #19117: [SPARK-21904] [SQL] Rename tempTables to tempViews in Se...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19117 **[Test build #82337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82337/testReport)** for PR 19117 at commit

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

2017-09-29 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141985815 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala --- @@ -413,36 +414,103 @@ class

[GitHub] spark issue #19388: [SPARK-22162] Executors and the driver should use consis...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19388 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82331/ Test FAILed. ---

[GitHub] spark issue #19388: [SPARK-22162] Executors and the driver should use consis...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19388 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19388: [SPARK-22162] Executors and the driver should use consis...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19388 **[Test build #82331 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82331/testReport)** for PR 19388 at commit

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

2017-09-29 Thread joseph-torres
Github user joseph-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141984167 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala --- @@ -413,36 +414,103 @@ class

[GitHub] spark issue #19270: [SPARK-21809] : Change Stage Page to use datatables to s...

2017-09-29 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/19270 Thanks, I'll pull the latest changes and keep testing. And thanks for your quick responses, I understand large changes like this take forever to review and can get frustrating for the submitter.

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

2017-09-29 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141982780 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala --- @@ -233,16 +234,54 @@ object

[GitHub] spark issue #18732: [SPARK-20396][SQL][PySpark] groupby().apply() with panda...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18732 **[Test build #82336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82336/testReport)** for PR 18732 at commit

[GitHub] spark issue #18732: [SPARK-20396][SQL][PySpark] groupby().apply() with panda...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18732 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18732: [SPARK-20396][SQL][PySpark] groupby().apply() with panda...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18732 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82336/ Test FAILed. ---

[GitHub] spark issue #18732: [SPARK-20396][SQL][PySpark] groupby().apply() with panda...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18732 **[Test build #82336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82336/testReport)** for PR 18732 at commit

[GitHub] spark pull request #19229: [SPARK-22001][ML][SQL] ImputerModel can do withCo...

2017-09-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19229#discussion_r141976671 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2102,6 +2102,55 @@ class Dataset[T] private[sql]( } /**

[GitHub] spark issue #19380: [SPARK-22157] [SQL] The uniux_timestamp method handles t...

2017-09-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19380 The workaround is to let users write a UDF to handle these cases --- - To unsubscribe, e-mail:

[GitHub] spark issue #18732: [SPARK-20396][SQL][PySpark] groupby().apply() with panda...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18732 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82335/ Test FAILed. ---

[GitHub] spark issue #18732: [SPARK-20396][SQL][PySpark] groupby().apply() with panda...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18732 **[Test build #82335 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82335/testReport)** for PR 18732 at commit

[GitHub] spark issue #18732: [SPARK-20396][SQL][PySpark] groupby().apply() with panda...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18732 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #18732: [SPARK-20396][SQL][PySpark] groupby().apply() wit...

2017-09-29 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/18732#discussion_r141976177 --- Diff: python/pyspark/sql/group.py --- @@ -194,6 +194,28 @@ def pivot(self, pivot_col, values=None): jgd = self._jgd.pivot(pivot_col,

[GitHub] spark issue #18732: [SPARK-20396][SQL][PySpark] groupby().apply() with panda...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18732 **[Test build #82335 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82335/testReport)** for PR 18732 at commit

[GitHub] spark issue #19393: [SPARK-21644][SQL] LocalLimit.maxRows is defined incorre...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19393 **[Test build #82334 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82334/testReport)** for PR 19393 at commit

[GitHub] spark issue #19388: [SPARK-22162] Executors and the driver should use consis...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19388 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19388: [SPARK-22162] Executors and the driver should use consis...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19388 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82325/ Test FAILed. ---

[GitHub] spark pull request #19383: [SPARK-20643][core] Add listener implementation t...

2017-09-29 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19383#discussion_r141960405 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software

  1   2   3   4   >