[GitHub] spark pull request #19818: [SPARK-22604][SQL] remove the get address methods...

2017-11-24 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19818#discussion_r153039386 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java --- @@ -62,13 +62,6 @@ */ public abstract

[GitHub] spark pull request #19818: [SPARK-22604][SQL] remove the get address methods...

2017-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19818 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19818: [SPARK-22604][SQL] remove the get address methods from C...

2017-11-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19818 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19818: [SPARK-22604][SQL] remove the get address methods...

2017-11-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19818#discussion_r153039303 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java --- @@ -73,12 +75,12 @@ public

[GitHub] spark issue #19818: [SPARK-22604][SQL] remove the get address methods from C...

2017-11-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19818 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19803 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19803: [SPARK-22596][SQL] set ctx.currentVars in CodegenSupport...

2017-11-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19803 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19803: [SPARK-22596][SQL] set ctx.currentVars in CodegenSupport...

2017-11-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19803 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19810: [SPARK-22599][SQL] In-Memory Table Pruning without Extra...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19810 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84181/ Test PASSed. ---

[GitHub] spark issue #19810: [SPARK-22599][SQL] In-Memory Table Pruning without Extra...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19810 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19810: [SPARK-22599][SQL] In-Memory Table Pruning without Extra...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19810 **[Test build #84181 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84181/testReport)** for PR 19810 at commit

[GitHub] spark issue #19817: [SPARK-22603][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19817 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84180/ Test PASSed. ---

[GitHub] spark issue #19817: [SPARK-22603][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19817 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19817: [SPARK-22603][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19817 **[Test build #84180 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84180/testReport)** for PR 19817 at commit

[GitHub] spark issue #19811: [WIP][SPARK-18016][SQL] Code Generation: Constant Pool L...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19811 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84179/ Test PASSed. ---

[GitHub] spark issue #19811: [WIP][SPARK-18016][SQL] Code Generation: Constant Pool L...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19811 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19811: [WIP][SPARK-18016][SQL] Code Generation: Constant Pool L...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19811 **[Test build #84179 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84179/testReport)** for PR 19811 at commit

[GitHub] spark issue #19808: [SPARK-22597][SQL] Add spark-sql cmd script for Windows ...

2017-11-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19808 Thanks @viirya and @cloud-fan. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19518: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-11-24 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19518 > 4 or 5 bytes: others (ldc or ldc_w) I think ldc is 2 bytes and ldc_w is 3 bytes? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19810: [SPARK-22599][SQL] In-Memory Table Pruning without Extra...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19810 **[Test build #84181 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84181/testReport)** for PR 19810 at commit

[GitHub] spark issue #19817: [SPARK-22603][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19817 **[Test build #84180 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84180/testReport)** for PR 19817 at commit

[GitHub] spark issue #19810: [SPARK-22599][SQL] In-Memory Table Pruning without Extra...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19810 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84178/ Test FAILed. ---

[GitHub] spark issue #19810: [SPARK-22599][SQL] In-Memory Table Pruning without Extra...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19810 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19810: [SPARK-22599][SQL] In-Memory Table Pruning without Extra...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19810 **[Test build #84178 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84178/testReport)** for PR 19810 at commit

[GitHub] spark issue #19811: [WIP][SPARK-18016][SQL] Code Generation: Constant Pool L...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19811 **[Test build #84179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84179/testReport)** for PR 19811 at commit

[GitHub] spark issue #19811: [WIP][SPARK-18016][SQL] Code Generation: Constant Pool L...

2017-11-24 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19811 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18692: [SPARK-21417][SQL] Infer join conditions using propagate...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18692 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18692: [SPARK-21417][SQL] Infer join conditions using propagate...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18692 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84177/ Test PASSed. ---

[GitHub] spark issue #18692: [SPARK-21417][SQL] Infer join conditions using propagate...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18692 **[Test build #84177 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84177/testReport)** for PR 18692 at commit

[GitHub] spark issue #18692: [SPARK-21417][SQL] Infer join conditions using propagate...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18692 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #18692: [SPARK-21417][SQL] Infer join conditions using propagate...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18692 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84176/ Test FAILed. ---

[GitHub] spark issue #18692: [SPARK-21417][SQL] Infer join conditions using propagate...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18692 **[Test build #84176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84176/testReport)** for PR 18692 at commit

[GitHub] spark issue #19810: [SPARK-22599][SQL] In-Memory Table Pruning without Extra...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19810 **[Test build #84178 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84178/testReport)** for PR 19810 at commit

[GitHub] spark issue #19810: [SPARK-22599][SQL] In-Memory Table Pruning without Extra...

2017-11-24 Thread CodingCat
Github user CodingCat commented on the issue: https://github.com/apache/spark/pull/19810 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-24 Thread setjet
Github user setjet commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r153025270 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -99,3 +94,91 @@ class TypedAverage[IN](val f: IN

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r153025148 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -99,3 +94,91 @@ class TypedAverage[IN](val f:

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r153025008 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -99,3 +94,91 @@ class TypedAverage[IN](val f:

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r153024974 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -99,3 +94,91 @@ class TypedAverage[IN](val f:

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-24 Thread setjet
Github user setjet commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r153024799 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -99,3 +94,91 @@ class TypedAverage[IN](val f: IN

[GitHub] spark pull request #11994: [SPARK-14151] Expose metrics Source and Sink inte...

2017-11-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11994#discussion_r153024408 --- Diff: project/MimaExcludes.scala --- @@ -76,7 +76,10 @@ object MimaExcludes { // [SPARK-14280] Support Scala 2.12

[GitHub] spark pull request #11994: [SPARK-14151] Expose metrics Source and Sink inte...

2017-11-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11994#discussion_r153024461 --- Diff: external/spark-ganglia-lgpl/src/main/scala/org/apache/spark/metrics/sink/GangliaSink.scala --- @@ -59,22 +61,22 @@ class GangliaSink(val

[GitHub] spark issue #11994: [SPARK-14151] Expose metrics Source and Sink interface

2017-11-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/11994 what's the next step on this PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19775: [SPARK-22343][core] Add support for publishing Spark met...

2017-11-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19775 I agree this is useful to have, @jerryshao is probably right though, it is likely better to add extensibility into the Metrics system. @jerryshao I'll review your PR @matyix could

[GitHub] spark issue #19802: [WIP][SPARK-22594][CORE] Handling spark-submit and maste...

2017-11-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19802 I think there are some values in having a better experience with mismatch client/server versions. We discussed it might be even more common when the client was a R package (or Python perhaps

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r153024025 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -99,3 +94,91 @@ class TypedAverage[IN](val f:

[GitHub] spark issue #19807: [SPARK-22495] Fix setup of SPARK_HOME variable on Window...

2017-11-24 Thread jsnowacki
Github user jsnowacki commented on the issue: https://github.com/apache/spark/pull/19807 Thanks! Closing. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19807: [SPARK-22495] Fix setup of SPARK_HOME variable on...

2017-11-24 Thread jsnowacki
Github user jsnowacki closed the pull request at: https://github.com/apache/spark/pull/19807 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19807: [SPARK-22495] Fix setup of SPARK_HOME variable on Window...

2017-11-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19807 I fixed it during merge and merged this to 2.2. @jsnowacki thanks and please close this PR. --- - To unsubscribe,

[GitHub] spark issue #18692: [SPARK-21417][SQL] Infer join conditions using propagate...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18692 **[Test build #84177 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84177/testReport)** for PR 18692 at commit

[GitHub] spark issue #18692: [SPARK-21417][SQL] Infer join conditions using propagate...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18692 **[Test build #84176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84176/testReport)** for PR 18692 at commit

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-24 Thread setjet
Github user setjet commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r153022290 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -99,3 +94,91 @@ class TypedAverage[IN](val f: IN

[GitHub] spark pull request #19807: [SPARK-22495] Fix setup of SPARK_HOME variable on...

2017-11-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19807#discussion_r153021890 --- Diff: bin/find-spark-home.cmd --- @@ -0,0 +1,60 @@ +@echo off + +rem +rem Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark issue #19789: [SPARK-22562][Streaming] CachedKafkaConsumer unsafe evic...

2017-11-24 Thread daroo
Github user daroo commented on the issue: https://github.com/apache/spark/pull/19789 I don't know what are the plans for the structured streaming which @zsxwing has in mind, but before I created the PR I actually had seen how this problem is currently solved in kafka-0-10-sql module

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r153021722 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -99,3 +94,91 @@ class TypedAverage[IN](val f:

[GitHub] spark pull request #19816: [WIP][SPARK-21693][FOLLOWUP][R] Reduce shuffle pa...

2017-11-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19816#discussion_r153021587 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -3021,41 +3021,54 @@ test_that("dapplyCollect() on DataFrame with a binary column", { })

[GitHub] spark pull request #19816: [WIP][SPARK-21693][FOLLOWUP][R] Reduce shuffle pa...

2017-11-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19816#discussion_r153021622 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -3078,101 +3091,117 @@ test_that("coalesce, repartition, numPartitions", { })

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-24 Thread setjet
Github user setjet commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r153021545 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -99,3 +94,91 @@ class TypedAverage[IN](val f: IN

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r153020749 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -99,3 +94,91 @@ class TypedAverage[IN](val f:

[GitHub] spark issue #19789: [SPARK-22562][Streaming] CachedKafkaConsumer unsafe evic...

2017-11-24 Thread koeninger
Github user koeninger commented on the issue: https://github.com/apache/spark/pull/19789 Seems reasonable to me but you should probably ask zsxwing if it fits in with plans for the structured streaming kafka code. On Thu, Nov 23, 2017 at 10:23 PM, Hyukjin Kwon

[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...

2017-11-24 Thread setjet
Github user setjet commented on the issue: https://github.com/apache/spark/pull/18113 @cloud-fan done, some small white spaces remain as it formats the functions within the file consistently --- - To unsubscribe,

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-24 Thread setjet
Github user setjet commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r153020474 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -38,13 +38,11 @@ class TypedSumDouble[IN](val f:

[GitHub] spark pull request #18113: [SPARK-20890][SQL] Added min and max typed aggreg...

2017-11-24 Thread setjet
Github user setjet commented on a diff in the pull request: https://github.com/apache/spark/pull/18113#discussion_r153020437 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -81,14 +77,13 @@ class TypedCount[IN](val f: IN =>

[GitHub] spark issue #19818: [SPARK-22604][SQL] remove the get address methods from C...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19818 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84174/ Test PASSed. ---

[GitHub] spark issue #19818: [SPARK-22604][SQL] remove the get address methods from C...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19818 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19818: [SPARK-22604][SQL] remove the get address methods from C...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19818 **[Test build #84174 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84174/testReport)** for PR 19818 at commit

[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18113 **[Test build #84175 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84175/testReport)** for PR 18113 at commit

[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84175/ Test FAILed. ---

[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18113 **[Test build #84175 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84175/testReport)** for PR 18113 at commit

[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...

2017-11-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18113 can you check the diff and revert all the unnecessary changes? thanks! --- - To unsubscribe, e-mail:

[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...

2017-11-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18113 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...

2017-11-24 Thread setjet
Github user setjet commented on the issue: https://github.com/apache/spark/pull/18113 @cloud-fan could you have a look please? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19815 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19815 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84172/ Test PASSed. ---

[GitHub] spark issue #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19815 **[Test build #84172 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84172/testReport)** for PR 19815 at commit

[GitHub] spark pull request #19808: [SPARK-22597][SQL] Add spark-sql cmd script for W...

2017-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19808 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19815 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84170/ Test PASSed. ---

[GitHub] spark issue #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19815 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19815 **[Test build #84170 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84170/testReport)** for PR 19815 at commit

[GitHub] spark issue #19808: [SPARK-22597][SQL] Add spark-sql cmd script for Windows ...

2017-11-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19808 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r153017609 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -147,6 +149,11 @@ trait CodegenSupport extends

[GitHub] spark issue #19752: [SPARK-22520][SQL] Support code generation for large Cas...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19752 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19752: [SPARK-22520][SQL] Support code generation for large Cas...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19752 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84168/ Test PASSed. ---

[GitHub] spark issue #19752: [SPARK-22520][SQL] Support code generation for large Cas...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19752 **[Test build #84168 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84168/testReport)** for PR 19752 at commit

[GitHub] spark issue #19817: [SPARK-22603][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19817 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84173/ Test FAILed. ---

[GitHub] spark issue #19817: [SPARK-22603][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19817 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19817: [SPARK-22603][SQL] Fix 64KB JVM bytecode limit problem w...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19817 **[Test build #84173 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84173/testReport)** for PR 19817 at commit

[GitHub] spark pull request #19817: [SPARK-22603][SQL] Fix 64KB JVM bytecode limit pr...

2017-11-24 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19817#discussion_r153012255 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -1372,19 +1372,26 @@ case class

[GitHub] spark issue #19775: [SPARK-22343][core] Add support for publishing Spark met...

2017-11-24 Thread matyix
Github user matyix commented on the issue: https://github.com/apache/spark/pull/19775 @jerryshao this PR is not Kubernetes specific, it's an extension of the Spark Metrics system which is part of the core already. We could externalize it the PR #11994 above ever gets merged.

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r153009697 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -147,6 +149,11 @@ trait CodegenSupport extends

[GitHub] spark issue #19518: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-11-24 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19518 In #19811, first, I will take a hybrid approach of outer (flat) global variable and arrays. The threshold for # of global variables would be configurable. I will give high priority to

[GitHub] spark issue #19811: [WIP][SPARK-18016][SQL] Code Generation: Constant Pool L...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19811 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84169/ Test FAILed. ---

[GitHub] spark issue #19811: [WIP][SPARK-18016][SQL] Code Generation: Constant Pool L...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19811 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19811: [WIP][SPARK-18016][SQL] Code Generation: Constant Pool L...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19811 **[Test build #84169 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84169/testReport)** for PR 19811 at commit

[GitHub] spark issue #19518: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-11-24 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19518 I created and ran another synthetic benchmark program for comparing flat global variables, inner global variables, and array using janinoc for target Java file. The performance is not much

[GitHub] spark issue #19808: [SPARK-22597][SQL] Add spark-sql cmd script for Windows ...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19808 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84166/ Test PASSed. ---

[GitHub] spark issue #19808: [SPARK-22597][SQL] Add spark-sql cmd script for Windows ...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19808 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19808: [SPARK-22597][SQL] Add spark-sql cmd script for Windows ...

2017-11-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19808 **[Test build #84166 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84166/testReport)** for PR 19808 at commit

[GitHub] spark issue #19816: [WIP][SPARK-21693][FOLLOWUP][R] Reduce shuffle partition...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19816 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19816: [WIP][SPARK-21693][FOLLOWUP][R] Reduce shuffle partition...

2017-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19816 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84171/ Test PASSed. ---

  1   2   3   >