Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20421
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20421
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86802/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20421
**[Test build #86802 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86802/testReport)**
for PR 20421 at commit
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20404
LGTM.
I'd like to leave this to @felixcheung to confirm setting the default
session is okay or not
(https://github.com/apache/spark/pull/20404#discussion_r164362178).
---
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20430#discussion_r164662154
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala
---
@@ -34,16 +34,12 @@ object CommandUtils extends
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20404
Hi all, can you please review again, thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20428
Let's also update PR description too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20431
I didn't notice significant difference. It is about 450~500 milliseconds.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20421
**[Test build #86802 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86802/testReport)**
for PR 20421 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20421
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/366/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20421
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20427#discussion_r164660069
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
---
@@ -23,7 +23,7 @@ import
Github user rekhajoshm commented on the issue:
https://github.com/apache/spark/pull/20432
ð LGTM @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20386
**[Test build #86801 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86801/testReport)**
for PR 20386 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20386
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20386
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/365/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86792/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86792 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86792/testReport)**
for PR 20422 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20430
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20430
**[Test build #86790 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86790/testReport)**
for PR 20430 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20430
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86790/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20177
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86791/
Test PASSed.
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20387
don't we already have table in DataFrameReader?
http://spark.apache.org/docs/latest/api/python/pyspark.sql.html?highlight=dataframereader#pyspark.sql.DataFrameReader.table
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20177
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20177
**[Test build #86791 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86791/testReport)**
for PR 20177 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20332
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/20332
Merged to master / branch-2.3. Thanks @sethah, and @WeichenXu123 for review.
---
-
To unsubscribe, e-mail:
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/20332#discussion_r164654897
--- Diff: docs/ml-classification-regression.md ---
@@ -111,10 +110,9 @@ Continuing the earlier example:
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20378
I like this idea, too, but seems like there are too many violating files so
we can't enable this for now.
I'm wondering how we can encourage contributors to follow the style,
hopefully
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20343
I checked all the queries again and I found that some queries (q6, q11,
q20, q22, q24, q34, q35, q47, q49, q57, q64, q72, q74, q75, q78, q98) only have
minor changes (See the comments to point out
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20343
**[Test build #86800 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86800/testReport)**
for PR 20343 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20343
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/364/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20343
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20433
**[Test build #86799 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86799/testReport)**
for PR 20433 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20433
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/363/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20433
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20343
I opened a new pr to support `[date] + 14 days`:
https://github.com/apache/spark/pull/20433
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20361#discussion_r164650445
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -377,6 +377,12 @@ object SQLConf {
.booleanConf
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20433
[SPARK-23264][SQL] Support interval values without INTERVAL clauses
## What changes were proposed in this pull request?
This pr updated parsing rules in `SqlBase.g4` to support a SQL query
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20429
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20431
does this significantly increase the test runtime?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/362/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20428
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20429
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20386
CC @rdblue @zsxwing @jose-torres @sameeragarwal
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20432
cc @rekhajoshm @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20424#discussion_r164649608
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -191,7 +191,20 @@ private[spark] class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20428
**[Test build #86798 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86798/testReport)**
for PR 20428 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20432
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20432
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/361/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20386#discussion_r164649253
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/EpochCoordinator.scala
---
@@ -148,7 +148,8 @@ private[continuous]
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20386#discussion_r164648934
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceV2Writer.java
---
@@ -63,32 +65,30 @@
DataWriterFactory
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20432
**[Test build #86797 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86797/testReport)**
for PR 20432 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20386#discussion_r164648815
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceV2Writer.java
---
@@ -63,32 +65,30 @@
DataWriterFactory
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/20432
[SPARK-23174][BUILD][PYTHON][FOLLOWUP] Add pycodestyle*.py to .gitignore
file.
## What changes were proposed in this pull request?
This is a follow-up pr of #20338 which changed the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20386#discussion_r164648645
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceV2Writer.java
---
@@ -40,11 +40,13 @@
* 1. Create a writer
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20400
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86795/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20400
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20400
**[Test build #86795 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86795/testReport)**
for PR 20400 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20386#discussion_r164648356
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceV2Writer.java
---
@@ -40,11 +40,13 @@
* 1. Create a writer
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20431
**[Test build #86796 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86796/testReport)**
for PR 20431 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20431
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/360/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20431
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20431
cc @vanzin @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/20431
[SPARK-23222][SQL] Make DataFrameRangeSuite not flaky
## What changes were proposed in this pull request?
It is reported that the test `Cancelling stage in a query with Range` in
Github user bersprockets commented on a diff in the pull request:
https://github.com/apache/spark/pull/20424#discussion_r164646512
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -191,7 +191,20 @@ private[spark] class
Github user zjffdu commented on a diff in the pull request:
https://github.com/apache/spark/pull/13599#discussion_r164646157
--- Diff:
core/src/main/scala/org/apache/spark/api/python/VirtualEnvFactory.scala ---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20400
**[Test build #86795 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86795/testReport)**
for PR 20400 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20400
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20400
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/359/
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20424#discussion_r164643325
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -191,7 +191,20 @@ private[spark] class
Github user bersprockets commented on a diff in the pull request:
https://github.com/apache/spark/pull/20424#discussion_r164642503
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -191,7 +191,20 @@ private[spark] class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20386
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86788/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20386
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20386
**[Test build #86788 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86788/testReport)**
for PR 20386 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86787/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86794/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20428
**[Test build #86794 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86794/testReport)**
for PR 20428 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #86787 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86787/testReport)**
for PR 20424 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20428
**[Test build #86794 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86794/testReport)**
for PR 20428 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/358/
Github user bersprockets commented on a diff in the pull request:
https://github.com/apache/spark/pull/20424#discussion_r164641641
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -191,7 +191,20 @@ private[spark] class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user rekhajoshm commented on the issue:
https://github.com/apache/spark/pull/20378
Thanks @HyukjinKwon for your update.
@HyukjinKwon @holdenk @ueshin @viirya @icexelloss @felixcheung
@BryanCutler and @MrBago - While you are thinking on it, below is my analysis.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20427
**[Test build #86793 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86793/testReport)**
for PR 20427 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20427
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20427
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/357/
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20427
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user bersprockets commented on a diff in the pull request:
https://github.com/apache/spark/pull/20424#discussion_r164640285
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -191,7 +191,20 @@ private[spark] class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20427
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86789/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20427
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20427
**[Test build #86789 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86789/testReport)**
for PR 20427 at commit
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20424#discussion_r164637553
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -191,7 +191,20 @@ private[spark] class
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20378
Hey @holdenk, @ueshin, @viirya, @icexelloss, @felixcheung, @BryanCutler and
@MrBago. What do you guys think about checking docstring and the list above? I
think this could prevent nitpicking
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20422#discussion_r164635886
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala ---
@@ -166,8 +153,20 @@ private[spark] class
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20378
So, seems we got:
```
First line should end with a period. 293
Multiline docstring should end with 1 blank line. 279
Blank line missing after one-line summary. 265
Return
1 - 100 of 487 matches
Mail list logo
