[GitHub] spark issue #20657: [SPARK-23361][yarn] Allow AM to restart after initial to...

2018-03-22 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20657 Thanks, merging to master branch! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20887 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20887 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88535/ Test PASSed. ---

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20887 **[Test build #88535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88535/testReport)** for PR 20887 at commit

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/20888 Uploaded logs for the jira. You're right when you pointed out a second issue with the `stageToKill`. The `onJobStart` tries to cancel the same ID twice. ---

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/20888 I mean on my machine the stage ID is zero for long long time here: ``` DataFrameRangeSuite.stageToKill = TaskContext.get().stageId() ``` and after 200 seconds the other

[GitHub] spark issue #20633: [SPARK-23455][ML] Default Params in ML should be saved s...

2018-03-22 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20633 @jkbradley Thanks for your comments! I've addressed them. Please review it again. Thank you. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19840: [SPARK-22640][PYSPARK][YARN]switch python exec on execut...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19840 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19840: [SPARK-22640][PYSPARK][YARN]switch python exec on execut...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19840 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1718/

[GitHub] spark issue #20831: [SPARK-23614][SQL] Fix incorrect reuse exchange when cac...

2018-03-22 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20831 Thanks! @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20861: [SPARK-23599][SQL] Use RandomUUIDGenerator in Uuid expre...

2018-03-22 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20861 @hvanhovell Ok. But this needs #20817. Since #20817 just adds new class and doesn't change existing code, I think it can be directly merged into 2.3. Should I create a backport PR of it too? Or you

[GitHub] spark pull request #20851: [SPARK-23727][SQL] Support for pushing down filte...

2018-03-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20851#discussion_r176636849 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -353,6 +353,13 @@ object SQLConf { .booleanConf

[GitHub] spark pull request #20831: [SPARK-23614][SQL] Fix incorrect reuse exchange w...

2018-03-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20831 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20831: [SPARK-23614][SQL] Fix incorrect reuse exchange when cac...

2018-03-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20831 thanks, merging to master/2.3! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20878: [MINOR][PYTHON] Remove unused codes in schema par...

2018-03-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20878 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20878: [MINOR][PYTHON] Remove unused codes in schema parsing lo...

2018-03-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20878 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20887 Hi, @gatorsmile . Could you review this PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20888 > if I execute the test on my machine alone it never pass. you mean it never fails on your machine, right? its only flaky when you run everything on jenkins? ---

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20888 hmm you're right, I was looking at a different branch in my editor and didn't pay attention that it was reset in the code I linked to on master, oops. I still dont' understand your proposed

[GitHub] spark issue #20208: [SPARK-23007][SQL][TEST] Add schema evolution test suite...

2018-03-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20208 Yes --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20868: [SPARK-23750][SQL] Inner Join Elimination based on Infor...

2018-03-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20868 cc @hvanhovell @cloud-fan @rxin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20851: [SPARK-23727][SQL] Support for pushing down filte...

2018-03-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20851#discussion_r176633578 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -353,6 +353,12 @@ object SQLConf { .booleanConf

[GitHub] spark issue #20541: [SPARK-23356][SQL]Pushes Project to both sides of Union ...

2018-03-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20541 I don't agree. `a + 1`/`a + b` are evaluated the same number of time, no matter you push in through Union or not. I don't see any performance benefit by doing this, except you can eliminate the

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20858 @maropu Maybe you can help @mn-mikke review this PR ? Will open an umbrella JIRA for the built-in functions we plan to do in Apache 2.4. In the list, we have multiple for operating nested

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/20888 Just an additional info if I execute the test on my machine alone it never pass. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Implementation of the concat_a...

2018-03-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r176631936 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -699,3 +699,88 @@ abstract class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Implementation of the concat_a...

2018-03-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r176631836 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -408,6 +408,7 @@ object FunctionRegistry {

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/20888 Where do you think the reset should happen? There is already one inside `withSQLConf` which makes a reset before job submit. Related the ID I've just taken a look at the original

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Implementation of the concat_a...

2018-03-22 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r176631255 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -699,3 +699,88 @@ abstract class

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20888 I think you're right about killing the wrong stage, but I don't think its exactly what you've outlined. The original code doesn't try to kill a stage with ID == 0 -- instead its just waiting until

[GitHub] spark issue #20541: [SPARK-23356][SQL]Pushes Project to both sides of Union ...

2018-03-22 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/20541 oh ,yeah, there is a little difference, for a + 1 and a + b. **for a + 1**: ``` `PushProjectionThroughUnion `rule handles: Union :- Project [(a#0 + 1) AS aa#10] : +-

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20888 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20887 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20887 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88533/ Test PASSed. ---

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20887 **[Test build #88533 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88533/testReport)** for PR 20887 at commit

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20888 **[Test build #88536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88536/testReport)** for PR 20888 at commit

[GitHub] spark pull request #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wa...

2018-03-22 Thread gaborgsomogyi
GitHub user gaborgsomogyi opened a pull request: https://github.com/apache/spark/pull/20888 [SPARK-23775][TEST] DataFrameRangeSuite should wait for first stage ## What changes were proposed in this pull request? DataFrameRangeSuite.test("Cancelling stage in a query with

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20887 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20887 **[Test build #88535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88535/testReport)** for PR 20887 at commit

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20887 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1717/

[GitHub] spark issue #20884: [SPARK-23773][SQL] JacksonGenerator does not include key...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20884 **[Test build #4143 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4143/testReport)** for PR 20884 at commit

[GitHub] spark issue #19876: [ML][SPARK-11171][SPARK-11239] Add PMML export to Spark ...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19876 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19876: [ML][SPARK-11171][SPARK-11239] Add PMML export to Spark ...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19876 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88534/ Test PASSed. ---

[GitHub] spark issue #19876: [ML][SPARK-11171][SPARK-11239] Add PMML export to Spark ...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19876 **[Test build #88534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88534/testReport)** for PR 19876 at commit

[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark UI to specific ho...

2018-03-22 Thread felixalbani
Github user felixalbani commented on the issue: https://github.com/apache/spark/pull/20883 @gerashegalov Updated the PR title --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20842: [SPARK-23162][PySpark][ML] Add r2adj into Python ...

2018-03-22 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20842#discussion_r176605304 --- Diff: python/pyspark/ml/regression.py --- @@ -347,6 +347,20 @@ def r2(self): """ return self._call_java("r2") +

[GitHub] spark pull request #20842: [SPARK-23162][PySpark][ML] Add r2adj into Python ...

2018-03-22 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20842#discussion_r176606317 --- Diff: python/pyspark/ml/regression.py --- @@ -347,6 +347,20 @@ def r2(self): """ return self._call_java("r2") +

[GitHub] spark issue #19876: [ML][SPARK-11171][SPARK-11239] Add PMML export to Spark ...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19876 **[Test build #88534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88534/testReport)** for PR 19876 at commit

[GitHub] spark issue #19876: [ML][SPARK-11171][SPARK-11239] Add PMML export to Spark ...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19876 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19876: [ML][SPARK-11171][SPARK-11239] Add PMML export to Spark ...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19876 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1716/

[GitHub] spark issue #20886: [WIP][SPARK-19724][SQL]create a managed table with an ex...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20886 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88530/ Test FAILed. ---

[GitHub] spark issue #20886: [WIP][SPARK-19724][SQL]create a managed table with an ex...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20886 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20886: [WIP][SPARK-19724][SQL]create a managed table with an ex...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20886 **[Test build #88530 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88530/testReport)** for PR 20886 at commit

[GitHub] spark pull request #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should ...

2018-03-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20887#discussion_r176604372 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1152,7 +1152,18 @@ class AstBuilder(conf:

[GitHub] spark issue #19876: [ML][SPARK-11171][SPARK-11239] Add PMML export to Spark ...

2018-03-22 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/19876 See some related thoughts in how to support Spark in kubeflow: https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/issues/119 ---

[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark2 history server t...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20883 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark2 history server t...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20883 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88528/ Test PASSed. ---

[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark2 history server t...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20883 **[Test build #88528 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88528/testReport)** for PR 20883 at commit

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20887 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1715/

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20887 **[Test build #88533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88533/testReport)** for PR 20887 at commit

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20887 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should ...

2018-03-22 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/20887 [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncate the values ## What changes were proposed in this pull request? This PR aims to fix the following `CAST` behavior on

[GitHub] spark issue #20885: [SPARK-23724][SPARK-23765][SQL] Line separator for the j...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20885 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20885: [SPARK-23724][SPARK-23765][SQL] Line separator for the j...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20885 **[Test build #88532 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88532/testReport)** for PR 20885 at commit

[GitHub] spark issue #20885: [SPARK-23724][SPARK-23765][SQL] Line separator for the j...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20885 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88532/ Test FAILed. ---

[GitHub] spark pull request #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20327#discussion_r176599395 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala --- @@ -136,6 +135,39 @@ class YarnClusterSuite extends

[GitHub] spark issue #20885: [SPARK-23724][SPARK-23765][SQL] Line separator for the j...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20885 **[Test build #88532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88532/testReport)** for PR 20885 at commit

[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark2 history server t...

2018-03-22 Thread gerashegalov
Github user gerashegalov commented on the issue: https://github.com/apache/spark/pull/20883 This PR's title should reference Spark UI in general as opposed to just SHS --- - To unsubscribe, e-mail:

[GitHub] spark issue #20885: [SPARK-23724][SPARK-23765][SQL] Line separator for the j...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20885 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88531/ Test FAILed. ---

[GitHub] spark issue #20885: [SPARK-23724][SPARK-23765][SQL] Line separator for the j...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20885 **[Test build #88531 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88531/testReport)** for PR 20885 at commit

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-22 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/20877 @HyukjinKwon We have a few clients who are interested in processing of JSON streaming like data. Here is the PR which combines your changes and mine: https://github.com/apache/spark/pull/20885

[GitHub] spark issue #20885: [SPARK-23724][SPARK-23765][SQL] Line separator for the j...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20885 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20885: [SPARK-23724][SPARK-23765][SQL] Line separator for the j...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20885 **[Test build #88531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88531/testReport)** for PR 20885 at commit

[GitHub] spark pull request #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-22 Thread gerashegalov
Github user gerashegalov commented on a diff in the pull request: https://github.com/apache/spark/pull/20327#discussion_r176598095 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala --- @@ -136,6 +135,39 @@ class YarnClusterSuite

[GitHub] spark pull request #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-22 Thread gerashegalov
Github user gerashegalov commented on a diff in the pull request: https://github.com/apache/spark/pull/20327#discussion_r176597452 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala --- @@ -136,6 +135,39 @@ class YarnClusterSuite

[GitHub] spark issue #20886: [WIP][SPARK-19724][SQL]create a managed table with an ex...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20886 **[Test build #88530 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88530/testReport)** for PR 20886 at commit

[GitHub] spark issue #20886: [WIP][SPARK-19724][SQL]create a managed table with an ex...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20886 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1714/

[GitHub] spark issue #20886: [WIP][SPARK-19724][SQL]create a managed table with an ex...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20886 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20886: [WIP][SPARK-19724][SQL]create a managed table wit...

2018-03-22 Thread gengliangwang
GitHub user gengliangwang opened a pull request: https://github.com/apache/spark/pull/20886 [WIP][SPARK-19724][SQL]create a managed table with an existed default table should throw an exception ## What changes were proposed in this pull request? This PR is to finish

[GitHub] spark issue #20885: [SPARK-23724][SPARK-23765][SQL] Line separator for the j...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20885 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20885: [SPARK-23724][SPARK-23765][SQL] Line separator for the j...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20885 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88529/ Test FAILed. ---

[GitHub] spark issue #20885: [SPARK-23724][SPARK-23765][SQL] Line separator for the j...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20885 **[Test build #88529 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88529/testReport)** for PR 20885 at commit

[GitHub] spark issue #20885: [SPARK-23724][SPARK-23765][SQL] Line separator for the j...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20885 **[Test build #88529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88529/testReport)** for PR 20885 at commit

[GitHub] spark issue #20885: [SPARK-23724][SPARK-23765][SQL] Line separator for the j...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20885 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20885: [SPARK-23724][SPARK-23765][SQL] Line separator fo...

2018-03-22 Thread MaxGekk
GitHub user MaxGekk opened a pull request: https://github.com/apache/spark/pull/20885 [SPARK-23724][SPARK-23765][SQL] Line separator for the json datasource ## What changes were proposed in this pull request? Currently,

[GitHub] spark pull request #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20327#discussion_r176585546 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala --- @@ -136,6 +135,39 @@ class YarnClusterSuite extends

[GitHub] spark issue #20884: [SPARK-23773][SQL] JacksonGenerator does not include key...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20884 **[Test build #4143 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4143/testReport)** for PR 20884 at commit

[GitHub] spark pull request #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-22 Thread gerashegalov
Github user gerashegalov commented on a diff in the pull request: https://github.com/apache/spark/pull/20327#discussion_r176584238 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala --- @@ -136,6 +135,39 @@ class YarnClusterSuite

[GitHub] spark issue #20604: [SPARK-23365][CORE] Do not adjust num executors when kil...

2018-03-22 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20604 @vanzin @sitalkedia @jiangxb1987 I was looking at this code again, and I'd appreciate your thoughts on how this relates to [SPARK-21834](https://issues.apache.org/jira/browse/SPARK-21834)

[GitHub] spark issue #20884: [SPARK-23773][SQL] JacksonGenerator does not include key...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20884 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20884: [SPARK-23773][SQL] JacksonGenerator does not include key...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20884 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20884: [SPARK-23773][SQL] JacksonGenerator does not include key...

2018-03-22 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20884 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20884: [SPARK-23773][SQL] JacksonGenerator does not incl...

2018-03-22 Thread makagonov
GitHub user makagonov opened a pull request: https://github.com/apache/spark/pull/20884 [SPARK-23773][SQL] JacksonGenerator does not include keys that have null value for StructTypes ## What changes were proposed in this pull request? As stated in Jira, when `toJSON` is called

[GitHub] spark issue #20397: [SPARK-23219][SQL]Rename ReadTask to DataReaderFactory i...

2018-03-22 Thread jose-torres
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/20397 In general I have very weak opinions on what classes are named :) I agree that readers and writers are very different in the DataSourceV2 API, and they're even more so in

[GitHub] spark issue #20397: [SPARK-23219][SQL]Rename ReadTask to DataReaderFactory i...

2018-03-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20397 what do streaming guys think? cc @tdas @jose-torres --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20861: [SPARK-23599][SQL] Use RandomUUIDGenerator in Uuid expre...

2018-03-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/20861 @viirya can you create a backport for 2.3? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark2 history server t...

2018-03-22 Thread felixalbani
Github user felixalbani commented on the issue: https://github.com/apache/spark/pull/20883 Removed "Please review ..." remnants from template --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20579: [SPARK-23372][SQL] Writing empty struct in parquet fails...

2018-03-22 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/20579 Thanks a lot @cloud-fan @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark2 history server t...

2018-03-22 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20883 The change itself LGTM pending tests. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark2 history server t...

2018-03-22 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20883 Also, please remove remnants of the template from the PR description ("Please review ..."). --- - To unsubscribe, e-mail:

  1   2   3   4   >