[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

2018-07-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21318 @rxin re: https://github.com/apache/spark/pull/21318#discussion_r20582 I meant to say for instance, like "Please refer the SQL function documentation in the corresponding version". We don't

[GitHub] spark issue #21894: [MINOR][BUILD] Remove -Phive-thriftserver profile within...

2018-07-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21894 cc @felixcheung --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18942: [BACKPORT-2.1][SPARK-19372][SQL] Fix throwing a Java exc...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18942 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21902: [SPARK-24952][SQL] Support LZMA2 compression by A...

2018-07-27 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21902#discussion_r205934042 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1449,6 +1451,16 @@ object SQLConf { .intConf

[GitHub] spark issue #21103: [SPARK-23915][SQL] Add array_except function

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21103 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93709/ Test PASSed. ---

[GitHub] spark issue #21103: [SPARK-23915][SQL] Add array_except function

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21103 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-07-27 Thread cclauss
Github user cclauss commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r205933934 --- Diff: python/pyspark/streaming/tests.py --- @@ -206,6 +207,22 @@ def func(dstream): expected = [[len(x)] for x in input]

[GitHub] spark pull request #21906: [SPARK-24924][SQL][FOLLOW-UP] Add mapping for bui...

2018-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21906 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21103: [SPARK-23915][SQL] Add array_except function

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21103 **[Test build #93709 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93709/testReport)** for PR 21103 at commit

[GitHub] spark issue #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/21886 @gatorsmile Thank you.. I will make the changes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #21650: [SPARK-24624][SQL][PYTHON] Support mixture of Pyt...

2018-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21650 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21886 The code looks good to me. Let us improve the test cases. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21886#discussion_r205933857 --- Diff: sql/core/src/test/resources/sql-tests/results/intersect-all.sql.out --- @@ -0,0 +1,212 @@ +-- Automatically generated by SQLQueryTestSuite

[GitHub] spark issue #21906: [SPARK-24924][SQL][FOLLOW-UP] Add mapping for built-in A...

2018-07-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21906 LGTM. Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21886#discussion_r205933861 --- Diff: sql/core/src/test/resources/sql-tests/results/intersect-all.sql.out --- @@ -0,0 +1,212 @@ +-- Automatically generated by SQLQueryTestSuite

[GitHub] spark pull request #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21886#discussion_r205933866 --- Diff: sql/core/src/test/resources/sql-tests/results/intersect-all.sql.out --- @@ -0,0 +1,212 @@ +-- Automatically generated by SQLQueryTestSuite

[GitHub] spark pull request #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21886#discussion_r205933837 --- Diff: sql/core/src/test/resources/sql-tests/results/intersect-all.sql.out --- @@ -0,0 +1,212 @@ +-- Automatically generated by SQLQueryTestSuite

[GitHub] spark issue #21650: [SPARK-24624][SQL][PYTHON] Support mixture of Python UDF...

2018-07-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21650 LGTM. Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21906: [SPARK-24924][SQL][FOLLOW-UP] Add mapping for built-in A...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21906 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21906: [SPARK-24924][SQL][FOLLOW-UP] Add mapping for built-in A...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21906 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93712/ Test PASSed. ---

[GitHub] spark issue #21906: [SPARK-24924][SQL][FOLLOW-UP] Add mapping for built-in A...

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21906 **[Test build #93712 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93712/testReport)** for PR 21906 at commit

[GitHub] spark pull request #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21886#discussion_r205933692 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1934,6 +1934,23 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/21886#discussion_r205933642 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1934,6 +1934,23 @@ class Dataset[T] private[sql](

[GitHub] spark issue #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21886 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93708/ Test PASSed. ---

[GitHub] spark issue #21906: [SPARK-24924][SQL][FOLLOW-UP] Add mapping for built-in A...

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21906 **[Test build #93712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93712/testReport)** for PR 21906 at commit

[GitHub] spark pull request #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21886#discussion_r205933541 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1934,6 +1934,23 @@ class Dataset[T] private[sql](

[GitHub] spark issue #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21886 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21886 **[Test build #93708 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93708/testReport)** for PR 21886 at commit

[GitHub] spark issue #21906: [SPARK-24924][SQL][FOLLOW-UP] Add mapping for built-in A...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21906 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21906: [SPARK-24924][SQL][FOLLOW-UP] Add mapping for built-in A...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21906 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21906: [SPARK-24924][SQL][FOLLOW-UP] Add mapping for built-in A...

2018-07-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21906 cc @gengliangwang --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21906: [SPARK-24924][SQL][FOLLOW-UP] Add mapping for bui...

2018-07-27 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/21906 [SPARK-24924][SQL][FOLLOW-UP] Add mapping for built-in Avro data source ## What changes were proposed in this pull request? Add one more test case for `com.databricks.spark.avro`.

[GitHub] spark issue #21906: [SPARK-24924][SQL][FOLLOW-UP] Add mapping for built-in A...

2018-07-27 Thread holdensmagicalunicorn
Github user holdensmagicalunicorn commented on the issue: https://github.com/apache/spark/pull/21906 @gatorsmile, thanks! I am a bot who has found some folks who might be able to help with the review:@HyukjinKwon ---

[GitHub] spark issue #21905: [SPARK-24956][Build][test-maven] Upgrade maven version t...

2018-07-27 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21905 hmm, interesting suggestions https://github.com/apache/spark/pull/21905#issuecomment-408580441 --- - To unsubscribe,

[GitHub] spark pull request #21902: [SPARK-24952][SQL] Support LZMA2 compression by A...

2018-07-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21902#discussion_r205933175 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1449,6 +1451,16 @@ object SQLConf { .intConf

[GitHub] spark issue #20028: [SPARK-19053][ML]Supporting multiple evaluation metrics ...

2018-07-27 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20028 this shouldn't say version 2.3.0? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20272: [SPARK-23078] [CORE] [K8s] allow Spark Thrift Server to ...

2018-07-27 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20272 still need to run tests https://github.com/apache/spark/pull/20272#pullrequestreview-108271893 --- - To unsubscribe,

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r205932789 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala --- @@

[GitHub] spark issue #21905: [SPARK-24956][Build][test-maven] Upgrade maven version t...

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21905 **[Test build #93711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93711/testReport)** for PR 21905 at commit

[GitHub] spark issue #21905: [SPARK-24956][Build][test-maven] Upgrade maven version t...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21905 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21905: [SPARK-24956][Build][test-maven] Upgrade maven version t...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21905 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21904: [SPARK-24953] [SQL] Prune a branch in `CaseWhen` if prev...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21904 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21905: [SPARK-24956][Build][test-maven] Upgrade maven version t...

2018-07-27 Thread holdensmagicalunicorn
Github user holdensmagicalunicorn commented on the issue: https://github.com/apache/spark/pull/21905 @kiszk, thanks! I am a bot who has found some folks who might be able to help with the review:@tomdz, @pwendell and @marmbrus ---

[GitHub] spark issue #21905: [SPARK-24956][Build][test-maven] Upgrade maven version t...

2018-07-27 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21905 cc @srowen @HyukjinKwon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21904: [SPARK-24953] [SQL] Prune a branch in `CaseWhen` if prev...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21904 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93705/ Test PASSed. ---

[GitHub] spark pull request #21905: [SPARK-24956][Build][test-maven] Upgrade maven ve...

2018-07-27 Thread kiszk
GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/21905 [SPARK-24956][Build][test-maven] Upgrade maven version to 3.5.4 ## What changes were proposed in this pull request? This PR updates maven version from 3.3.9 to 3.5.4. The current build

[GitHub] spark issue #21904: [SPARK-24953] [SQL] Prune a branch in `CaseWhen` if prev...

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21904 **[Test build #93705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93705/testReport)** for PR 21904 at commit

[GitHub] spark issue #21898: [SPARK-24817][Core] Implement BarrierTaskContext.barrier...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21898 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21898: [SPARK-24817][Core] Implement BarrierTaskContext.barrier...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21898 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93706/ Test FAILed. ---

[GitHub] spark issue #21898: [SPARK-24817][Core] Implement BarrierTaskContext.barrier...

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21898 **[Test build #93706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93706/testReport)** for PR 21898 at commit

[GitHub] spark issue #21902: [SPARK-24952][SQL] Support LZMA2 compression by Avro dat...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21902 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21902: [SPARK-24952][SQL] Support LZMA2 compression by Avro dat...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21902 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93704/ Test PASSed. ---

[GitHub] spark issue #21902: [SPARK-24952][SQL] Support LZMA2 compression by Avro dat...

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21902 **[Test build #93704 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93704/testReport)** for PR 21902 at commit

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21901 LGTM, too --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21883: [SPARK-24937][SQL] Datasource partition table should loa...

2018-07-27 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/21883 cc @gatorsmile @gengliangwang --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21608: [SPARK-24626] [SQL] Improve location size calculation in...

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21608 **[Test build #93710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93710/testReport)** for PR 21608 at commit

[GitHub] spark issue #21608: [SPARK-24626] [SQL] Improve location size calculation in...

2018-07-27 Thread Achuth17
Github user Achuth17 commented on the issue: https://github.com/apache/spark/pull/21608 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21102: [SPARK-23913][SQL] Add array_intersect function

2018-07-27 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21102#discussion_r205930801 --- Diff: core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala --- @@ -272,7 +272,7 @@ class OpenHashSet[@specialized(Long, Int) T:

[GitHub] spark pull request #21102: [SPARK-23913][SQL] Add array_intersect function

2018-07-27 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21102#discussion_r205930794 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -3805,3 +3801,339 @@ object ArrayUnion {

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-07-27 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20636 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21899: [SPARK-24912][SQL] Don't obscure source of OOM during br...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21899 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21899: [SPARK-24912][SQL] Don't obscure source of OOM during br...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21899 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93703/ Test PASSed. ---

[GitHub] spark issue #21899: [SPARK-24912][SQL] Don't obscure source of OOM during br...

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21899 **[Test build #93703 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93703/testReport)** for PR 21899 at commit

[GitHub] spark pull request #21103: [SPARK-23915][SQL] Add array_except function

2018-07-27 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21103#discussion_r205930539 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -3968,3 +3964,242 @@ object ArrayUnion {

[GitHub] spark pull request #21754: [SPARK-24705][SQL] Cannot reuse an exchange opera...

2018-07-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21754#discussion_r205929427 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala --- @@ -89,23 +97,42 @@ case class ReuseExchange(conf: SQLConf)

[GitHub] spark pull request #21754: [SPARK-24705][SQL] Cannot reuse an exchange opera...

2018-07-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21754#discussion_r205929402 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala --- @@ -52,6 +52,14 @@ case class ReusedExchangeExec(override

[GitHub] spark issue #21772: [SPARK-24809] [SQL] Serializing LongToUnsafeRowMap in ex...

2018-07-27 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21772 good catch! LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21772: [SPARK-24809] [SQL] Serializing LongToUnsafeRowMa...

2018-07-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21772#discussion_r205929311 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/HashedRelationSuite.scala --- @@ -278,6 +278,36 @@ class HashedRelationSuite

[GitHub] spark pull request #21103: [SPARK-23915][SQL] Add array_except function

2018-07-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21103#discussion_r205929135 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -3968,3 +3964,242 @@ object ArrayUnion

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/21901 the spark-master-test-sbt build failed on ubuntu, but the the improtant bit is that the DateTimeUtilsSuite tests passed! i think this PR should be g2g for merging in to master. thanks

[GitHub] spark pull request #21103: [SPARK-23915][SQL] Add array_except function

2018-07-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21103#discussion_r205928966 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -3968,3 +3964,317 @@ object ArrayUnion

[GitHub] spark pull request #21103: [SPARK-23915][SQL] Add array_except function

2018-07-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21103#discussion_r205928882 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -3651,14 +3651,9 @@ case class

[GitHub] spark pull request #21103: [SPARK-23915][SQL] Add array_except function

2018-07-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21103#discussion_r205928822 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -3651,14 +3651,9 @@ case class

[GitHub] spark issue #21732: [SPARK-24762][SQL] Aggregator should be able to use Opti...

2018-07-27 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21732 This PR is just a special handling for `Option[Product]` in Aggregator, I think we don't need it when we have the more general solution, right? ---

[GitHub] spark pull request #21584: [SPARK-24433][K8S] Initial R Bindings for SparkR ...

2018-07-27 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21584#discussion_r205928623 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala --- @@ -205,7 +218,7 @@ private[spark] object

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21901 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93697/ Test PASSed. ---

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21901 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21901 **[Test build #93697 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93697/testReport)** for PR 21901 at commit

[GitHub] spark issue #21103: [SPARK-23915][SQL] Add array_except function

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21103 **[Test build #93709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93709/testReport)** for PR 21103 at commit

[GitHub] spark issue #21103: [SPARK-23915][SQL] Add array_except function

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21103 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21886 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21103: [SPARK-23915][SQL] Add array_except function

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21103 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21886 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21103: [SPARK-23915][SQL] Add array_except function

2018-07-27 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21103 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21886 **[Test build #93708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93708/testReport)** for PR 21886 at commit

[GitHub] spark issue #21886: [SPARK-21274][SQL] Implement INTERSECT ALL clause

2018-07-27 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/21886 @gatorsmile Rebased. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21608: [SPARK-24626] [SQL] Improve location size calculation in...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21608 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93702/ Test FAILed. ---

[GitHub] spark issue #21608: [SPARK-24626] [SQL] Improve location size calculation in...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21608 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21608: [SPARK-24626] [SQL] Improve location size calculation in...

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21608 **[Test build #93702 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93702/testReport)** for PR 21608 at commit

[GitHub] spark pull request #21318: [minor] Update docs for functions.scala to make i...

2018-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21318 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

2018-07-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21318 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21904: [SPARK-24953] [SQL] Prune a branch in `CaseWhen` ...

2018-07-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21904#discussion_r205925217 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -416,6 +416,29 @@ object SimplifyConditionals

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21318 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21318 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93695/ Test PASSed. ---

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21318 **[Test build #93695 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93695/testReport)** for PR 21318 at commit

[GitHub] spark issue #21847: [SPARK-24855][SQL][EXTERNAL]: Built-in AVRO support shou...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21847 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93707/ Test FAILed. ---

[GitHub] spark issue #21847: [SPARK-24855][SQL][EXTERNAL]: Built-in AVRO support shou...

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21847 **[Test build #93707 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93707/testReport)** for PR 21847 at commit

[GitHub] spark issue #21847: [SPARK-24855][SQL][EXTERNAL]: Built-in AVRO support shou...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21847 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21847: [SPARK-24855][SQL][EXTERNAL]: Built-in AVRO support shou...

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21847 **[Test build #93707 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93707/testReport)** for PR 21847 at commit

[GitHub] spark issue #21102: [SPARK-23913][SQL] Add array_intersect function

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21102 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

  1   2   3   4   5   6   >