Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21933
**[Test build #94346 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94346/testReport)**
for PR 21933 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21980
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21980
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94332/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21980
**[Test build #94332 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94332/testReport)**
for PR 21980 at commit
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21721#discussion_r208106031
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ProgressReporter.scala
---
@@ -196,6 +237,18 @@ trait ProgressReporter
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21933
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21845
**[Test build #94345 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94345/testReport)**
for PR 21845 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21845
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21845
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21898
@rxin, here we seems indeed starting to hit the time limit now.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21980
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21980
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94331/
Test PASSed.
---
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21087#discussion_r208105302
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1490,6 +1495,8 @@ class SQLConf extends Serializable with Logging {
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21845
I am reopening this per
https://github.com/apache/spark/pull/21898#issuecomment-410909703
cc @cloud-fan, @rxin and @shaneknapp
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21980
**[Test build #94331 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94331/testReport)**
for PR 21980 at commit
GitHub user HyukjinKwon reopened a pull request:
https://github.com/apache/spark/pull/21845
[SPARK-24886][INFRA] Fix the testing script to increase timeout for Jenkins
build (from 300m to 330m)
## What changes were proposed in this pull request?
Currently, looks we hit the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21898
**[Test build #94344 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94344/testReport)**
for PR 21898 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22019
Hm.. wait let me take a closer look.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21898
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21898
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21860
**[Test build #94343 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94343/testReport)**
for PR 21860 at commit
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/21898
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21087#discussion_r208103944
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedWriteSuite.scala
---
@@ -48,16 +49,40 @@ abstract class BucketedWriteSuite extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21991
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94329/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21991
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21991
**[Test build #94329 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94329/testReport)**
for PR 21991 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22019
**[Test build #94342 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94342/testReport)**
for PR 22019 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22019
Looks few other types could potentially have this issue too. Let me fix
them all here while I am here.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22019
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22019
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/22019
[SPARK-25040][SQL] Empty string for double and float types should be nulls
in JSON
## What changes were proposed in this pull request?
This PR proposes to treat empty strings for
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22019
cc @cloud-fan, @viirya and @fuqiliang
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20666
That's not related to this change. The issue itself seems to be a behaviour
change between 1.6 and 2.x for treating empty string as null or not in double
and float, which is rather a corner
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21919#discussion_r208100226
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -46,6 +46,9 @@ case class
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21305
LGTM, pending jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21898
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21898
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21898
**[Test build #94341 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94341/testReport)**
for PR 21898 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21898
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16898#discussion_r208098556
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
---
@@ -119,23 +130,45 @@ object FileFormatWriter
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22009#discussion_r208098178
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/memoryV2.scala
---
@@ -132,35 +134,15 @@ class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22009
**[Test build #94340 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94340/testReport)**
for PR 22009 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22009
**[Test build #94338 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94338/testReport)**
for PR 22009 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94338/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21305
**[Test build #94339 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94339/testReport)**
for PR 21305 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21305
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21305
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21305
@cloud-fan, I've rebased and updated with the requested change to disallow
missing columns, even if they're optional. Thanks for reviewing!
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22009
**[Test build #94338 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94338/testReport)**
for PR 22009 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22009#discussion_r208095752
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/sources/v2/JavaBatchDataSourceV2.java
---
@@ -1,114 +0,0 @@
-/*
- * Licensed to the
Github user leachbj commented on a diff in the pull request:
https://github.com/apache/spark/pull/16898#discussion_r208094538
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
---
@@ -119,23 +130,45 @@ object FileFormatWriter
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22011#discussion_r208093660
--- Diff: python/pyspark/rdd.py ---
@@ -2429,6 +2441,29 @@ def _wrap_function(sc, func, deserializer,
serializer, profiler=None):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22009
**[Test build #94337 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94337/testReport)**
for PR 22009 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94337/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22017
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22017
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94325/
Test PASSed.
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22011#discussion_r208093240
--- Diff: python/pyspark/rdd.py ---
@@ -2429,6 +2441,29 @@ def _wrap_function(sc, func, deserializer,
serializer, profiler=None):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22017
**[Test build #94325 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94325/testReport)**
for PR 22017 at commit
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/22009
There must not be one. I thought you'd already started a PR, my mistake.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22011#discussion_r208092650
--- Diff: python/pyspark/rdd.py ---
@@ -2429,6 +2441,29 @@ def _wrap_function(sc, func, deserializer,
serializer, profiler=None):
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22009
@rdblue can you point me to the other PR? This is the only PR I send out
for data source v2 API improvement. I'd appreciate your time to review it,
thanks!
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21991
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94323/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21991
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22009
**[Test build #94337 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94337/testReport)**
for PR 22009 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94336/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22009
**[Test build #94336 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94336/testReport)**
for PR 22009 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21991
**[Test build #94323 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94323/testReport)**
for PR 21991 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22011#discussion_r208092333
--- Diff: python/pyspark/rdd.py ---
@@ -2406,6 +2406,18 @@ def toLocalIterator(self):
sock_info =
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/22009
Does this replace the other PR? I haven't looked at that one yet. If this
is ready to review and follows the doc, I can review it.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22014
LGTM except those rather nits.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22014#discussion_r208091824
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -709,6 +709,7 @@ object ScalaReflection extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22014#discussion_r208091445
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxCountDistinctForIntervals.scala
---
@@ -67,6 +67,7 @@
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22014#discussion_r208090085
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -471,6 +471,7 @@ class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22014#discussion_r208089613
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/ValueInterval.scala
---
@@ -86,6 +87,7 @@ object
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21977#discussion_r208091782
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
@@ -60,14 +61,26 @@ private[spark] object PythonEvalType {
*/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22009
**[Test build #94336 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94336/testReport)**
for PR 22009 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21898
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21898
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94326/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21898
**[Test build #94326 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94326/testReport)**
for PR 21898 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21991
The failed test is `FlatMapGroupsWithStateSuite.flatMapGroupsWithState`. I
saw it fails some times occasionally. I think it should not be related to this
change. @HyukjinKwon @dbtsai
---
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21305#discussion_r208090428
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala ---
@@ -336,4 +337,124 @@ object DataType {
case (fromDataType,
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21305#discussion_r208090280
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeWriteCompatibilitySuite.scala
---
@@ -0,0 +1,395 @@
+/*
+ * Licensed to
Github user fuqiliang commented on the issue:
https://github.com/apache/spark/pull/20666
for specify, the json file (Sanity4.json) is
`{"a":"a1","int":1,"other":4.4}
{"a":"a2","int":"","other":""}`
code ï¼
> val config = new
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r208089990
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -169,25 +181,50 @@ package object expressions {
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17185
Thanks for the review. I have addressed your comments and pushed the
changes.
@cloud-fan, Please take a look.
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94335 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94335/testReport)**
for PR 17185 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21991
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94324/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22018
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21721#discussion_r208089043
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ProgressReporter.scala
---
@@ -196,6 +237,18 @@ trait ProgressReporter
1 - 100 of 713 matches
Mail list logo
