[GitHub] [spark] yeshengm commented on a change in pull request #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions
yeshengm commented on a change in pull request #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions URL: https://github.com/apache/spark/pull/24749#discussion_r290588408 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -82,13 +82,15 @@ singleTableSchema statement : query #statementDefault | ctes? dmlStatementNoWith #dmlStatement -| USE db=identifier#use -| CREATE database (IF NOT EXISTS)? identifier +| USE db=errorCapturingIdentifier #use +| CREATE database (IF NOT EXISTS)? errorCapturingIdentifier ((COMMENT comment=STRING) | locationSpec | (WITH DBPROPERTIES tablePropertyList))* #createDatabase -| ALTER database identifier SET DBPROPERTIES tablePropertyList #setDatabaseProperties -| DROP database (IF EXISTS)? identifier (RESTRICT | CASCADE)? #dropDatabase +| ALTER database errorCapturingIdentifier +SET DBPROPERTIES tablePropertyList #setDatabaseProperties +| DROP database (IF EXISTS)? db=errorCapturingIdentifier Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #24741: [SPARK-27322][SQL] DataSourceV2: Select from multiple catalogs
gatorsmile commented on a change in pull request #24741: [SPARK-27322][SQL] DataSourceV2: Select from multiple catalogs URL: https://github.com/apache/spark/pull/24741#discussion_r290587603 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala ## @@ -98,8 +100,22 @@ case class DataSourceResolution( case DropViewStatement(AsTableIdentifier(tableName), ifExists) => DropTableCommand(tableName, ifExists, isView = true, purge = false) + +case u @ UnresolvedRelation(CatalogObjectIdentifier(Some(catalog), ident)) => Review comment: ``` new FindDataSourceTable(session) +: new ResolveSQLOnFile(session) +: new FallBackFileSourceV2(session) +: DataSourceResolution(conf, session.catalog(_)) +: ``` I do not know who make this decision, but semantically, this could be different. one is before the rule ResolveSQLOnFile; another is after the rule ResolveSQLOnFile This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table
SparkQA commented on issue #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table URL: https://github.com/apache/spark/pull/24721#issuecomment-498946767 **[Test build #106189 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106189/testReport)** for PR 24721 at commit [`c5b626c`](https://github.com/apache/spark/commit/c5b626cebedb39459cfe9445eb8dc595812bdff8). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table
AmplabJenkins removed a comment on issue #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table URL: https://github.com/apache/spark/pull/24721#issuecomment-498946466 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table
AmplabJenkins removed a comment on issue #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table URL: https://github.com/apache/spark/pull/24721#issuecomment-498946472 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11440/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table
AmplabJenkins commented on issue #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table URL: https://github.com/apache/spark/pull/24721#issuecomment-498946466 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table
AmplabJenkins commented on issue #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table URL: https://github.com/apache/spark/pull/24721#issuecomment-498946472 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11440/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table
gatorsmile commented on issue #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table URL: https://github.com/apache/spark/pull/24721#issuecomment-498946186 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
AmplabJenkins removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498945700 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106185/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
AmplabJenkins removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498945696 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
AmplabJenkins commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498945700 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106185/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
SparkQA removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498931917 **[Test build #106185 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106185/testReport)** for PR 24792 at commit [`3a9aa1e`](https://github.com/apache/spark/commit/3a9aa1e32e6d2f4a489ddfa00156b5da0eca9404). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
AmplabJenkins commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498945696 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
SparkQA commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498945607 **[Test build #106185 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106185/testReport)** for PR 24792 at commit [`3a9aa1e`](https://github.com/apache/spark/commit/3a9aa1e32e6d2f4a489ddfa00156b5da0eca9404). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24802: [SPARK-27949][SQL]Support ANSI SQL grammar `substring(string_expression from n1 [for n2])`
AmplabJenkins removed a comment on issue #24802: [SPARK-27949][SQL]Support ANSI SQL grammar `substring(string_expression from n1 [for n2])` URL: https://github.com/apache/spark/pull/24802#issuecomment-498944556 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException
gatorsmile commented on a change in pull request #24800: [SPARK-27947][SQL]
ParsedStatement subclass toString may throw ClassCastException
URL: https://github.com/apache/spark/pull/24800#discussion_r290585629
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/sql/ParsedStatement.scala
##
@@ -36,8 +38,11 @@ import
org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
private[sql] abstract class ParsedStatement extends LogicalPlan {
// Redact properties and options when parsed nodes are used by generic
methods like toString
override def productIterator: Iterator[Any] = super.productIterator.map {
-case mapArg: Map[_, _] =>
conf.redactOptions(mapArg.asInstanceOf[Map[String, String]])
-case other => other
+case mapArg: Map[_, _] =>
+ // May match any Map type, e.g. Map[String, Int], due to type erasure
+ Try(conf.redactOptions(mapArg.asInstanceOf[Map[String,
String]])).getOrElse(mapArg)
Review comment:
but, my question is should we still redact the string key when the value is
not string, or redact the string value when the key is not string?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24802: [SPARK-27949][SQL]Support ANSI SQL grammar `substring(string_expression from n1 [for n2])`
AmplabJenkins removed a comment on issue #24802: [SPARK-27949][SQL]Support ANSI SQL grammar `substring(string_expression from n1 [for n2])` URL: https://github.com/apache/spark/pull/24802#issuecomment-498944560 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106179/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24802: [SPARK-27949][SQL]Support ANSI SQL grammar `substring(string_expression from n1 [for n2])`
AmplabJenkins commented on issue #24802: [SPARK-27949][SQL]Support ANSI SQL grammar `substring(string_expression from n1 [for n2])` URL: https://github.com/apache/spark/pull/24802#issuecomment-498944560 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106179/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24802: [SPARK-27949][SQL]Support ANSI SQL grammar `substring(string_expression from n1 [for n2])`
AmplabJenkins commented on issue #24802: [SPARK-27949][SQL]Support ANSI SQL grammar `substring(string_expression from n1 [for n2])` URL: https://github.com/apache/spark/pull/24802#issuecomment-498944556 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException
gatorsmile commented on a change in pull request #24800: [SPARK-27947][SQL]
ParsedStatement subclass toString may throw ClassCastException
URL: https://github.com/apache/spark/pull/24800#discussion_r290585465
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/sql/ParsedStatement.scala
##
@@ -36,8 +38,11 @@ import
org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
private[sql] abstract class ParsedStatement extends LogicalPlan {
// Redact properties and options when parsed nodes are used by generic
methods like toString
override def productIterator: Iterator[Any] = super.productIterator.map {
-case mapArg: Map[_, _] =>
conf.redactOptions(mapArg.asInstanceOf[Map[String, String]])
-case other => other
+case mapArg: Map[_, _] =>
+ // May match any Map type, e.g. Map[String, Int], due to type erasure
+ Try(conf.redactOptions(mapArg.asInstanceOf[Map[String,
String]])).getOrElse(mapArg)
Review comment:
Is this what you want?
```
case mapArg: Map[String, String] => conf.redactOptions(mapArg)
case other => other
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24802: [SPARK-27949][SQL]Support ANSI SQL grammar `substring(string_expression from n1 [for n2])`
SparkQA removed a comment on issue #24802: [SPARK-27949][SQL]Support ANSI SQL grammar `substring(string_expression from n1 [for n2])` URL: https://github.com/apache/spark/pull/24802#issuecomment-498914094 **[Test build #106179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106179/testReport)** for PR 24802 at commit [`385f327`](https://github.com/apache/spark/commit/385f3277ce9136b649aa6b7da7162edbc9802f68). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24802: [SPARK-27949][SQL]Support ANSI SQL grammar `substring(string_expression from n1 [for n2])`
SparkQA commented on issue #24802: [SPARK-27949][SQL]Support ANSI SQL grammar `substring(string_expression from n1 [for n2])` URL: https://github.com/apache/spark/pull/24802#issuecomment-498944209 **[Test build #106179 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106179/testReport)** for PR 24802 at commit [`385f327`](https://github.com/apache/spark/commit/385f3277ce9136b649aa6b7da7162edbc9802f68). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method
SparkQA commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method URL: https://github.com/apache/spark/pull/24803#issuecomment-498944005 **[Test build #106188 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106188/testReport)** for PR 24803 at commit [`3d4b2c3`](https://github.com/apache/spark/commit/3d4b2c3c31664af7cf6998dfb966119232d56fff). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method
AmplabJenkins removed a comment on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method URL: https://github.com/apache/spark/pull/24803#issuecomment-498943695 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method
AmplabJenkins removed a comment on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method URL: https://github.com/apache/spark/pull/24803#issuecomment-498943696 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11439/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method
AmplabJenkins commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method URL: https://github.com/apache/spark/pull/24803#issuecomment-498943696 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11439/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method
AmplabJenkins commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method URL: https://github.com/apache/spark/pull/24803#issuecomment-498943695 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API
AmplabJenkins removed a comment on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API URL: https://github.com/apache/spark/pull/24774#issuecomment-498942886 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106184/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API
AmplabJenkins removed a comment on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API URL: https://github.com/apache/spark/pull/24774#issuecomment-498942883 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API
SparkQA commented on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API URL: https://github.com/apache/spark/pull/24774#issuecomment-498942806 **[Test build #106184 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106184/testReport)** for PR 24774 at commit [`7d69a50`](https://github.com/apache/spark/commit/7d69a5074a3585961720b82973d148b3745e439a). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API
AmplabJenkins commented on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API URL: https://github.com/apache/spark/pull/24774#issuecomment-498942883 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API
AmplabJenkins commented on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API URL: https://github.com/apache/spark/pull/24774#issuecomment-498942886 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106184/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method
gatorsmile commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method URL: https://github.com/apache/spark/pull/24803#issuecomment-498942818 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API
SparkQA removed a comment on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API URL: https://github.com/apache/spark/pull/24774#issuecomment-498929604 **[Test build #106184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106184/testReport)** for PR 24774 at commit [`7d69a50`](https://github.com/apache/spark/commit/7d69a5074a3585961720b82973d148b3745e439a). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method
AmplabJenkins removed a comment on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method URL: https://github.com/apache/spark/pull/24803#issuecomment-498935302 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jzhuge commented on a change in pull request #24741: [SPARK-27322][SQL] DataSourceV2: Select from multiple catalogs
jzhuge commented on a change in pull request #24741: [SPARK-27322][SQL]
DataSourceV2: Select from multiple catalogs
URL: https://github.com/apache/spark/pull/24741#discussion_r290583573
##
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala
##
@@ -153,7 +153,8 @@ object HiveAnalysis extends Rule[LogicalPlan] {
case CreateTable(tableDesc, mode, None) if DDLUtils.isHiveTable(tableDesc)
=>
CreateTableCommand(tableDesc, ignoreIfExists = mode == SaveMode.Ignore)
-case CreateTable(tableDesc, mode, Some(query)) if
DDLUtils.isHiveTable(tableDesc) =>
+case CreateTable(tableDesc, mode, Some(query))
+if DDLUtils.isHiveTable(tableDesc) && query.resolved =>
Review comment:
This PR prevents lookupTableFromCatalog from throwing NoSuchTableException
right away. Instead, it relies on checkAnalysis to throw an exception for
UnresolvedRelation.
The test hive.SQLQuerySuite."double nested data" would fail in the following
sql without this change:
```
CREATE TABLE test_ctas_1234 AS SELECT * from notexists
```
HiveAnalysis gets to run before checkAnalysis, thus exposing this bug where
query.output is used before query is resolved.
So wouldn't say it is a totally separate issue.
In addition, outside of this PR, it'd be hard to write a unit test.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24628: [SPARK-27749][SQL] hadoop-3.2 support hive-thriftserver
SparkQA commented on issue #24628: [SPARK-27749][SQL] hadoop-3.2 support hive-thriftserver URL: https://github.com/apache/spark/pull/24628#issuecomment-498941423 **[Test build #106187 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106187/testReport)** for PR 24628 at commit [`cee5636`](https://github.com/apache/spark/commit/cee56365f1f2a589dde0eb0b602f1db1c912da9f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24628: [SPARK-27749][SQL] hadoop-3.2 support hive-thriftserver
AmplabJenkins removed a comment on issue #24628: [SPARK-27749][SQL] hadoop-3.2 support hive-thriftserver URL: https://github.com/apache/spark/pull/24628#issuecomment-498941157 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24628: [SPARK-27749][SQL] hadoop-3.2 support hive-thriftserver
AmplabJenkins removed a comment on issue #24628: [SPARK-27749][SQL] hadoop-3.2 support hive-thriftserver URL: https://github.com/apache/spark/pull/24628#issuecomment-498941161 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11438/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24628: [SPARK-27749][SQL] hadoop-3.2 support hive-thriftserver
AmplabJenkins commented on issue #24628: [SPARK-27749][SQL] hadoop-3.2 support hive-thriftserver URL: https://github.com/apache/spark/pull/24628#issuecomment-498941157 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24628: [SPARK-27749][SQL] hadoop-3.2 support hive-thriftserver
AmplabJenkins commented on issue #24628: [SPARK-27749][SQL] hadoop-3.2 support hive-thriftserver URL: https://github.com/apache/spark/pull/24628#issuecomment-498941161 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11438/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24798: [SPARK-27724][WIP] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
AmplabJenkins removed a comment on issue #24798: [SPARK-27724][WIP] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-498940385 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106178/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangyum commented on issue #24628: [SPARK-27749][SQL] hadoop-3.2 support hive-thriftserver
wangyum commented on issue #24628: [SPARK-27749][SQL] hadoop-3.2 support hive-thriftserver URL: https://github.com/apache/spark/pull/24628#issuecomment-498940320 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24798: [SPARK-27724][WIP] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
AmplabJenkins commented on issue #24798: [SPARK-27724][WIP] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-498940382 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24798: [SPARK-27724][WIP] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
AmplabJenkins commented on issue #24798: [SPARK-27724][WIP] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-498940385 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106178/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24798: [SPARK-27724][WIP] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
AmplabJenkins removed a comment on issue #24798: [SPARK-27724][WIP] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-498940382 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24798: [SPARK-27724][WIP] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
SparkQA removed a comment on issue #24798: [SPARK-27724][WIP] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-498906718 **[Test build #106178 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106178/testReport)** for PR 24798 at commit [`bc8d3b5`](https://github.com/apache/spark/commit/bc8d3b568988c904dff4f31a19f6dc0aa33f4a8b). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24798: [SPARK-27724][WIP] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
SparkQA commented on issue #24798: [SPARK-27724][WIP] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-498940097 **[Test build #106178 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106178/testReport)** for PR 24798 at commit [`bc8d3b5`](https://github.com/apache/spark/commit/bc8d3b568988c904dff4f31a19f6dc0aa33f4a8b). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class InMemoryTable(` * `class BufferedRows extends WriterCommitMessage with InputPartition with Serializable ` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24628: [SPARK-27749][SQL][test-hadoop3.2] hadoop-3.2 support hive-thriftserver
AmplabJenkins removed a comment on issue #24628: [SPARK-27749][SQL][test-hadoop3.2] hadoop-3.2 support hive-thriftserver URL: https://github.com/apache/spark/pull/24628#issuecomment-498939636 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106182/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24628: [SPARK-27749][SQL][test-hadoop3.2] hadoop-3.2 support hive-thriftserver
AmplabJenkins removed a comment on issue #24628: [SPARK-27749][SQL][test-hadoop3.2] hadoop-3.2 support hive-thriftserver URL: https://github.com/apache/spark/pull/24628#issuecomment-498939631 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24628: [SPARK-27749][SQL][test-hadoop3.2] hadoop-3.2 support hive-thriftserver
AmplabJenkins commented on issue #24628: [SPARK-27749][SQL][test-hadoop3.2] hadoop-3.2 support hive-thriftserver URL: https://github.com/apache/spark/pull/24628#issuecomment-498939636 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106182/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24628: [SPARK-27749][SQL][test-hadoop3.2] hadoop-3.2 support hive-thriftserver
AmplabJenkins commented on issue #24628: [SPARK-27749][SQL][test-hadoop3.2] hadoop-3.2 support hive-thriftserver URL: https://github.com/apache/spark/pull/24628#issuecomment-498939631 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24628: [SPARK-27749][SQL][test-hadoop3.2] hadoop-3.2 support hive-thriftserver
SparkQA removed a comment on issue #24628: [SPARK-27749][SQL][test-hadoop3.2] hadoop-3.2 support hive-thriftserver URL: https://github.com/apache/spark/pull/24628#issuecomment-498915681 **[Test build #106182 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106182/testReport)** for PR 24628 at commit [`cee5636`](https://github.com/apache/spark/commit/cee56365f1f2a589dde0eb0b602f1db1c912da9f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24628: [SPARK-27749][SQL][test-hadoop3.2] hadoop-3.2 support hive-thriftserver
SparkQA commented on issue #24628: [SPARK-27749][SQL][test-hadoop3.2] hadoop-3.2 support hive-thriftserver URL: https://github.com/apache/spark/pull/24628#issuecomment-498939301 **[Test build #106182 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106182/testReport)** for PR 24628 at commit [`cee5636`](https://github.com/apache/spark/commit/cee56365f1f2a589dde0eb0b602f1db1c912da9f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method
AmplabJenkins removed a comment on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method URL: https://github.com/apache/spark/pull/24803#issuecomment-498934948 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions
SparkQA commented on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions URL: https://github.com/apache/spark/pull/24749#issuecomment-498935356 **[Test build #106186 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106186/testReport)** for PR 24749 at commit [`7dae20e`](https://github.com/apache/spark/commit/7dae20e636c092502fb0b8b0525ef5043266b411). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method
AmplabJenkins commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method URL: https://github.com/apache/spark/pull/24803#issuecomment-498935302 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions
AmplabJenkins commented on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions URL: https://github.com/apache/spark/pull/24749#issuecomment-498935067 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions
AmplabJenkins removed a comment on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions URL: https://github.com/apache/spark/pull/24749#issuecomment-498935067 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions
AmplabJenkins commented on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions URL: https://github.com/apache/spark/pull/24749#issuecomment-498935074 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11437/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions
AmplabJenkins removed a comment on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions URL: https://github.com/apache/spark/pull/24749#issuecomment-498935074 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11437/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method
AmplabJenkins removed a comment on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method URL: https://github.com/apache/spark/pull/24803#issuecomment-498934847 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method
AmplabJenkins commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method URL: https://github.com/apache/spark/pull/24803#issuecomment-498934847 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method
AmplabJenkins commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method URL: https://github.com/apache/spark/pull/24803#issuecomment-498934948 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method
LantaoJin commented on issue #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method URL: https://github.com/apache/spark/pull/24803#issuecomment-498934555 cc @gatorsmile @wangyum This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on a change in pull request #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API
LantaoJin commented on a change in pull request #24774: [SPARK-27899][SQL] Make
HiveMetastoreClient.getTableObjectsByName available in
ExternalCatalog/SessionCatalog API
URL: https://github.com/apache/spark/pull/24774#discussion_r290577824
##
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##
@@ -384,127 +388,144 @@ private[hive] class HiveClientImpl(
Option(client.getTable(dbName, tableName, false /* do not throw exception
*/))
}
+ private def getRawTablesByNames(dbName: String, tableNames: Seq[String]):
Seq[HiveTable] = {
+try {
+ msClient.getTableObjectsByName(dbName,
tableNames.asJava).asScala.map(new HiveTable(_))
+} catch {
+ case ex: Exception =>
+throw new HiveException(s"Unable to fetch tables of db $dbName", ex);
+}
+ }
+
override def tableExists(dbName: String, tableName: String): Boolean =
withHiveState {
getRawTableOption(dbName, tableName).nonEmpty
}
+ override def getTablesByName(
+ dbName: String,
+ tableNames: Seq[String]): Seq[CatalogTable] = withHiveState {
+getRawTablesByNames(dbName, tableNames).map(convertHiveTableToCatalogTable)
+ }
+
override def getTableOption(
dbName: String,
tableName: String): Option[CatalogTable] = withHiveState {
logDebug(s"Looking up $dbName.$tableName")
-getRawTableOption(dbName, tableName).map { h =>
- // Note: Hive separates partition columns and the schema, but for us the
- // partition columns are part of the schema
- val cols = h.getCols.asScala.map(fromHiveColumn)
- val partCols = h.getPartCols.asScala.map(fromHiveColumn)
- val schema = StructType(cols ++ partCols)
-
- val bucketSpec = if (h.getNumBuckets > 0) {
-val sortColumnOrders = h.getSortCols.asScala
-// Currently Spark only supports columns to be sorted in ascending
order
-// but Hive can support both ascending and descending order. If all
the columns
-// are sorted in ascending order, only then propagate the sortedness
information
-// to downstream processing / optimizations in Spark
-// TODO: In future we can have Spark support columns sorted in
descending order
-val allAscendingSorted = sortColumnOrders.forall(_.getOrder ==
HIVE_COLUMN_ORDER_ASC)
-
-val sortColumnNames = if (allAscendingSorted) {
- sortColumnOrders.map(_.getCol)
-} else {
- Seq.empty
-}
-Option(BucketSpec(h.getNumBuckets, h.getBucketCols.asScala,
sortColumnNames))
+getRawTableOption(dbName, tableName).map(convertHiveTableToCatalogTable)
+ }
+
+ private def convertHiveTableToCatalogTable(h: HiveTable): CatalogTable = {
Review comment:
See #24803
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on a change in pull request #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API
LantaoJin commented on a change in pull request #24774: [SPARK-27899][SQL] Make
HiveMetastoreClient.getTableObjectsByName available in
ExternalCatalog/SessionCatalog API
URL: https://github.com/apache/spark/pull/24774#discussion_r290577893
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
##
@@ -128,6 +128,8 @@ trait ExternalCatalog {
def getTable(db: String, table: String): CatalogTable
+ def getTablesByName(db: String, tables: Seq[String]): Seq[CatalogTable]
Review comment:
fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin opened a new pull request #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method
LantaoJin opened a new pull request #24803: [SPARK-27899][SQL] Refactor getTableOption() to extract a common method URL: https://github.com/apache/spark/pull/24803 ## What changes were proposed in this pull request? This is a part of #24774, to reduce the code changes made by that. ## How was this patch tested? Exist UTs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
SparkQA commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498931917 **[Test build #106185 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106185/testReport)** for PR 24792 at commit [`3a9aa1e`](https://github.com/apache/spark/commit/3a9aa1e32e6d2f4a489ddfa00156b5da0eca9404). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
AmplabJenkins removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498931624 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11436/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
AmplabJenkins removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498931621 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
AmplabJenkins commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498931624 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11436/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
AmplabJenkins commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498931621 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24704: [SPARK-20286][core] Improve logic for timing out executors in dynamic allocation.
AmplabJenkins commented on issue #24704: [SPARK-20286][core] Improve logic for timing out executors in dynamic allocation. URL: https://github.com/apache/spark/pull/24704#issuecomment-498931443 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24704: [SPARK-20286][core] Improve logic for timing out executors in dynamic allocation.
AmplabJenkins removed a comment on issue #24704: [SPARK-20286][core] Improve logic for timing out executors in dynamic allocation. URL: https://github.com/apache/spark/pull/24704#issuecomment-498931448 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106177/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24704: [SPARK-20286][core] Improve logic for timing out executors in dynamic allocation.
AmplabJenkins removed a comment on issue #24704: [SPARK-20286][core] Improve logic for timing out executors in dynamic allocation. URL: https://github.com/apache/spark/pull/24704#issuecomment-498931443 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24704: [SPARK-20286][core] Improve logic for timing out executors in dynamic allocation.
AmplabJenkins commented on issue #24704: [SPARK-20286][core] Improve logic for timing out executors in dynamic allocation. URL: https://github.com/apache/spark/pull/24704#issuecomment-498931448 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106177/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions
AmplabJenkins commented on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions URL: https://github.com/apache/spark/pull/24749#issuecomment-498931306 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions
AmplabJenkins removed a comment on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions URL: https://github.com/apache/spark/pull/24749#issuecomment-498931311 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106175/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions
AmplabJenkins removed a comment on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions URL: https://github.com/apache/spark/pull/24749#issuecomment-498931306 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions
AmplabJenkins commented on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions URL: https://github.com/apache/spark/pull/24749#issuecomment-498931311 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106175/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24704: [SPARK-20286][core] Improve logic for timing out executors in dynamic allocation.
SparkQA commented on issue #24704: [SPARK-20286][core] Improve logic for timing out executors in dynamic allocation. URL: https://github.com/apache/spark/pull/24704#issuecomment-498931158 **[Test build #106177 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106177/testReport)** for PR 24704 at commit [`9ae62d9`](https://github.com/apache/spark/commit/9ae62d930aec531c5c19a718a76ea4ac01c2695d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24704: [SPARK-20286][core] Improve logic for timing out executors in dynamic allocation.
SparkQA removed a comment on issue #24704: [SPARK-20286][core] Improve logic for timing out executors in dynamic allocation. URL: https://github.com/apache/spark/pull/24704#issuecomment-498903823 **[Test build #106177 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106177/testReport)** for PR 24704 at commit [`9ae62d9`](https://github.com/apache/spark/commit/9ae62d930aec531c5c19a718a76ea4ac01c2695d). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions
SparkQA removed a comment on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions URL: https://github.com/apache/spark/pull/24749#issuecomment-498893852 **[Test build #106175 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106175/testReport)** for PR 24749 at commit [`48a9ee3`](https://github.com/apache/spark/commit/48a9ee3c2e686017cb9c1e8e68b2590e6618). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions
SparkQA commented on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for identifier with hyphens except those in expressions URL: https://github.com/apache/spark/pull/24749#issuecomment-498931038 **[Test build #106175 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106175/testReport)** for PR 24749 at commit [`48a9ee3`](https://github.com/apache/spark/commit/48a9ee3c2e686017cb9c1e8e68b2590e6618). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
AmplabJenkins removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498930409 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106180/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
SparkQA removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498914105 **[Test build #106180 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106180/testReport)** for PR 24792 at commit [`e7a387c`](https://github.com/apache/spark/commit/e7a387cfe9b2d5c0c58f1cab2cd4b931c7bb584b). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
AmplabJenkins commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498930409 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106180/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
AmplabJenkins commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498930404 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
SparkQA commented on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498930308 **[Test build #106180 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106180/testReport)** for PR 24792 at commit [`e7a387c`](https://github.com/apache/spark/commit/e7a387cfe9b2d5c0c58f1cab2cd4b931c7bb584b). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint
AmplabJenkins removed a comment on issue #24792: [WIP][SPARK-27943][SQL] Add new feature create table could specify column with default constraint URL: https://github.com/apache/spark/pull/24792#issuecomment-498930404 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API
SparkQA commented on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API URL: https://github.com/apache/spark/pull/24774#issuecomment-498929604 **[Test build #106184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106184/testReport)** for PR 24774 at commit [`7d69a50`](https://github.com/apache/spark/commit/7d69a5074a3585961720b82973d148b3745e439a). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API
AmplabJenkins removed a comment on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API URL: https://github.com/apache/spark/pull/24774#issuecomment-498929552 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11435/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API
AmplabJenkins removed a comment on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API URL: https://github.com/apache/spark/pull/24774#issuecomment-498929546 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API
AmplabJenkins commented on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API URL: https://github.com/apache/spark/pull/24774#issuecomment-498929552 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11435/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API
AmplabJenkins commented on issue #24774: [SPARK-27899][SQL] Make HiveMetastoreClient.getTableObjectsByName available in ExternalCatalog/SessionCatalog API URL: https://github.com/apache/spark/pull/24774#issuecomment-498929546 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException
AmplabJenkins removed a comment on issue #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException URL: https://github.com/apache/spark/pull/24800#issuecomment-498928904 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException
AmplabJenkins removed a comment on issue #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException URL: https://github.com/apache/spark/pull/24800#issuecomment-498928909 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106173/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException
SparkQA removed a comment on issue #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException URL: https://github.com/apache/spark/pull/24800#issuecomment-498893854 **[Test build #106173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106173/testReport)** for PR 24800 at commit [`4b1692b`](https://github.com/apache/spark/commit/4b1692bae53f07c157ec30dd1efca1d2f617d09f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException
AmplabJenkins commented on issue #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException URL: https://github.com/apache/spark/pull/24800#issuecomment-498928904 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
