[GitHub] [spark] gengliangwang commented on issue #24849: [SPARK-28018][SQL] Allow upcasting decimal to double/float

2019-06-30 Thread GitBox
gengliangwang commented on issue #24849: [SPARK-28018][SQL] Allow upcasting decimal to double/float URL: https://github.com/apache/spark/pull/24849#issuecomment-507140862 > - Add a decimal type for SQL literals that can be cast to float because the intended type of the literal is not known

[GitHub] [spark] turboFei edited a comment on issue #24992: [SPARK-28194][SQL] Judge whether to reorder joinKeys to prevent None.get in EnsureRequirements

2019-06-30 Thread GitBox
turboFei edited a comment on issue #24992: [SPARK-28194][SQL] Judge whether to reorder joinKeys to prevent None.get in EnsureRequirements URL: https://github.com/apache/spark/pull/24992#issuecomment-507135803 @maropu It is difficult to judge Set(currentOrderOfKeys) == Set(expectedOrder

[GitHub] [spark] turboFei edited a comment on issue #24992: [SPARK-28194][SQL] Judge whether to reorder joinKeys to prevent None.get in EnsureRequirements

2019-06-30 Thread GitBox
turboFei edited a comment on issue #24992: [SPARK-28194][SQL] Judge whether to reorder joinKeys to prevent None.get in EnsureRequirements URL: https://github.com/apache/spark/pull/24992#issuecomment-507135803 @maropu It is difficult to judge Set(currentOrderOfKeys) == Set(expectedOrder

[GitHub] [spark] turboFei edited a comment on issue #24992: [SPARK-28194][SQL] Judge whether to reorder joinKeys to prevent None.get in EnsureRequirements

2019-06-30 Thread GitBox
turboFei edited a comment on issue #24992: [SPARK-28194][SQL] Judge whether to reorder joinKeys to prevent None.get in EnsureRequirements URL: https://github.com/apache/spark/pull/24992#issuecomment-507135803 @maropu It is difficult to judge Set(currentOrderOfKeys) == Set(expectedOrder

[GitHub] [spark] turboFei commented on issue #24992: [SPARK-28194][SQL] Judge whether to reorder joinKeys to prevent None.get in EnsureRequirements

2019-06-30 Thread GitBox
turboFei commented on issue #24992: [SPARK-28194][SQL] Judge whether to reorder joinKeys to prevent None.get in EnsureRequirements URL: https://github.com/apache/spark/pull/24992#issuecomment-507135803 It is difficult to judge Set(currentOrderOfKeys) == Set(expectedOrderOfKeys). For exa

[GitHub] [spark] SparkQA commented on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite

2019-06-30 Thread GitBox
SparkQA commented on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite URL: https://github.com/apache/spark/pull/24998#issuecomment-507134687 **[Test build #107063 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107063/

[GitHub] [spark] AmplabJenkins removed a comment on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite URL: https://github.com/apache/spark/pull/24998#issuecomment-507134249 Test PASSed. Refer to this link for build results (access rights to CI server needed): h

[GitHub] [spark] AmplabJenkins removed a comment on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite URL: https://github.com/apache/spark/pull/24998#issuecomment-507134241 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins commented on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite URL: https://github.com/apache/spark/pull/24998#issuecomment-507134241 Merged build finished. Test PASSed. Th

[GitHub] [spark] jerryshao commented on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite

2019-06-30 Thread GitBox
jerryshao commented on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite URL: https://github.com/apache/spark/pull/24998#issuecomment-507134239 I'm OK with the changes. This is an automa

[GitHub] [spark] AmplabJenkins commented on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite URL: https://github.com/apache/spark/pull/24998#issuecomment-507134249 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://a

[GitHub] [spark] jerryshao commented on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite

2019-06-30 Thread GitBox
jerryshao commented on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite URL: https://github.com/apache/spark/pull/24998#issuecomment-507133562 Jenkins, test this please. This is an auto

[GitHub] [spark] SparkQA commented on issue #25016: [SPARK-28200][SQL] Decimal overflow handling in ExpressionEncoder

2019-06-30 Thread GitBox
SparkQA commented on issue #25016: [SPARK-28200][SQL] Decimal overflow handling in ExpressionEncoder URL: https://github.com/apache/spark/pull/25016#issuecomment-507132873 **[Test build #107062 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107062/testRepor

[GitHub] [spark] AmplabJenkins removed a comment on issue #25016: [SPARK-28200][SQL] Decimal overflow handling in ExpressionEncoder

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #25016: [SPARK-28200][SQL] Decimal overflow handling in ExpressionEncoder URL: https://github.com/apache/spark/pull/25016#issuecomment-507132340 Merged build finished. Test PASSed. Thi

[GitHub] [spark] AmplabJenkins removed a comment on issue #25016: [SPARK-28200][SQL] Decimal overflow handling in ExpressionEncoder

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #25016: [SPARK-28200][SQL] Decimal overflow handling in ExpressionEncoder URL: https://github.com/apache/spark/pull/25016#issuecomment-507132345 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://am

[GitHub] [spark] AmplabJenkins commented on issue #25016: [SPARK-28200][SQL] Decimal overflow handling in ExpressionEncoder

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #25016: [SPARK-28200][SQL] Decimal overflow handling in ExpressionEncoder URL: https://github.com/apache/spark/pull/25016#issuecomment-507132345 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.

[GitHub] [spark] AmplabJenkins commented on issue #25016: [SPARK-28200][SQL] Decimal overflow handling in ExpressionEncoder

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #25016: [SPARK-28200][SQL] Decimal overflow handling in ExpressionEncoder URL: https://github.com/apache/spark/pull/25016#issuecomment-507132340 Merged build finished. Test PASSed. This is an

[GitHub] [spark] turboFei commented on a change in pull request #24992: [SPARK-28194][SQL] Judge whether to reorder joinKeys to prevent None.get in EnsureRequirements

2019-06-30 Thread GitBox
turboFei commented on a change in pull request #24992: [SPARK-28194][SQL] Judge whether to reorder joinKeys to prevent None.get in EnsureRequirements URL: https://github.com/apache/spark/pull/24992#discussion_r298889535 ## File path: sql/core/src/main/scala/org/apache/spark/sql/ex

[GitHub] [spark] maropu commented on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding.

2019-06-30 Thread GitBox
maropu commented on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding. URL: https://github.com/apache/spark/pull/22347#issuecomment-507130730 sure. @Dooyoung-Hwang are you there? --

[GitHub] [spark] cloud-fan commented on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding.

2019-06-30 Thread GitBox
cloud-fan commented on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding. URL: https://github.com/apache/spark/pull/22347#issuecomment-507129518 LGTM, @maropu can you take it over if @Dooyoung-Hwang is not active? --

[GitHub] [spark] SparkQA commented on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding.

2019-06-30 Thread GitBox
SparkQA commented on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding. URL: https://github.com/apache/spark/pull/22347#issuecomment-507129391 **[Test build #107061 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBui

[GitHub] [spark] cloud-fan commented on a change in pull request #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding.

2019-06-30 Thread GitBox
cloud-fan commented on a change in pull request #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding. URL: https://github.com/apache/spark/pull/22347#discussion_r298891683 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/

[GitHub] [spark] cloud-fan commented on a change in pull request #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding.

2019-06-30 Thread GitBox
cloud-fan commented on a change in pull request #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding. URL: https://github.com/apache/spark/pull/22347#discussion_r298891651 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/

[GitHub] [spark] AmplabJenkins removed a comment on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding.

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding. URL: https://github.com/apache/spark/pull/22347#issuecomment-507128897 Test PASSed. Refer to this link for build results (access rights to CI server nee

[GitHub] [spark] AmplabJenkins commented on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding.

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding. URL: https://github.com/apache/spark/pull/22347#issuecomment-507128897 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding.

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding. URL: https://github.com/apache/spark/pull/22347#issuecomment-507128893 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins commented on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding.

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding. URL: https://github.com/apache/spark/pull/22347#issuecomment-507128893 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding.

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding. URL: https://github.com/apache/spark/pull/22347#issuecomment-502206062 Can one of the admins verify this patch? --

[GitHub] [spark] cloud-fan commented on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding.

2019-06-30 Thread GitBox
cloud-fan commented on issue #22347: [SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding. URL: https://github.com/apache/spark/pull/22347#issuecomment-507128498 retest this please This is an

[GitHub] [spark] LiShuMing commented on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite

2019-06-30 Thread GitBox
LiShuMing commented on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite URL: https://github.com/apache/spark/pull/24998#issuecomment-507128537 In `core/test` module, only this unittest failed. Maybe I need check other modules? -

[GitHub] [spark] cloud-fan closed pull request #25004: [SPARK-28205][SQL] useV1SourceList configuration should be for all data sources

2019-06-30 Thread GitBox
cloud-fan closed pull request #25004: [SPARK-28205][SQL] useV1SourceList configuration should be for all data sources URL: https://github.com/apache/spark/pull/25004 This is an automated message from the Apache Git Service.

[GitHub] [spark] jerryshao commented on a change in pull request #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-06-30 Thread GitBox
jerryshao commented on a change in pull request #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#discussion_r298889988 ## File path: core/src/main/java/org/apache/spark/api/shuffle/ShuffleDataIO.java ## @

[GitHub] [spark] cloud-fan commented on issue #25004: [SPARK-28205][SQL] useV1SourceList configuration should be for all data sources

2019-06-30 Thread GitBox
cloud-fan commented on issue #25004: [SPARK-28205][SQL] useV1SourceList configuration should be for all data sources URL: https://github.com/apache/spark/pull/25004#issuecomment-507127467 thanks, merging to master! This is an

[GitHub] [spark] cloud-fan commented on issue #24960: [SPARK-28156][SQL] Self-join should not miss cached view

2019-06-30 Thread GitBox
cloud-fan commented on issue #24960: [SPARK-28156][SQL] Self-join should not miss cached view URL: https://github.com/apache/spark/pull/24960#issuecomment-507127363 Another idea: shall we apply `AliasViewChild` right before `EliminateView`? -

[GitHub] [spark] turboFei commented on a change in pull request #24992: [SPARK-28194][SQL] Refactor code to prevent None.get in EnsureRequirements

2019-06-30 Thread GitBox
turboFei commented on a change in pull request #24992: [SPARK-28194][SQL] Refactor code to prevent None.get in EnsureRequirements URL: https://github.com/apache/spark/pull/24992#discussion_r298889535 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Ensu

[GitHub] [spark] jerryshao commented on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite

2019-06-30 Thread GitBox
jerryshao commented on issue #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite URL: https://github.com/apache/spark/pull/24998#issuecomment-507126499 I would guess that other tests will also be failed possibly if you have local modified properties. Have you

[GitHub] [spark] turboFei commented on a change in pull request #24992: [SPARK-28194][SQL] Refactor code to prevent None.get in EnsureRequirements

2019-06-30 Thread GitBox
turboFei commented on a change in pull request #24992: [SPARK-28194][SQL] Refactor code to prevent None.get in EnsureRequirements URL: https://github.com/apache/spark/pull/24992#discussion_r298889300 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Ensu

[GitHub] [spark] maropu commented on a change in pull request #24992: [SPARK-28194][SQL] Refactor code to prevent None.get in EnsureRequirements

2019-06-30 Thread GitBox
maropu commented on a change in pull request #24992: [SPARK-28194][SQL] Refactor code to prevent None.get in EnsureRequirements URL: https://github.com/apache/spark/pull/24992#discussion_r29620 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Ensure

[GitHub] [spark] cloud-fan commented on a change in pull request #24738: [SPARK-23098][SQL] Migrate Kafka Batch source to v2.

2019-06-30 Thread GitBox
cloud-fan commented on a change in pull request #24738: [SPARK-23098][SQL] Migrate Kafka Batch source to v2. URL: https://github.com/apache/spark/pull/24738#discussion_r298887969 ## File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchStrea

[GitHub] [spark] SparkQA commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-06-30 Thread GitBox
SparkQA commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-507124499 **[Test build #107060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107060/testRe

[GitHub] [spark] AngersZhuuuu commented on issue #25015: [SPARK-28217][SQL] Allow a pluggable statistics plan visitor for a logical plan.

2019-06-30 Thread GitBox
AngersZh commented on issue #25015: [SPARK-28217][SQL] Allow a pluggable statistics plan visitor for a logical plan. URL: https://github.com/apache/spark/pull/25015#issuecomment-507124404 [SPARK-27602] (https://issues.apache.org/jira/browse/SPARK-27602) I've thought about doing t

[GitHub] [spark] turboFei commented on a change in pull request #24992: [SPARK-28194][SQL] Refactor code to prevent None.get in EnsureRequirements

2019-06-30 Thread GitBox
turboFei commented on a change in pull request #24992: [SPARK-28194][SQL] Refactor code to prevent None.get in EnsureRequirements URL: https://github.com/apache/spark/pull/24992#discussion_r298887634 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Ensu

[GitHub] [spark] turboFei removed a comment on issue #24992: [SPARK-28194][SQL] Refactor code to prevent None.get in EnsureRequirements

2019-06-30 Thread GitBox
turboFei removed a comment on issue #24992: [SPARK-28194][SQL] Refactor code to prevent None.get in EnsureRequirements URL: https://github.com/apache/spark/pull/24992#issuecomment-507123648 Yes, it is a bug. ![image](https://user-images.githubusercontent.com/6757692/60413014-fde62a00-9c

[GitHub] [spark] AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-507124116 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-507124120 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:/

[GitHub] [spark] AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-507124116 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-507124120 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.

[GitHub] [spark] turboFei commented on issue #24992: [SPARK-28194][SQL] Refactor code to prevent None.get in EnsureRequirements

2019-06-30 Thread GitBox
turboFei commented on issue #24992: [SPARK-28194][SQL] Refactor code to prevent None.get in EnsureRequirements URL: https://github.com/apache/spark/pull/24992#issuecomment-507123648 Yes, it is a bug. ![image](https://user-images.githubusercontent.com/6757692/60413014-fde62a00-9c05-11e9-

[GitHub] [spark] cloud-fan commented on issue #24978: [SPARK-28177][SQL] Adjust post shuffle partition number in adaptive execution

2019-06-30 Thread GitBox
cloud-fan commented on issue #24978: [SPARK-28177][SQL] Adjust post shuffle partition number in adaptive execution URL: https://github.com/apache/spark/pull/24978#issuecomment-507123632 LGTM This is an automated message from

[GitHub] [spark] xianyinxin commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-06-30 Thread GitBox
xianyinxin commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-507123598 retest this please This is an automated message

[GitHub] [spark] cloud-fan commented on a change in pull request #24978: [SPARK-28177][SQL] Adjust post shuffle partition number in adaptive execution

2019-06-30 Thread GitBox
cloud-fan commented on a change in pull request #24978: [SPARK-28177][SQL] Adjust post shuffle partition number in adaptive execution URL: https://github.com/apache/spark/pull/24978#discussion_r298886464 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/

[GitHub] [spark] AngersZhuuuu edited a comment on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first.

2019-06-30 Thread GitBox
AngersZh edited a comment on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first. URL: https://github.com/apache/spark/pull/24909#issuecomment-507122951 @gatorsmile @GregOwen Could you review this again? Thanks -

[GitHub] [spark] AngersZhuuuu commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first.

2019-06-30 Thread GitBox
AngersZh commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first. URL: https://github.com/apache/spark/pull/24909#issuecomment-507122951 @gatorsmile @GregOwen Could you review this again? ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion URL: https://github.com/apache/spark/pull/24963#issuecomment-507117221 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion URL: https://github.com/apache/spark/pull/24963#issuecomment-507117224 Test PASSed. Refer to this link for build results (access rights to CI server ne

[GitHub] [spark] AmplabJenkins commented on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion URL: https://github.com/apache/spark/pull/24963#issuecomment-507117224 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion URL: https://github.com/apache/spark/pull/24963#issuecomment-507117221 Merged build finished. Test PASSed. --

[GitHub] [spark] SparkQA removed a comment on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion

2019-06-30 Thread GitBox
SparkQA removed a comment on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion URL: https://github.com/apache/spark/pull/24963#issuecomment-507107652 **[Test build #107058 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullR

[GitHub] [spark] SparkQA commented on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion

2019-06-30 Thread GitBox
SparkQA commented on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion URL: https://github.com/apache/spark/pull/24963#issuecomment-507117059 **[Test build #107058 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestB

[GitHub] [spark] SparkQA commented on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message

2019-06-30 Thread GitBox
SparkQA commented on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message URL: https://github.com/apache/spark/pull/25019#issuecomment-507111962 **[Test build #107059 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPull

[GitHub] [spark] AmplabJenkins removed a comment on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message URL: https://github.com/apache/spark/pull/25019#issuecomment-507111666 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message URL: https://github.com/apache/spark/pull/25019#issuecomment-507111665 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins commented on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message URL: https://github.com/apache/spark/pull/25019#issuecomment-507111666 Test PASSed. Refer to this link for build results (access rights to CI server n

[GitHub] [spark] AmplabJenkins commented on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message URL: https://github.com/apache/spark/pull/25019#issuecomment-507111665 Merged build finished. Test PASSed. -

[GitHub] [spark] maropu commented on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message

2019-06-30 Thread GitBox
maropu commented on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message URL: https://github.com/apache/spark/pull/25019#issuecomment-507111650 This issue only exists in INSERT command? Probably, you'd be better to make the title an

[GitHub] [spark] maropu commented on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message

2019-06-30 Thread GitBox
maropu commented on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message URL: https://github.com/apache/spark/pull/25019#issuecomment-507111332 ok to test This is an a

[GitHub] [spark] AmplabJenkins removed a comment on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #25019: [SPARK-28195][SQL] Fix CheckAnalysis not working for command and report misleading error message URL: https://github.com/apache/spark/pull/25019#issuecomment-507110740 Can one of the admins verify this patch?

[GitHub] [spark] HyukjinKwon closed pull request #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API

2019-06-30 Thread GitBox
HyukjinKwon closed pull request #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API URL: https://github.com/apache/spark/pull/25012 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on a change in pull request #25016: [SPARK-28200][SQL] Decimal overflow handling in ExpressionEncoder

2019-06-30 Thread GitBox
cloud-fan commented on a change in pull request #25016: [SPARK-28200][SQL] Decimal overflow handling in ExpressionEncoder URL: https://github.com/apache/spark/pull/25016#discussion_r298877783 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/Expressio

[GitHub] [spark] AmplabJenkins removed a comment on issue #25019: [SPARK-28195]Fix CheckAnalysis not working for command and report misleading error message

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #25019: [SPARK-28195]Fix CheckAnalysis not working for command and report misleading error message URL: https://github.com/apache/spark/pull/25019#issuecomment-507110404 Can one of the admins verify this patch? --

[GitHub] [spark] AmplabJenkins commented on issue #25019: [SPARK-28195]Fix CheckAnalysis not working for command and report misleading error message

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #25019: [SPARK-28195]Fix CheckAnalysis not working for command and report misleading error message URL: https://github.com/apache/spark/pull/25019#issuecomment-507110740 Can one of the admins verify this patch? --

[GitHub] [spark] AmplabJenkins commented on issue #25019: [SPARK-28195]Fix CheckAnalysis not working for command and report misleading error message

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #25019: [SPARK-28195]Fix CheckAnalysis not working for command and report misleading error message URL: https://github.com/apache/spark/pull/25019#issuecomment-507110326 Can one of the admins verify this patch? --

[GitHub] [spark] AmplabJenkins commented on issue #25019: [SPARK-28195]Fix CheckAnalysis not working for command and report misleading error message

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #25019: [SPARK-28195]Fix CheckAnalysis not working for command and report misleading error message URL: https://github.com/apache/spark/pull/25019#issuecomment-507110404 Can one of the admins verify this patch? --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25019: [SPARK-28195]Fix CheckAnalysis not working for command and report misleading error message

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #25019: [SPARK-28195]Fix CheckAnalysis not working for command and report misleading error message URL: https://github.com/apache/spark/pull/25019#issuecomment-507110326 Can one of the admins verify this patch? --

[GitHub] [spark] liupc opened a new pull request #25019: [SPARK-28195]Fix CheckAnalysis not working for command and report misleading error message

2019-06-30 Thread GitBox
liupc opened a new pull request #25019: [SPARK-28195]Fix CheckAnalysis not working for command and report misleading error message URL: https://github.com/apache/spark/pull/25019 ## What changes were proposed in this pull request? This PR will try to fix the issue that the sub pl

[GitHub] [spark] HyukjinKwon commented on issue #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API

2019-06-30 Thread GitBox
HyukjinKwon commented on issue #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API URL: https://github.com/apache/spark/pull/25012#issuecomment-507110218 Merged to master. This is an automated message from th

[GitHub] [spark] itsvikramagr commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-06-30 Thread GitBox
itsvikramagr commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r298875972 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/WALUtils.sca

[GitHub] [spark] AmplabJenkins removed a comment on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion URL: https://github.com/apache/spark/pull/24963#issuecomment-507108414 Test PASSed. Refer to this link for build results (access rights to CI server ne

[GitHub] [spark] AmplabJenkins removed a comment on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion URL: https://github.com/apache/spark/pull/24963#issuecomment-507108411 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins commented on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion URL: https://github.com/apache/spark/pull/24963#issuecomment-507108414 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion URL: https://github.com/apache/spark/pull/24963#issuecomment-507108411 Merged build finished. Test PASSed. --

[GitHub] [spark] itsvikramagr commented on issue #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-06-30 Thread GitBox
itsvikramagr commented on issue #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#issuecomment-507108250 Thanks, @HeartSaVioR for the review. Let me work on your comments. Also, I am looking into generating performance numbers f

[GitHub] [spark] SparkQA commented on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion

2019-06-30 Thread GitBox
SparkQA commented on issue #24963: [SPARK-28159][ML] Make the transform natively in ml framework to avoid extra conversion URL: https://github.com/apache/spark/pull/24963#issuecomment-507107652 **[Test build #107058 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBu

[GitHub] [spark] cloud-fan closed pull request #25010: [SPARK-28201][SQL] Revisit MakeDecimal behavior on overflow

2019-06-30 Thread GitBox
cloud-fan closed pull request #25010: [SPARK-28201][SQL] Revisit MakeDecimal behavior on overflow URL: https://github.com/apache/spark/pull/25010 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [spark] cloud-fan commented on issue #25010: [SPARK-28201][SQL] Revisit MakeDecimal behavior on overflow

2019-06-30 Thread GitBox
cloud-fan commented on issue #25010: [SPARK-28201][SQL] Revisit MakeDecimal behavior on overflow URL: https://github.com/apache/spark/pull/25010#issuecomment-507106833 thanks, merging to master! This is an automated message f

[GitHub] [spark] AmplabJenkins removed a comment on issue #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API URL: https://github.com/apache/spark/pull/25012#issuecomment-507106133 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API URL: https://github.com/apache/spark/pull/25012#issuecomment-507106139 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.c

[GitHub] [spark] SparkQA removed a comment on issue #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API

2019-06-30 Thread GitBox
SparkQA removed a comment on issue #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API URL: https://github.com/apache/spark/pull/25012#issuecomment-507099969 **[Test build #107056 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107056/testRe

[GitHub] [spark] AmplabJenkins commented on issue #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API URL: https://github.com/apache/spark/pull/25012#issuecomment-507106133 Merged build finished. Test PASSed. This is an autom

[GitHub] [spark] AmplabJenkins commented on issue #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API URL: https://github.com/apache/spark/pull/25012#issuecomment-507106139 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkel

[GitHub] [spark] SparkQA commented on issue #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API

2019-06-30 Thread GitBox
SparkQA commented on issue #25012: [SPARK-28215][SQL][R] as_tibble was removed from Arrow R API URL: https://github.com/apache/spark/pull/25012#issuecomment-507106090 **[Test build #107056 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107056/testReport)**

[GitHub] [spark] cloud-fan commented on a change in pull request #24795: [SPARK-27945][SQL] Minimal changes to support columnar processing

2019-06-30 Thread GitBox
cloud-fan commented on a change in pull request #24795: [SPARK-27945][SQL] Minimal changes to support columnar processing URL: https://github.com/apache/spark/pull/24795#discussion_r298873668 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scal

[GitHub] [spark] cloud-fan commented on a change in pull request #24795: [SPARK-27945][SQL] Minimal changes to support columnar processing

2019-06-30 Thread GitBox
cloud-fan commented on a change in pull request #24795: [SPARK-27945][SQL] Minimal changes to support columnar processing URL: https://github.com/apache/spark/pull/24795#discussion_r298873668 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scal

[GitHub] [spark] AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-507101280 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://

[GitHub] [spark] HyukjinKwon commented on issue #24946: [SPARK-27234][SS][PYTHON] Use InheritableThreadLocal for current epoch in EpochTracker (to support Python UDFs)

2019-06-30 Thread GitBox
HyukjinKwon commented on issue #24946: [SPARK-27234][SS][PYTHON] Use InheritableThreadLocal for current epoch in EpochTracker (to support Python UDFs) URL: https://github.com/apache/spark/pull/24946#issuecomment-507101455 gentle ping .. :-) .. -

[GitHub] [spark] HyukjinKwon commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-06-30 Thread GitBox
HyukjinKwon commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-507101426 gentle ping .. :-) .. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-06-30 Thread GitBox
AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-507101274 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-06-30 Thread GitBox
SparkQA removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-507101082 **[Test build #107057 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/10705

[GitHub] [spark] AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-507101274 Merged build finished. Test FAILed. This is

[GitHub] [spark] AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-06-30 Thread GitBox
AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-507101280 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.c

  1   2   3   >