[GitHub] [spark] AmplabJenkins removed a comment on issue #25834: [WIP][SPARK-29155][SQL] Support special date/timestamp values in the PostgreSQL dialect only

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25834: [WIP][SPARK-29155][SQL] Support special date/timestamp values in the PostgreSQL dialect only URL: https://github.com/apache/spark/pull/25834#issuecomment-532978569 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25834: [WIP][SPARK-29155][SQL] Support special date/timestamp values in the PostgreSQL dialect only

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25834: [WIP][SPARK-29155][SQL] Support special date/timestamp values in the PostgreSQL dialect only URL: https://github.com/apache/spark/pull/25834#issuecomment-532978575 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #25834: [WIP][SPARK-29155][SQL] Support special date/timestamp values in the PostgreSQL dialect only

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25834: [WIP][SPARK-29155][SQL] Support special date/timestamp values in the PostgreSQL dialect only URL: https://github.com/apache/spark/pull/25834#issuecomment-532978575 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25834: [WIP][SPARK-29155][SQL] Support special date/timestamp values in the PostgreSQL dialect only

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25834: [WIP][SPARK-29155][SQL] Support special date/timestamp values in the PostgreSQL dialect only URL: https://github.com/apache/spark/pull/25834#issuecomment-532978569 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT URL: https://github.com/apache/spark/pull/25835#issuecomment-532978425 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT URL: https://github.com/apache/spark/pull/25835#issuecomment-532978435 Test PASSed. Refer to this link for build

[GitHub] [spark] AmplabJenkins commented on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT URL: https://github.com/apache/spark/pull/25835#issuecomment-532978425 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #25834: [WIP][SPARK-29155][SQL] Support special date/timestamp values in the PostgreSQL dialect only

2019-09-18 Thread GitBox
SparkQA commented on issue #25834: [WIP][SPARK-29155][SQL] Support special date/timestamp values in the PostgreSQL dialect only URL: https://github.com/apache/spark/pull/25834#issuecomment-532978223 **[Test build #110973 has

[GitHub] [spark] AmplabJenkins commented on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT URL: https://github.com/apache/spark/pull/25835#issuecomment-532978435 Test PASSed. Refer to this link for build results

[GitHub] [spark] SparkQA removed a comment on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT

2019-09-18 Thread GitBox
SparkQA removed a comment on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT URL: https://github.com/apache/spark/pull/25835#issuecomment-532922053 **[Test build #110953 has

[GitHub] [spark] sarutak commented on a change in pull request #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view

2019-09-18 Thread GitBox
sarutak commented on a change in pull request #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view URL: https://github.com/apache/spark/pull/25846#discussion_r325998724 ## File path: core/src/main/resources/org/apache/spark/ui/static/timeline-view.css ##

[GitHub] [spark] SparkQA commented on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT

2019-09-18 Thread GitBox
SparkQA commented on issue #25835: [SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT URL: https://github.com/apache/spark/pull/25835#issuecomment-532977764 **[Test build #110953 has

[GitHub] [spark] imback82 commented on issue #25771: [SPARK-28970][SQL] Implement USE CATALOG/NAMESPACE for Data Source V2

2019-09-18 Thread GitBox
imback82 commented on issue #25771: [SPARK-28970][SQL] Implement USE CATALOG/NAMESPACE for Data Source V2 URL: https://github.com/apache/spark/pull/25771#issuecomment-532975834 @cloud-fan I noticed that three hive-thriftserver related tests were failing after this change because of

[GitHub] [spark] MaxGekk commented on issue #25708: [SPARK-28141][SQL] Support special date values

2019-09-18 Thread GitBox
MaxGekk commented on issue #25708: [SPARK-28141][SQL] Support special date values URL: https://github.com/apache/spark/pull/25708#issuecomment-532975906 I have rebased this on the master with merged https://github.com/apache/spark/pull/25716 . @HyukjinKwon Could you take a look at this,

[GitHub] [spark] MaxGekk commented on a change in pull request #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks

2019-09-18 Thread GitBox
MaxGekk commented on a change in pull request #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks URL: https://github.com/apache/spark/pull/25828#discussion_r325994572 ## File path: sql/core/benchmarks/DataSourceReadBenchmark-results.txt ## @@ -2,251

[GitHub] [spark] MaxGekk commented on a change in pull request #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks

2019-09-18 Thread GitBox
MaxGekk commented on a change in pull request #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks URL: https://github.com/apache/spark/pull/25828#discussion_r325994572 ## File path: sql/core/benchmarks/DataSourceReadBenchmark-results.txt ## @@ -2,251

[GitHub] [spark] gatorsmile closed pull request #25693: [SPARK-28989][SQL] Add a SQLConf `spark.sql.ansi.enabled`

2019-09-18 Thread GitBox
gatorsmile closed pull request #25693: [SPARK-28989][SQL] Add a SQLConf `spark.sql.ansi.enabled` URL: https://github.com/apache/spark/pull/25693 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] gatorsmile commented on issue #25693: [SPARK-28989][SQL] Add a SQLConf `spark.sql.ansi.enabled`

2019-09-18 Thread GitBox
gatorsmile commented on issue #25693: [SPARK-28989][SQL] Add a SQLConf `spark.sql.ansi.enabled` URL: https://github.com/apache/spark/pull/25693#issuecomment-532972576 LGTM Thanks! Merged to master. This is an

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks

2019-09-18 Thread GitBox
dongjoon-hyun commented on a change in pull request #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks URL: https://github.com/apache/spark/pull/25828#discussion_r325994228 ## File path: sql/core/benchmarks/DataSourceReadBenchmark-results.txt ## @@

[GitHub] [spark] MaxGekk commented on a change in pull request #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks

2019-09-18 Thread GitBox
MaxGekk commented on a change in pull request #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks URL: https://github.com/apache/spark/pull/25828#discussion_r325994058 ## File path: sql/core/benchmarks/DataSourceReadBenchmark-results.txt ## @@ -2,251

[GitHub] [spark] HyukjinKwon commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file

2019-09-18 Thread GitBox
HyukjinKwon commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file URL: https://github.com/apache/spark/pull/25845#issuecomment-532971687 @HeartSaVioR, if you concern about compatibility, you could leave a note in migration guide at

[GitHub] [spark] AmplabJenkins removed a comment on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view URL: https://github.com/apache/spark/pull/25846#issuecomment-532971416 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view URL: https://github.com/apache/spark/pull/25846#issuecomment-532971411 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view URL: https://github.com/apache/spark/pull/25846#issuecomment-532971416 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view URL: https://github.com/apache/spark/pull/25846#issuecomment-532971411 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA commented on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view

2019-09-18 Thread GitBox
SparkQA commented on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view URL: https://github.com/apache/spark/pull/25846#issuecomment-532971146 **[Test build #110972 has

[GitHub] [spark] zhengruifeng commented on a change in pull request #25802: [SPARK-29095][ML] add extractInstances

2019-09-18 Thread GitBox
zhengruifeng commented on a change in pull request #25802: [SPARK-29095][ML] add extractInstances URL: https://github.com/apache/spark/pull/25802#discussion_r325993291 ## File path: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala ## @@ -62,6 +62,40 @@ private[ml]

[GitHub] [spark] MaxGekk commented on a change in pull request #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks

2019-09-18 Thread GitBox
MaxGekk commented on a change in pull request #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks URL: https://github.com/apache/spark/pull/25828#discussion_r325993197 ## File path: sql/core/benchmarks/DataSourceReadBenchmark-results.txt ## @@ -2,251

[GitHub] [spark] dongjoon-hyun commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
dongjoon-hyun commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532970669 Thank you, @srowen and @HyukjinKwon . Since there is no other option, we had better merge this PR~

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
dongjoon-hyun edited a comment on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532970077 @srowen . I took a look. `UseCodeCacheFlushing` was introduced at JDK6 by default `false`, but was changed at

[GitHub] [spark] AmplabJenkins removed a comment on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view URL: https://github.com/apache/spark/pull/25846#issuecomment-532969772 Can one of the admins verify this patch?

[GitHub] [spark] dongjoon-hyun commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
dongjoon-hyun commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532970077 @srowen . I took a look. `UseCodeCacheFlushing` was introduced at JDK6 by default `false`, but was changed at JDK7 by

[GitHub] [spark] sarutak commented on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view

2019-09-18 Thread GitBox
sarutak commented on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view URL: https://github.com/apache/spark/pull/25846#issuecomment-532970022 ok to test. This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view URL: https://github.com/apache/spark/pull/25846#issuecomment-532969485 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view URL: https://github.com/apache/spark/pull/25846#issuecomment-532969772 Can one of the admins verify this patch? This is

[GitHub] [spark] wangyum commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-09-18 Thread GitBox
wangyum commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-532969472 @tooptoop4 I think it's different things.

[GitHub] [spark] AmplabJenkins commented on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view URL: https://github.com/apache/spark/pull/25846#issuecomment-532969485 Can one of the admins verify this patch? This is

[GitHub] [spark] dongjoon-hyun commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern

2019-09-18 Thread GitBox
dongjoon-hyun commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern URL: https://github.com/apache/spark/pull/25842#issuecomment-532968870 Thank you for review. I transformed the test cases, too.

[GitHub] [spark] TomokoKomiyama opened a new pull request #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view

2019-09-18 Thread GitBox
TomokoKomiyama opened a new pull request #25846: [SPARK-29168][WebUI] Fix the appearance issue on timeline view URL: https://github.com/apache/spark/pull/25846 ### What changes were proposed in this pull request? Changed color settings in .vis-timeline

[GitHub] [spark] AmplabJenkins removed a comment on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern URL: https://github.com/apache/spark/pull/25842#issuecomment-532968476 Merged build finished. Test PASSed. This is

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable

2019-09-18 Thread GitBox
AngersZh commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable URL: https://github.com/apache/spark/pull/25844#discussion_r325991432 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern URL: https://github.com/apache/spark/pull/25842#issuecomment-532968479 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern URL: https://github.com/apache/spark/pull/25842#issuecomment-532968479 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern URL: https://github.com/apache/spark/pull/25842#issuecomment-532968476 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern

2019-09-18 Thread GitBox
SparkQA commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern URL: https://github.com/apache/spark/pull/25842#issuecomment-532968268 **[Test build #110970 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110970/testReport)**

[GitHub] [spark] SparkQA commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold

2019-09-18 Thread GitBox
SparkQA commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold URL: https://github.com/apache/spark/pull/25829#issuecomment-532968269 **[Test build #110971 has

[GitHub] [spark] imback82 commented on a change in pull request #25771: [SPARK-28970][SQL] Implement USE CATALOG/NAMESPACE for Data Source V2

2019-09-18 Thread GitBox
imback82 commented on a change in pull request #25771: [SPARK-28970][SQL] Implement USE CATALOG/NAMESPACE for Data Source V2 URL: https://github.com/apache/spark/pull/25771#discussion_r325990343 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold URL: https://github.com/apache/spark/pull/25829#issuecomment-532967138 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold URL: https://github.com/apache/spark/pull/25829#issuecomment-532967140 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold URL: https://github.com/apache/spark/pull/25829#issuecomment-532967138 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold URL: https://github.com/apache/spark/pull/25829#issuecomment-532967140 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] zhengruifeng commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold

2019-09-18 Thread GitBox
zhengruifeng commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold URL: https://github.com/apache/spark/pull/25829#issuecomment-532966941 retest this please This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks URL: https://github.com/apache/spark/pull/25828#issuecomment-532965921 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532965987 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532965992 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks URL: https://github.com/apache/spark/pull/25828#issuecomment-532965925 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] maropu commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable

2019-09-18 Thread GitBox
maropu commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable URL: https://github.com/apache/spark/pull/25844#discussion_r325989089 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532965987 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532965992 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected URL: https://github.com/apache/spark/pull/25843#issuecomment-532965766 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected URL: https://github.com/apache/spark/pull/25843#issuecomment-532965773 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks URL: https://github.com/apache/spark/pull/25828#issuecomment-532965925 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks URL: https://github.com/apache/spark/pull/25828#issuecomment-532965921 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file URL: https://github.com/apache/spark/pull/25845#issuecomment-532964191 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected URL: https://github.com/apache/spark/pull/25843#issuecomment-532965766 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks

2019-09-18 Thread GitBox
SparkQA removed a comment on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks URL: https://github.com/apache/spark/pull/25828#issuecomment-532905800 **[Test build #110947 has

[GitHub] [spark] AmplabJenkins commented on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected URL: https://github.com/apache/spark/pull/25843#issuecomment-532965773 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
SparkQA removed a comment on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532930208 **[Test build #110957 has

[GitHub] [spark] SparkQA commented on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected

2019-09-18 Thread GitBox
SparkQA commented on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected URL: https://github.com/apache/spark/pull/25843#issuecomment-532965537 **[Test build #110969 has

[GitHub] [spark] SparkQA commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G

2019-09-18 Thread GitBox
SparkQA commented on issue #25836: [SPARK-29159][BUILD] Increase ReservedCodeCacheSize to 1G URL: https://github.com/apache/spark/pull/25836#issuecomment-532965604 **[Test build #110957 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110957/testReport)**

[GitHub] [spark] SparkQA commented on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks

2019-09-18 Thread GitBox
SparkQA commented on issue #25828: [SPARK-29141][SQL][TEST] Use SqlBasedBenchmark in SQL benchmarks URL: https://github.com/apache/spark/pull/25828#issuecomment-532965588 **[Test build #110947 has

[GitHub] [spark] SparkQA commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file

2019-09-18 Thread GitBox
SparkQA commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file URL: https://github.com/apache/spark/pull/25845#issuecomment-532965539 **[Test build #110968 has

[GitHub] [spark] maropu commented on a change in pull request #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-09-18 Thread GitBox
maropu commented on a change in pull request #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#discussion_r325983692 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/window_part1.sql ## @@ -0,0

[GitHub] [spark] maropu commented on a change in pull request #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-09-18 Thread GitBox
maropu commented on a change in pull request #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#discussion_r325988295 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/window_part1.sql ## @@ -0,0

[GitHub] [spark] maropu commented on a change in pull request #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-09-18 Thread GitBox
maropu commented on a change in pull request #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#discussion_r325987766 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/window_part1.sql ## @@ -0,0

[GitHub] [spark] maropu commented on a change in pull request #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-09-18 Thread GitBox
maropu commented on a change in pull request #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#discussion_r325986810 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/window_part1.sql ## @@ -0,0

[GitHub] [spark] dongjoon-hyun commented on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected

2019-09-18 Thread GitBox
dongjoon-hyun commented on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected URL: https://github.com/apache/spark/pull/25843#issuecomment-532964914 Retest this please. This

[GitHub] [spark] dongjoon-hyun closed pull request #25841: [SPARK-28683][BUILD][FOLLOW-UP][2.4] Fix javadoc generation issue after upgrading genjavadoc to 0.14

2019-09-18 Thread GitBox
dongjoon-hyun closed pull request #25841: [SPARK-28683][BUILD][FOLLOW-UP][2.4] Fix javadoc generation issue after upgrading genjavadoc to 0.14 URL: https://github.com/apache/spark/pull/25841 This is an automated message

[GitHub] [spark] HeartSaVioR commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file

2019-09-18 Thread GitBox
HeartSaVioR commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file URL: https://github.com/apache/spark/pull/25845#issuecomment-532964896 We might be able to remedy the backward incompatible change via having new option to let

[GitHub] [spark] cloud-fan commented on a change in pull request #25771: [SPARK-28970][SQL] Implement USE CATALOG/NAMESPACE for Data Source V2

2019-09-18 Thread GitBox
cloud-fan commented on a change in pull request #25771: [SPARK-28970][SQL] Implement USE CATALOG/NAMESPACE for Data Source V2 URL: https://github.com/apache/spark/pull/25771#discussion_r325987967 ## File path:

[GitHub] [spark] dongjoon-hyun commented on issue #25841: [SPARK-28683][BUILD][FOLLOW-UP][2.4] Fix javadoc generation issue after upgrading genjavadoc to 0.14

2019-09-18 Thread GitBox
dongjoon-hyun commented on issue #25841: [SPARK-28683][BUILD][FOLLOW-UP][2.4] Fix javadoc generation issue after upgrading genjavadoc to 0.14 URL: https://github.com/apache/spark/pull/25841#issuecomment-532964585 I'll merge this because this is verified manually and currently blocks the

[GitHub] [spark] AmplabJenkins commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file URL: https://github.com/apache/spark/pull/25845#issuecomment-532964191 Can one of the admins verify this patch?

[GitHub] [spark] HeartSaVioR commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file

2019-09-18 Thread GitBox
HeartSaVioR commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file URL: https://github.com/apache/spark/pull/25845#issuecomment-532964064 As I commented in `Does this PR introduce any user-facing change?` section, it may not be backward

[GitHub] [spark] HeartSaVioR opened a new pull request #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file

2019-09-18 Thread GitBox
HeartSaVioR opened a new pull request #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file URL: https://github.com/apache/spark/pull/25845 ### What changes were proposed in this pull request? Credit to @vanzin as he found and commented on this while

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable

2019-09-18 Thread GitBox
AngersZh commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable URL: https://github.com/apache/spark/pull/25844#discussion_r325987334 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-532962979 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-532962975 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-532962975 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-532962979 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
SparkQA removed a comment on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-532928842 **[Test build #110956 has

[GitHub] [spark] SparkQA commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-18 Thread GitBox
SparkQA commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-532962592 **[Test build #110956 has

[GitHub] [spark] LantaoJin commented on a change in pull request #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table

2019-09-18 Thread GitBox
LantaoJin commented on a change in pull request #25840: [SPARK-29166][SQL] Add a parameter to limit the number of dynamic partitions for data source table URL: https://github.com/apache/spark/pull/25840#discussion_r325985789 ## File path:

[GitHub] [spark] wangyum commented on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package

2019-09-18 Thread GitBox
wangyum commented on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package URL: https://github.com/apache/spark/pull/25022#issuecomment-532961590 @MaxGekk WDYT? This is an automated

[GitHub] [spark] wangyum commented on issue #25817: [SPARK-29108][SQL][TESTS] Port window.sql (Part 2)

2019-09-18 Thread GitBox
wangyum commented on issue #25817: [SPARK-29108][SQL][TESTS] Port window.sql (Part 2) URL: https://github.com/apache/spark/pull/25817#issuecomment-532960337 Yes. We also need to drop `numerics`: https://github.com/apache/spark/pull/25817/files#diff-67dcfa1c6f3eddf7e1f24e5cfa300302R205

[GitHub] [spark] AmplabJenkins removed a comment on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected URL: https://github.com/apache/spark/pull/25843#issuecomment-532959780 Test FAILed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected

2019-09-18 Thread GitBox
AmplabJenkins removed a comment on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected URL: https://github.com/apache/spark/pull/25843#issuecomment-532959777 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA removed a comment on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected

2019-09-18 Thread GitBox
SparkQA removed a comment on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected URL: https://github.com/apache/spark/pull/25843#issuecomment-532955059 **[Test build #110966 has

[GitHub] [spark] AmplabJenkins commented on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected URL: https://github.com/apache/spark/pull/25843#issuecomment-532959777 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA commented on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected

2019-09-18 Thread GitBox
SparkQA commented on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected URL: https://github.com/apache/spark/pull/25843#issuecomment-532959757 **[Test build #110966 has

[GitHub] [spark] AmplabJenkins commented on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected

2019-09-18 Thread GitBox
AmplabJenkins commented on issue #25843: [SPARK-29101][SQL][2.4] Fix count API for csv file when DROPMALFORMED mode is selected URL: https://github.com/apache/spark/pull/25843#issuecomment-532959780 Test FAILed. Refer to this link for build results (access rights to CI server needed):

  1   2   3   4   5   6   7   8   9   10   >