[GitHub] [spark] SparkQA commented on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-01-26 Thread GitBox
SparkQA commented on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT URL: https://github.com/apache/spark/pull/27058#issuecomment-578629266 **[Test build #117434 has

[GitHub] [spark] AmplabJenkins commented on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT URL: https://github.com/apache/spark/pull/27058#issuecomment-578625013 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT URL: https://github.com/apache/spark/pull/27058#issuecomment-578625016 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT URL: https://github.com/apache/spark/pull/27058#issuecomment-578625013 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT URL: https://github.com/apache/spark/pull/27058#issuecomment-578625016 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578621322 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578621317 Merged build finished. Test FAILed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578621322 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578621317 Merged build finished. Test FAILed. This is an

[GitHub] [spark] SparkQA commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
SparkQA commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578621153 **[Test build #117433 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117433/testReport)**

[GitHub] [spark] SparkQA removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
SparkQA removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578619376 **[Test build #117433 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT URL: https://github.com/apache/spark/pull/27058#issuecomment-578620873 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT URL: https://github.com/apache/spark/pull/27058#issuecomment-578620862 Build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578620910 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578620910 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578620914 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT URL: https://github.com/apache/spark/pull/27058#issuecomment-578620862 Build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT URL: https://github.com/apache/spark/pull/27058#issuecomment-578620873 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578620914 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] xuzikun2003 commented on a change in pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-01-26 Thread GitBox
xuzikun2003 commented on a change in pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec URL: https://github.com/apache/spark/pull/27019#discussion_r371088520 ## File path:

[GitHub] [spark] SparkQA commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
SparkQA commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578619376 **[Test build #117433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117433/testReport)**

[GitHub] [spark] gatorsmile commented on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table"

2020-01-26 Thread GitBox
gatorsmile commented on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table" URL: https://github.com/apache/spark/pull/24938#issuecomment-578618967 ping @viirya Do you think we can finish it before the code freeze?

[GitHub] [spark] SparkQA commented on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-01-26 Thread GitBox
SparkQA commented on issue #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT URL: https://github.com/apache/spark/pull/27058#issuecomment-578618570 **[Test build #117432 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes URL: https://github.com/apache/spark/pull/27365#issuecomment-578617191 Test PASSed. Refer to this link for build

[GitHub] [spark] AmplabJenkins commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes URL: https://github.com/apache/spark/pull/27365#issuecomment-578617183 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes URL: https://github.com/apache/spark/pull/27365#issuecomment-578617191 Test PASSed. Refer to this link for build results

[GitHub] [spark] AmplabJenkins removed a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes URL: https://github.com/apache/spark/pull/27365#issuecomment-578617183 Merged build finished. Test PASSed.

[GitHub] [spark] beliefer commented on a change in pull request #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-01-26 Thread GitBox
beliefer commented on a change in pull request #27058: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT URL: https://github.com/apache/spark/pull/27058#discussion_r371085072 ## File path:

[GitHub] [spark] SparkQA removed a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes

2020-01-26 Thread GitBox
SparkQA removed a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes URL: https://github.com/apache/spark/pull/27365#issuecomment-578588187 **[Test build #117430 has

[GitHub] [spark] SparkQA commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes

2020-01-26 Thread GitBox
SparkQA commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes URL: https://github.com/apache/spark/pull/27365#issuecomment-578616313 **[Test build #117430 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578615281 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578615276 Merged build finished. Test FAILed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578615276 Merged build finished. Test FAILed. This is an

[GitHub] [spark] SparkQA commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
SparkQA commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578615143 **[Test build #117431 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117431/testReport)**

[GitHub] [spark] AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578615281 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
SparkQA removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578614124 **[Test build #117431 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578615024 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578615024 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578615014 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578615014 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
SparkQA commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578614124 **[Test build #117431 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117431/testReport)**

[GitHub] [spark] sandeep-katta commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD

2020-01-26 Thread GitBox
sandeep-katta commented on issue #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD URL: https://github.com/apache/spark/pull/27021#issuecomment-578611669 @rdblue please review this, I have tested the changes from my end.

[GitHub] [spark] HeartSaVioR commented on a change in pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-01-26 Thread GitBox
HeartSaVioR commented on a change in pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec URL: https://github.com/apache/spark/pull/27019#discussion_r371073779 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-01-26 Thread GitBox
HeartSaVioR commented on a change in pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec URL: https://github.com/apache/spark/pull/27019#discussion_r371073779 ## File path:

[GitHub] [spark] xuzikun2003 commented on a change in pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-01-26 Thread GitBox
xuzikun2003 commented on a change in pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec URL: https://github.com/apache/spark/pull/27019#discussion_r371071649 ## File path:

[GitHub] [spark] dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0

2020-01-26 Thread GitBox
dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-578601545 ? @zero323 . It seems that you missed my point. I advised like the following. > I'd like to recommend you to mention

[GitHub] [spark] HeartSaVioR edited a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes

2020-01-26 Thread GitBox
HeartSaVioR edited a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes URL: https://github.com/apache/spark/pull/27365#issuecomment-578588303 > I think it's also fine to have git enforce it.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes URL: https://github.com/apache/spark/pull/27365#issuecomment-578588611 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes URL: https://github.com/apache/spark/pull/27365#issuecomment-578588614 Test PASSed. Refer to this link for build

[GitHub] [spark] AmplabJenkins commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes URL: https://github.com/apache/spark/pull/27365#issuecomment-578588614 Test PASSed. Refer to this link for build results

[GitHub] [spark] AmplabJenkins commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes URL: https://github.com/apache/spark/pull/27365#issuecomment-578588611 Merged build finished. Test PASSed.

[GitHub] [spark] HeartSaVioR commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes

2020-01-26 Thread GitBox
HeartSaVioR commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes URL: https://github.com/apache/spark/pull/27365#issuecomment-578588303 > I think it's also fine to have git enforce it. Is

[GitHub] [spark] SparkQA commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes

2020-01-26 Thread GitBox
SparkQA commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files, and enforce the EOL for java/scala/xml/py/R files to LF in gitattributes URL: https://github.com/apache/spark/pull/27365#issuecomment-578588187 **[Test build #117430 has

[GitHub] [spark] HeartSaVioR commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files

2020-01-26 Thread GitBox
HeartSaVioR commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files URL: https://github.com/apache/spark/pull/27365#issuecomment-578586936 @dongjoon-hyun `^M` in the PR description is CR/LF, so you may want to type CTRL+V -> CTRL+M in bash shell to get it. I'll update

[GitHub] [spark] zero323 commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0

2020-01-26 Thread GitBox
zero323 commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-578581851 > Please note that I'm supporting your effort on this PR. Otherwise, I'll not chim in here to add comments. Thank you,

[GitHub] [spark] dongjoon-hyun edited a comment on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0

2020-01-26 Thread GitBox
dongjoon-hyun edited a comment on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-578573228 We cannot say `We're good` when we know something wrong. I'd like to recommend you to mention what you've done

[GitHub] [spark] dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0

2020-01-26 Thread GitBox
dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-578573228 We cannot say `We're good` when we know something wrong. I'd like to recommend you to mention what you've done clearly.

[GitHub] [spark] BryanCutler commented on a change in pull request #27358: [SPARK-30640][PYTHON][SQL] Prevent unnecessary copies of data during Arrow to Pandas conversion

2020-01-26 Thread GitBox
BryanCutler commented on a change in pull request #27358: [SPARK-30640][PYTHON][SQL] Prevent unnecessary copies of data during Arrow to Pandas conversion URL: https://github.com/apache/spark/pull/27358#discussion_r371049435 ## File path: python/pyspark/sql/pandas/conversion.py

[GitHub] [spark] zero323 commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0

2020-01-26 Thread GitBox
zero323 commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-578570778 > @zero323 . Thank you for the screencast. However, it skipped all arrow related tests. Please playback the screencast.

[GitHub] [spark] dongjoon-hyun edited a comment on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0

2020-01-26 Thread GitBox
dongjoon-hyun edited a comment on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-578569365 @zero323 . Thank you for the screencast. However, it skipped all arrow related tests. Please playback the

[GitHub] [spark] dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0

2020-01-26 Thread GitBox
dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-578569365 @zero323 . Thank you for the screencast. However, it skipped all arrow related tests.

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0

2020-01-26 Thread GitBox
dongjoon-hyun commented on a change in pull request #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#discussion_r371046762 ## File path: R/pkg/tests/run-all.R ## @@ -60,11 +59,23 @@ if

[GitHub] [spark] zero323 commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0

2020-01-26 Thread GitBox
zero323 commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-578568461 > Please update the PR description. For example, the followings? All done @dongjoon-hyun

[GitHub] [spark] dongjoon-hyun edited a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files

2020-01-26 Thread GitBox
dongjoon-hyun edited a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files URL: https://github.com/apache/spark/pull/27365#issuecomment-578568350 @HeartSaVioR . When I follow the direction in the PR description at the master branch, the result is different. Did I

[GitHub] [spark] dongjoon-hyun commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files

2020-01-26 Thread GitBox
dongjoon-hyun commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files URL: https://github.com/apache/spark/pull/27365#issuecomment-578568350 @HeartSaVioR . When I follow the direction in the PR description, the result is different. Did I miss something? ``` $

[GitHub] [spark] zero323 commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0

2020-01-26 Thread GitBox
zero323 commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-578568240 @HyukjinKwon > @zero323, do you mind if I ask to check R 3.4.x latest and testthat latest combination I'd say

[GitHub] [spark] viirya commented on a change in pull request #27358: [SPARK-30640][PYTHON][SQL] Prevent unnecessary copies of data during Arrow to Pandas conversion

2020-01-26 Thread GitBox
viirya commented on a change in pull request #27358: [SPARK-30640][PYTHON][SQL] Prevent unnecessary copies of data during Arrow to Pandas conversion URL: https://github.com/apache/spark/pull/27358#discussion_r371046394 ## File path: python/pyspark/sql/pandas/conversion.py

[GitHub] [spark] BryanCutler commented on a change in pull request #27358: [SPARK-30640][PYTHON][SQL] Prevent unnecessary copies of data during Arrow to Pandas conversion

2020-01-26 Thread GitBox
BryanCutler commented on a change in pull request #27358: [SPARK-30640][PYTHON][SQL] Prevent unnecessary copies of data during Arrow to Pandas conversion URL: https://github.com/apache/spark/pull/27358#discussion_r371042017 ## File path: python/pyspark/sql/pandas/conversion.py

[GitHub] [spark] siknezevic commented on issue #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-01-26 Thread GitBox
siknezevic commented on issue #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements URL: https://github.com/apache/spark/pull/27246#issuecomment-578559734 I fixed the issues in ExternalAppendOnlyUnsafeRowArray. Next, I coming days will push new PR for

[GitHub] [spark] viirya commented on a change in pull request #27358: [SPARK-30640][PYTHON][SQL] Prevent unnecessary copies of data during Arrow to Pandas conversion

2020-01-26 Thread GitBox
viirya commented on a change in pull request #27358: [SPARK-30640][PYTHON][SQL] Prevent unnecessary copies of data during Arrow to Pandas conversion URL: https://github.com/apache/spark/pull/27358#discussion_r371040215 ## File path: python/pyspark/sql/pandas/conversion.py

[GitHub] [spark] github-actions[bot] commented on issue #18898: [SPARK-21245][ML] Resolve code duplication for classification/regression summarizers

2020-01-26 Thread GitBox
github-actions[bot] commented on issue #18898: [SPARK-21245][ML] Resolve code duplication for classification/regression summarizers URL: https://github.com/apache/spark/pull/18898#issuecomment-578557489 We're closing this PR because it hasn't been updated in a while. This isn't a

[GitHub] [spark] github-actions[bot] closed pull request #23327: [SPARK-26222][SQL] Track file listing time

2020-01-26 Thread GitBox
github-actions[bot] closed pull request #23327: [SPARK-26222][SQL] Track file listing time URL: https://github.com/apache/spark/pull/23327 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] github-actions[bot] commented on issue #20690: [SPARK-23532][Standalone]Improve data locality when launching new executors for dynamic allocation

2020-01-26 Thread GitBox
github-actions[bot] commented on issue #20690: [SPARK-23532][Standalone]Improve data locality when launching new executors for dynamic allocation URL: https://github.com/apache/spark/pull/20690#issuecomment-578557483 We're closing this PR because it hasn't been updated in a while. This

[GitHub] [spark] BryanCutler closed pull request #27358: [SPARK-30640][PYTHON][SQL] Prevent unnecessary copies of data during Arrow to Pandas conversion

2020-01-26 Thread GitBox
BryanCutler closed pull request #27358: [SPARK-30640][PYTHON][SQL] Prevent unnecessary copies of data during Arrow to Pandas conversion URL: https://github.com/apache/spark/pull/27358 This is an automated message from the

[GitHub] [spark] BryanCutler commented on issue #27358: [SPARK-30640][PYTHON][SQL] Prevent unnecessary copies of data during Arrow to Pandas conversion

2020-01-26 Thread GitBox
BryanCutler commented on issue #27358: [SPARK-30640][PYTHON][SQL] Prevent unnecessary copies of data during Arrow to Pandas conversion URL: https://github.com/apache/spark/pull/27358#issuecomment-578553730 This is a pretty minor change, so I'm gonna go ahead and merge

[GitHub] [spark] AmplabJenkins commented on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType URL: https://github.com/apache/spark/pull/27354#issuecomment-578546109 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType URL: https://github.com/apache/spark/pull/27354#issuecomment-578546105 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType URL: https://github.com/apache/spark/pull/27354#issuecomment-578546109 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType URL: https://github.com/apache/spark/pull/27354#issuecomment-578546105 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA commented on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType

2020-01-26 Thread GitBox
SparkQA commented on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType URL: https://github.com/apache/spark/pull/27354#issuecomment-578545881 **[Test build #117429 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117429/testReport)**

[GitHub] [spark] SparkQA removed a comment on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType

2020-01-26 Thread GitBox
SparkQA removed a comment on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType URL: https://github.com/apache/spark/pull/27354#issuecomment-578524901 **[Test build #117429 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #27355: [SPARK-30625][SQL] Support `escape` as third parameter of the `like` function

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27355: [SPARK-30625][SQL] Support `escape` as third parameter of the `like` function URL: https://github.com/apache/spark/pull/27355#issuecomment-578543478 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27355: [SPARK-30625][SQL] Support `escape` as third parameter of the `like` function

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27355: [SPARK-30625][SQL] Support `escape` as third parameter of the `like` function URL: https://github.com/apache/spark/pull/27355#issuecomment-578543475 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27355: [SPARK-30625][SQL] Support `escape` as third parameter of the `like` function

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27355: [SPARK-30625][SQL] Support `escape` as third parameter of the `like` function URL: https://github.com/apache/spark/pull/27355#issuecomment-578543478 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27355: [SPARK-30625][SQL] Support `escape` as third parameter of the `like` function

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27355: [SPARK-30625][SQL] Support `escape` as third parameter of the `like` function URL: https://github.com/apache/spark/pull/27355#issuecomment-578543475 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #27355: [SPARK-30625][SQL] Support `escape` as third parameter of the `like` function

2020-01-26 Thread GitBox
SparkQA commented on issue #27355: [SPARK-30625][SQL] Support `escape` as third parameter of the `like` function URL: https://github.com/apache/spark/pull/27355#issuecomment-578543163 **[Test build #117428 has

[GitHub] [spark] SparkQA removed a comment on issue #27355: [SPARK-30625][SQL] Support `escape` as third parameter of the `like` function

2020-01-26 Thread GitBox
SparkQA removed a comment on issue #27355: [SPARK-30625][SQL] Support `escape` as third parameter of the `like` function URL: https://github.com/apache/spark/pull/27355#issuecomment-578522206 **[Test build #117428 has

[GitHub] [spark] asfgit closed pull request #26957: [SPARK-30314] Add identifier and catalog information to DataSourceV2Relation

2020-01-26 Thread GitBox
asfgit closed pull request #26957: [SPARK-30314] Add identifier and catalog information to DataSourceV2Relation URL: https://github.com/apache/spark/pull/26957 This is an automated message from the Apache Git Service. To

[GitHub] [spark] dilipbiswal commented on issue #27289: [SPARK-30581][DOC] Document SORT BY Clause of SELECT statement in SQLReference

2020-01-26 Thread GitBox
dilipbiswal commented on issue #27289: [SPARK-30581][DOC] Document SORT BY Clause of SELECT statement in SQLReference URL: https://github.com/apache/spark/pull/27289#issuecomment-578528636 @maropu I had tried to document this in the main description section like this : `The SORT BY

[GitHub] [spark] SparkQA removed a comment on issue #27292: [SPARK-30582][WEBUI] Spark UI is not showing Aggregated Metrics by Executor in stage page

2020-01-26 Thread GitBox
SparkQA removed a comment on issue #27292: [SPARK-30582][WEBUI] Spark UI is not showing Aggregated Metrics by Executor in stage page URL: https://github.com/apache/spark/pull/27292#issuecomment-578518568 **[Test build #4994 has

[GitHub] [spark] SparkQA commented on issue #27292: [SPARK-30582][WEBUI] Spark UI is not showing Aggregated Metrics by Executor in stage page

2020-01-26 Thread GitBox
SparkQA commented on issue #27292: [SPARK-30582][WEBUI] Spark UI is not showing Aggregated Metrics by Executor in stage page URL: https://github.com/apache/spark/pull/27292#issuecomment-578526618 **[Test build #4994 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType URL: https://github.com/apache/spark/pull/27354#issuecomment-578525325 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType URL: https://github.com/apache/spark/pull/27354#issuecomment-578525328 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType URL: https://github.com/apache/spark/pull/27354#issuecomment-578525325 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType URL: https://github.com/apache/spark/pull/27354#issuecomment-578525328 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files URL: https://github.com/apache/spark/pull/27365#issuecomment-578525218 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files URL: https://github.com/apache/spark/pull/27365#issuecomment-578525218 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files

2020-01-26 Thread GitBox
AmplabJenkins removed a comment on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files URL: https://github.com/apache/spark/pull/27365#issuecomment-578525220 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files

2020-01-26 Thread GitBox
AmplabJenkins commented on issue #27365: [MINOR][SQL] Convert CRLF into LF in source files URL: https://github.com/apache/spark/pull/27365#issuecomment-578525220 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] patrickcording commented on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType

2020-01-26 Thread GitBox
patrickcording commented on issue #27354: [SPARK-30633][SQL] Append L to seed when type is LongType URL: https://github.com/apache/spark/pull/27354#issuecomment-578525003 @srowen, @dongjoon-hyun, I extended the first test to also run using integer seeds and when mixing integer and long

  1   2   3   >