[GitHub] [spark] AmplabJenkins removed a comment on pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

AmplabJenkins removed a comment on pull request #28322: URL: https://github.com/apache/spark/pull/28322#issuecomment-618816134 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

AmplabJenkins commented on pull request #28310: URL: https://github.com/apache/spark/pull/28310#issuecomment-618816180 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

AmplabJenkins removed a comment on pull request #28310: URL: https://github.com/apache/spark/pull/28310#issuecomment-618816180 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

AmplabJenkins commented on pull request #28322: URL: https://github.com/apache/spark/pull/28322#issuecomment-618816134 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

SparkQA commented on pull request #28322: URL: https://github.com/apache/spark/pull/28322#issuecomment-618815765 **[Test build #121721 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121721/testReport)** for PR 28322 at commit

[GitHub] [spark] SparkQA commented on pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

SparkQA commented on pull request #28310: URL: https://github.com/apache/spark/pull/28310#issuecomment-618815774 **[Test build #121720 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121720/testReport)** for PR 28310 at commit

[GitHub] [spark] yaooqinn opened a new pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

yaooqinn opened a new pull request #28322: URL: https://github.com/apache/spark/pull/28322 ### What changes were proposed in this pull request? ```scala spark.sql.session.timeZone spark.sql.warehouse.dir ``` these 2 configs are nondeterministic and vary

[GitHub] [spark] huaxingao commented on a change in pull request #28277: [SPARK-31502][SQL][DOCS] Document identifier in SQL Reference

huaxingao commented on a change in pull request #28277: URL: https://github.com/apache/spark/pull/28277#discussion_r414311098 ## File path: docs/sql-ref-identifier.md ## @@ -0,0 +1,76 @@ +--- +layout: global +title: Identifiers +displayTitle: Identifiers +license: | +

[GitHub] [spark] AmplabJenkins commented on pull request #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC

AmplabJenkins commented on pull request #28261: URL: https://github.com/apache/spark/pull/28261#issuecomment-618806002 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC

AmplabJenkins removed a comment on pull request #28261: URL: https://github.com/apache/spark/pull/28261#issuecomment-618806002 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

SparkQA commented on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-618805725 **[Test build #121718 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121718/testReport)** for PR 28294 at commit

[GitHub] [spark] SparkQA commented on pull request #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC

SparkQA commented on pull request #28261: URL: https://github.com/apache/spark/pull/28261#issuecomment-618805721 **[Test build #121719 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121719/testReport)** for PR 28261 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28317: [SPARK-31534][WEBUI] Text for tooltip should be escaped.

AmplabJenkins removed a comment on pull request #28317: URL: https://github.com/apache/spark/pull/28317#issuecomment-618804784 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28317: [SPARK-31534][WEBUI] Text for tooltip should be escaped.

AmplabJenkins commented on pull request #28317: URL: https://github.com/apache/spark/pull/28317#issuecomment-618804778 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28317: [SPARK-31534][WEBUI] Text for tooltip should be escaped.

AmplabJenkins removed a comment on pull request #28317: URL: https://github.com/apache/spark/pull/28317#issuecomment-618804778 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28317: [SPARK-31534][WEBUI] Text for tooltip should be escaped.

SparkQA removed a comment on pull request #28317: URL: https://github.com/apache/spark/pull/28317#issuecomment-618762905 **[Test build #121709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121709/testReport)** for PR 28317 at commit

[GitHub] [spark] SparkQA commented on pull request #28317: [SPARK-31534][WEBUI] Text for tooltip should be escaped.

SparkQA commented on pull request #28317: URL: https://github.com/apache/spark/pull/28317#issuecomment-618804445 **[Test build #121709 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121709/testReport)** for PR 28317 at commit

[GitHub] [spark] cloud-fan commented on pull request #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC

cloud-fan commented on pull request #28261: URL: https://github.com/apache/spark/pull/28261#issuecomment-618804266 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

AmplabJenkins removed a comment on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-618804149 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

AmplabJenkins commented on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-618804149 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] xuanyuanking commented on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

xuanyuanking commented on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-618803730 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on a change in pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions

cloud-fan commented on a change in pull request #28313: URL: https://github.com/apache/spark/pull/28313#discussion_r414292509 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ## @@ -477,7 +477,7 @@ class DateFunctionsSuite extends QueryTest

[GitHub] [spark] HyukjinKwon commented on pull request #28285: [SPARK-31510][R][BUILD] Set setwd in R documentation build

HyukjinKwon commented on pull request #28285: URL: https://github.com/apache/spark/pull/28285#issuecomment-618799587 I also merged this into branch-3.0. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] cloud-fan commented on pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

cloud-fan commented on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-618798605 Yes, please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] cloud-fan commented on a change in pull request #28277: [SPARK-31502][SQL][DOCS] Document identifier in SQL Reference

cloud-fan commented on a change in pull request #28277: URL: https://github.com/apache/spark/pull/28277#discussion_r414287476 ## File path: docs/sql-ref-identifier.md ## @@ -0,0 +1,76 @@ +--- +layout: global +title: Identifiers +displayTitle: Identifiers +license: | +

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

AmplabJenkins removed a comment on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-618796171 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

AmplabJenkins removed a comment on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-618796169 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

AmplabJenkins commented on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-618796169 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

SparkQA removed a comment on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-618744399 **[Test build #121705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121705/testReport)** for PR 28294 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28277: [SPARK-31502][SQL][DOCS] Document identifier in SQL Reference

cloud-fan commented on a change in pull request #28277: URL: https://github.com/apache/spark/pull/28277#discussion_r414284944 ## File path: docs/sql-ref-identifier.md ## @@ -0,0 +1,76 @@ +--- +layout: global +title: Identifiers +displayTitle: Identifiers +license: | +

[GitHub] [spark] SparkQA commented on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

SparkQA commented on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-618795986 **[Test build #121705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121705/testReport)** for PR 28294 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28277: [SPARK-31502][SQL][DOCS] Document identifier in SQL Reference

cloud-fan commented on a change in pull request #28277: URL: https://github.com/apache/spark/pull/28277#discussion_r414284944 ## File path: docs/sql-ref-identifier.md ## @@ -0,0 +1,76 @@ +--- +layout: global +title: Identifiers +displayTitle: Identifiers +license: | +

[GitHub] [spark] cloud-fan commented on a change in pull request #28277: [SPARK-31502][SQL][DOCS] Document identifier in SQL Reference

cloud-fan commented on a change in pull request #28277: URL: https://github.com/apache/spark/pull/28277#discussion_r414284261 ## File path: docs/sql-ref-identifier.md ## @@ -0,0 +1,76 @@ +--- +layout: global +title: Identifiers +displayTitle: Identifiers +license: | +

[GitHub] [spark] cloud-fan commented on a change in pull request #28277: [SPARK-31502][SQL][DOCS] Document identifier in SQL Reference

cloud-fan commented on a change in pull request #28277: URL: https://github.com/apache/spark/pull/28277#discussion_r414284261 ## File path: docs/sql-ref-identifier.md ## @@ -0,0 +1,76 @@ +--- +layout: global +title: Identifiers +displayTitle: Identifiers +license: | +

[GitHub] [spark] cloud-fan commented on a change in pull request #28277: [SPARK-31502][SQL][DOCS] Document identifier in SQL Reference

cloud-fan commented on a change in pull request #28277: URL: https://github.com/apache/spark/pull/28277#discussion_r414283582 ## File path: docs/sql-ref-identifier.md ## @@ -0,0 +1,76 @@ +--- +layout: global +title: Identifiers +displayTitle: Identifiers +license: | +

[GitHub] [spark] dongjoon-hyun commented on pull request #28320: [SPARK-30199][DSTREAM] Recover `spark.(ui|blockManager).port` from checkpoint

dongjoon-hyun commented on pull request #28320: URL: https://github.com/apache/spark/pull/28320#issuecomment-618793764 Thank you, @holdenk , @dbtsai , @aaruna . Merged to branch-2.4 for Apache Spark 2.4.6 release. This is

[GitHub] [spark] Ngone51 commented on pull request #28257: [SPARK-31485][CORE] Avoid application hang if only partial barrier tasks launched

Ngone51 commented on pull request #28257: URL: https://github.com/apache/spark/pull/28257#issuecomment-618793300 Sure, thanks all!! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] dongjoon-hyun commented on pull request #28321: [SPARK-31547][BUILD] Upgrade Genjavadoc to 0.16

dongjoon-hyun commented on pull request #28321: URL: https://github.com/apache/spark/pull/28321#issuecomment-618793367 Thank you, @sarutak and @HyukjinKwon ! This is an automated message from the Apache Git Service. To

[GitHub] [spark] cloud-fan commented on pull request #28257: [SPARK-31485][CORE] Avoid application hang if only partial barrier tasks launched

cloud-fan commented on pull request #28257: URL: https://github.com/apache/spark/pull/28257#issuecomment-618793062 @Ngone51 can you send a backport PR for 3.0 and 2.4? This is an automated message from the Apache Git

[GitHub] [spark] cloud-fan edited a comment on pull request #28257: [SPARK-31485][CORE] Avoid application hang if only partial barrier tasks launched

cloud-fan edited a comment on pull request #28257: URL: https://github.com/apache/spark/pull/28257#issuecomment-618792364 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on pull request #28257: [SPARK-31485][CORE] Avoid application hang if only partial barrier tasks launched

cloud-fan commented on pull request #28257: URL: https://github.com/apache/spark/pull/28257#issuecomment-618792364 thanks, merging to master/3.0! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #28301: [SPARK-31521][CORE] Correct the fetch size when merging blocks into a merged block

SparkQA commented on pull request #28301: URL: https://github.com/apache/spark/pull/28301#issuecomment-618791399 **[Test build #121717 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121717/testReport)** for PR 28301 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28301: [SPARK-31521][CORE] Correct the fetch size when merging blocks into a merged block

AmplabJenkins removed a comment on pull request #28301: URL: https://github.com/apache/spark/pull/28301#issuecomment-618790025 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28301: [SPARK-31521][CORE] Correct the fetch size when merging blocks into a merged block

AmplabJenkins commented on pull request #28301: URL: https://github.com/apache/spark/pull/28301#issuecomment-618790025 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28301: [SPARK-31521][CORE] Correct the fetch size when merging blocks into a merged block

AmplabJenkins removed a comment on pull request #28301: URL: https://github.com/apache/spark/pull/28301#issuecomment-618789483 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] Ngone51 commented on pull request #28301: [SPARK-31521][CORE] Correct the fetch size when merging blocks into a merged block

Ngone51 commented on pull request #28301: URL: https://github.com/apache/spark/pull/28301#issuecomment-618789780 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins commented on pull request #28301: [SPARK-31521][CORE] Correct the fetch size when merging blocks into a merged block

AmplabJenkins commented on pull request #28301: URL: https://github.com/apache/spark/pull/28301#issuecomment-618789478 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28301: [SPARK-31521][CORE] Correct the fetch size when merging blocks into a merged block

AmplabJenkins removed a comment on pull request #28301: URL: https://github.com/apache/spark/pull/28301#issuecomment-618789478 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28301: [SPARK-31521][CORE] Correct the fetch size when merging blocks into a merged block

SparkQA removed a comment on pull request #28301: URL: https://github.com/apache/spark/pull/28301#issuecomment-618755302 **[Test build #121707 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121707/testReport)** for PR 28301 at commit

[GitHub] [spark] SparkQA commented on pull request #28301: [SPARK-31521][CORE] Correct the fetch size when merging blocks into a merged block

SparkQA commented on pull request #28301: URL: https://github.com/apache/spark/pull/28301#issuecomment-618789221 **[Test build #121707 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121707/testReport)** for PR 28301 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

cloud-fan commented on a change in pull request #28310: URL: https://github.com/apache/spark/pull/28310#discussion_r414274656 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -618,6 +618,22 @@ object DateTimeUtils {

[GitHub] [spark] cloud-fan commented on a change in pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

cloud-fan commented on a change in pull request #28310: URL: https://github.com/apache/spark/pull/28310#discussion_r414274382 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -618,6 +618,22 @@ object DateTimeUtils {

[GitHub] [spark] zhengruifeng commented on pull request #27978: [SPARK-31127][ML] Implement abstract Selector

zhengruifeng commented on pull request #27978: URL: https://github.com/apache/spark/pull/27978#issuecomment-618788030 @huaxingao I am neutral on both methods, I am OK with abstract selector if you prefer it. Since I had just make computation in tests and selectors more distributedly, so

[GitHub] [spark] dbtsai removed a comment on pull request #28319: [SPARK-31364][SQL][TESTS] Benchmark Parquet Nested Field Predicate Pushdown

dbtsai removed a comment on pull request #28319: URL: https://github.com/apache/spark/pull/28319#issuecomment-618781554 cc @HyukjinKwon as well. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dbtsai commented on a change in pull request #28319: [SPARK-31364][SQL][TESTS] Benchmark Parquet Nested Field Predicate Pushdown

dbtsai commented on a change in pull request #28319: URL: https://github.com/apache/spark/pull/28319#discussion_r414271016 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/ParquetNestedPredicatePushDownBenchmark.scala ## @@ -0,0 +1,120 @@ +/* + *

[GitHub] [spark] dbtsai commented on a change in pull request #28319: [SPARK-31364][SQL][TESTS] Benchmark Parquet Nested Field Predicate Pushdown

dbtsai commented on a change in pull request #28319: URL: https://github.com/apache/spark/pull/28319#discussion_r414270915 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/ParquetNestedPredicatePushDownBenchmark.scala ## @@ -0,0 +1,120 @@ +/* + *

[GitHub] [spark] dbtsai commented on a change in pull request #28319: [SPARK-31364][SQL][TESTS] Benchmark Parquet Nested Field Predicate Pushdown

dbtsai commented on a change in pull request #28319: URL: https://github.com/apache/spark/pull/28319#discussion_r414270789 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/ParquetNestedPredicatePushDownBenchmark.scala ## @@ -0,0 +1,120 @@ +/* + *

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28311: [SPARK-31010][SQL][DOC][FOLLOW-UP] Improve deprecated warning message for untyped scala udf

AmplabJenkins removed a comment on pull request #28311: URL: https://github.com/apache/spark/pull/28311#issuecomment-618785173 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28311: [SPARK-31010][SQL][DOC][FOLLOW-UP] Improve deprecated warning message for untyped scala udf

AmplabJenkins commented on pull request #28311: URL: https://github.com/apache/spark/pull/28311#issuecomment-618785173 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28311: [SPARK-31010][SQL][DOC][FOLLOW-UP] Improve deprecated warning message for untyped scala udf

SparkQA commented on pull request #28311: URL: https://github.com/apache/spark/pull/28311#issuecomment-618784934 **[Test build #121716 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121716/testReport)** for PR 28311 at commit

[GitHub] [spark] dbtsai commented on a change in pull request #28319: [SPARK-31364][SQL][TESTS] Benchmark Parquet Nested Field Predicate Pushdown

dbtsai commented on a change in pull request #28319: URL: https://github.com/apache/spark/pull/28319#discussion_r414269258 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/ParquetNestedPredicatePushDownBenchmark.scala ## @@ -0,0 +1,120 @@ +/* + *

[GitHub] [spark] dbtsai commented on a change in pull request #28319: [SPARK-31364][SQL][TESTS] Benchmark Parquet Nested Field Predicate Pushdown

dbtsai commented on a change in pull request #28319: URL: https://github.com/apache/spark/pull/28319#discussion_r414269670 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/ParquetNestedPredicatePushDownBenchmark.scala ## @@ -0,0 +1,120 @@ +/* + *

[GitHub] [spark] smparkes commented on a change in pull request #23080: [SPARK-26108][SQL] Support custom lineSep in CSV datasource

smparkes commented on a change in pull request #23080: URL: https://github.com/apache/spark/pull/23080#discussion_r414269603 ## File path: python/pyspark/sql/readwriter.py ## @@ -922,6 +925,8 @@ def csv(self, path, mode=None, compression=None, sep=None, quote=None, escape=No

[GitHub] [spark] dbtsai commented on a change in pull request #28319: [SPARK-31364][SQL][TESTS] Benchmark Parquet Nested Field Predicate Pushdown

dbtsai commented on a change in pull request #28319: URL: https://github.com/apache/spark/pull/28319#discussion_r414269258 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/ParquetNestedPredicatePushDownBenchmark.scala ## @@ -0,0 +1,120 @@ +/* + *

[GitHub] [spark] dbtsai commented on a change in pull request #28319: [SPARK-31364][SQL][TESTS] Benchmark Parquet Nested Field Predicate Pushdown

dbtsai commented on a change in pull request #28319: URL: https://github.com/apache/spark/pull/28319#discussion_r414269508 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/ParquetNestedPredicatePushDownBenchmark.scala ## @@ -0,0 +1,120 @@ +/* + *

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

AmplabJenkins removed a comment on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-618783641 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

AmplabJenkins commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-618783641 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

SparkQA commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-618783283 **[Test build #121715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121715/testReport)** for PR 28123 at commit

[GitHub] [spark] imback82 commented on a change in pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

imback82 commented on a change in pull request #28123: URL: https://github.com/apache/spark/pull/28123#discussion_r414267327 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ## @@ -855,4 +874,30 @@ abstract class BucketedReadSuite

[GitHub] [spark] HyukjinKwon commented on pull request #27557: [SPARK-30804][SS] Measure and log elapsed time for "compact" operation in CompactibleFileStreamLog

HyukjinKwon commented on pull request #27557: URL: https://github.com/apache/spark/pull/27557#issuecomment-618783067 Merged to master and branch-3.0. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] yaooqinn commented on a change in pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

yaooqinn commented on a change in pull request #28310: URL: https://github.com/apache/spark/pull/28310#discussion_r414266944 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -288,19 +292,22 @@ class Analyzer( * 1. If

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27991: [SPARK-31227][SQL] Non-nullable null type in complex types should not coerce to nullable type

HyukjinKwon commented on a change in pull request #27991: URL: https://github.com/apache/spark/pull/27991#discussion_r414266838 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ## @@ -1532,6 +1532,13 @@ class DataFrameFunctionsSuite

[GitHub] [spark] dbtsai commented on a change in pull request #28319: [SPARK-31364][SQL][TESTS] Benchmark Parquet Nested Field Predicate Pushdown

dbtsai commented on a change in pull request #28319: URL: https://github.com/apache/spark/pull/28319#discussion_r414267119 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/ParquetNestedPredicatePushDownBenchmark.scala ## @@ -0,0 +1,120 @@ +/* + *

[GitHub] [spark] dbtsai commented on a change in pull request #28319: [SPARK-31364][SQL][TESTS] Benchmark Parquet Nested Field Predicate Pushdown

dbtsai commented on a change in pull request #28319: URL: https://github.com/apache/spark/pull/28319#discussion_r414266511 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/ParquetNestedPredicatePushDownBenchmark.scala ## @@ -0,0 +1,120 @@ +/* + *

[GitHub] [spark] dbtsai commented on pull request #28319: [SPARK-31364][SQL][TESTS] Benchmark Parquet Nested Field Predicate Pushdown

dbtsai commented on pull request #28319: URL: https://github.com/apache/spark/pull/28319#issuecomment-618781554 cc @HyukjinKwon as well. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] aaruna commented on pull request #28320: [SPARK-30199][DSTREAM] Recover `spark.(ui|blockManager).port` from checkpoint

aaruna commented on pull request #28320: URL: https://github.com/apache/spark/pull/28320#issuecomment-618780551 LGTM, thanks for the backport! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dbtsai commented on pull request #28320: [SPARK-30199][DSTREAM] Recover `spark.(ui|blockManager).port` from checkpoint

dbtsai commented on pull request #28320: URL: https://github.com/apache/spark/pull/28320#issuecomment-618779885 LGTM. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] sarutak commented on pull request #28321: [SPARK-31547][BUILD] Upgrade Genjavadoc to 0.16

sarutak commented on pull request #28321: URL: https://github.com/apache/spark/pull/28321#issuecomment-618777284 LGTM. I also checked on my laptop. Merging this into master. Thanks @dongjoon-hyun and @HyukjinKwon ! This

[GitHub] [spark] cloud-fan commented on a change in pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

cloud-fan commented on a change in pull request #28310: URL: https://github.com/apache/spark/pull/28310#discussion_r414259239 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -288,19 +292,22 @@ class Analyzer( * 1. If

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28316: [SPARK-31532][SQL] Builder should not propagate static sql configs to the existing active or default SparkSession

AmplabJenkins removed a comment on pull request #28316: URL: https://github.com/apache/spark/pull/28316#issuecomment-618776523 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28316: [SPARK-31532][SQL] Builder should not propagate static sql configs to the existing active or default SparkSession

AmplabJenkins commented on pull request #28316: URL: https://github.com/apache/spark/pull/28316#issuecomment-618776523 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] wezhang commented on pull request #28292: [SPARK-31516][DOC] Fix non-existed metric hiveClientCalls.count of CodeGenerator in DOC

wezhang commented on pull request #28292: URL: https://github.com/apache/spark/pull/28292#issuecomment-618776317 Thank you @srowen ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA commented on pull request #28316: [SPARK-31532][SQL] Builder should not propagate static sql configs to the existing active or default SparkSession

SparkQA commented on pull request #28316: URL: https://github.com/apache/spark/pull/28316#issuecomment-618776300 **[Test build #121714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121714/testReport)** for PR 28316 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #27477: [SPARK-30724][SQL] Support 'LIKE ANY' and 'LIKE ALL' operators

AmplabJenkins commented on pull request #27477: URL: https://github.com/apache/spark/pull/27477#issuecomment-618774511 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27477: [SPARK-30724][SQL] Support 'LIKE ANY' and 'LIKE ALL' operators

AmplabJenkins removed a comment on pull request #27477: URL: https://github.com/apache/spark/pull/27477#issuecomment-618774511 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #27477: [SPARK-30724][SQL] Support 'LIKE ANY' and 'LIKE ALL' operators

SparkQA commented on pull request #27477: URL: https://github.com/apache/spark/pull/27477#issuecomment-618774287 **[Test build #121713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121713/testReport)** for PR 27477 at commit

[GitHub] [spark] Ngone51 commented on a change in pull request #28311: [SPARK-31010][SQL][DOC][FOLLOW-UP] Improve deprecated warning message for untyped scala udf

Ngone51 commented on a change in pull request #28311: URL: https://github.com/apache/spark/pull/28311#discussion_r414254859 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -4856,16 +4856,16 @@ object functions { * @group udf_funcs *

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28316: [SPARK-31532][SQL] Builder should not propagate static sql configs to the existing active or default SparkSession

AmplabJenkins removed a comment on pull request #28316: URL: https://github.com/apache/spark/pull/28316#issuecomment-618772887 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28316: [SPARK-31532][SQL] Builder should not propagate static sql configs to the existing active or default SparkSession

AmplabJenkins commented on pull request #28316: URL: https://github.com/apache/spark/pull/28316#issuecomment-618772887 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] WeichenXu123 commented on pull request #28279: [SPARK-31497][ML][PYSPARK] Fix Pyspark CrossValidator/TrainValidationSplit with pipeline estimator cannot save and load model

WeichenXu123 commented on pull request #28279: URL: https://github.com/apache/spark/pull/28279#issuecomment-618772740 I create a follow-up refactor jira ticket here: https://issues.apache.org/jira/browse/SPARK-31548 This

[GitHub] [spark] cloud-fan commented on a change in pull request #28316: [SPARK-31532][SQL] Builder should not propagate static sql configs to the existing active or default SparkSession

cloud-fan commented on a change in pull request #28316: URL: https://github.com/apache/spark/pull/28316#discussion_r414254022 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala ## @@ -959,6 +953,20 @@ object SparkSession extends Logging {

[GitHub] [spark] SparkQA commented on pull request #28316: [SPARK-31532][SQL] Builder should not propagate static sql configs to the existing active or default SparkSession

SparkQA commented on pull request #28316: URL: https://github.com/apache/spark/pull/28316#issuecomment-618772579 **[Test build #121712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121712/testReport)** for PR 28316 at commit

[GitHub] [spark] yaooqinn commented on a change in pull request #28316: [SPARK-31532][SQL] Builder should not propagate static sql configs to the existing active or default SparkSession

yaooqinn commented on a change in pull request #28316: URL: https://github.com/apache/spark/pull/28316#discussion_r414253520 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala ## @@ -168,4 +168,33 @@ class SparkSessionBuilderSuite

[GitHub] [spark] cloud-fan commented on a change in pull request #28311: [SPARK-31010][SQL][DOC][FOLLOW-UP] Improve deprecated warning message for untyped scala udf

cloud-fan commented on a change in pull request #28311: URL: https://github.com/apache/spark/pull/28311#discussion_r414253057 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -4856,16 +4856,16 @@ object functions { * @group udf_funcs *

[GitHub] [spark] yaooqinn commented on a change in pull request #28316: [SPARK-31532][SQL] Builder should not propagate static sql configs to the existing active or default SparkSession

yaooqinn commented on a change in pull request #28316: URL: https://github.com/apache/spark/pull/28316#discussion_r414248316 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala ## @@ -905,7 +905,9 @@ object SparkSession extends Logging { // Get

[GitHub] [spark] yaooqinn commented on a change in pull request #28316: [SPARK-31532][SQL] Builder should not propagate static sql configs to the existing active or default SparkSession

yaooqinn commented on a change in pull request #28316: URL: https://github.com/apache/spark/pull/28316#discussion_r414248086 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala ## @@ -905,7 +905,9 @@ object SparkSession extends Logging { // Get

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28311: [SPARK-31010][SQL][DOC][FOLLOW-UP] Improve deprecated warning message for untyped scala udf

AmplabJenkins removed a comment on pull request #28311: URL: https://github.com/apache/spark/pull/28311#issuecomment-618767358 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28311: [SPARK-31010][SQL][DOC][FOLLOW-UP] Improve deprecated warning message for untyped scala udf

AmplabJenkins commented on pull request #28311: URL: https://github.com/apache/spark/pull/28311#issuecomment-618767358 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28311: [SPARK-31010][SQL][DOC][FOLLOW-UP] Improve deprecated warning message for untyped scala udf

SparkQA commented on pull request #28311: URL: https://github.com/apache/spark/pull/28311#issuecomment-618767082 **[Test build #121711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121711/testReport)** for PR 28311 at commit

[GitHub] [spark] HyukjinKwon commented on a change in pull request #23080: [SPARK-26108][SQL] Support custom lineSep in CSV datasource

HyukjinKwon commented on a change in pull request #23080: URL: https://github.com/apache/spark/pull/23080#discussion_r414245634 ## File path: python/pyspark/sql/readwriter.py ## @@ -922,6 +925,8 @@ def csv(self, path, mode=None, compression=None, sep=None, quote=None,

  1   2   3   4   5   6   7   8   >