[GitHub] [spark] viirya commented on a change in pull request #26422: [SPARK-29786][SQL] Fix MetaException when dropping a partition not exists on HDFS

2020-05-22 Thread GitBox


viirya commented on a change in pull request #26422:
URL: https://github.com/apache/spark/pull/26422#discussion_r429517900



##
File path: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##
@@ -638,6 +644,17 @@ private[hive] class HiveClientImpl(
 s"No partition is dropped. One partition spec '$s' does not exist 
in table '$table' " +
 s"database '$db'")
 }
+// Check whether the partition we are going to drop is empty.
+// We make a dummy one for the empty partition. See [SPARK-29786] for 
more details.
+parts.foreach { partition =>
+  val partPath = partition.getPath.head
+  if (isExistPath(partPath)) {
+val fs = partPath.getFileSystem(conf)
+fs.mkdirs(partPath)
+fs.deleteOnExit(partPath)
+  }

Review comment:
   I'm confused. When the partition exists (`isExistPath` returns true), 
why you need to mkdir it again?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632990441







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632990441







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly

2020-05-22 Thread GitBox


SparkQA commented on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632990317


   **[Test build #123025 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123025/testReport)**
 for PR 28620 at commit 
[`1dac0ef`](https://github.com/apache/spark/commit/1dac0ef36744b736927e67d139f0b21477fa1a3d).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] MaxGekk commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly

2020-05-22 Thread GitBox


MaxGekk commented on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632989799


   @cloud-fan @HyukjinKwon @hvanhovell Please, review this PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] MaxGekk opened a new pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly

2020-05-22 Thread GitBox


MaxGekk opened a new pull request #28620:
URL: https://github.com/apache/spark/pull/28620


   ### What changes were proposed in this pull request?
   Use `format()` methods for Java date-time types in `Row.jsonValue`. The PR 
https://github.com/apache/spark/pull/28582 added the methods to avoid 
conversions to days and microseconds.
   
   ### Why are the changes needed?
   To avoid unnecessary overhead of converting Java date-time types to 
micros/days before formatting. Also formatters have to convert input 
micros/days back to Java types to pass instances to standard library API.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   By existing tests in `RowJsonSuite`.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #27006:
URL: https://github.com/apache/spark/pull/27006#issuecomment-632989057







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #27006:
URL: https://github.com/apache/spark/pull/27006#issuecomment-632989057







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-22 Thread GitBox


SparkQA commented on pull request #27006:
URL: https://github.com/apache/spark/pull/27006#issuecomment-632988959


   **[Test build #123024 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123024/testReport)**
 for PR 27006 at commit 
[`f951b5e`](https://github.com/apache/spark/commit/f951b5ed10805c998dc6f8656724972e6c4bc719).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #27006:
URL: https://github.com/apache/spark/pull/27006#issuecomment-632889226


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123019/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] yaooqinn commented on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-22 Thread GitBox


yaooqinn commented on pull request #27006:
URL: https://github.com/apache/spark/pull/27006#issuecomment-632988407


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28619: [WIP][SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-632985431


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28619: [WIP][SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-632985525


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28619: [WIP][SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-632985431


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] prakharjain09 commented on pull request #28619: [WIP][SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-05-22 Thread GitBox


prakharjain09 commented on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-632985151


   I am adding more UTs for this change. So added WIP in title.
   
   @holdenk Please give some feedback on the actual logic.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] prakharjain09 opened a new pull request #28619: [WIP][SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-05-22 Thread GitBox


prakharjain09 opened a new pull request #28619:
URL: https://github.com/apache/spark/pull/28619


   ### What changes were proposed in this pull request?
   This PR adds functionality to consider the running tasks on decommission 
executors based on some config.
   In spark-on-cloud , we sometimes already know that an executor won't be 
alive for more than fix amount of time. Ex- In AWS Spot nodes, once we get the 
notification, we know that a node will be gone in 120 seconds.
   So if the running tasks on the decommissioning executors may run beyond 
currentTime+120 seconds, then they are candidate for speculation.
   
   ### Why are the changes needed?
   Currently when an executor is decommission, we stop scheduling new tasks on 
those executors but the already running tasks keeps on running on them. Based 
on the cloud, we might know beforehand that an executor won't be alive for more 
than a preconfigured time. Different cloud providers gives different timeouts 
before they take away the nodes. For Ex- In case of AWS spot nodes, an executor 
won't be alive for more than 120 seconds. We can utilize this information in 
cloud environments and take better decisions about speculating the already 
running tasks on decommission executors.
   
   ### Does this PR introduce _any_ user-facing change?
   Yes. This PR adds a new config "spark.executor.decommission.killInterval" 
which they can explicitly set based on the cloud environment where they are 
running.
   
   
   ### How was this patch tested?
   Added UT.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28603: [SPARK-31788][CORE][PYTHON] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28603:
URL: https://github.com/apache/spark/pull/28603#issuecomment-632975557







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28603: [SPARK-31788][CORE][PYTHON] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28603:
URL: https://github.com/apache/spark/pull/28603#issuecomment-632975557







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28603: [SPARK-31788][CORE][PYTHON] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox


SparkQA removed a comment on pull request #28603:
URL: https://github.com/apache/spark/pull/28603#issuecomment-632971926


   **[Test build #123023 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123023/testReport)**
 for PR 28603 at commit 
[`c65be0d`](https://github.com/apache/spark/commit/c65be0d6ac8e78f56ca8cd063d9db1012b65f0ab).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28603: [SPARK-31788][CORE][PYTHON] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox


SparkQA commented on pull request #28603:
URL: https://github.com/apache/spark/pull/28603#issuecomment-632975404


   **[Test build #123023 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123023/testReport)**
 for PR 28603 at commit 
[`c65be0d`](https://github.com/apache/spark/commit/c65be0d6ac8e78f56ca8cd063d9db1012b65f0ab).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28603: [SPARK-31788][CORE][PYTHON] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28603:
URL: https://github.com/apache/spark/pull/28603#issuecomment-632972088







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28603: [SPARK-31788][CORE][PYTHON] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28603:
URL: https://github.com/apache/spark/pull/28603#issuecomment-632972088







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28603: [SPARK-31788][CORE][PYTHON] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox


SparkQA commented on pull request #28603:
URL: https://github.com/apache/spark/pull/28603#issuecomment-632971926


   **[Test build #123023 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123023/testReport)**
 for PR 28603 at commit 
[`c65be0d`](https://github.com/apache/spark/commit/c65be0d6ac8e78f56ca8cd063d9db1012b65f0ab).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28603: [SPARK-31788][CORE] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox


HyukjinKwon commented on pull request #28603:
URL: https://github.com/apache/spark/pull/28603#issuecomment-632971649


   ok to test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28603: [SPARK-31788][CORE] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28603:
URL: https://github.com/apache/spark/pull/28603#issuecomment-632402291


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28618:
URL: https://github.com/apache/spark/pull/28618#issuecomment-632965792


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123022/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox


SparkQA removed a comment on pull request #28618:
URL: https://github.com/apache/spark/pull/28618#issuecomment-632965454


   **[Test build #123022 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123022/testReport)**
 for PR 28618 at commit 
[`98821b9`](https://github.com/apache/spark/commit/98821b91a0273300ffb40c197628f1abf69fbafb).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28618:
URL: https://github.com/apache/spark/pull/28618#issuecomment-632965788


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28618:
URL: https://github.com/apache/spark/pull/28618#issuecomment-632965788







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox


SparkQA commented on pull request #28618:
URL: https://github.com/apache/spark/pull/28618#issuecomment-632965784


   **[Test build #123022 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123022/testReport)**
 for PR 28618 at commit 
[`98821b9`](https://github.com/apache/spark/commit/98821b91a0273300ffb40c197628f1abf69fbafb).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28618:
URL: https://github.com/apache/spark/pull/28618#issuecomment-632965590







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28618:
URL: https://github.com/apache/spark/pull/28618#issuecomment-632965590







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox


SparkQA commented on pull request #28618:
URL: https://github.com/apache/spark/pull/28618#issuecomment-632965454


   **[Test build #123022 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123022/testReport)**
 for PR 28618 at commit 
[`98821b9`](https://github.com/apache/spark/commit/98821b91a0273300ffb40c197628f1abf69fbafb).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] mccheah opened a new pull request #28618: [WIP][SPARK-31801][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox


mccheah opened a new pull request #28618:
URL: https://github.com/apache/spark/pull/28618


   ### What changes were proposed in this pull request?
   
   Adds a `ShuffleOutputTracker` API that can be used for managing shuffle 
metadata on the driver. Accepts map output metadata returned by the map output 
writers.
   
   Requires https://github.com/apache/spark/pull/28616.
   
   ### Why are the changes needed?
   
   Part of the design as discussed in [this 
document](https://docs.google.com/document/d/1Aj6IyMsbS2sdIfHxLvIbHUNjHIWHTabfknIPoxOrTjk/edit#),
 and part of the wider effort of SPARK-25299.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Enables additional APIs for the shuffle storage plugin tree. Usage will 
become more apparent when the read side of the shuffle plugin tree is 
introduced.
   
   ### How was this patch tested?
   
   We've added a mock implementation of the shuffle plugin tree here, to prove 
that a Spark job using a different implementation of the plugin can use all of 
the plugin points for an alternative shuffle data storage solution.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28617: [SPARK-31694][SQL][WIP] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28617:
URL: https://github.com/apache/spark/pull/28617#issuecomment-632962034


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28617: [SPARK-31694][SQL][WIP] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28617:
URL: https://github.com/apache/spark/pull/28617#issuecomment-632962217


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28617: [SPARK-31694][SQL][WIP] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28617:
URL: https://github.com/apache/spark/pull/28617#issuecomment-632962034


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] holdenk commented on pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability

2020-05-22 Thread GitBox


holdenk commented on pull request #28614:
URL: https://github.com/apache/spark/pull/28614#issuecomment-632961876


   Merged to master.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] stczwd opened a new pull request #28617: [SPARK-32694][SQL][WIP] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-05-22 Thread GitBox


stczwd opened a new pull request #28617:
URL: https://github.com/apache/spark/pull/28617


   ### What changes were proposed in this pull request?
   There are no partition Commands, such as AlterTableAddPartition supported in 
DatasourceV2, it is widely used in mysql or hive or other datasources. Thus it 
is necessary to defined Partition Catalog API to support these Commands.
   
   We add TablePartition to store partition messages and SupportsPartitions to 
support these commands.
   
   
   ### Does this PR introduce _any_ user-facing change?
   Yes. This PR will enable user to use some partition commands
   
   
   ### How was this patch tested?
   run all tests and add some partition api tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] asfgit closed pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability

2020-05-22 Thread GitBox


asfgit closed pull request #28614:
URL: https://github.com/apache/spark/pull/28614


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632957704







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632957704







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


SparkQA removed a comment on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632930084


   **[Test build #123021 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123021/testReport)**
 for PR 28610 at commit 
[`9d736ef`](https://github.com/apache/spark/commit/9d736efdc4f0ef456ae90eac7eb032c9e09ae8ed).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


SparkQA commented on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632957362


   **[Test build #123021 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123021/testReport)**
 for PR 28610 at commit 
[`9d736ef`](https://github.com/apache/spark/commit/9d736efdc4f0ef456ae90eac7eb032c9e09ae8ed).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon edited a comment on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-22 Thread GitBox


HyukjinKwon edited a comment on pull request #28523:
URL: https://github.com/apache/spark/pull/28523#issuecomment-632953003


   @rdblue Looks it became the different proposal as you and other people 
discussed and suggested there, which you didn't technically vote for. It seems 
reviewed properly by other committers, and I see you were pinged multiple times.
   
   I am surprised people actually thumbed up for the comment that simply 
misunderstood.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #26422: [SPARK-29786][SQL] Fix MetaException when dropping a partition not exists on HDFS

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #26422:
URL: https://github.com/apache/spark/pull/26422#issuecomment-632955271


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] github-actions[bot] closed pull request #27213: [SPARK-30516][SQL] involve partition filters in the statistic estimation of FileScan

2020-05-22 Thread GitBox


github-actions[bot] closed pull request #27213:
URL: https://github.com/apache/spark/pull/27213


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] github-actions[bot] closed pull request #26503: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-22 Thread GitBox


github-actions[bot] closed pull request #26503:
URL: https://github.com/apache/spark/pull/26503


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-22 Thread GitBox


HyukjinKwon commented on pull request #28523:
URL: https://github.com/apache/spark/pull/28523#issuecomment-632953003


   Looks it became the different proposal as you and other people discussed and 
suggested there, which you didn't technically vote for. It seems reviewed 
properly by other committers, and I see you were pinged multiple times.
   
   I am surprised people actually thumbed up for the comment that simply 
misunderstood.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox


maropu commented on a change in pull request #28600:
URL: https://github.com/apache/spark/pull/28600#discussion_r429495426



##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3495,6 +3495,14 @@ class SQLQuerySuite extends QueryTest with 
SharedSparkSession with AdaptiveSpark
 assert(df4.schema.head.name === "randn(1)")
 checkIfSeedExistsInExplain(df2)
   }
+
+  test("SPARK-31761: test byte, short, integer overflow for (Divide) integral 
type ") {

Review comment:
   nit: `integral type "` -> `integral type"`





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox


maropu commented on a change in pull request #28600:
URL: https://github.com/apache/spark/pull/28600#discussion_r429495362



##
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##
@@ -684,6 +685,24 @@ object TypeCoercion {
 }
   }
 
+  /**
+   * The DIV operator always returns long-type value .
+   * This rule cast the integral inputs to long type, to avoid overflow during 
calculation.
+   */
+  object IntegralDivision extends TypeCoercionRule {
+override protected def coerceTypes(
+plan: LogicalPlan): LogicalPlan = plan resolveExpressions {
+  case e if !e.childrenResolved => e
+  case d @ IntegralDivide(left, right) =>
+IntegralDivide(castToLong(left), castToLong(right))
+}
+
+def castToLong(expr: Expression): Expression = expr.dataType match {

Review comment:
   nit: `private def mayCastToLong`.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HeartSaVioR commented on pull request #27664: [SPARK-30915][SS] CompactibleFileStreamLog: Avoid reading the metadata log file when finding the latest batch ID

2020-05-22 Thread GitBox


HeartSaVioR commented on pull request #27664:
URL: https://github.com/apache/spark/pull/27664#issuecomment-632952595


   Thanks all for reviewing and merging!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox


maropu commented on a change in pull request #28600:
URL: https://github.com/apache/spark/pull/28600#discussion_r429492387



##
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##
@@ -684,6 +685,24 @@ object TypeCoercion {
 }
   }
 
+  /**
+   * The DIV operator always returns long-type value .
+   * This rule cast the integral inputs to long type, to avoid overflow during 
calculation.
+   */
+  object IntegralDivision extends TypeCoercionRule {
+override protected def coerceTypes(
+plan: LogicalPlan): LogicalPlan = plan resolveExpressions {

Review comment:
   nit: It seems you don't need the line break.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] huaxingao commented on pull request #28608: [SPARK-31612][SQL][DOCS][FOLLOW-UP] Fix a few issues in SQL ref

2020-05-22 Thread GitBox


huaxingao commented on pull request #28608:
URL: https://github.com/apache/spark/pull/28608#issuecomment-632947089


   Thanks @maropu @srowen 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox


maropu commented on a change in pull request #28600:
URL: https://github.com/apache/spark/pull/28600#discussion_r429492032



##
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##
@@ -684,6 +685,24 @@ object TypeCoercion {
 }
   }
 
+  /**
+   * The DIV operator always returns long-type value .

Review comment:
   nit: `value .` -> `value.`





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox


maropu commented on a change in pull request #28600:
URL: https://github.com/apache/spark/pull/28600#discussion_r429491977



##
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##
@@ -684,6 +685,24 @@ object TypeCoercion {
 }
   }
 
+  /**
+   * The DIV operator always returns long-type value .
+   * This rule cast the integral inputs to long type, to avoid overflow during 
calculation.
+   */
+  object IntegralDivision extends TypeCoercionRule {

Review comment:
   Plz add fine-grained tests  for this rule in `TypeCoercionSuite`.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu closed pull request #28604: [SPARK-29854][SQL][TESTS] Add tests to check lpad/rpad throw an exception for invalid length input

2020-05-22 Thread GitBox


maropu closed pull request #28604:
URL: https://github.com/apache/spark/pull/28604


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu commented on pull request #28604: [SPARK-29854][SQL][TESTS] Add tests to check lpad/rpad throw an exception for invalid length input

2020-05-22 Thread GitBox


maropu commented on pull request #28604:
URL: https://github.com/apache/spark/pull/28604#issuecomment-632946339


   Thanks, all! Merged to master/3.0.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu closed pull request #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

2020-05-22 Thread GitBox


maropu closed pull request #27024:
URL: https://github.com/apache/spark/pull/27024


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] asfgit closed pull request #27664: [SPARK-30915][SS] CompactibleFileStreamLog: Avoid reading the metadata log file when finding the latest batch ID

2020-05-22 Thread GitBox


asfgit closed pull request #27664:
URL: https://github.com/apache/spark/pull/27664


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu commented on pull request #28608: [SPARK-31612][SQL][DOCS][FOLLOW-UP] Fix a few issues in SQL ref

2020-05-22 Thread GitBox


maropu commented on pull request #28608:
URL: https://github.com/apache/spark/pull/28608#issuecomment-632945396


   Merged to master/3.0.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] zsxwing commented on pull request #27664: [SPARK-30915][SS] CompactibleFileStreamLog: Avoid reading the metadata log file when finding the latest batch ID

2020-05-22 Thread GitBox


zsxwing commented on pull request #27664:
URL: https://github.com/apache/spark/pull/27664#issuecomment-632945403


   Thanks! Merging to master.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu closed pull request #28608: [SPARK-31612][SQL][DOCS][FOLLOW-UP] Fix a few issues in SQL ref

2020-05-22 Thread GitBox


maropu closed pull request #28608:
URL: https://github.com/apache/spark/pull/28608


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] jiangxb1987 commented on pull request #26503: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-22 Thread GitBox


jiangxb1987 commented on pull request #26503:
URL: https://github.com/apache/spark/pull/26503#issuecomment-632938069


   @caneGuy I'll merge this PR after you addressed Vanzin's comments.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28616: [SPARK-31798][SHUFFLE][API] Shuffle Writer API changes to return custom map output metadata

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28616:
URL: https://github.com/apache/spark/pull/28616#issuecomment-632936256


   Merged build finished. Test PASSed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28616: [SPARK-31798][SHUFFLE][API] Shuffle Writer API changes to return custom map output metadata

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28616:
URL: https://github.com/apache/spark/pull/28616#issuecomment-632936256


   Merged build finished. Test PASSed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28616: [SPARK-31798][SHUFFLE][API] Shuffle Writer API changes to return custom map output metadata

2020-05-22 Thread GitBox


SparkQA removed a comment on pull request #28616:
URL: https://github.com/apache/spark/pull/28616#issuecomment-632893338


   **[Test build #123020 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123020/testReport)**
 for PR 28616 at commit 
[`6ecd3ad`](https://github.com/apache/spark/commit/6ecd3ad725107cb6508a20190b3d6327eb7ab3c7).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] skambha commented on pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-05-22 Thread GitBox


skambha commented on pull request #27627:
URL: https://github.com/apache/spark/pull/27627#issuecomment-632935982


   Hi @cloud-fan, I have posted some comments on the 
https://github.com/skambha/spark/pull/1 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28616: [SPARK-31798][SHUFFLE][API] Shuffle Writer API changes to return custom map output metadata

2020-05-22 Thread GitBox


SparkQA commented on pull request #28616:
URL: https://github.com/apache/spark/pull/28616#issuecomment-632935966


   **[Test build #123020 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123020/testReport)**
 for PR 28616 at commit 
[`6ecd3ad`](https://github.com/apache/spark/commit/6ecd3ad725107cb6508a20190b3d6327eb7ab3c7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632930383







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632930383







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28601: [SPARK-31786][K8S][BUILD] Upgrade kubernetes-client to 4.9.2

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28601:
URL: https://github.com/apache/spark/pull/28601#issuecomment-632930187







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28601: [SPARK-31786][K8S][BUILD] Upgrade kubernetes-client to 4.9.2

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28601:
URL: https://github.com/apache/spark/pull/28601#issuecomment-632930187







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


SparkQA commented on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632930084


   **[Test build #123021 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123021/testReport)**
 for PR 28610 at commit 
[`9d736ef`](https://github.com/apache/spark/commit/9d736efdc4f0ef456ae90eac7eb032c9e09ae8ed).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28601: [SPARK-31786][K8S][BUILD] Upgrade kubernetes-client to 4.9.2

2020-05-22 Thread GitBox


SparkQA removed a comment on pull request #28601:
URL: https://github.com/apache/spark/pull/28601#issuecomment-632862106


   **[Test build #123017 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123017/testReport)**
 for PR 28601 at commit 
[`4327940`](https://github.com/apache/spark/commit/43279402fbd10ee1cfecbc01d3fdec46f7cbc7d2).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632929644







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632929644







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28601: [SPARK-31786][K8S][BUILD] Upgrade kubernetes-client to 4.9.2

2020-05-22 Thread GitBox


SparkQA commented on pull request #28601:
URL: https://github.com/apache/spark/pull/28601#issuecomment-632929676


   **[Test build #123017 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123017/testReport)**
 for PR 28601 at commit 
[`4327940`](https://github.com/apache/spark/commit/43279402fbd10ee1cfecbc01d3fdec46f7cbc7d2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


SparkQA removed a comment on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632862111


   **[Test build #123016 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123016/testReport)**
 for PR 28610 at commit 
[`0a089ad`](https://github.com/apache/spark/commit/0a089ad7bd89a379264c612c9e5e7071d7c4a707).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


SparkQA commented on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632929206


   **[Test build #123016 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123016/testReport)**
 for PR 28610 at commit 
[`0a089ad`](https://github.com/apache/spark/commit/0a089ad7bd89a379264c612c9e5e7071d7c4a707).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632925412


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123018/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632925404


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632925404







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


SparkQA removed a comment on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632879997


   **[Test build #123018 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123018/testReport)**
 for PR 28610 at commit 
[`4fe6be1`](https://github.com/apache/spark/commit/4fe6be150e777203e4d8c6973107fab339573a40).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox


SparkQA commented on pull request #28610:
URL: https://github.com/apache/spark/pull/28610#issuecomment-632925032


   **[Test build #123018 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123018/testReport)**
 for PR 28610 at commit 
[`4fe6be1`](https://github.com/apache/spark/commit/4fe6be150e777203e4d8c6973107fab339573a40).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] turboFei commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] For dynamic partition overwrite operation, fix speculation task conflict issue and FileAlreadyExistsExceptio

2020-05-22 Thread GitBox


turboFei commented on pull request #26339:
URL: https://github.com/apache/spark/pull/26339#issuecomment-632923671


   have sent an email into that email thread, thanks a lot @Ngone51 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28613: [SPARK-31755][SQL][FOLLOWUP] Update date-time, CSV and JSON benchmark results

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28613:
URL: https://github.com/apache/spark/pull/28613#issuecomment-632920630







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28613: [SPARK-31755][SQL][FOLLOWUP] Update date-time, CSV and JSON benchmark results

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28613:
URL: https://github.com/apache/spark/pull/28613#issuecomment-632920630







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28613: [SPARK-31755][SQL][FOLLOWUP] Update date-time, CSV and JSON benchmark results

2020-05-22 Thread GitBox


SparkQA commented on pull request #28613:
URL: https://github.com/apache/spark/pull/28613#issuecomment-632920089


   **[Test build #123011 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123011/testReport)**
 for PR 28613 at commit 
[`117b3d0`](https://github.com/apache/spark/commit/117b3d082162396070d03c5a92b8edfb163c3f59).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28613: [SPARK-31755][SQL][FOLLOWUP] Update date-time, CSV and JSON benchmark results

2020-05-22 Thread GitBox


SparkQA removed a comment on pull request #28613:
URL: https://github.com/apache/spark/pull/28613#issuecomment-632787264


   **[Test build #123011 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123011/testReport)**
 for PR 28613 at commit 
[`117b3d0`](https://github.com/apache/spark/commit/117b3d082162396070d03c5a92b8edfb163c3f59).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632914986







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632914986







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-22 Thread GitBox


SparkQA removed a comment on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632781808


   **[Test build #123010 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123010/testReport)**
 for PR 28592 at commit 
[`3047f88`](https://github.com/apache/spark/commit/3047f88bb3d0ca95ea4135e3c997f0602578c480).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-22 Thread GitBox


SparkQA commented on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632914362


   **[Test build #123010 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123010/testReport)**
 for PR 28592 at commit 
[`3047f88`](https://github.com/apache/spark/commit/3047f88bb3d0ca95ea4135e3c997f0602578c480).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
 * `case class SecondsToTimestamp(child: Expression)`
 * `case class MillisToTimestamp(child: Expression)`
 * `case class MicrosToTimestamp(child: Expression)`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28615: [SPARK-31778][K8S][BUILD] Support cross-building docker images

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #28615:
URL: https://github.com/apache/spark/pull/28615#issuecomment-632910491







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28615: [SPARK-31778][K8S][BUILD] Support cross-building docker images

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #28615:
URL: https://github.com/apache/spark/pull/28615#issuecomment-632910491







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28615: [SPARK-31778][K8S][BUILD] Support cross-building docker images

2020-05-22 Thread GitBox


SparkQA removed a comment on pull request #28615:
URL: https://github.com/apache/spark/pull/28615#issuecomment-632831451


   **[Test build #123014 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123014/testReport)**
 for PR 28615 at commit 
[`ea0769d`](https://github.com/apache/spark/commit/ea0769dc04803402c252feff238fc5edab517dda).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #27664: [SPARK-30915][SS] CompactibleFileStreamLog: Avoid reading the metadata log file when finding the latest batch ID

2020-05-22 Thread GitBox


AmplabJenkins commented on pull request #27664:
URL: https://github.com/apache/spark/pull/27664#issuecomment-632909876







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #27664: [SPARK-30915][SS] CompactibleFileStreamLog: Avoid reading the metadata log file when finding the latest batch ID

2020-05-22 Thread GitBox


AmplabJenkins removed a comment on pull request #27664:
URL: https://github.com/apache/spark/pull/27664#issuecomment-632909876







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28615: [SPARK-31778][K8S][BUILD] Support cross-building docker images

2020-05-22 Thread GitBox


SparkQA commented on pull request #28615:
URL: https://github.com/apache/spark/pull/28615#issuecomment-632909655


   **[Test build #123014 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123014/testReport)**
 for PR 28615 at commit 
[`ea0769d`](https://github.com/apache/spark/commit/ea0769dc04803402c252feff238fc5edab517dda).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



  1   2   3   4   5   6   7   >