[GitHub] [spark] cloud-fan commented on a change in pull request #28824: [SPARK-31984][SQL] Make micros rebasing functions via local timestamps pure

2020-06-15 Thread GitBox
cloud-fan commented on a change in pull request #28824: URL: https://github.com/apache/spark/pull/28824#discussion_r440626757 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/RebaseDateTimeSuite.scala ## @@ -416,38 +418,39 @@ class RebaseDateTimeSui

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-644567030 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28810: [SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28810: URL: https://github.com/apache/spark/pull/28810#issuecomment-644566932 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-644567025 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644566919 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28824: [SPARK-31984][SQL] Make micros rebasing functions via local timestamps pure

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28824: URL: https://github.com/apache/spark/pull/28824#issuecomment-644566910 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-644567025 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28810: [SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28810: URL: https://github.com/apache/spark/pull/28810#issuecomment-644566932 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644566919 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-68725 **[Test build #124079 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124079/testReport)** for PR 28784 at commit [`1177e9a`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28824: [SPARK-31984][SQL] Make micros rebasing functions via local timestamps pure

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28824: URL: https://github.com/apache/spark/pull/28824#issuecomment-644566910 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28784: [SPARK-31957][SQL][test-maven] Cleanup hive scratch dir for the developer api startWithContext

2020-06-15 Thread GitBox
SparkQA commented on pull request #28784: URL: https://github.com/apache/spark/pull/28784#issuecomment-644566496 **[Test build #124079 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124079/testReport)** for PR 28784 at commit [`1177e9a`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #28824: [SPARK-31984][SQL] Make micros rebasing functions via local timestamps pure

2020-06-15 Thread GitBox
SparkQA commented on pull request #28824: URL: https://github.com/apache/spark/pull/28824#issuecomment-644566345 **[Test build #124103 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124103/testReport)** for PR 28824 at commit [`381e950`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28810: [SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

2020-06-15 Thread GitBox
SparkQA commented on pull request #28810: URL: https://github.com/apache/spark/pull/28810#issuecomment-644566350 **[Test build #124104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124104/testReport)** for PR 28810 at commit [`1251b68`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
SparkQA commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644566272 **[Test build #124102 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124102/testReport)** for PR 28835 at commit [`9c6ac83`](https://github.com

[GitHub] [spark] sarutak edited a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
sarutak edited a comment on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644553331 @liucht-inspur You can't run Jenkins by yourself for now. If you continue to contribute to Spark, you will be added to the whitelist and be given the right to run Jenki

[GitHub] [spark] sarutak edited a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
sarutak edited a comment on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644553331 @liucht-inspur You can't run Jenkins by yourself for now. If you continue to contribute to Spark, you will be added to the whitelist and given the right to run Jenkins

[GitHub] [spark] yaooqinn commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP][test-maven] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
yaooqinn commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644564303 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on pull request #28810: [SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

2020-06-15 Thread GitBox
maropu commented on pull request #28810: URL: https://github.com/apache/spark/pull/28810#issuecomment-644563828 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [spark] dbtsai commented on a change in pull request #28788: [SPARK-31960][Yarn][Build] Only populate Hadoop classpath for no-hadoop build

2020-06-15 Thread GitBox
dbtsai commented on a change in pull request #28788: URL: https://github.com/apache/spark/pull/28788#discussion_r440618141 ## File path: docs/running-on-yarn.md ## @@ -82,6 +82,19 @@ In `cluster` mode, the driver runs on a different machine than the client, so `S Running Sp

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28838: [SPARK-31997][SQL][TESTS] Drop test_udtf table when SingleSessionSuite test completed

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28838: URL: https://github.com/apache/spark/pull/28838#issuecomment-644560857 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28838: [SPARK-31997][SQL][TESTS] Drop test_udtf table when SingleSessionSuite test completed

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28838: URL: https://github.com/apache/spark/pull/28838#issuecomment-644560857 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28838: [SPARK-31997][SQL][TESTS] Drop test_udtf table when SingleSessionSuite test completed

2020-06-15 Thread GitBox
SparkQA commented on pull request #28838: URL: https://github.com/apache/spark/pull/28838#issuecomment-644560348 **[Test build #124101 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124101/testReport)** for PR 28838 at commit [`03bf55f`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644559483 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644559477 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644515779 **[Test build #124088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124088/testReport)** for PR 28835 at commit [`9c6ac83`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28838: [SPARK-31997][SQL][TESTS] Drop test_udtf table when SingleSessionSuite test completed

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28838: URL: https://github.com/apache/spark/pull/28838#issuecomment-644536866 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644559477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Cleanup the thread local variable of hive metastore

2020-06-15 Thread GitBox
SparkQA commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-644559034 **[Test build #124088 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124088/testReport)** for PR 28835 at commit [`9c6ac83`](https://github.co

[GitHub] [spark] wangyum commented on pull request #28838: [SPARK-31997][SQL][TESTS] Drop test_udtf table when SingleSessionSuite test completed

2020-06-15 Thread GitBox
wangyum commented on pull request #28838: URL: https://github.com/apache/spark/pull/28838#issuecomment-644558909 ok to test. This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [spark] SparkQA commented on pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-06-15 Thread GitBox
SparkQA commented on pull request #28715: URL: https://github.com/apache/spark/pull/28715#issuecomment-644557745 **[Test build #124100 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124100/testReport)** for PR 28715 at commit [`a85f511`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28715: URL: https://github.com/apache/spark/pull/28715#issuecomment-64470 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28715: URL: https://github.com/apache/spark/pull/28715#issuecomment-64470 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644554496 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] karuppayya commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-06-15 Thread GitBox
karuppayya commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r440609572 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ## @@ -226,18 +226,33 @@ case class GenerateExec( "0"

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644554489 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] karuppayya commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-06-15 Thread GitBox
karuppayya commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r440609352 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ## @@ -226,18 +226,33 @@ case class GenerateExec( "0"

[GitHub] [spark] SparkQA commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
SparkQA commented on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644555082 **[Test build #124099 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124099/testReport)** for PR 28799 at commit [`7969e44`](https://github.com

[GitHub] [spark] karuppayya commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-06-15 Thread GitBox
karuppayya commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r440609422 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala ## @@ -51,6 +51,93 @@ class WholeStageCodegenSuite e

[GitHub] [spark] AmplabJenkins commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644554489 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644524138 **[Test build #124091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124091/testReport)** for PR 28836 at commit [`be81da3`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644553439 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] SparkQA commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644554389 **[Test build #124091 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124091/testReport)** for PR 28836 at commit [`be81da3`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644538711 **[Test build #124097 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124097/testReport)** for PR 28836 at commit [`2555c49`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644553430 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] sarutak commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
sarutak commented on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644553331 @liucht-inspur You can't run Jenkins by yourself for now. If you continue to contribute to Spark, you will added to the whitelist and be given the right to run Jenkins by sayi

[GitHub] [spark] AmplabJenkins commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644553430 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644553374 **[Test build #124097 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124097/testReport)** for PR 28836 at commit [`2555c49`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644552854 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] LuciferYang commented on pull request #28838: [SPARK-31997][SQL][TESTS] Drop test_udtf table when SingleSessionSuite test completed

2020-06-15 Thread GitBox
LuciferYang commented on pull request #28838: URL: https://github.com/apache/spark/pull/28838#issuecomment-644553047 ping @xuanyuanking This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644552854 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] sarutak commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
sarutak commented on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644552511 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] karuppayya commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-06-15 Thread GitBox
karuppayya commented on a change in pull request #28715: URL: https://github.com/apache/spark/pull/28715#discussion_r440603564 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ## @@ -226,18 +226,33 @@ case class GenerateExec( "0"

[GitHub] [spark] liucht-inspur commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
liucht-inspur commented on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644549227 retest this please. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] cloud-fan closed pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps

2020-06-15 Thread GitBox
cloud-fan closed pull request #28816: URL: https://github.com/apache/spark/pull/28816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] cloud-fan commented on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps

2020-06-15 Thread GitBox
cloud-fan commented on pull request #28816: URL: https://github.com/apache/spark/pull/28816#issuecomment-644548956 thanks, merging to master/3.0! This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [spark] karuppayya commented on pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2020-06-15 Thread GitBox
karuppayya commented on pull request #28715: URL: https://github.com/apache/spark/pull/28715#issuecomment-644546701 @maropu Updated the description with benchmarks. This is an automated message from the Apache Git Service. To

[GitHub] [spark] ulysses-you commented on a change in pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
ulysses-you commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440601141 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala ## @@ -61,6 +61,7 @@ class DataTypeParserSui

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-644544929 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-644544929 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-644488405 **[Test build #124083 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124083/testReport)** for PR 28635 at commit [`0a71849`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-06-15 Thread GitBox
SparkQA commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-644544080 **[Test build #124083 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124083/testReport)** for PR 28635 at commit [`0a71849`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28810: [SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28810: URL: https://github.com/apache/spark/pull/28810#issuecomment-644543101 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28810: [SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28810: URL: https://github.com/apache/spark/pull/28810#issuecomment-644543095 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28810: [SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28810: URL: https://github.com/apache/spark/pull/28810#issuecomment-644543095 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28810: [SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28810: URL: https://github.com/apache/spark/pull/28810#issuecomment-644476504 **[Test build #124081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124081/testReport)** for PR 28810 at commit [`1251b68`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28810: [SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

2020-06-15 Thread GitBox
SparkQA commented on pull request #28810: URL: https://github.com/apache/spark/pull/28810#issuecomment-644542692 **[Test build #124081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124081/testReport)** for PR 28810 at commit [`1251b68`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644541643 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644541638 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644541638 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644508863 **[Test build #124086 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124086/testReport)** for PR 28799 at commit [`7969e44`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28799: [SPARK-31871][CORE][WEBUI][2.4] Display the canvas element icon for sorting column

2020-06-15 Thread GitBox
SparkQA commented on pull request #28799: URL: https://github.com/apache/spark/pull/28799#issuecomment-644541195 **[Test build #124086 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124086/testReport)** for PR 28799 at commit [`7969e44`](https://github.co

[GitHub] [spark] HeartSaVioR edited a comment on pull request #28831: [SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' for mixed string/array

2020-06-15 Thread GitBox
HeartSaVioR edited a comment on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-644538409 cc. @kiszk @viirya as initial reviewers as I can see they're contributed the code part. cc. @bersprockets who helps to review initial patch. -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644536779 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] SparkQA commented on pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
SparkQA commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644538725 **[Test build #124098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124098/testReport)** for PR 28833 at commit [`479901d`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644538711 **[Test build #124097 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124097/testReport)** for PR 28836 at commit [`2555c49`](https://github.com

[GitHub] [spark] HeartSaVioR commented on pull request #28831: [SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' for mixed string/array types

2020-06-15 Thread GitBox
HeartSaVioR commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-644538409 cc. @kiszk @viirya as initial reviews as I can see they're contributed the code part. cc. @bersprockets who helps to review initial patch. --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644537540 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] SparkQA removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644536706 **[Test build #124095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124095/testReport)** for PR 28836 at commit [`31e6573`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644537530 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644537521 **[Test build #124095 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124095/testReport)** for PR 28836 at commit [`31e6573`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644537530 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28831: [SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' for mixed string/

2020-06-15 Thread GitBox
HeartSaVioR commented on a change in pull request #28831: URL: https://github.com/apache/spark/pull/28831#discussion_r440592664 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala ## @@ -123,26 +123,41 @@ case class Conca

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644536999 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644537057 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28831: [SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' for mixed string/ar

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-644537071 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644536999 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28838: [SPARK-31997][SQL][TESTS] Drop test_udtf table when SingleSessionSuite test completed

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28838: URL: https://github.com/apache/spark/pull/28838#issuecomment-644536555 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #28831: [SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' for mixed string/array type

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-644537071 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644536775 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644537057 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28838: [SPARK-31997][SQL][TESTS] Drop test_udtf table when SingleSessionSuite test completed

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28838: URL: https://github.com/apache/spark/pull/28838#issuecomment-644536866 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] SparkQA commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

2020-06-15 Thread GitBox
SparkQA commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-644536706 **[Test build #124095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124095/testReport)** for PR 28836 at commit [`31e6573`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644536775 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28831: [SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' for mixed string/array types of c

2020-06-15 Thread GitBox
SparkQA commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-644536708 **[Test build #124096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124096/testReport)** for PR 28831 at commit [`d75ad5a`](https://github.com

[GitHub] [spark] maropu commented on pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
maropu commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644536578 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [spark] AmplabJenkins commented on pull request #28838: [SPARK-31997][SQL][TESTS] Drop test_udtf table when SingleSessionSuite test completed

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28838: URL: https://github.com/apache/spark/pull/28838#issuecomment-644536555 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] SparkQA removed a comment on pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644460954 **[Test build #124080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124080/testReport)** for PR 28833 at commit [`479901d`](https://gi

[GitHub] [spark] LuciferYang opened a new pull request #28838: [SPARK-31997][SQL][TESTS] Drop test_udtf table when SingleSessionSuite test completed

2020-06-15 Thread GitBox
LuciferYang opened a new pull request #28838: URL: https://github.com/apache/spark/pull/28838 ### What changes were proposed in this pull request? `SingleSessionSuite` not do `DROP TABLE IF EXISTS test_udtf` when test completed, then if we do mvn test `HiveThriftBinaryServerSuite`, the t

[GitHub] [spark] SparkQA commented on pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype

2020-06-15 Thread GitBox
SparkQA commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644536074 **[Test build #124080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124080/testReport)** for PR 28833 at commit [`479901d`](https://github.co

  1   2   3   4   5   6   7   8   >