huaxingao commented on pull request #29043:
URL: https://github.com/apache/spark/pull/29043#issuecomment-657179299
@TJX2014
I am still not convinced that it's a good idea to map TimeStamp to DateTime
in MySQLDialect. Using an example similar to yours:
```
sql("select
AmplabJenkins removed a comment on pull request #28898:
URL: https://github.com/apache/spark/pull/28898#issuecomment-657178823
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28898:
URL: https://github.com/apache/spark/pull/28898#issuecomment-657178823
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28898:
URL: https://github.com/apache/spark/pull/28898#issuecomment-657154729
**[Test build #125699 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125699/testReport)**
for PR 28898 at commit
SparkQA commented on pull request #28898:
URL: https://github.com/apache/spark/pull/28898#issuecomment-657178726
**[Test build #125699 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125699/testReport)**
for PR 28898 at commit
imback82 commented on pull request #28123:
URL: https://github.com/apache/spark/pull/28123#issuecomment-657170656
> (3).We are seeing in production, coalescing might hurt the parallelism, if
the number of buckets are too few. Another way to avoid shuffle and sort, is to
split/divide the
imback82 commented on a change in pull request #29074:
URL: https://github.com/apache/spark/pull/29074#discussion_r453261237
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
##
@@ -171,19 +176,50 @@ case class
AmplabJenkins removed a comment on pull request #29074:
URL: https://github.com/apache/spark/pull/29074#issuecomment-657167465
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29074:
URL: https://github.com/apache/spark/pull/29074#issuecomment-657167465
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29074:
URL: https://github.com/apache/spark/pull/29074#issuecomment-657167295
**[Test build #125704 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125704/testReport)**
for PR 29074 at commit
maropu commented on pull request #28123:
URL: https://github.com/apache/spark/pull/28123#issuecomment-657166984
Thanks for your interest, @c21
> (1).Is there a reason why we don't cover ShuffledHashJoin as well? (we are
seeing in production, people also use ShuffledHashJoin a lot
imback82 opened a new pull request #29074:
URL: https://github.com/apache/spark/pull/29074
### What changes were proposed in this pull request?
This PR proposes to improve `EnsureRquirement.reorderJoinKeys` to handle
the following scenarios:
1. If the keys cannot be
AmplabJenkins removed a comment on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657165941
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657163429
**[Test build #125702 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125702/testReport)**
for PR 29069 at commit
AmplabJenkins commented on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657165941
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657165900
**[Test build #125702 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125702/testReport)**
for PR 29069 at commit
kiszk commented on a change in pull request #29067:
URL: https://github.com/apache/spark/pull/29067#discussion_r453257863
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/InMemoryColumnarQuerySuite.scala
##
@@ -474,12 +484,8 @@ class
AmplabJenkins removed a comment on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657163573
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-657163572
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657163573
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-657163572
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-657163441
**[Test build #125703 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125703/testReport)**
for PR 28715 at commit
SparkQA commented on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657163429
**[Test build #125702 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125702/testReport)**
for PR 29069 at commit
kiszk commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-657162781
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
AmplabJenkins removed a comment on pull request #29072:
URL: https://github.com/apache/spark/pull/29072#issuecomment-657162290
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29072:
URL: https://github.com/apache/spark/pull/29072#issuecomment-657162290
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29072:
URL: https://github.com/apache/spark/pull/29072#issuecomment-657142312
**[Test build #125695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125695/testReport)**
for PR 29072 at commit
SparkQA commented on pull request #29072:
URL: https://github.com/apache/spark/pull/29072#issuecomment-657162153
**[Test build #125695 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125695/testReport)**
for PR 29072 at commit
AmplabJenkins removed a comment on pull request #29072:
URL: https://github.com/apache/spark/pull/29072#issuecomment-657161975
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29072:
URL: https://github.com/apache/spark/pull/29072#issuecomment-657161975
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29072:
URL: https://github.com/apache/spark/pull/29072#issuecomment-657143178
**[Test build #125696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125696/testReport)**
for PR 29072 at commit
SparkQA commented on pull request #29072:
URL: https://github.com/apache/spark/pull/29072#issuecomment-657161855
**[Test build #125696 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125696/testReport)**
for PR 29072 at commit
AmplabJenkins removed a comment on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657160470
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA removed a comment on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657159524
**[Test build #125701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125701/testReport)**
for PR 29069 at commit
AmplabJenkins removed a comment on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657160466
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA commented on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657160461
**[Test build #125701 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125701/testReport)**
for PR 29069 at commit
AmplabJenkins commented on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657160466
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kiszk commented on pull request #29073:
URL: https://github.com/apache/spark/pull/29073#issuecomment-657160205
Thank you for your contribution.
- Could you update the description based on the template (like
[this](https://github.com/apache/spark/pull/28958))?
- Could you apply this
AmplabJenkins removed a comment on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657159620
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657159620
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657159524
**[Test build #125701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125701/testReport)**
for PR 29069 at commit
AmplabJenkins removed a comment on pull request #28971:
URL: https://github.com/apache/spark/pull/28971#issuecomment-657157966
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28971:
URL: https://github.com/apache/spark/pull/28971#issuecomment-657157966
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-657157955
**[Test build #125700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125700/testReport)**
for PR 29013 at commit
SparkQA removed a comment on pull request #28971:
URL: https://github.com/apache/spark/pull/28971#issuecomment-657133192
**[Test build #125693 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125693/testReport)**
for PR 28971 at commit
SparkQA commented on pull request #28971:
URL: https://github.com/apache/spark/pull/28971#issuecomment-657157739
**[Test build #125693 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125693/testReport)**
for PR 28971 at commit
AmplabJenkins removed a comment on pull request #29066:
URL: https://github.com/apache/spark/pull/29066#issuecomment-657155924
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA removed a comment on pull request #29066:
URL: https://github.com/apache/spark/pull/29066#issuecomment-657128198
**[Test build #125690 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125690/testReport)**
for PR 29066 at commit
SparkQA removed a comment on pull request #28746:
URL: https://github.com/apache/spark/pull/28746#issuecomment-657135885
**[Test build #125694 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125694/testReport)**
for PR 28746 at commit
AmplabJenkins removed a comment on pull request #29066:
URL: https://github.com/apache/spark/pull/29066#issuecomment-657155922
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-657157242
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28746:
URL: https://github.com/apache/spark/pull/28746#issuecomment-657157265
This is an automated message from the Apache Git Service.
To respond to the message, please log on
maropu commented on pull request #29056:
URL: https://github.com/apache/spark/pull/29056#issuecomment-657157467
> LATERAL VIEW，PIVOT I am not sure if them shoud belong to function group or
our key words group,such as SELECT
So i just leave them for furture. I will add it if needed.
AmplabJenkins commented on pull request #28746:
URL: https://github.com/apache/spark/pull/28746#issuecomment-657157265
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-657157242
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28746:
URL: https://github.com/apache/spark/pull/28746#issuecomment-657157152
**[Test build #125694 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125694/testReport)**
for PR 28746 at commit
AmplabJenkins commented on pull request #29066:
URL: https://github.com/apache/spark/pull/29066#issuecomment-657155922
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29066:
URL: https://github.com/apache/spark/pull/29066#issuecomment-657155858
**[Test build #125690 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125690/testReport)**
for PR 29066 at commit
AmplabJenkins removed a comment on pull request #29073:
URL: https://github.com/apache/spark/pull/29073#issuecomment-657155463
Can one of the admins verify this patch?
This is an automated message from the Apache Git
AmplabJenkins commented on pull request #29073:
URL: https://github.com/apache/spark/pull/29073#issuecomment-65716
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
LantaoJin commented on pull request #29062:
URL: https://github.com/apache/spark/pull/29062#issuecomment-657155507
> Can you keep the original PR template? Like "What changes were proposed in
this pull request?" was removed. Please describe why the issue happened and how
this fixes it in
AmplabJenkins commented on pull request #29073:
URL: https://github.com/apache/spark/pull/29073#issuecomment-657155463
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
ChuliangXiao opened a new pull request #29073:
URL: https://github.com/apache/spark/pull/29073
change `true` to `True` in the python code
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR
maropu commented on pull request #28979:
URL: https://github.com/apache/spark/pull/28979#issuecomment-657155312
Thanks! Merged to master.
This is an automated message from the Apache Git Service.
To respond to the message,
maropu closed pull request #28979:
URL: https://github.com/apache/spark/pull/28979
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
AmplabJenkins removed a comment on pull request #28898:
URL: https://github.com/apache/spark/pull/28898#issuecomment-657154893
This is an automated message from the Apache Git Service.
To respond to the message, please log on
maropu commented on pull request #29056:
URL: https://github.com/apache/spark/pull/29056#issuecomment-657154982
> @maropu EXPLAIN LOGICAL seesm disallowed, so i did not add it in the
ref-docs
AFTER key words, i have no ideas about its usage , Do you have any ideas?
LATERAL VIEW，PIVOT
AmplabJenkins commented on pull request #28898:
URL: https://github.com/apache/spark/pull/28898#issuecomment-657154893
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28898:
URL: https://github.com/apache/spark/pull/28898#issuecomment-657154729
**[Test build #125699 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125699/testReport)**
for PR 28898 at commit
maropu commented on pull request #28898:
URL: https://github.com/apache/spark/pull/28898#issuecomment-657154379
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
TJX2014 commented on pull request #29043:
URL: https://github.com/apache/spark/pull/29043#issuecomment-657153936
@srowen @huaxingao Thank you for your response, the main issue resolved by
this PR is ``
This is an automated
TJX2014 closed pull request #29043:
URL: https://github.com/apache/spark/pull/29043
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
TJX2014 removed a comment on pull request #29043:
URL: https://github.com/apache/spark/pull/29043#issuecomment-657153936
@srowen @huaxingao Thank you for your response, the main issue resolved by
this PR is ``
This is an
TJX2014 opened a new pull request #29043:
URL: https://github.com/apache/spark/pull/29043
### What changes were proposed in this pull request?
1. Change timestamp to mysql to datetime in
`org.apache.spark.sql.jdbc.MySQLDialect#getJDBCType`
2. Add UT in
github-actions[bot] commented on pull request #26674:
URL: https://github.com/apache/spark/pull/26674#issuecomment-657153865
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue
TJX2014 edited a comment on pull request #29043:
URL: https://github.com/apache/spark/pull/29043#issuecomment-657024230
@huaxingao
Thank you for your detail response.
Actually, `Timestamp` in spark has the range '0001-01-01T00:00:00.00Z,
-12-31T23:59:59.99Z', see
TJX2014 edited a comment on pull request #29043:
URL: https://github.com/apache/spark/pull/29043#issuecomment-657153038
Hi @srowen , The zone info is according to local zone of mysql, it seems we
should not consider it as timezone loss because we have considered it when
write. The
TJX2014 edited a comment on pull request #29043:
URL: https://github.com/apache/spark/pull/29043#issuecomment-657153038
@srowen The zone info is according to local zone of mysql, it seems we
should not consider it as timezone loss because we have consider it when
writting. The different
TJX2014 edited a comment on pull request #29043:
URL: https://github.com/apache/spark/pull/29043#issuecomment-657153038
@srowen The zone info is according to local zone of mysql, it seems we
should not consider it as timezone loss because we have considered it when
write. The different
TJX2014 commented on pull request #29043:
URL: https://github.com/apache/spark/pull/29043#issuecomment-657153038
@srowen The zone info is according to local zone of mysql, it seems we
should not consider it as timezone loss. The different between DATETIME and
TIMESTAMP is zone index
AmplabJenkins removed a comment on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657152582
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657152579
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657151458
**[Test build #125698 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125698/testReport)**
for PR 29069 at commit
AmplabJenkins commented on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657152579
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657152573
**[Test build #125698 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125698/testReport)**
for PR 29069 at commit
AmplabJenkins removed a comment on pull request #29072:
URL: https://github.com/apache/spark/pull/29072#issuecomment-657151510
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657151632
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657151632
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29072:
URL: https://github.com/apache/spark/pull/29072#issuecomment-657151508
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA commented on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657151458
**[Test build #125698 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125698/testReport)**
for PR 29069 at commit
AmplabJenkins commented on pull request #29072:
URL: https://github.com/apache/spark/pull/29072#issuecomment-657151508
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29072:
URL: https://github.com/apache/spark/pull/29072#issuecomment-657151270
**[Test build #125691 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125691/testReport)**
for PR 29072 at commit
SparkQA removed a comment on pull request #29072:
URL: https://github.com/apache/spark/pull/29072#issuecomment-657131268
**[Test build #125691 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125691/testReport)**
for PR 29072 at commit
AmplabJenkins removed a comment on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657150638
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins commented on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657150686
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657150634
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657150528
**[Test build #125697 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125697/testReport)**
for PR 29069 at commit
frankyin-factual commented on pull request #28898:
URL: https://github.com/apache/spark/pull/28898#issuecomment-657150642
@viirya @maropu Looks like the build env stabilizes. Can I get a retest?
This is an automated message
SparkQA commented on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657150629
**[Test build #125697 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125697/testReport)**
for PR 29069 at commit
AmplabJenkins commented on pull request #29069:
URL: https://github.com/apache/spark/pull/29069#issuecomment-657150634
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
1 - 100 of 470 matches
Mail list logo
