AmplabJenkins removed a comment on pull request #29332:
URL: https://github.com/apache/spark/pull/29332#issuecomment-668996964
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29332:
URL: https://github.com/apache/spark/pull/29332#issuecomment-668996964
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29332:
URL: https://github.com/apache/spark/pull/29332#issuecomment-668959450
**[Test build #127074 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127074/testReport)**
for PR 29332 at commit
SparkQA commented on pull request #29332:
URL: https://github.com/apache/spark/pull/29332#issuecomment-668996210
**[Test build #127074 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127074/testReport)**
for PR 29332 at commit
cloud-fan commented on a change in pull request #29311:
URL: https://github.com/apache/spark/pull/29311#discussion_r465489920
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##
@@ -895,6 +905,10 @@ abstract class CastBase extends
cloud-fan commented on a change in pull request #29311:
URL: https://github.com/apache/spark/pull/29311#discussion_r465489374
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##
@@ -342,7 +344,9 @@ abstract class CastBase extends
cloud-fan commented on a change in pull request #29311:
URL: https://github.com/apache/spark/pull/29311#discussion_r465489447
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##
@@ -351,7 +355,9 @@ abstract class CastBase extends
cloud-fan commented on a change in pull request #29311:
URL: https://github.com/apache/spark/pull/29311#discussion_r465489268
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##
@@ -321,7 +321,9 @@ abstract class CastBase extends
cloud-fan commented on a change in pull request #29311:
URL: https://github.com/apache/spark/pull/29311#discussion_r465488975
##
File path: docs/sql-migration-guide.md
##
@@ -34,6 +34,8 @@ license: |
- In Spark 3.1, structs and maps are wrapped by the `{}` brackets in
stijndehaes commented on pull request #28423:
URL: https://github.com/apache/spark/pull/28423#issuecomment-668991161
@jkleckner I have never had a problem with the driver watching the
executors. I think there was already a fallback mechanism there, but I never
looked into the code for
JkSelf commented on pull request #29266:
URL: https://github.com/apache/spark/pull/29266#issuecomment-668989319
Can you show the plan changes in UI? And whether introduced additional
shuffle when change the partition num in bucket side or not?
cloud-fan commented on pull request #29137:
URL: https://github.com/apache/spark/pull/29137#issuecomment-668988346
```
== Physical Plan ==
AdaptiveSparkPlan (9)
+- == Current Plan ==
BroadcastHashJoin Inner BuildRight (8)
:- Project (3)
: +- Filter (2)
+- ==
ScrapCodes commented on pull request #29334:
URL: https://github.com/apache/spark/pull/29334#issuecomment-668988454
Alrighty, then I will skip this for 2.4.7 release, even though I still feel
that this might be safe and good for people in general, provided jackson 2.6.7
had last release
AmplabJenkins removed a comment on pull request #29353:
URL: https://github.com/apache/spark/pull/29353#issuecomment-668986802
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29352:
URL: https://github.com/apache/spark/pull/29352#issuecomment-668986647
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29353:
URL: https://github.com/apache/spark/pull/29353#issuecomment-668986802
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29352:
URL: https://github.com/apache/spark/pull/29352#issuecomment-668986647
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on pull request #29334:
URL: https://github.com/apache/spark/pull/29334#issuecomment-668986454
For the PR itself, I agree with @srowen's and @dongjoon-hyun comments at
https://github.com/apache/spark/pull/29334#issuecomment-668044607 and
SparkQA removed a comment on pull request #29353:
URL: https://github.com/apache/spark/pull/29353#issuecomment-668914387
**[Test build #127071 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127071/testReport)**
for PR 29353 at commit
SparkQA commented on pull request #29353:
URL: https://github.com/apache/spark/pull/29353#issuecomment-668986200
**[Test build #127071 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127071/testReport)**
for PR 29353 at commit
SparkQA removed a comment on pull request #29352:
URL: https://github.com/apache/spark/pull/29352#issuecomment-668911605
**[Test build #127070 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127070/testReport)**
for PR 29352 at commit
SparkQA commented on pull request #29352:
URL: https://github.com/apache/spark/pull/29352#issuecomment-668985998
**[Test build #127070 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127070/testReport)**
for PR 29352 at commit
HyukjinKwon commented on pull request #29334:
URL: https://github.com/apache/spark/pull/29334#issuecomment-668985839
Yes, I think it does. That was one of reasons why I was hesitant. FYI, there
was a bit of discussions and updates about resources at SPARK-32264.
Given that the PRs
AmplabJenkins removed a comment on pull request #29350:
URL: https://github.com/apache/spark/pull/29350#issuecomment-668985557
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29350:
URL: https://github.com/apache/spark/pull/29350#issuecomment-668985557
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29350:
URL: https://github.com/apache/spark/pull/29350#issuecomment-668985252
**[Test build #127079 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127079/testReport)**
for PR 29350 at commit
HeartSaVioR commented on a change in pull request #29350:
URL: https://github.com/apache/spark/pull/29350#discussion_r465477234
##
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##
@@ -530,10 +530,16 @@ private[history] class
AmplabJenkins removed a comment on pull request #29350:
URL: https://github.com/apache/spark/pull/29350#issuecomment-668691724
Can one of the admins verify this patch?
This is an automated message from the Apache Git
AmplabJenkins removed a comment on pull request #28761:
URL: https://github.com/apache/spark/pull/28761#issuecomment-668983580
This is an automated message from the Apache Git Service.
To respond to the message, please log on
HeartSaVioR commented on pull request #29350:
URL: https://github.com/apache/spark/pull/29350#issuecomment-668983630
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log
ScrapCodes commented on pull request #29334:
URL: https://github.com/apache/spark/pull/29334#issuecomment-668983574
@HyukjinKwon Thanks for looking in to it, and it is my mistake, I did not
know that github actions are not ported to other branches yet. I am not 100%
sure that they should
AmplabJenkins commented on pull request #28761:
URL: https://github.com/apache/spark/pull/28761#issuecomment-668983580
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28761:
URL: https://github.com/apache/spark/pull/28761#issuecomment-668983196
**[Test build #127078 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127078/testReport)**
for PR 28761 at commit
viirya commented on pull request #28761:
URL: https://github.com/apache/spark/pull/28761#issuecomment-668982975
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
HyukjinKwon commented on pull request #29334:
URL: https://github.com/apache/spark/pull/29334#issuecomment-668981971
@ScrapCodes, yes, the m2 is corrupted in Jenkins machine. In the master,
this dependency check is being skipped in Jenkins and GitHub Actions build runs
instead.
In
AmplabJenkins removed a comment on pull request #29031:
URL: https://github.com/apache/spark/pull/29031#issuecomment-668981428
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29031:
URL: https://github.com/apache/spark/pull/29031#issuecomment-668981428
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29031:
URL: https://github.com/apache/spark/pull/29031#issuecomment-668981110
**[Test build #127077 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127077/testReport)**
for PR 29031 at commit
cloud-fan commented on pull request #29031:
URL: https://github.com/apache/spark/pull/29031#issuecomment-668980317
add to whitelist
This is an automated message from the Apache Git Service.
To respond to the message, please
allisonwang-db opened a new pull request #29031:
URL: https://github.com/apache/spark/pull/29031
### What changes were proposed in this pull request?
This PR added a physical rule to remove redundant project nodes. A
`ProjectExec` is redundant when
1. It has the same output
cloud-fan commented on pull request #29031:
URL: https://github.com/apache/spark/pull/29031#issuecomment-668980249
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
cloud-fan closed pull request #29031:
URL: https://github.com/apache/spark/pull/29031
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cloud-fan commented on pull request #29125:
URL: https://github.com/apache/spark/pull/29125#issuecomment-668980063
@skambha you will still hit the sum bug when you disable whole-stage-codegen
(or fallback to it due to generated code exceeds 64kb), right?
We are not introducing a new
ScrapCodes commented on pull request #29334:
URL: https://github.com/apache/spark/pull/29334#issuecomment-668977421
Alright, one more https://github.com/FasterXML/jackson-databind/issues/2798,
Shall we consider 2.10.x ? change is the same and the later is free from whole
store house of
ScrapCodes commented on pull request #29334:
URL: https://github.com/apache/spark/pull/29334#issuecomment-668976387
@Fokko, @srowen and @dongjoon-hyun Thank for giving me the feedback. I
agree, with you guys. But, I wanted to give this patch a try - can it be done
in a clean way? This
MaxGekk commented on pull request #29311:
URL: https://github.com/apache/spark/pull/29311#issuecomment-668976181
@cloud-fan @maropu @HyukjinKwon Please, review this PR.
This is an automated message from the Apache Git
HyukjinKwon commented on pull request #29354:
URL: https://github.com/apache/spark/pull/29354#issuecomment-668975373
It might be great if we can elabourate how it improves performance. We can
focus on the fix only instead of mixing refactoring here.
HyukjinKwon commented on a change in pull request #29354:
URL: https://github.com/apache/spark/pull/29354#discussion_r465466999
##
File path:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala
##
@@ -1,427 +0,0 @@
-/*
Review comment:
Hey,
HyukjinKwon commented on a change in pull request #29353:
URL: https://github.com/apache/spark/pull/29353#discussion_r465466392
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcDeserializer.scala
##
@@ -72,137 +74,191 @@ class
AmplabJenkins removed a comment on pull request #29211:
URL: https://github.com/apache/spark/pull/29211#issuecomment-668973946
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29211:
URL: https://github.com/apache/spark/pull/29211#issuecomment-668973946
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29211:
URL: https://github.com/apache/spark/pull/29211#issuecomment-668973694
**[Test build #127076 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127076/testReport)**
for PR 29211 at commit
SparkQA commented on pull request #29339:
URL: https://github.com/apache/spark/pull/29339#issuecomment-668973681
**[Test build #127075 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127075/testReport)**
for PR 29339 at commit
AmplabJenkins removed a comment on pull request #29339:
URL: https://github.com/apache/spark/pull/29339#issuecomment-668972189
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29339:
URL: https://github.com/apache/spark/pull/29339#issuecomment-668972189
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on a change in pull request #29353:
URL: https://github.com/apache/spark/pull/29353#discussion_r465460837
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcDeserializer.scala
##
@@ -72,137 +74,191 @@ class
HyukjinKwon commented on a change in pull request #29353:
URL: https://github.com/apache/spark/pull/29353#discussion_r465460837
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcDeserializer.scala
##
@@ -72,137 +74,191 @@ class
AmplabJenkins removed a comment on pull request #29333:
URL: https://github.com/apache/spark/pull/29333#issuecomment-668968321
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29333:
URL: https://github.com/apache/spark/pull/29333#issuecomment-668968315
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29333:
URL: https://github.com/apache/spark/pull/29333#issuecomment-668968315
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29333:
URL: https://github.com/apache/spark/pull/29333#issuecomment-668937610
**[Test build #127073 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127073/testReport)**
for PR 29333 at commit
SparkQA commented on pull request #29333:
URL: https://github.com/apache/spark/pull/29333#issuecomment-668968035
**[Test build #127073 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127073/testReport)**
for PR 29333 at commit
HyukjinKwon commented on a change in pull request #29349:
URL: https://github.com/apache/spark/pull/29349#discussion_r465458165
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
##
@@ -47,6 +48,13 @@ import
AmplabJenkins removed a comment on pull request #29332:
URL: https://github.com/apache/spark/pull/29332#issuecomment-668959724
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29332:
URL: https://github.com/apache/spark/pull/29332#issuecomment-668959724
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29332:
URL: https://github.com/apache/spark/pull/29332#issuecomment-668845081
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA commented on pull request #29332:
URL: https://github.com/apache/spark/pull/29332#issuecomment-668959450
**[Test build #127074 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127074/testReport)**
for PR 29332 at commit
beliefer commented on pull request #27429:
URL: https://github.com/apache/spark/pull/27429#issuecomment-668956644
cc @cloud-fan
This is an automated message from the Apache Git Service.
To respond to the message, please log
stczwd commented on a change in pull request #29339:
URL: https://github.com/apache/spark/pull/29339#discussion_r465425990
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterTableDropPartitionExec.scala
##
@@ -0,0 +1,58 @@
+/*
+ *
HyukjinKwon commented on pull request #29333:
URL: https://github.com/apache/spark/pull/29333#issuecomment-668945164
The latest commit above
(https://github.com/apache/spark/pull/29333/commits/2688f21f1852b3e6a577fa9292985b346b9bdf6d)
contains the problem in terms of forked repos and PRs
AmplabJenkins removed a comment on pull request #29333:
URL: https://github.com/apache/spark/pull/29333#issuecomment-668938127
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29333:
URL: https://github.com/apache/spark/pull/29333#issuecomment-668938127
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29333:
URL: https://github.com/apache/spark/pull/29333#issuecomment-668937610
**[Test build #127073 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127073/testReport)**
for PR 29333 at commit
HyukjinKwon commented on pull request #29333:
URL: https://github.com/apache/spark/pull/29333#issuecomment-668935709
I am making some changes to demonstrate the problem in terms of the fork and
PRs. Please ignore the changes made from now on. I will switch back from the
draft later when
HyukjinKwon closed pull request #29320:
URL: https://github.com/apache/spark/pull/29320
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
HyukjinKwon commented on pull request #29320:
URL: https://github.com/apache/spark/pull/29320#issuecomment-668934219
Thank you @viirya for approaching this. I am merging this to master.
This is an automated message from the
HyukjinKwon commented on pull request #29333:
URL: https://github.com/apache/spark/pull/29333#issuecomment-668933522
Sure, let me take a closer look for that approach. In worst case, we might
have to drop this and go back to the original @viirya's approach at #29169.
wangshisan commented on pull request #29266:
URL: https://github.com/apache/spark/pull/29266#issuecomment-668932395
> this is with AQE? if so can we please add that to description and it might
be nice to describe approach taken to handle it in description as well.
Added.
wangshisan commented on a change in pull request #29266:
URL: https://github.com/apache/spark/pull/29266#discussion_r465428028
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##
@@ -250,6 +251,85 @@ case class
wangshisan edited a comment on pull request #29266:
URL: https://github.com/apache/spark/pull/29266#issuecomment-668926319
> Yea I'm also wondering the approach here. The skew join handling needs to
split the skew side, and repeat the other side. I don't think we can split the
buckets of
AmplabJenkins removed a comment on pull request #29339:
URL: https://github.com/apache/spark/pull/29339#issuecomment-668927448
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29339:
URL: https://github.com/apache/spark/pull/29339#issuecomment-668927448
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
stczwd commented on a change in pull request #29339:
URL: https://github.com/apache/spark/pull/29339#discussion_r465425990
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterTableDropPartitionExec.scala
##
@@ -0,0 +1,58 @@
+/*
+ *
SparkQA commented on pull request #29339:
URL: https://github.com/apache/spark/pull/29339#issuecomment-668927081
**[Test build #127072 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127072/testReport)**
for PR 29339 at commit
wangshisan commented on pull request #29266:
URL: https://github.com/apache/spark/pull/29266#issuecomment-668926319
> Yea I'm also wondering the approach here. The skew join handling needs to
split the skew side, and repeat the other side. I don't think we can split the
buckets of
wangshisan commented on a change in pull request #29266:
URL: https://github.com/apache/spark/pull/29266#discussion_r465422329
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##
@@ -250,6 +251,85 @@ case class
AmplabJenkins removed a comment on pull request #29342:
URL: https://github.com/apache/spark/pull/29342#issuecomment-668916700
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29342:
URL: https://github.com/apache/spark/pull/29342#issuecomment-668916700
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29342:
URL: https://github.com/apache/spark/pull/29342#issuecomment-668826573
**[Test build #127065 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127065/testReport)**
for PR 29342 at commit
SparkQA commented on pull request #29342:
URL: https://github.com/apache/spark/pull/29342#issuecomment-668916087
**[Test build #127065 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127065/testReport)**
for PR 29342 at commit
AmplabJenkins removed a comment on pull request #29353:
URL: https://github.com/apache/spark/pull/29353#issuecomment-668914789
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29353:
URL: https://github.com/apache/spark/pull/29353#issuecomment-668914789
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29353:
URL: https://github.com/apache/spark/pull/29353#issuecomment-668914387
**[Test build #127071 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127071/testReport)**
for PR 29353 at commit
AmplabJenkins removed a comment on pull request #29353:
URL: https://github.com/apache/spark/pull/29353#issuecomment-668823788
Can one of the admins verify this patch?
This is an automated message from the Apache Git
AmplabJenkins removed a comment on pull request #29352:
URL: https://github.com/apache/spark/pull/29352#issuecomment-668912120
This is an automated message from the Apache Git Service.
To respond to the message, please log on
viirya commented on pull request #29353:
URL: https://github.com/apache/spark/pull/29353#issuecomment-668912282
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29352:
URL: https://github.com/apache/spark/pull/29352#issuecomment-668912120
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29352:
URL: https://github.com/apache/spark/pull/29352#issuecomment-668911605
**[Test build #127070 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127070/testReport)**
for PR 29352 at commit
AmplabJenkins removed a comment on pull request #29352:
URL: https://github.com/apache/spark/pull/29352#issuecomment-668813824
Can one of the admins verify this patch?
This is an automated message from the Apache Git
viirya commented on pull request #29352:
URL: https://github.com/apache/spark/pull/29352#issuecomment-668910801
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
1 - 100 of 583 matches
Mail list logo
