AmplabJenkins removed a comment on pull request #29339:
URL: https://github.com/apache/spark/pull/29339#issuecomment-670827006
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29339:
URL: https://github.com/apache/spark/pull/29339#issuecomment-670827006
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29339:
URL: https://github.com/apache/spark/pull/29339#issuecomment-670801837
**[Test build #127219 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127219/testReport)**
for PR 29339 at commit
SparkQA commented on pull request #29339:
URL: https://github.com/apache/spark/pull/29339#issuecomment-670826865
**[Test build #127219 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127219/testReport)**
for PR 29339 at commit
cloud-fan commented on a change in pull request #29031:
URL: https://github.com/apache/spark/pull/29031#discussion_r467349934
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/RemoveRedundantProjects.scala
##
@@ -78,9 +86,11 @@ case class
AmplabJenkins removed a comment on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670807750
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670807750
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670725493
**[Test build #127218 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127218/testReport)**
for PR 28804 at commit
SparkQA commented on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670807546
**[Test build #127218 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127218/testReport)**
for PR 28804 at commit
HyukjinKwon closed pull request #29386:
URL: https://github.com/apache/spark/pull/29386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
HyukjinKwon commented on pull request #29386:
URL: https://github.com/apache/spark/pull/29386#issuecomment-670804169
Merged to master.
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon commented on pull request #29331:
URL: https://github.com/apache/spark/pull/29331#issuecomment-670803903
cc @tgravescs too
This is an automated message from the Apache Git Service.
To respond to the message,
AmplabJenkins commented on pull request #29339:
URL: https://github.com/apache/spark/pull/29339#issuecomment-670802009
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29339:
URL: https://github.com/apache/spark/pull/29339#issuecomment-670802009
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29339:
URL: https://github.com/apache/spark/pull/29339#issuecomment-670801837
**[Test build #127219 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127219/testReport)**
for PR 29339 at commit
HyukjinKwon commented on a change in pull request #29385:
URL: https://github.com/apache/spark/pull/29385#discussion_r467342735
##
File path: python/docs/source/migration_guide/index.rst
##
@@ -20,3 +20,14 @@
Migration Guide
===
+Migration Guide: PySpark
HyukjinKwon commented on pull request #29385:
URL: https://github.com/apache/spark/pull/29385#issuecomment-670801380
Nice, thank you @viirya! I will take a look next Monday!
This is an automated message from the Apache Git
stczwd commented on pull request #29339:
URL: https://github.com/apache/spark/pull/29339#issuecomment-670801145
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
dongjoon-hyun commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670799920
Got it. I updated my previous comment by marking my misunderstanding.
This is an automated message from
dongjoon-hyun edited a comment on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670794507
Hi, @Fokko . ~It seems that @srowen clearly gave -1 on this approach.
Although I approved this, we cannot merge your PR if there is a -1.~
~I must admit that
srowen commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670797950
No -1 here. I don't object to the current change.
This is an automated message from the Apache Git Service.
To
github-actions[bot] closed pull request #27026:
URL: https://github.com/apache/spark/pull/27026
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dongjoon-hyun commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670794888
While I wrote the above my comment, I didn't notice the last comment from
@srowen . However, I believe it's better to adjust now.
dongjoon-hyun edited a comment on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670794888
Oh, while I wrote the above my comment, I didn't notice the last comment
from @srowen . However, I believe it's better to adjust now.
dongjoon-hyun commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670794507
Hi, @Fokko . It seems that @srowen clearly gave -1 on this approach.
Although I approved this, we cannot merge your PR if there is a -1.
I must admit that I didn't
srowen commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670794000
No, I don't feel that way. If others would like to merge, go ahead. I would
merge the narrower change myself, but do not object to the broader one.
dongjoon-hyun commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670791274
Got it. So, you decided to give -1 for the enforcing for that reason.
This is an automated message from
srowen commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670786844
I did. If most of the changes are exceptions, that makes me wonder how much
this rule will just trigger false positives. I am not sure how worth it is to
enforce this if mostly
dongjoon-hyun edited a comment on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670783658
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dongjoon-hyun commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670783658
Hey, @srowen . Did you see my first comment, "Without the rule enforcement,
unused import always happens again"?
-
maropu edited a comment on pull request #29384:
URL: https://github.com/apache/spark/pull/29384#issuecomment-670779886
Thanks, all!
@dongjoon-hyun Sure!
@cloud-fan okay, I'll do follow-up.
This is an automated
maropu commented on pull request #29384:
URL: https://github.com/apache/spark/pull/29384#issuecomment-670779886
@dongjoon-hyun Sure!
@cloud-fan okay, I'll do follow-up.
This is an automated message from the Apache Git
AmplabJenkins removed a comment on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670778245
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670778245
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670707796
**[Test build #127217 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127217/testReport)**
for PR 29121 at commit
SparkQA commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-67074
**[Test build #127217 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127217/testReport)**
for PR 29121 at commit
AmplabJenkins removed a comment on pull request #29031:
URL: https://github.com/apache/spark/pull/29031#issuecomment-670772420
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29031:
URL: https://github.com/apache/spark/pull/29031#issuecomment-670772420
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29031:
URL: https://github.com/apache/spark/pull/29031#issuecomment-670771944
**[Test build #127212 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127212/testReport)**
for PR 29031 at commit
SparkQA removed a comment on pull request #29031:
URL: https://github.com/apache/spark/pull/29031#issuecomment-670642619
**[Test build #127212 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127212/testReport)**
for PR 29031 at commit
AmplabJenkins removed a comment on pull request #29074:
URL: https://github.com/apache/spark/pull/29074#issuecomment-670766308
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29074:
URL: https://github.com/apache/spark/pull/29074#issuecomment-670766308
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29074:
URL: https://github.com/apache/spark/pull/29074#issuecomment-670645783
**[Test build #127213 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127213/testReport)**
for PR 29074 at commit
SparkQA commented on pull request #29074:
URL: https://github.com/apache/spark/pull/29074#issuecomment-670763604
**[Test build #127213 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127213/testReport)**
for PR 29074 at commit
AmplabJenkins removed a comment on pull request #29342:
URL: https://github.com/apache/spark/pull/29342#issuecomment-670751473
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29342:
URL: https://github.com/apache/spark/pull/29342#issuecomment-670751473
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29342:
URL: https://github.com/apache/spark/pull/29342#issuecomment-670632896
**[Test build #127211 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127211/testReport)**
for PR 29342 at commit
SparkQA commented on pull request #29342:
URL: https://github.com/apache/spark/pull/29342#issuecomment-670748063
**[Test build #127211 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127211/testReport)**
for PR 29342 at commit
AmplabJenkins removed a comment on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670725860
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670725860
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670725493
**[Test build #127218 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127218/testReport)**
for PR 28804 at commit
AmplabJenkins commented on pull request #29386:
URL: https://github.com/apache/spark/pull/29386#issuecomment-670715442
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29386:
URL: https://github.com/apache/spark/pull/29386#issuecomment-670715442
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #29386:
URL: https://github.com/apache/spark/pull/29386#issuecomment-670654894
**[Test build #127215 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127215/testReport)**
for PR 29386 at commit
SparkQA commented on pull request #29386:
URL: https://github.com/apache/spark/pull/29386#issuecomment-670714635
**[Test build #127215 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127215/testReport)**
for PR 29386 at commit
srowen commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670711092
My last comment was, why do we need to add the rule and then a ton of
exclusions? just remove the unused imports. That's a much narrower change
mridulm commented on pull request #24554:
URL: https://github.com/apache/spark/pull/24554#issuecomment-670710590
Catching up on PR's ... this essentially means all executors on same host
have effectively same preferred locality (modulo concurrent block removal) -
did we update the
AmplabJenkins removed a comment on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670707738
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670707728
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670694343
**[Test build #127216 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127216/testReport)**
for PR 28804 at commit
SparkQA commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670707796
**[Test build #127217 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127217/testReport)**
for PR 29121 at commit
SparkQA commented on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670707640
**[Test build #127216 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127216/testReport)**
for PR 28804 at commit
AmplabJenkins commented on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670707728
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670705663
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670705663
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dongjoon-hyun commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670705302
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message,
allisonwang-db commented on pull request #29137:
URL: https://github.com/apache/spark/pull/29137#issuecomment-670699341
I've updated the PR description. Please let me know if it makes sense.
This is an automated message from
viirya commented on a change in pull request #29342:
URL: https://github.com/apache/spark/pull/29342#discussion_r467252553
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##
@@ -71,8 +88,122 @@ case class
viirya commented on a change in pull request #29342:
URL: https://github.com/apache/spark/pull/29342#discussion_r467251404
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##
@@ -71,8 +88,122 @@ case class
viirya commented on a change in pull request #29342:
URL: https://github.com/apache/spark/pull/29342#discussion_r467250468
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##
@@ -71,8 +88,122 @@ case class
viirya commented on a change in pull request #29342:
URL: https://github.com/apache/spark/pull/29342#discussion_r467250293
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##
@@ -71,8 +88,122 @@ case class
AmplabJenkins removed a comment on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670694952
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670694952
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670694343
**[Test build #127216 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127216/testReport)**
for PR 28804 at commit
karuppayya commented on a change in pull request #28804:
URL: https://github.com/apache/spark/pull/28804#discussion_r467173370
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala
##
@@ -353,4 +353,8 @@ object AggUtils {
Fokko commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670690427
Would it be possible to move this forward? :)
This is an automated message from the Apache Git Service.
To
viirya commented on a change in pull request #29342:
URL: https://github.com/apache/spark/pull/29342#discussion_r467244022
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##
@@ -314,7 +343,13 @@ private[joins] object
viirya commented on a change in pull request #29342:
URL: https://github.com/apache/spark/pull/29342#discussion_r467244022
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##
@@ -314,7 +343,13 @@ private[joins] object
AmplabJenkins removed a comment on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670659771
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29331:
URL: https://github.com/apache/spark/pull/29331#issuecomment-670659548
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670645866
**[Test build #127214 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127214/testReport)**
for PR 28804 at commit
AmplabJenkins removed a comment on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670659760
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670659760
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670659564
**[Test build #127214 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127214/testReport)**
for PR 28804 at commit
AmplabJenkins commented on pull request #29331:
URL: https://github.com/apache/spark/pull/29331#issuecomment-670659548
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29331:
URL: https://github.com/apache/spark/pull/29331#issuecomment-670596918
**[Test build #127208 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127208/testReport)**
for PR 29331 at commit
SparkQA commented on pull request #29331:
URL: https://github.com/apache/spark/pull/29331#issuecomment-670658671
**[Test build #127208 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127208/testReport)**
for PR 29331 at commit
dongjoon-hyun commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-670656860
Thank you so much. Yes. I'm looking forward to seeing that~
This is an automated message from the Apache
dongjoon-hyun commented on a change in pull request #29386:
URL: https://github.com/apache/spark/pull/29386#discussion_r467209211
##
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
##
@@ -395,7 +395,7 @@ class
AmplabJenkins removed a comment on pull request #29386:
URL: https://github.com/apache/spark/pull/29386#issuecomment-670655440
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29386:
URL: https://github.com/apache/spark/pull/29386#issuecomment-670655440
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29386:
URL: https://github.com/apache/spark/pull/29386#issuecomment-670654894
**[Test build #127215 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127215/testReport)**
for PR 29386 at commit
dongjoon-hyun opened a new pull request #29386:
URL: https://github.com/apache/spark/pull/29386
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
###
viirya commented on a change in pull request #29328:
URL: https://github.com/apache/spark/pull/29328#discussion_r467199754
##
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
##
@@ -229,6 +229,7 @@ class DataFrameReader private[sql](sparkSession:
AmplabJenkins removed a comment on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670646425
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29074:
URL: https://github.com/apache/spark/pull/29074#issuecomment-670646303
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29074:
URL: https://github.com/apache/spark/pull/29074#issuecomment-670646303
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28804:
URL: https://github.com/apache/spark/pull/28804#issuecomment-670646425
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
viirya commented on pull request #29385:
URL: https://github.com/apache/spark/pull/29385#issuecomment-670646380
cc @HyukjinKwon
This is an automated message from the Apache Git Service.
To respond to the message, please log
SparkQA commented on pull request #29074:
URL: https://github.com/apache/spark/pull/29074#issuecomment-670645783
**[Test build #127213 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127213/testReport)**
for PR 29074 at commit
1 - 100 of 447 matches
Mail list logo
