Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/17182#discussion_r105752410
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -63,7 +63,10 @@ case class CreateFunctionCommand
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/17223#discussion_r105797391
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -793,6 +794,20 @@ private[spark] class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/17182#discussion_r105797595
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -63,7 +63,10 @@ case class CreateFunctionCommand
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/17251#discussion_r105952373
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -590,6 +591,22 @@ object TypeCoercion
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17232
Retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17232
Thank you for doing this, @gatorsmile ! It looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17223
I see. That's the reason why not to support that. Thank you, @cloud-fan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17223
I'll close this PR and JIRA issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/17223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17266
The following is the error message. Since we are not escaping in the spark
master, the behavior (incorrect filtering or the error message) is the same
from the master branch Spark
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17266
For non-error message cases, incorrect result is also a problem in this
issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17251
@cloud-fan . Sorry, but could you review this `stack` PR once again? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17273
Yep. I see. Thank you for review, @rxin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15789
Thank you for review and merging, @srowen , @gatorsmile , and @rxin .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Hi, @gatorsmile .
Could you review again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15682
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15546#discussion_r87346524
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -162,6 +165,8 @@ class SQLBuilder private (
case p
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15682
Hmm. `randomized aggregation test` fails consistently.
```
- randomized aggregation test - [typed, with distinct] - with grouping keys
- with non-empty input
```
---
If your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
During updating the PR, I rebased and squashed to resolve conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15664
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15546#discussion_r87356916
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -138,9 +138,12 @@ class SQLBuilder private (
case g
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15546#discussion_r87357616
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -138,9 +138,12 @@ class SQLBuilder private (
case g
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
The three failures seems to be irrelevant.
```
[info] - randomized aggregation test - [typed, with partial + safe] - with
grouping keys - with non-empty input *** FAILED *** (1 second
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15682
Retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15664
Two failures seems to be irrelevant.
```
[info] - randomized aggregation test - [typed, with partial + safe] - with
grouping keys - with non-empty input *** FAILED *** (1 second, 367
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15664
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15546#discussion_r87431426
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -138,9 +138,12 @@ class SQLBuilder private (
case g
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Thank you, @gatorsmile !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you, @hvanhovell .
Now, this PR becomes much concise due to your advice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you, @viirya ! I also feel like that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87546041
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -226,6 +227,63 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87549043
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -226,6 +227,63 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87554053
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,102 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87554964
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,102 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87555430
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,102 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87558776
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,102 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87559593
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,102 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Could you review again, @gatorsmile ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you, @viirya . I added a prevention logic to prevent that case. Now
the PR works more like Hive.
Hi, @hvanhovell .
Could you review when you have sometime?
---
If your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Thank you, @gatorsmile .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Thank you, @gatorsmile .
I'll make a backport for 2.0, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15546
Thank you for review, @rxin and @cloud-fan , too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/15856
[SPARK-17982][SQL][BACKPORT-2.0] SQLBuilder should wrap the generated SQL
with parenthesis for LIMIT
## What changes were proposed in this pull request?
Currently, `SQLBuilder
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15856
Hi, @gatorsmile .
This is a backport of #15546 for `branch-2.0`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15856
Thank you again, @gatorsmile !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/15856
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15856
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87684919
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,111 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87688739
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,66 @@ case class
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/15863
[SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperties` to be
case-insensitive
## What changes were proposed in this pull request?
`JDBCOptions.asConnectionProperties` fails to
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15863
Thank you for review, @HyukjinKwon . Let me see that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15863
Yes. It seems not to solve this problem. The problem is the following list
is case-sensitive.
```
private val jdbcOptionNames = ArrayBuffer.empty[String]
```
---
If your project
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15863
Thank you for review, @gatorsmile .
In the Spark code, `JDBCOption` is always receiving `CaseInsensitiveMap`.
For example, here.
-
https://github.com/apache/spark/blob/master/sql
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15862
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15863
Oh, sure. I'll investigate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15863
I updated `DataSource` consistently to use `CaseInsensitiveMap` and am
running tests.
After testing, this PR will include the followings.
- Fix `DataSource` to use `CaseInsensitiveMap
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15857
Thank you for pining me, @gatorsmile . Thank you for fixing this,
@hvanhovell .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15863#discussion_r87700361
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -314,8 +311,7 @@ case class DataSource
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15857
It looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/15868
[SPARK-18413][SQL] Control the number of JDBC connections by repartition
with `numPartition` JDBCOption
## What changes were proposed in this pull request?
This PR aims to control
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15868
Thank you for review, @lichenglin .
For 1, Jenkins test that, too.
For 2, sure! It sounds reasonable and better.
---
If your project is set up for it, you can reply to this email
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87746263
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -449,7 +452,7 @@ object FoldablePropagation
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15863
Thank you for review, @cloud-fan .
Actually, this PR includes two different ones. The first commit is about a
bug and the others (from seconds) is potential improvement
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15863
@cloud-fan and @gatorsmile .
For the `DataSource` options issue, I'm working on
[SPARK-18433](https://issues.apache.org/jira/browse/SPARK-18433) for the
followings.
- CSVOp
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15868#discussion_r87857574
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -667,9 +667,15 @@ object JdbcUtils extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14638
Thank you, @jamartinh . I hope so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14638
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15868
Hi, @srowen .
I addressed the comment and added an image in the PR description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15868#discussion_r87872317
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -667,7 +667,14 @@ object JdbcUtils extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15880
Hi, @cloud-fan . What about just showing warning for that?
For Hive 1.2.1 and 2.1.0, it's `true` like the old Spark.
```sql
hive> SELECT 19157170390056973L = "1915
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14638
Thank you for review, @srowen !
Yes. The issue was `the question here is whether the change belongs here or
elsewhere`, and I couldn't find better place.
---
If your project is s
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14638#discussion_r87876602
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -113,6 +113,10 @@ class HadoopTableReader(
val
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14638#discussion_r87878854
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -122,10 +126,18 @@ class HadoopTableReader(
val
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15868
Then, @gatorsmile .
Could you review this PR, too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15682
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
I'm closing this PR in favor of #15704 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/15302
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you for review, again. I'll fix them soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87910682
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -215,8 +215,14 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87910722
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,58 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87914133
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -243,7 +243,7 @@ partitionSpec
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15868
Thank you, @gatorsmile ! I'll update this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you, @hvanhovell !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15868
@gatorsmile , I addressed all comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/15884
[WIP][SPARK-18433][SQL] Improve DataSource option keys to be more
case-insensitive
## What changes were proposed in this pull request?
This PR aims to improve DataSource option keys
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15868
Thank you for retriggering, @gatorsmile .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15884#discussion_r87935620
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -34,35 +34,42 @@ private[sql] class JSONOptions
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15884#discussion_r87936058
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -34,35 +34,42 @@ private[sql] class JSONOptions
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15884#discussion_r87936113
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -34,35 +34,42 @@ private[sql] class JSONOptions
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15880
+1 on the postgres approach
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Hi, @hvanhovell or @gatorsmile .
Could you merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15868
Hi, @srowen and @gatorsmile .
How do you think about the updated PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15884
Thank you, @cloud-fan .
It becomes much better. Could you review again please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15868#discussion_r88108090
--- Diff: docs/sql-programming-guide.md ---
@@ -1087,6 +1087,13 @@ the following case-sensitive options:
+ maxConnection
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15868#discussion_r88108224
--- Diff: docs/sql-programming-guide.md ---
@@ -1087,6 +1087,13 @@ the following case-sensitive options:
+ maxConnection
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you so much, @hvanhovell , @gatorsmile, @viirya !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Oh, @hvanhovell.
Can make a backport for branch-2.1 which will release this month?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
I see. I agree. Thank you so much for cherry-picking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
I feel that we are really so close to 2.1. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
401 - 500 of 7376 matches
Mail list logo
