Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16804
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16873
cc @cloud-fan @jiangxb1987
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/16873
[SPARK-19509][SQL] Grouping Sets do not respect nullable grouping columns
## What changes were proposed in this pull request?
The analyzer currently does not check if a column used in
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16872#discussion_r100308080
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala ---
@@ -127,4 +133,28 @@ class DataFrameRangeSuite extends QueryTest
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16872#discussion_r100309681
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -443,6 +443,10 @@ case class RangeExec(range
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16872#discussion_r100310307
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala ---
@@ -127,4 +133,28 @@ class DataFrameRangeSuite extends QueryTest
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16873
also cc @stanzhai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16869
cc @rxin @yhuai wdyt? Should we be bold and remove this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16869
LGTM. I'd like to wait a little with merging this in order to build some
consensus.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16872#discussion_r100350259
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala ---
@@ -127,4 +133,28 @@ class DataFrameRangeSuite extends QueryTest
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16873#discussion_r100357789
--- Diff: sql/core/src/test/resources/sql-tests/inputs/grouping_set.sql ---
@@ -13,5 +18,8 @@ SELECT a, b, c, count(d) FROM grouping GROUP BY a, b, c
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16610#discussion_r100360526
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -102,6 +102,27 @@ object functions {
Column(literalExpr
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16610#discussion_r100360787
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -153,6 +154,12 @@ object Literal
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16852
LGTM - merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16852
@bogdanrdc can you create a backport for branch-2.1?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16869
I had an offline discussion with @rxin about this, and we have decided to
merge this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16872#discussion_r100389578
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala ---
@@ -127,4 +133,28 @@ class DataFrameRangeSuite extends QueryTest
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16610#discussion_r100397651
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -153,6 +154,12 @@ object Literal
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16610#discussion_r100397761
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -153,6 +154,12 @@ object Literal
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16873
I am merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell closed the pull request at:
https://github.com/apache/spark/pull/16873
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16874
@stanzhai I have merged my PR, and assigned the PR to your name. Could you
close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16875
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/16886
[SPARK-19548][SQL] Support Hive UDFs which return typed Lists/Maps
## What changes were proposed in this pull request?
This PR adds support for Hive UDFs that return fully typed java Lists
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16886
cc @cloud-fan @yhuai @maropu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16881#discussion_r100520672
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -496,7 +496,7 @@ case class JsonToStruct
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16881
LGTM - merging to master/2.1. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16882
@HyukjinKwon Can you also improve the error message. I don't think
`StructType(StructField(_1,StringType,true), StructField(_2,StringType,true))
<> StructType(StructField(_1,Stri
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16870#discussion_r100524361
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -500,6 +516,20 @@ class DateFunctionsSuite extends QueryTest with
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16870#discussion_r100523512
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -477,6 +475,24 @@ class DateFunctionsSuite extends QueryTest with
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16870#discussion_r100523109
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -95,9 +95,12 @@ object DateTimeUtils {
sdf
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16785
@viirya this looks like a very big hammer to solve this problem. Can't we
try a different approach?
I think we should try to avoid optimizing already optimized code snippets,
you
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16818#discussion_r100539109
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/BoundOrdering.scala
---
@@ -25,18 +25,22 @@ import
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16870#discussion_r100539828
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -465,15 +465,15 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16886#discussion_r100544404
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -218,22 +220,33 @@ private[hive] trait HiveInspectors
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16886#discussion_r100545658
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -218,22 +220,33 @@ private[hive] trait HiveInspectors
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15928#discussion_r100559409
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/execution/benchmark/HiveUDFsBenchmark.scala
---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15928#discussion_r100561335
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/execution/benchmark/HiveUDFsBenchmark.scala
---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16887#discussion_r100573520
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -2207,10 +2207,32 @@ class SparkContext(config: SparkConf) extends
Logging
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16886#discussion_r100595034
--- Diff:
sql/hive/src/test/java/org/apache/spark/sql/hive/execution/UDFRawList.java ---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16887
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16894
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16909#discussion_r100756976
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -97,6 +98,11 @@ case class SortMergeJoinExec
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16909#discussion_r100757130
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -376,8 +386,15 @@ case class SortMergeJoinExec
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16909#discussion_r100756129
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala
---
@@ -285,6 +283,9 @@ case class WindowExec(
val
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16909#discussion_r100756047
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala
---
@@ -310,10 +311,15 @@ case class WindowExec
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16909#discussion_r100756809
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArray.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16909#discussion_r100755730
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArray.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16909#discussion_r100755136
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArray.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16909#discussion_r100756696
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArray.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16909#discussion_r100757937
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/RowBuffer.scala
---
@@ -17,99 +17,33 @@
package
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16870#discussion_r100771130
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -477,6 +483,27 @@ class DateFunctionsSuite extends QueryTest with
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16870
LGTM - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16870
@windpiger can you open a backport to branch-2.1? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16882#discussion_r100774050
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -321,12 +321,12 @@ trait CheckAnalysis extends
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16882
LGTM - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16872#discussion_r100827652
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala ---
@@ -127,4 +133,28 @@ class DataFrameRangeSuite extends QueryTest
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16921
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16921
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16909
@zhzhan is this an actual problem? The BufferedRowIterator should not hold
a lot of rows in practice. cc @davies
---
If your project is set up for it, you can reply to this email and have your
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16870
Yeah, you are right. Lets leave this as it currently is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16925#discussion_r101022875
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -363,6 +363,29 @@ case class
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16870
Yes it is
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16909
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16941#discussion_r101313928
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
---
@@ -505,7 +505,13 @@ class PlanParserSuite extends
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16941
LGTM pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16939
LGTM - merging to master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16759
LGTM - merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16798
LGTM - merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16802
LGTM - merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16915
@kevinyu98 @nsyca @dilipbiswal could someone confirm that these results
match DB2?
I also think that this PR is almost too large.
---
If your project is set up for it, you can reply to
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16943#discussion_r101381101
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
---
@@ -129,6 +129,8 @@ class SQLExecutionSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16943#discussion_r101383173
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
---
@@ -129,6 +129,8 @@ class SQLExecutionSuite extends
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16958
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16962#discussion_r101724210
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -573,6 +575,21 @@ final class DataFrameWriter[T] private[sql](ds
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16974
LGTM - pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16974
@srowen should we add a regression test? It seems weird that we didn't
catch this in tests.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16960#discussion_r101782666
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -309,4 +314,94 @@ class SQLMetricsSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16960#discussion_r101782872
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -309,4 +314,94 @@ class SQLMetricsSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16960#discussion_r101783584
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -309,4 +314,94 @@ class SQLMetricsSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16960#discussion_r101783889
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -309,4 +314,94 @@ class SQLMetricsSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16960#discussion_r101784563
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -309,4 +314,94 @@ class SQLMetricsSuite extends
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16960
LGTM - pending jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16785
cc @sameeragarwal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16998
@viirya does this PR supersede #16785? I do like the non-parallel approach.
I will try to take a more in-depth look at the end of the week (beginning of
the next sprint).
---
If your project
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16985#discussion_r101973786
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -33,8 +33,8 @@ import
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16610#discussion_r101974502
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -102,6 +102,27 @@ object functions {
Column(literalExpr
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16610#discussion_r101974913
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -102,6 +102,27 @@ object functions {
Column(literalExpr
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r102335398
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -163,9 +163,11 @@ object FunctionRegistry
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/17027
[SPARK-19650] Runnable commands should not trigger a Spark job [WIP]
## What changes were proposed in this pull request?
Spark executes SQL commands eagerly. It does this by materializing an
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17026
LGTM - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17028#discussion_r102490587
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -138,7 +138,8 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r102535917
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -163,9 +163,11 @@ object FunctionRegistry
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r102593931
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -163,9 +163,11 @@ object FunctionRegistry
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/17030
[SPARK-19459] Support for nested char/varchar fields in ORC
## What changes were proposed in this pull request?
This PR is a small follow-up on https://github.com/apache/spark/pull/16804
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17030
cc @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17028#discussion_r102673129
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -130,20 +130,30 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17028#discussion_r102673567
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -274,7 +283,8 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17028#discussion_r102673952
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/PercentileSuite.scala
---
@@ -39,44 +38,44 @@ class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17028#discussion_r102673905
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/PercentileSuite.scala
---
@@ -39,44 +38,44 @@ class
1 - 100 of 4178 matches
Mail list logo
