Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14034#discussion_r69528969
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StatisticsSuite.scala ---
@@ -31,4 +33,46 @@ class StatisticsSuite extends QueryTest with
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13981#discussion_r69631781
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/DecisionTreeRegressorSuite.scala
---
@@ -96,6 +97,25 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13981#discussion_r69703134
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/DecisionTreeRegressorSuite.scala
---
@@ -96,6 +97,25 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14080#discussion_r69981791
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java
---
@@ -143,4 +179,26 @@ private
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14083#discussion_r69982767
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -165,111 +169,99 @@ abstract class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14087#discussion_r69984584
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -281,6 +281,31 @@ final class DataStreamReader
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14087#discussion_r69984805
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -281,6 +281,31 @@ final class DataStreamReader
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14087#discussion_r69984678
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -281,6 +281,31 @@ final class DataStreamReader
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14087#discussion_r69985195
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -281,6 +281,31 @@ final class DataStreamReader
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14087#discussion_r69985212
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -281,6 +281,31 @@ final class DataStreamReader
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14087#discussion_r69985100
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -281,6 +281,31 @@ final class DataStreamReader
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14087#discussion_r69985379
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
---
@@ -331,6 +331,24 @@ class FileStreamSourceSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13526#discussion_r69986179
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
---
@@ -175,6 +175,17 @@ object AppendColumns
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13526#discussion_r69986245
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala ---
@@ -65,6 +65,46 @@ class KeyValueGroupedDataset[K, V] private
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13526#discussion_r69986420
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala ---
@@ -65,6 +65,46 @@ class KeyValueGroupedDataset[K, V] private
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13526#discussion_r69986532
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala ---
@@ -65,6 +65,46 @@ class KeyValueGroupedDataset[K, V] private
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13526#discussion_r69986479
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala ---
@@ -65,6 +65,46 @@ class KeyValueGroupedDataset[K, V] private
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13526#discussion_r69986596
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -312,6 +312,17 @@ class DatasetSuite extends QueryTest with
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19056#discussion_r135610234
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -39,6 +39,16 @@ abstract class Optimizer
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19056#discussion_r135610632
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala
---
@@ -126,16 +128,17 @@ class TextSocketSource(host
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19056#discussion_r135610992
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala
---
@@ -126,16 +128,17 @@ class TextSocketSource(host
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19056#discussion_r135989439
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala
---
@@ -130,16 +130,7 @@ class TextSocketSource(host
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/19089
Logs are back with the change. ð Thanks (and don't mess it up again
fixing STS :))
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/19095
[SPARK-21886][SQL] Use SparkSession.internalCreateDataFrame to createâ¦
⦠Dataset with LogicalRDD logical operator
## What changes were proposed in this pull request
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/19095
That was really quick! Thanks a lot @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/19112
[SPARK-21901][SS] Define toString for StateOperatorProgress
## What changes were proposed in this pull request?
Just `StateOperatorProgress.toString` + few formatting fixes
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19112#discussion_r136726289
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/progress.scala ---
@@ -200,7 +202,7 @@ class SourceProgress protected[sql
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19112#discussion_r136726445
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/progress.scala ---
@@ -177,11 +179,11 @@ class SourceProgress protected[sql
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19112#discussion_r136750244
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/progress.scala ---
@@ -200,7 +202,7 @@ class SourceProgress protected[sql
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/19112
Hey @HyukjinKwon, as the only committer who's been involved in this PR,
could you review it again and possibly merge to master? T
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/17657
[TEST][MINOR] Replace repartitionBy with distribute in
CollapseRepartitionSuite
## What changes were proposed in this pull request?
Replace non-existent `repartitionBy` with
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/17670
I think the change should rather be [here](ResolveTableValuedFunctions)
where the built-in table-valued function `range` is resolved.
---
If your project is set up for it, you can reply to
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/17712#discussion_r112634044
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -47,12 +47,20 @@ case class UserDefinedFunction
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/17712#discussion_r112634273
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -256,10 +256,12 @@ class UDFSuite extends QueryTest with
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/17712#discussion_r112634952
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -256,10 +256,12 @@ class UDFSuite extends QueryTest with
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/17712#discussion_r112692504
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -47,20 +47,31 @@ case class UserDefinedFunction
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/17712#discussion_r112692885
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -47,20 +47,31 @@ case class UserDefinedFunction
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/17727
[SQL][MINOR] Remove misleading comment (and tags do better)
## What changes were proposed in this pull request?
Misleading comment removed (and tags do a better job to express
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/17727
Fair enough. Let's do it here. Quoting directly from the code:
> Converts a logical plan into zero or more SparkPlans. This API is
exposed for experimenting with the query
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/17727
Is the comment correct then? I don't think so. What about improving it? I
don't mind if we stop discussing it either. It's a tiny change after all (and
don't want to dra
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/17801
[MINOR][SQL][DOCS] Improve unix_timestamp's scaladoc (and typo hunting)
## What changes were proposed in this pull request?
* Docs are consistent (across different `unix_time
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/17801
Are the errors (that led to `fails to generate documentation`) after my
change? Look very weird to me.
```
[error]
/home/jenkins/workspace/SparkPullRequestBuilder/core/target
Github user jaceklaskowski closed the pull request at:
https://github.com/apache/spark/pull/17727
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/18642
@zsxwing @tdas Could you review the change and let me know what you think?
I'd appreciate. Thanks.
---
If your project is set up for it, you can reply to this email and have your
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/18347#discussion_r122616876
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -465,6 +465,8 @@ case class DataSource
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/18347#discussion_r122617147
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -465,6 +465,8 @@ case class DataSource
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/17917
[SPARK-20600][SS] KafkaRelation should be pretty printed in web UI
## What changes were proposed in this pull request?
User-friendly name of `KafkaRelation` in web UI (under Details
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/17904
WFM. Thanks @ajbozarth!
```
$ git fetch origin pull/17904/head:17904
$ gco 17904
$ ./build/mvn -Phadoop-2.7,yarn,mesos,hive,hive-thriftserver -DskipTests
clean install
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16960
I think that the commit has left
[numGeneratedRows](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala#L344
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/17917#discussion_r115711771
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaRelation.scala
---
@@ -143,4 +143,6 @@ private[kafka010] class
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16960
I'll have a look at this this week and send a PR unless you beat me to it
:) Thanks @ala!
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/17917
https://cloud.githubusercontent.com/assets/62313/25960541/879096ce-3677-11e7-900f-09bd5f200a00.png";>
---
If your project is set up for it, you can reply to this email and have yo
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/18026
[SPARK-16202][SQL][DOC] Follow-up to Correct The Description of
CreatableRelationProvider's createRelation
## What changes were proposed in this pull request?
Follow-up to
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/18074
[DOCS][MINOR] Scaladoc fixes (aka typo hunting)
## What changes were proposed in this pull request?
Minor changes to scaladoc
## How was this patch tested?
Local
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/18074#discussion_r118436041
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -35,12 +35,13 @@ import
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/15575
I'm late with this, but just leaving it for future code reviewers...
I think the change took the most extreme path where even such simple
`outputPartitioning` as the o
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/18074#discussion_r118788857
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala
---
@@ -153,19 +153,24 @@ case class WindowExec
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/18074
Hey @srowen could you review the changes again and accept possibly? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/18144
@cloud-fan I don't understand why would that be an issue...ever. The API is
not consistent and I often run into it.
---
If your project is set up for it, you can reply to this emai
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/18074#discussion_r119168394
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala
---
@@ -153,12 +153,13 @@ case class WindowExec
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/18144
@cloud-fan If consistency is to remove (not add) I'm fine. Either way
consistency is the ultimate goal (as I myself am running into this discrepancy
far too often).
---
If your proje
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22238#discussion_r213063267
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -2812,6 +2812,12 @@ See [Input Sources](#input-sources) and [Output
Sinks](#output
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22238#discussion_r213264786
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -266,7 +266,9 @@ object SQLConf
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22238#discussion_r213264912
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -868,7 +870,9 @@ object SQLConf {
.internal
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214751023
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -805,6 +805,80 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214751748
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -63,7 +63,7 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214751169
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -805,6 +805,80 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214750815
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -805,6 +805,80 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214751930
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -754,6 +754,47 @@ class HiveDDLSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214751219
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -805,6 +805,80 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214751309
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -805,6 +805,80 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22318#discussion_r214752480
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala ---
@@ -295,4 +295,14 @@ class DataFrameJoinSuite extends QueryTest
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22316#discussion_r214752855
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -416,7 +426,7 @@ class RelationalGroupedDataset
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/22332
Why not `select($"*", newColumnHere)` or `select(newColumnHere, $"*")`?
Somehow I don't think the use case merit
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215036263
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageDataSource.scala ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215037968
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/source/image/ImageFileFormatSuite.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215036643
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageDataSource.scala ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215037240
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageFileFormat.scala ---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215038606
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/source/image/ImageFileFormatSuite.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215039097
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -567,6 +567,7 @@ object DataSource extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215138476
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageDataSource.scala ---
@@ -45,6 +45,8 @@ package org.apache.spark.ml.source.image
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215138305
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageDataSource.scala ---
@@ -29,7 +29,7 @@ package org.apache.spark.ml.source.image
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215138635
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageOptions.scala ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215145351
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -831,13 +831,21 @@ class DataFrameSuite extends QueryTest with
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215144982
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`&#
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215144932
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`&#
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215145065
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`&#
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215144732
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`&#
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r215214259
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -82,7 +83,7 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r215213849
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -805,6 +805,80 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r215215098
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -754,6 +754,54 @@ class HiveDDLSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215216011
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageDataSource.scala ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r215376132
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -82,7 +83,7 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/21838#discussion_r234099158
--- Diff:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroCatalystDataConversionSuite.scala
---
@@ -0,0 +1,175
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r234177079
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallbackSuite.scala
---
@@ -17,17
501 - 595 of 595 matches
Mail list logo
