Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16674
@gatorsmile @cloud-fan Could you please look at this when you have time?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100238713
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSQLViewSuite.scala
---
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/16869
[SPARK-19025][SQL] Remove SQL builder for operators
## What changes were proposed in this pull request?
With the new approach of view resolution, we can get rid of SQL generation
on
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16873#discussion_r100348823
--- Diff: sql/core/src/test/resources/sql-tests/inputs/grouping_set.sql ---
@@ -13,5 +18,8 @@ SELECT a, b, c, count(d) FROM grouping GROUP BY a, b, c
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16873
Thank you for ccing me @hvanhovell ! This PR looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100455122
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSQLViewSuite.scala
---
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100670864
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ---
@@ -452,311 +542,96 @@ class SQLViewSuite extends QueryTest
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100670964
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ---
@@ -452,311 +542,96 @@ class SQLViewSuite extends QueryTest
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100671808
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSQLViewSuite.scala
---
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100689818
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSQLViewSuite.scala
---
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100689894
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -617,13 +617,17 @@ class Analyzer(
private
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16921
Thank you for doing this, this looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15861
This PR should be separated into some smaller ones, I'll do this at about
March.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r93646337
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +510,62 @@ class Analyzer
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16233
I'm working on the last option approach, I hope I could finish that in one
or two more days.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16233
@yhuai @hvanhovell @cloud-fan @gatorsmile Could you please review this PR
when you have time? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16373
@yhuai @hvanhovell @gatorsmile Would you please review this PR when you
have time? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r93994361
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -377,6 +378,36 @@ case class
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r93996552
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLViewSuite.scala
---
@@ -543,4 +545,34 @@ class SQLViewSuite extends QueryTest
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r93996591
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +510,121 @@ class Analyzer
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16373#discussion_r94004561
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -619,18 +621,34 @@ case class ShowTablesCommand
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16373#discussion_r94004875
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -619,18 +621,34 @@ case class ShowTablesCommand
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16373#discussion_r94014794
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -619,18 +621,34 @@ case class ShowTablesCommand
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16373#discussion_r94014930
--- Diff: sql/core/src/test/resources/sql-tests/results/show-tables.sql.out
---
@@ -128,62 +128,108 @@ SHOW TABLE EXTENDED
-- !query 13
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16373#discussion_r94018052
--- Diff: sql/core/src/test/resources/sql-tests/results/show-tables.sql.out
---
@@ -128,62 +128,108 @@ SHOW TABLE EXTENDED
-- !query 13
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16233
@hvanhovell I've added `AnalysisContext` to support resolve a view
references CTE/Windows.
@gatorsmile I'll try to improve the test cases next week, coz I plan to
make a
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r94366640
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +510,94 @@ class Analyzer
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r94366859
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -377,6 +378,39 @@ case class
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r94367053
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -377,6 +378,39 @@ case class
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95055413
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +539,93 @@ class Analyzer
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95083902
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -465,6 +466,48 @@ class
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95084050
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -465,6 +466,48 @@ class
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95095587
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95095659
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -767,7 +857,7 @@ class Analyzer
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95098435
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16497
@tanejagagan Would you please revert the unnecessary code changes?
BTW: You can test the scala style on local environment by running
`./dev/lint-scala` from console.
---
If your
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95293559
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -51,16 +51,31 @@ import
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95294834
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -81,7 +96,11 @@ case class Percentile
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95295298
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -91,9 +110,16 @@ case class
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95293614
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -51,16 +51,31 @@ import
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95295476
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -126,10 +152,15 @@ case class
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95295321
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -126,10 +152,15 @@ case class
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95294516
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -51,16 +51,31 @@ import
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95294336
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -51,16 +51,31 @@ import
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95308691
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -81,7 +96,11 @@ case class Percentile
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16233
@gatorsmile Thank you for such a detailed review! I'll address them ASAP!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95420106
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +542,90 @@ class Analyzer
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95420369
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95420669
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +542,90 @@ class Analyzer
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95421031
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +542,90 @@ class Analyzer
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95422458
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -125,11 +132,16 @@ private[hive] class
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95427497
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -767,19 +857,19 @@ class Analyzer
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95428074
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95428444
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95428827
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -619,7 +642,11 @@ private[spark] class HiveExternalCatalog
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95428960
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +542,90 @@ class Analyzer
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95429665
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +542,90 @@ class Analyzer
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95429866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +542,90 @@ class Analyzer
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95430942
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +542,90 @@ class Analyzer
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95431784
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +542,90 @@ class Analyzer
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95510361
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -125,11 +132,16 @@ private[hive] class
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95510561
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +545,88 @@ class Analyzer
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95512712
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -125,11 +132,16 @@ private[hive] class
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95519850
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2476,4 +2476,14 @@ class SQLQuerySuite extends QueryTest with
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95527384
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLViewSuite.scala
---
@@ -543,4 +545,157 @@ class SQLViewSuite extends QueryTest
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95534400
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95711504
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -50,6 +50,36 @@ object SimpleAnalyzer extends
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95723547
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95731778
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/16561
[SPARK-18209][SQL] Alias the view with its child by mapping the columns by
index
## What changes were proposed in this pull request?
This PR is a follow-up to address the comments
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r95823820
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -29,40 +29,31 @@ import
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r95826222
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -29,40 +29,31 @@ import
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16233
@yhuai I was trying to do that yesterday and found that JIRA went something
wrong, will try again later today.
---
If your project is set up for it, you can reply to this email and have your
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95929443
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96159390
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -198,9 +203,44 @@ case class CatalogTable
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96168416
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -28,22 +28,56 @@ import
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96168755
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -28,22 +28,56 @@ import
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96331626
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -28,22 +28,60 @@ import
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/16613
[SPARK-19024][SQL] Implement new approach to write a permanent view
## What changes were proposed in this pull request?
On CREATE/ALTER a view, it's no longer needed to generate
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/16615
[Minor][SQL] Remove duplicate call of reset() function in
CurrentOrigin.withOrigin()
## What changes were proposed in this pull request?
Remove duplicate call of reset() function in
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/15346
[SPARK-17741][SQL] Grammar to parse top level and nested data fields
separately
## What changes were proposed in this pull request?
Currently we use the same rule to parse top level
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15346#discussion_r81808926
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
---
@@ -67,9 +86,331 @@ class SparkSqlParserSuite extends
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15346#discussion_r81936312
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -593,6 +593,14 @@ colTypeList
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15346
@hvanhovell Thank you for your suggestion! I've addressed your comment and
amended the testcases. Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15346#discussion_r81937555
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
---
@@ -67,9 +86,133 @@ class SparkSqlParserSuite extends
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15346
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15346
@hvanhovell Could you please look at this? Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/15403
[SPARK-17832][SQL] TableIdentifier.quotedString creates un-parseable names
when name contains a backtick
## What changes were proposed in this pull request?
The `quotedString` method
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15403
Besides, we have similar problem in `lookupFunction` as well as
`lookupTable` if one of `database`ã`table`ã`function` contains backtick,
should we resolve the problem in this PR too
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15319
@sameeragarwal Could you review this PR please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15403
@hvanhovell nvm about the `catalog.getTable` issue, it turns out to be my
mistake. Sorry about that...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15319#discussion_r82515583
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -74,14 +74,26 @@ abstract class QueryPlan[PlanType
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15319
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15346
@HyukjinKwon I'll fix that in a follow up. Thank you for telling!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/15417
[SPARK-17851][SQL][MINOR][TESTS] Update invalid test sql in
`ColumnPruningSuite`
## What changes were proposed in this pull request?
The `originalQuery` in `ColumnPruningSuite.test
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15417
cc @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/15418
[MINOR][SQL][TESTS] Remove unused function in `SparkSqlParserSuite`
## What changes were proposed in this pull request?
The function `SparkSqlParserSuite.createTempViewUsing` is not
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15319
Not sure why these testcases are failing, they passed in my local
envirement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15319
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15417
Yes - there are several tens of test sql that fails checkAnalysis, should
we update them all?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
1 - 100 of 1801 matches
Mail list logo
