[GitHub] spark pull request #22959: [SPARK-25876][k8s] Simplify kubernetes configurat...

Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22959#discussion_r234775406 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfDriverFeatureStep.scala --- @@ -16,40

[GitHub] spark pull request #22959: [SPARK-25876][k8s] Simplify kubernetes configurat...

Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22959#discussion_r234773869 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala --- @@ -85,7 +83,7

[GitHub] spark pull request #23136: [SPARK-25515][K8s] Adds a config option to keep e...

Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/23136#discussion_r236455846 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala --- @@ -86,11 +88,14

[GitHub] spark pull request #23136: [SPARK-25515][K8s] Adds a config option to keep e...

Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/23136#discussion_r236455466 --- Diff: docs/running-on-kubernetes.md --- @@ -926,6 +926,13 @@ specific to Spark on Kubernetes. spark.kubernetes.executor.podTemplateFile

[GitHub] spark pull request #23136: [SPARK-25515][K8s] Adds a config option to keep e...

Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/23136#discussion_r236461893 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala --- @@ -86,11 +88,14

[GitHub] spark pull request #23136: [SPARK-25515][K8s] Adds a config option to keep e...

Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/23136#discussion_r236463330 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala --- @@ -86,11 +88,14

[GitHub] spark issue #23136: [SPARK-25515][K8s] Adds a config option to keep executor...

Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/23136 @mccheah do you have any comment? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark issue #22959: [SPARK-25876][k8s] Simplify kubernetes configuration typ...

Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/22959 @mccheah do you have any comment? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark issue #23136: [SPARK-25515][K8s] Adds a config option to keep executor...

Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/23136 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #23136: [SPARK-25515][K8s] Adds a config option to keep e...

Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/23136#discussion_r237626777 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala --- @@ -86,11 +88,14

[GitHub] spark issue #23136: [SPARK-25515][K8s] Adds a config option to keep executor...

Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/23136 LGTM. Will merge to master shortly. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

<    3   4   5   6   7   8