GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/21711
[SPARK-24681][SQL] Verify nested column names in Hive metastore
## What changes were proposed in this pull request?
This pr added code to check if nested column names do not include
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21704#discussion_r14021
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -2007,7 +2007,14 @@ case class Concat
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21706
Adds tests in `sql/core/src/test/resources/sql-tests/inputs/cast.sql` then
run `SPARK_GENERATE_GOLDEN_FILES=1 ./build/mvn -Dtest=none
-DwildcardSuites=org.apache.spark.sql.SQLQueryTestSuite test
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21657
ok, will revive the code here
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21706
Can you add tests in
`sql/core/src/test/resources/sql-tests/inputs/cast.sql`?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21705#discussion_r199820857
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/ExecutorSideSQLConfSuite.scala
---
@@ -40,16 +40,24 @@ class ExecutorSideSQLConfSuite
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21705#discussion_r199817849
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/ExecutorSideSQLConfSuite.scala
---
@@ -40,16 +40,24 @@ class ExecutorSideSQLConfSuite
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21705
ok, will do.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21657
@HyukjinKwon kindly ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/21705
[SPARK-24727][SQL] Add a static config to control cache size for generated
classes
## What changes were proposed in this pull request?
Since SPARK-24250 has been resolved, executors correctly
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21705
cc: @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21693
cc: @ueshin @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21693#discussion_r199744569
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2934,6 +2934,17 @@ object functions {
FromUTCTimestamp(ts.expr
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21693#discussion_r199744502
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2945,6 +2956,17 @@ object functions {
ToUTCTimestamp(ts.expr, Literal
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21699
`def pivot(pivotColumn: String)`, too?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21699
cc: @rxin @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21699#discussion_r199742580
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -340,36 +340,52 @@ class RelationalGroupedDataset protected[sql
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21703
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21668#discussion_r199682495
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -375,16 +375,16 @@ case class CatalogStatistics
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21668
yea, ok. I'll reconsider this again. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21657
@HyukjinKwon WDYT?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21679
Actually, the unsafe package does not include user-facing classes.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21657
Not sure though, the `tokenIndexArr` implementation is always faster than
the unsafe projection?
---
-
To unsubscribe, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21692
Thanks, I feel it'd be better to put concrete version numbers in the
description.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21687
IMHO we need the same fix for both cases. Also, I like simpler
implementations in expressions, so IMO it'd be better to fix in analysis phases
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21692
If we don't override this, which jline version does `sbt` use? `2.12.1`?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21667#discussion_r199418986
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala
---
@@ -30,7 +30,7 @@ import
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21667#discussion_r199418036
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala
---
@@ -152,6 +152,16 @@ trait FileFormat
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21667#discussion_r199416587
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -306,6 +306,7 @@ case class FileSourceScanExec
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21694
I'm not sure this issue should be fixed for test code qualities though, I
have one question; is this only a place having this issue
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21631
oh, super quick fix ;) Thanks, @MaxGekk
In the master, do we still hit the bug when parsing csv data?
---
-
To unsubscribe
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21556
@wangyum Thanks for the benchmarks!
@dongjoon-hyun In the benchmarks above, the results of ORC except for the
case `decimal(9, 2)` have worse performance values as compared to the Parquet
ones
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21657
@MaxGekk Do you mean we remove the option for column pruning?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21682
@gatorsmile aha, thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21679
btw, can you update the title like `[SPARK-24695][SQL]...`
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21679
Since `CalendarInterval` is an internal class, I think users are not
intended to use the class directly...
---
-
To unsubscribe
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21682
@HyukjinKwon btw, why we don't support pushdown for these types? Any
historical reason?
---
-
To unsubscribe, e-mail: reviews
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21687#discussion_r199386837
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -129,7 +129,7 @@ case class CaseWhen
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21687#discussion_r199385955
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala
---
@@ -113,6 +113,35 @@ class
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21674
LGTM, too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21667
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/21668
[SPARK-24690][SQL] Add a new config to control plan stats computation in
LogicalRelation
## What changes were proposed in this pull request?
This pr proposes to propose a new separate config so
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21668
This comes from #20345.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
I made a pr separately for adding the new config described above:
https://github.com/apache/spark/compare/master...maropu:PlanStatsConf
I'll file a jira and make a pr for separating discussions
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21657#discussion_r199034387
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -1579,4 +1579,16 @@ class CSVSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21657#discussion_r199033486
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -1579,4 +1579,16 @@ class CSVSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21657#discussion_r199033421
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -131,20 +132,30 @@ class CSVFileFormat extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21657#discussion_r199032884
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -1579,4 +1579,16 @@ class CSVSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21657#discussion_r199021518
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -1579,4 +1579,16 @@ class CSVSuite extends QueryTest
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21556
Can you benchmark code and results (on your env) in
`FilterPushdownBenchmark` for this type?
---
-
To unsubscribe, e-mail
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21655#discussion_r198752208
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -441,6 +441,24 @@ abstract class DDLSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21655#discussion_r198750322
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -1366,4 +1367,18 @@ class SessionCatalog
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21655#discussion_r198750034
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -1366,4 +1367,18 @@ class SessionCatalog
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21655#discussion_r198748602
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -441,6 +441,24 @@ abstract class DDLSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21655#discussion_r198748442
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -1366,4 +1367,18 @@ class SessionCatalog
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21656
Can you add a test to check if no exception thrown in that condition with
this patch?
---
-
To unsubscribe, e-mail: reviews
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21657
@HyukjinKwon @MaxGekk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/21657
[SPARK-24676][SQL] Project required data from CSV parsed data when column
pruning disabled
## What changes were proposed in this pull request?
This pr modified code to project required data
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
When trying to add the end-to-end test, I got stuck in a trouble; IIUC we
cannot enable `StarSchemaDetection.reorderStarJoins` now? That's because we
[need to turn off CBO to enable
it](https
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21631
@HyukjinKwon BTW, can you check this?
@MaxGekk Probably, I feel you'd be better to file a new jira for the point
you're looking
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21650
nit: Also, can you put `[SQL][PYTHON]` in the title?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
yea, sounds good to me. I'll add end-to-end tests.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21389
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21598
@cloud-fan This merge breaks the build?
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92364/consoleFull
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198355457
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,230 @@ class FileBasedDataSourceSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198355370
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198350214
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,230 @@ class FileBasedDataSourceSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198350225
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,230 @@ class FileBasedDataSourceSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198348474
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,230 @@ class FileBasedDataSourceSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20345#discussion_r198347568
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -84,19 +84,51 @@ object ReorderJoin extends Rule
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20345#discussion_r198345839
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -84,19 +84,50 @@ object ReorderJoin extends Rule
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20345#discussion_r198341155
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -84,19 +84,51 @@ object ReorderJoin extends Rule
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r198340472
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -109,6 +134,20 @@ class JDBCOptions(
s
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21643
LGTM except for one minor comment.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21643#discussion_r198339961
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/ComplexDataSuite.scala
---
@@ -104,4 +104,40 @@ class ComplexDataSuite extends
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21631
v2.5.9 also have the same behaviour? Anyway, it'd be better to ask the
author ;) I asked before and I got quick response
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21643#discussion_r198118072
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/ComplexDataSuite.scala
---
@@ -104,4 +104,13 @@ class ComplexDataSuite extends
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
I'm looking into the failure...
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20345#discussion_r198059157
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -141,14 +141,16 @@ object ExtractEquiJoinKeys extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20345#discussion_r198052416
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -141,14 +141,16 @@ object ExtractEquiJoinKeys extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20345#discussion_r198043685
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -84,19 +84,50 @@ object ReorderJoin extends Rule
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20345#discussion_r198043470
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala
---
@@ -81,14 +92,14 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20345#discussion_r198043374
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -84,19 +84,50 @@ object ReorderJoin extends Rule
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21590
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21641
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21641
I'm not 100% that we could remove this workaround because we hold some
workarounds that are not essentially needed anymore, e.g.,
`SnappyOutputStreamWrapper`.
Anyway, in the description
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r198027023
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -174,3 +209,25 @@ object JDBCOptions
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r198021171
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -65,13 +65,32 @@ class JDBCOptions
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r198021225
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -65,13 +65,32 @@ class JDBCOptions
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r198021157
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -65,13 +65,32 @@ class JDBCOptions
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r198019979
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -174,3 +209,25 @@ object JDBCOptions
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r198019710
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -150,6 +183,7 @@ class JDBCOptions
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r198018682
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -65,13 +65,32 @@ class JDBCOptions
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21590#discussion_r198018360
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -174,3 +209,25 @@ object JDBCOptions
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21631#discussion_r197973962
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityParser.scala
---
@@ -183,11 +183,19 @@ class UnivocityParser
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21389
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
801 - 900 of 3605 matches
Mail list logo
