[GitHub] spark pull request: [SPARK-2309][MLlib] Generalize the binary logi...

2014-10-28 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/1379#issuecomment-60792386 What is the current state of the PR? Can't see any changes in the code... --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-3251][MLLIB]: Clarify learning interfac...

2014-09-27 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2137#issuecomment-57055562 @jkbradley: yes, sounds great! I will give feedback to the design sheet asap. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-15 Thread BigCrunsh
GitHub user BigCrunsh opened a pull request: https://github.com/apache/spark/pull/2398 [SPARK-3396][MLLIB] Use SquaredL2Updater in LogisticRegressionWithSGD SimpleUpdater ignores the regularizer, which leads to an unregularized LogReg. To enable the common L2 regularizer

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-15 Thread BigCrunsh
Github user BigCrunsh closed the pull request at: https://github.com/apache/spark/pull/2231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-15 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-55594501 Changed target to master (https://github.com/apache/spark/pull/2398) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-3251][MLLIB]: Clarify learning interfac...

2014-09-11 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2137#issuecomment-55261445 I have to admit that this PR may try to address too many issues at once. It think the major ones are: Ideally, - the model should be immutable and stateless

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-04 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-54459193 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-04 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-54459168 @mengxr: done ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [FIX][MLLIB] Use SquaredL2Updater in LogisticR...

2014-09-03 Thread BigCrunsh
Github user BigCrunsh commented on a diff in the pull request: https://github.com/apache/spark/pull/2231#discussion_r17034656 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala --- @@ -125,4 +125,39 @@ class LogisticRegressionSuite

[GitHub] spark pull request: [FIX][MLLIB] Use SquaredL2Updater in LogisticR...

2014-09-03 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-54261292 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [FIX][MLLIB] Use SquaredL2Updater in LogisticR...

2014-09-03 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-54271799 I am not sure why this is failing... ``` - local metrics *** FAILED *** [info] org.apache.spark.scheduler.StageInfo@2f3ab430 fetchWaitTime

[GitHub] spark pull request: [FIX][MLLIB] Use SquaredL2Updater in LogisticR...

2014-09-03 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-54271813 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-3251][MLLIB]: Clarify learning interfac...

2014-09-01 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2137#issuecomment-54040903 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-3251][MLLIB]: Clarify learning interfac...

2014-09-01 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2137#issuecomment-54055010 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-3251][MLLIB]: Clarify learning interfac...

2014-09-01 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2137#issuecomment-54057841 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-3251][MLLIB]: Clarify learning interfac...

2014-09-01 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2137#issuecomment-54067988 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-3251][MLLIB]: Clarify learning interfac...

2014-09-01 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2137#issuecomment-54079294 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: Use SquaredL2Updater in LogisticRegressionWith...

2014-09-01 Thread BigCrunsh
GitHub user BigCrunsh opened a pull request: https://github.com/apache/spark/pull/2231 Use SquaredL2Updater in LogisticRegressionWithSGD SimpleUpdater ignores the regularizer, which leads to an unregularized LogReg. To enable the common L2 regularizer (and the corresponding

[GitHub] spark pull request: [SPARK-3251][MLLIB]: Clarify learning interfac...

2014-09-01 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2137#issuecomment-54092745 @mengxr, do you agree with this modification? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3251][MLLIB]: Clarify learning interfac...

2014-08-28 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2137#issuecomment-53702702 @mengxr, might it be that you mistake logistic regression for Naive Bayes? Logistic regression typically predicts well-calibrated probabilities, see e.g. [1]; it might

[GitHub] spark pull request: [SPARK-3251][MLLIB]: Clarify learning interfac...

2014-08-27 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2137#issuecomment-53569214 Currently, MLLIB contains linear models (GLMs) that produce scores based on an inner product, classification models that might derive a classification using scores

[GitHub] spark pull request: mllib: Clarify learning interfaces

2014-08-26 Thread BigCrunsh
GitHub user BigCrunsh opened a pull request: https://github.com/apache/spark/pull/2137 mllib: Clarify learning interfaces ** Make threshold mandatory ** Currently, the output of ``predict`` for an example is either the score or the class. This side-effect is caused