Github user JiahuiJiang commented on the issue:
https://github.com/apache/spark/pull/20961
Don't know why it failed so many times... but all these tests pass on my
local machine and the commit before adding the
Github user JiahuiJiang commented on the issue:
https://github.com/apache/spark/pull/20961
@kiszk Added the ticket number! Do we need to retrigger the test build on
that new commit?
---
-
To unsubscribe, e-mail
Github user JiahuiJiang commented on the issue:
https://github.com/apache/spark/pull/20961
@hvanhovell added a test, before this change the origin would be undefined
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user JiahuiJiang commented on the issue:
https://github.com/apache/spark/pull/20961
@gatorsmile fixed :D
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user JiahuiJiang closed the pull request at:
https://github.com/apache/spark/pull/20939
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user JiahuiJiang commented on the issue:
https://github.com/apache/spark/pull/20939
@gatorsmile Is #20961 crazy to do? It makes sure all the origins are kept
correctly after analyzing, so future refactor won't cause similar issue. But
not sure whether that behavior shou
GitHub user JiahuiJiang opened a pull request:
https://github.com/apache/spark/pull/20961
[SPARK-23823][SQL] Keep origin in transformExpression
Fixes https://issues.apache.org/jira/browse/SPARK-23823
Keep origin for all the methods using transformExpression
## What
Github user JiahuiJiang commented on the issue:
https://github.com/apache/spark/pull/20939
@gatorsmile Seems the tests are still flaking :/
And @robertzk proposed this fix https://github.com/JiahuiJiang/spark/pull/2
instead, where we keep the origin directly inside
Github user JiahuiJiang commented on the issue:
https://github.com/apache/spark/pull/20939
We are implementing a [language
server](https://microsoft.github.io/language-server-protocol/) that needs to
understand where the column locations, so we are depending on some of these
Github user JiahuiJiang commented on the issue:
https://github.com/apache/spark/pull/20939
Yes, for any SQL queries with columns inside.
e.g. "create table `/targetTable` as (\nselect col1 from
`/path/to/table1`\n)", after parsing the query, I got a QueryPlan where
GitHub user JiahuiJiang opened a pull request:
https://github.com/apache/spark/pull/20939
[SPARK-23823][SQL] Fix ResolveReferences
## What changes were proposed in this pull request?
Fixes https://issues.apache.org/jira/browse/SPARK-23823
Introduced in apache#19585
11 matches
Mail list logo
