[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-23 Thread QiangCai
Github user QiangCai closed the pull request at:

https://github.com/apache/spark/pull/10619


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-07 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10619#issuecomment-169700777
  
@sarutak I will do it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-06 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10562#issuecomment-169369194
  
OK. I have created another PR https://github.com/apache/spark/pull/10619.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-06 Thread QiangCai
GitHub user QiangCai opened a pull request:

https://github.com/apache/spark/pull/10619

[SPARK-12340][SQL]fix Int overflow in the SparkPlan.executeTake, RDD.take 
and AsyncRDDActions.takeAsync for branch-1.6

 I create this PR to merge this code into branch-1.6. And I have merged 
this code into master in PR https://github.com/apache/spark/pull/10562.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/QiangCai/spark bugfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10619.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10619


commit b35e9b922e893ab825bfd43370cc91852f6cc50a
Author: QiangCai <david.c...@gmail.com>
Date:   2016-01-06T15:51:17Z

avoid Int overflow




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-06 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10619#issuecomment-169502987
  
spark-12340 has passed this test, but just other error has happend.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-05 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10562#issuecomment-169063131
  
@sarutak  Maybe we have found another bug. I will try to fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-05 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10562#issuecomment-169070917
  
I have remove the initial size of the ArrayBuffer instance. And the default 
size is 16.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-05 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10562#issuecomment-169056589
  
@srowen I find error message in test bulid log, a OutOfMemoryError 
exception has happened. The code in 71 line of  the file AsyncRDDActions.scala 
is  "val results = new ArrayBuffer[T](num) ", because num(2147483638) is too 
large, JVM can't allocate enough memory space. I think I should modify unit 
test to smaller num in 2079 line of SQLQuerySuite.scala.

error message:
[info] Exception encountered when attempting to run a suite with class 
name: org.apache.spark.sql.SQLQuerySuite *** ABORTED *** (31 seconds, 447 
milliseconds)
[info]   java.lang.OutOfMemoryError: Java heap space
[info]   at 
scala.collection.mutable.ResizableArray$class.$init$(ResizableArray.scala:32)
[info]   at 
scala.collection.mutable.ArrayBuffer.(ArrayBuffer.scala:47)
[info]   at 
org.apache.spark.rdd.AsyncRDDActions$$anonfun$takeAsync$1.apply(AsyncRDDActions.scala:71)
[info]   at 
org.apache.spark.rdd.AsyncRDDActions$$anonfun$takeAsync$1.apply(AsyncRDDActions.scala:66)
[info]   at 
org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:150)
[info]   at 
org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:111)
[info]   at org.apache.spark.rdd.RDD.withScope(RDD.scala:316)
[info]   at 
org.apache.spark.rdd.AsyncRDDActions.takeAsync(AsyncRDDActions.scala:66)
[info]   at 
org.apache.spark.sql.SQLQuerySuite$$anonfun$132.apply$mcV$sp(SQLQuerySuite.scala:2079)
[info]   at 
org.apache.spark.sql.SQLQuerySuite$$anonfun$132.apply(SQLQuerySuite.scala:2071)
[info]   at 
org.apache.spark.sql.SQLQuerySuite$$anonfun$132.apply(SQLQuerySuite.scala:2071)
..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-05 Thread QiangCai
Github user QiangCai commented on a diff in the pull request:

https://github.com/apache/spark/pull/10562#discussion_r48868638
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala 
---
@@ -2067,4 +2067,16 @@ class SQLQuerySuite extends QueryTest with 
SharedSQLContext {
   )
 }
   }
+
+  test("SPARK-12340: overstep the bounds of Int in SparkPlan.executeTake"){
--- End diff --

I will do it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-05 Thread QiangCai
Github user QiangCai commented on a diff in the pull request:

https://github.com/apache/spark/pull/10562#discussion_r48844685
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala 
---
@@ -2028,6 +2028,7 @@ class SQLQuerySuite extends QueryTest with 
SharedSQLContext {
   Row(false) :: Row(true) :: Nil)
   }
 
+<<<<<<< 1cdc42d2b99edfec01066699a7620cca02b61f0e
--- End diff --

I have remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-05 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10562#issuecomment-168997795
  
@srowen I have rebased from master and resolved all conflicts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-05 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10562#issuecomment-169191091
  
I think I have resolved this problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-04 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10562#issuecomment-168863650
  
@srowen  I have no idea how to resolve this error. Would you help me?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-04 Thread QiangCai
Github user QiangCai closed the pull request at:

https://github.com/apache/spark/pull/10562


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-04 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10562#issuecomment-168674310
  
@srowen I have removed some whitespaces.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-04 Thread QiangCai
GitHub user QiangCai reopened a pull request:

https://github.com/apache/spark/pull/10562

[SPARK-12340][SQL]fix Int overflow in the SparkPlan.executeTake, RDD.take 
and AsyncRDDActions.takeAsync

I have closed pull request https://github.com/apache/spark/pull/10487. And 
I create this pull request to resolve the problem.

spark jira
https://issues.apache.org/jira/browse/SPARK-12340

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/QiangCai/spark bugfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10562.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10562


commit 4974f05d93852f4ee302715d811eb585affddd2d
Author: QiangCai <david.c...@gmail.com>
Date:   2016-01-03T13:47:58Z

[SPARK-12340][SQL]fix Int overflow in the SparkPlan.executeTake, RDD.take 
and AsyncRDDActions.takeAsync

commit 9c102bc81bdf704ef1e1c916727f2ec78702be5b
Author: cai qiang <david.c...@gmail.com>
Date:   2016-01-03T23:42:24Z

delete some blank lines

commit 639cfb26f33f2d0f31530b57a147f42904e635ef
Author: QiangCai <david.c...@gmail.com>
Date:   2016-01-04T13:00:40Z

remove whitespaces




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-03 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10562#issuecomment-168564772
  
I have removed some blank lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-03 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10487#issuecomment-168500336
  
I have created another pull request 
https://github.com/apache/spark/pull/10562.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-03 Thread QiangCai
Github user QiangCai closed the pull request at:

https://github.com/apache/spark/pull/10487


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-03 Thread QiangCai
GitHub user QiangCai opened a pull request:

https://github.com/apache/spark/pull/10562

[SPARK-12340][SQL]fix Int overflow in the SparkPlan.executeTake, RDD.take 
and AsyncRDDActions.takeAsync

I have close pull request https://github.com/apache/spark/pull/10487. And I 
create this pull request to resolve the problem.

spark jira
https://issues.apache.org/jira/browse/SPARK-12340

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/QiangCai/spark bugfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10562.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10562


commit 4974f05d93852f4ee302715d811eb585affddd2d
Author: QiangCai <david.c...@gmail.com>
Date:   2016-01-03T13:47:58Z

[SPARK-12340][SQL]fix Int overflow in the SparkPlan.executeTake, RDD.take 
and AsyncRDDActions.takeAsync




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-02 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10487#issuecomment-168467402
  
@sarutak When  I am rebasing  from master,  I get many conflicts. I don't 
known how to resolve it. I have  just pushed  the commit "merge".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2015-12-28 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10487#issuecomment-167709123
  
@sarutak I will try to add test cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL] Fix overstep the bounds of ...

2015-12-27 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10310#issuecomment-167393002
  
@srowen I have new another pull request. This pull request will be closed.
another pull request https://github.com/apache/spark/pull/10487


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2015-12-27 Thread QiangCai
GitHub user QiangCai opened a pull request:

https://github.com/apache/spark/pull/10487

[SPARK-12340][SQL]fix Int overflow in the SparkPlan.executeTake, RDD.take 
and AsyncRDDActions.takeAsync

@srowen  I new this pull request to to resolve the problem.

another pull request 
https://github.com/apache/spark/pull/10310

jira
https://issues.apache.org/jira/browse/SPARK-12340

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/QiangCai/spark bugfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10487.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10487


commit 18f1b81ba1fa47202ab069ce12f6f9141e981ed3
Author: QiangCai <david.c...@gmail.com>
Date:   2015-12-27T08:20:44Z

fix Int overflow




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL] Fix overstep the bounds of ...

2015-12-27 Thread QiangCai
Github user QiangCai closed the pull request at:

https://github.com/apache/spark/pull/10310


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL] Fix overstep the bounds of ...

2015-12-24 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10310#issuecomment-167117473
  
@srowen I maybe have made a mistake in git bash. Can I new another pull 
request to resolved this problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL] Fix overstep the bounds of ...

2015-12-23 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10310#issuecomment-166912120
  
@srowen I have modified all the code, and try to keep them to be the same.

At first, the var numPartsToTry and partsScanned  have been set to Long.
Secondly,  because  var p should be Seq[Int], so i have added to.Int  in 
the until statement  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL] Fix overstep the bounds of ...

2015-12-19 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10310#issuecomment-165964135
  
Yes. I will check all at first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL] Fix overstep the bounds of ...

2015-12-18 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10310#issuecomment-165946596
  
Yes. I will change all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL] Fix overstep the bounds of ...

2015-12-15 Thread QiangCai
GitHub user QiangCai opened a pull request:

https://github.com/apache/spark/pull/10310

[SPARK-12340][SQL] Fix overstep the bounds of Int in SparkPlan.executeTake

Modifies partsScanned to partsScanned.toLong and  chang result of math.min 
to Int.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/QiangCai/spark QiangCai

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10310.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10310


commit 37acd541e0447a46a3b7718a688c4312e86d13e6
Author: QiangCai <david.c...@gmail.com>
Date:   2015-12-15T12:24:38Z

 Fix overstep the bounds of Int in SparkPlan.executeTake

Modifies partsScanned to partsScanned.toLong and  chang result of math.min 
to Int.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12340][SQL] Fix overstep the bounds of ...

2015-12-15 Thread QiangCai
Github user QiangCai commented on the pull request:

https://github.com/apache/spark/pull/10310#issuecomment-164967364
  
Tthe number of  partitions which has scanned is  the size of seq p, not 
numPartsToTry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org