[GitHub] spark issue #14601: [SPARK-13979][Core] Killed executor is re spawned withou...

2017-07-23 Thread agsachin
Github user agsachin commented on the issue: https://github.com/apache/spark/pull/14601 Thanks @jiangxb2987 will add this test case by tomorrow and will be update the pr with results --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #14601: [SPARK-13979][Core] Killed executor is re spawned withou...

2017-02-25 Thread agsachin
Github user agsachin commented on the issue: https://github.com/apache/spark/pull/14601 @steveloughran I have updated the pull request to fs.* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #14601: [SPARK-13979][Core] Killed executor is re spawned withou...

2017-02-15 Thread agsachin
Github user agsachin commented on the issue: https://github.com/apache/spark/pull/14601 @lresendecan we go ahead with key.startsWith("fs."). so that we don't need to check so many conditions. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request #14601: [SPARK-13979][Core] Killed executor is re spawned...

2017-02-15 Thread agsachin
Github user agsachin commented on a diff in the pull request: https://github.com/apache/spark/pull/14601#discussion_r101252433 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -102,11 +102,20 @@ class SparkHadoopUtil extends Logging

[GitHub] spark pull request #14601: [SPARK-13979][Core] Killed executor is re spawned...

2016-08-20 Thread agsachin
Github user agsachin commented on a diff in the pull request: https://github.com/apache/spark/pull/14601#discussion_r75588799 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -107,6 +107,14 @@ class SparkHadoopUtil extends Logging

[GitHub] spark pull request #14601: [SPARK-13979][Core] Killed executor is re spawned...

2016-08-20 Thread agsachin
Github user agsachin commented on a diff in the pull request: https://github.com/apache/spark/pull/14601#discussion_r75588790 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -102,11 +102,19 @@ class SparkHadoopUtil extends Logging

[GitHub] spark pull request #14601: [SPARK-13979][Core][WIP]Killed executor is re spa...

2016-08-16 Thread agsachin
Github user agsachin commented on a diff in the pull request: https://github.com/apache/spark/pull/14601#discussion_r74917990 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -107,6 +107,14 @@ class SparkHadoopUtil extends Logging

[GitHub] spark issue #14601: [SPARK-13979][Core][WIP]Killed executor is re spawned wi...

2016-08-16 Thread agsachin
Github user agsachin commented on the issue: https://github.com/apache/spark/pull/14601 @lresende yes this fix works for the the scenario where the user has provided the properties programmatically like for swift:- sc.hadoopConfiguration.set("fs.swift2d

[GitHub] spark pull request #14601: [SPARK-13979][Core][WIP]Killed executor is re spa...

2016-08-16 Thread agsachin
Github user agsachin commented on a diff in the pull request: https://github.com/apache/spark/pull/14601#discussion_r74880042 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -107,6 +107,14 @@ class SparkHadoopUtil extends Logging

[GitHub] spark pull request #14601: [SPARK-13979][Spark Core][WIP]Killed executor is ...

2016-08-11 Thread agsachin
GitHub user agsachin opened a pull request: https://github.com/apache/spark/pull/14601 [SPARK-13979][Spark Core][WIP]Killed executor is re spawned without AWS key… ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix

[GitHub] spark pull request: [SPARK-15183][Streaming] Adding outputMode to ...

2016-05-08 Thread agsachin
Github user agsachin commented on the pull request: https://github.com/apache/spark/pull/12958#issuecomment-217718480 @tdas , @marmbrus any inputs on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15183][Streaming] Adding outputMode to ...

2016-05-08 Thread agsachin
Github user agsachin commented on a diff in the pull request: https://github.com/apache/spark/pull/12958#discussion_r62431170 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -25,13 +25,13 @@ import org.apache.hadoop.fs.Path import

[GitHub] spark pull request: SPARK-15183

2016-05-06 Thread agsachin
GitHub user agsachin opened a pull request: https://github.com/apache/spark/pull/12958 SPARK-15183 ## What changes were proposed in this pull request? while experimenting with structure streaming. I found that mode() is used for non-continuous queries while outputMode

[GitHub] spark pull request: [SPARK-14597] [Streaming] Streaming Listener t...

2016-04-20 Thread agsachin
Github user agsachin commented on the pull request: https://github.com/apache/spark/pull/12357#issuecomment-212749355 hey closed this thread as we are moving towards approach 2 explained in the jira https://issues.apache.org/jira/browse/SPARK-14597 --- If your project is set up

[GitHub] spark pull request: [SPARK-14597] [Streaming] Streaming Listener t...

2016-04-20 Thread agsachin
Github user agsachin closed the pull request at: https://github.com/apache/spark/pull/12357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-14745] [Streaming] [WIP] CEP support in...

2016-04-19 Thread agsachin
GitHub user agsachin opened a pull request: https://github.com/apache/spark/pull/12518 [SPARK-14745] [Streaming] [WIP] CEP support in Spark Streaming ## What changes were proposed in this pull request? This JIRA is about how/what can we add in Spark Streaming to support CEP

[GitHub] spark pull request: [SPARK-14597] [Streaming] Streaming Listener t...

2016-04-13 Thread agsachin
GitHub user agsachin opened a pull request: https://github.com/apache/spark/pull/12358 [SPARK-14597] [Streaming] Streaming Listener timing metrics should include time spent in JobGenerator's graph.generateJobs ## What changes were proposed in this pull request? I have

[GitHub] spark pull request: [SPARK-14597] [Streaming] Streaming Listener t...

2016-04-13 Thread agsachin
GitHub user agsachin opened a pull request: https://github.com/apache/spark/pull/12357 [SPARK-14597] [Streaming] Streaming Listener timing metrics should include time spent in JobGenerator's graph.generateJobs ## What changes were proposed in this pull request? (Please

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

2016-02-08 Thread agsachin
GitHub user agsachin opened a pull request: https://github.com/apache/spark/pull/3 [SPARK-13177][Examples]Update ActorWordCount example to not directly use low level linked list as it is deprecated. You can merge this pull request into a Git repository by running: $ git

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

2016-02-08 Thread agsachin
Github user agsachin commented on a diff in the pull request: https://github.com/apache/spark/pull/3#discussion_r52155735 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala --- @@ -18,16 +18,14 @@ // scalastyle:off println

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

2016-02-08 Thread agsachin
Github user agsachin commented on the pull request: https://github.com/apache/spark/pull/3#issuecomment-181349834 @srowen if this is ok can u ask jenkins to test.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-13065] [Streaming] streaming-twitter pa...

2016-02-08 Thread agsachin
Github user agsachin commented on the pull request: https://github.com/apache/spark/pull/11003#issuecomment-181354203 @BenFradet That's was a long thread , after reading all still I am not able to make conclusion what is final decision. There is no package in spark

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

2016-02-08 Thread agsachin
Github user agsachin commented on a diff in the pull request: https://github.com/apache/spark/pull/3#discussion_r52155740 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala --- @@ -63,7 +61,7 @@ class FeederActor extends Actor

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

2016-02-08 Thread agsachin
Github user agsachin commented on a diff in the pull request: https://github.com/apache/spark/pull/3#discussion_r52157133 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala --- @@ -18,16 +18,14 @@ // scalastyle:off println

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

2016-02-08 Thread agsachin
Github user agsachin commented on the pull request: https://github.com/apache/spark/pull/3#issuecomment-181376718 @srowen , I agree with you on Linked List front, just thinking to keep example simple --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-2788] [STREAMING] Add location filterin...

2016-02-08 Thread agsachin
Github user agsachin commented on the pull request: https://github.com/apache/spark/pull/1717#issuecomment-181379130 @srowen Is anyone working on third-party package for twitter, I suggest to add FilterQuery support to existing api, and move twitter Api's out of spark

[GitHub] spark pull request: [SPARK-13065] [Streaming] streaming-twitter pa...

2016-02-08 Thread agsachin
Github user agsachin commented on the pull request: https://github.com/apache/spark/pull/11003#issuecomment-181394626 @srowen Is anyone working on third-party package for twitter, [reference](https://github.com/apache/spark/pull/1717): I suggest to add FilterQuery support

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

2016-02-08 Thread agsachin
Github user agsachin commented on a diff in the pull request: https://github.com/apache/spark/pull/3#discussion_r52236639 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala --- @@ -63,11 +63,11 @@ class FeederActor extends Actor

[GitHub] spark pull request: [SPARK-13065] [Streaming] streaming-twitter pa...

2016-02-07 Thread agsachin
Github user agsachin commented on the pull request: https://github.com/apache/spark/pull/11003#issuecomment-181205794 cc @tdas , any inputs on this PR.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13065] [Streaming] streaming-twitter pa...

2016-02-03 Thread agsachin
Github user agsachin commented on the pull request: https://github.com/apache/spark/pull/11003#issuecomment-179340960 cc @tdas , please review this... or add some one who can review ? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13065] [Streaming] streaming-twitter pa...

2016-02-02 Thread agsachin
Github user agsachin commented on the pull request: https://github.com/apache/spark/pull/11003#issuecomment-178454467 List of changes: 1) Added support for passing FilterQuery object instead of just Seq of keywords 2) Java had more flexible Api syntax than that of Scala so

[GitHub] spark pull request: [SPARK-13065] [Streaming] streaming-twitter pa...

2016-02-01 Thread agsachin
GitHub user agsachin opened a pull request: https://github.com/apache/spark/pull/11003 [SPARK-13065] [Streaming] streaming-twitter pass twitter4j.FilterQuery argument to TwitterUtils.createStream() You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-11552][DOCS][Replaced example code in m...

2015-11-09 Thread agsachin
Github user agsachin commented on the pull request: https://github.com/apache/spark/pull/9539#issuecomment-155045413 Thanks @yinxusen I have removed all the empty lines --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-11552][DOCS][Replaced example code in m...

2015-11-07 Thread agsachin
GitHub user agsachin opened a pull request: https://github.com/apache/spark/pull/9539 [SPARK-11552][DOCS][Replaced example code in ml-decision-tree.md using include_example] I have tested it on my local, it is working fine, please review You can merge this pull request into a Git