[GitHub] spark pull request #21120: [SPARK-22448][ML] Added sum function to Summerize...

2018-08-16 Thread dedunumax
Github user dedunumax closed the pull request at: https://github.com/apache/spark/pull/21120 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21120: [SPARK-22448][ML] Added sum function to Summerize...

2018-06-29 Thread dedunumax
Github user dedunumax commented on a diff in the pull request: https://github.com/apache/spark/pull/21120#discussion_r199135313 --- Diff: mllib/src/main/scala/org/apache/spark/ml/stat/Summarizer.scala --- @@ -562,6 +573,23 @@ private[ml] object SummaryBuilderImpl extends Logging

[GitHub] spark issue #21120: [SPARK-22448][ML] Added sum function to Summerizer and M...

2018-05-04 Thread dedunumax
Github user dedunumax commented on the issue: https://github.com/apache/spark/pull/21120 cc @WeichenXu123 @dbtsai --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21120: [SPARK-22448][ML] Added sum function to Summerizer and M...

2018-04-24 Thread dedunumax
Github user dedunumax commented on the issue: https://github.com/apache/spark/pull/21120 cc @WeichenXu123 @dbtsai --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21120: [SPARK-22448][ML] Added sum function to Summerizer and M...

2018-04-24 Thread dedunumax
Github user dedunumax commented on the issue: https://github.com/apache/spark/pull/21120 I see, I will change the code like that. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21120: [SPARK-22448][ML] Added sum function to Summerizer and M...

2018-04-23 Thread dedunumax
Github user dedunumax commented on the issue: https://github.com/apache/spark/pull/21120 Having sum as a basic statistic will make the API user-friendly. I'm thinking about implementing other functions as well. Do you think it is not worth to implement

[GitHub] spark issue #21120: [SPARK-22448][ML] Added sum function to Summerizer and M...

2018-04-21 Thread dedunumax
Github user dedunumax commented on the issue: https://github.com/apache/spark/pull/21120 cc @rxin @cloud-fan @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #21120: [SPARK-22448][ML] Added sum function to Summerize...

2018-04-21 Thread dedunumax
GitHub user dedunumax opened a pull request: https://github.com/apache/spark/pull/21120 [SPARK-22448][ML] Added sum function to Summerizer and MultivariateOn… …lineSummarizer ## What changes were proposed in this pull request? This is going to add sum function