[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

Github user egraldlo commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49160379 thx @willb, maybe protected val SUBSTRING = Keyword(SUBSTRING) as well, but this will cause the code redundance. --- If your project is set up for it, you can reply

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

Github user egraldlo commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49161743 fine, that's great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SQL]Extract the joinkeys from join condition

Github user egraldlo commented on a diff in the pull request: https://github.com/apache/spark/pull/1190#discussion_r14230460 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -65,7 +64,7 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-2049] [sql] Avg function may cause over...

Github user egraldlo closed the pull request at: https://github.com/apache/spark/pull/978 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-2049] [sql] Avg function may cause over...

Github user egraldlo commented on the pull request: https://github.com/apache/spark/pull/978#issuecomment-45579617 yes, maybe I don't make the version of test branch to be up-to-date at that time. I will close the issue. --- If your project is set up for it, you can reply

[GitHub] spark pull request: do best to avoid overflow in avg function

GitHub user egraldlo opened a pull request: https://github.com/apache/spark/pull/977 do best to avoid overflow in avg function since we define the return data type of avg() to DoubleType, I think we can do our best to extend the scope to avoid the overflowing, so I think we can

[GitHub] spark pull request: do best to avoid overflow in avg function

Github user egraldlo commented on the pull request: https://github.com/apache/spark/pull/977#issuecomment-45195256 maybe something wrong with my branch, I will create a new one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: do best to avoid overflow in avg function

Github user egraldlo closed the pull request at: https://github.com/apache/spark/pull/977 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: do best to avoid overflowing in function avg

GitHub user egraldlo opened a pull request: https://github.com/apache/spark/pull/978 do best to avoid overflowing in function avg since we define the return data type of avg() to DoubleType, I think we can do our best to extend the scope to avoid the overflowing, so I think we can

[GitHub] spark pull request: system function upper and lower can be support...

GitHub user egraldlo opened a pull request: https://github.com/apache/spark/pull/936 system function upper and lower can be supported I don't know whether it's time to implement system function about string operation in spark sql now. You can merge this pull request into a Git

[GitHub] spark pull request: system function upper and lower can be support...

Github user egraldlo commented on the pull request: https://github.com/apache/spark/pull/936#issuecomment-44802398 thanks @liancheng and @marmbrus, I have modified the formatting issues and nullable. --- If your project is set up for it, you can reply to this email and have your