Github user hackingdata8 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4610#discussion_r24989501
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala ---
@@ -66,9 +66,17 @@ private[sql] class DefaultSource
mode match {
case SaveMode.Append =>
sys.error(s"Append mode is not supported by
${this.getClass.getCanonicalName}")
- case SaveMode.Overwrite =>
- fs.delete(filesystemPath, true)
+ case SaveMode.Overwrite => {
+ try {
+ fs.delete(filesystemPath, true)
+ } catch {
+ case e: IOException =>
+ throw new IOException(
+ s"Unable to clear output directory
${filesystemPath.toString} prior"
+ + s" to CREATE a JSON table AS SELECT:\n${e.toString}")
+ }
--- End diff --
@yhuai Yes, it is expected. If there is no exception thrown, it can ensure
delete success. I have found that other codes in spark do the same thing for
delete.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
