[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages

Github user isaias commented on the pull request: https://github.com/apache/spark/pull/2055#issuecomment-93381091 @srowen done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages

Github user isaias commented on a diff in the pull request: https://github.com/apache/spark/pull/2055#discussion_r25069002 --- Diff: core/src/main/scala/org/apache/spark/util/ActorLogReceive.scala --- @@ -43,7 +43,13 @@ private[spark] trait ActorLogReceive { private

[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages

Github user isaias commented on the pull request: https://github.com/apache/spark/pull/2055#issuecomment-53256206 Hi @ScrapCodes, I am starting to contribute with Spark and knowing the source code/structure now, but I think that the use of Actor are limited to internal

[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages

Github user isaias commented on the pull request: https://github.com/apache/spark/pull/2048#issuecomment-52742677 @rxin, the trait ActorLogReceive gets the concrete implementation through receiveWithLogging function overriding of implementing Actor and applying it, so I think

[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages

Github user isaias commented on the pull request: https://github.com/apache/spark/pull/2048#issuecomment-52744357 @rxin Very nice, it works. Should be better to close this PR and send another just with the trait changes? BR --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages

Github user isaias closed the pull request at: https://github.com/apache/spark/pull/2048 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages

Github user isaias commented on the pull request: https://github.com/apache/spark/pull/2048#issuecomment-52745159 Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages

GitHub user isaias opened a pull request: https://github.com/apache/spark/pull/2055 [SPARK-2312] Logging Unhandled messages The previous solution has changed based on https://github.com/apache/spark/pull/2048 discussions. You can merge this pull request into a Git repository

[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages

Github user isaias commented on the pull request: https://github.com/apache/spark/pull/2055#issuecomment-52752384 After send the PR I realized that I could have written some tests based on underlyingActor and isDefinedAt, if is valuable I can do it. BR --- If your project

[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages

GitHub user isaias opened a pull request: https://github.com/apache/spark/pull/2048 [SPARK-2312] Logging Unhandled messages Note about tests: The best way to write tests for Log is use the TestEventListener and EventFilter of Akka, but the current Actors aren't using default