[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...

2018-09-17 Thread jamesthomp
Github user jamesthomp commented on the issue: https://github.com/apache/spark/pull/21217 I would be glad for @viirya or @mgaido91 to pick this up from me. It sounds like the remaining work is to move the test from `SQLQuerySuite` into `AnalysisSuite`, but I'm not certain h

[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...

2018-07-17 Thread jamesthomp
Github user jamesthomp commented on the issue: https://github.com/apache/spark/pull/21217 @HyukjinKwon - I have resolved the conflict with the docs changes. Please let me know if any additional changes are required

[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...

2018-05-04 Thread jamesthomp
Github user jamesthomp commented on the issue: https://github.com/apache/spark/pull/21217 @gatorsmile - I have added a note to the migration guide. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIME...

2018-05-02 Thread jamesthomp
GitHub user jamesthomp opened a pull request: https://github.com/apache/spark/pull/21217 [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP to be case insensitive ## What changes were proposed in this pull request? This PR adjusts the behavior of CURRENT_DATE and

[GitHub] spark issue #20580: [SPARK-23388][SQL] Support for Parquet Binary DecimalTyp...

2018-02-12 Thread jamesthomp
Github user jamesthomp commented on the issue: https://github.com/apache/spark/pull/20580 I'll see if I can generate a parquet file with the right schema to add for a test, but probably cannot look at this till tom

[GitHub] spark issue #20580: [SPARK-23388][SQL] Support for Parquet Binary DecimalTyp...

2018-02-12 Thread jamesthomp
Github user jamesthomp commented on the issue: https://github.com/apache/spark/pull/20580 @kiszk - I've changed the implementation to no longer use `column.isArray()` and instead just inline the decimal type check (so no changes needed to the public api). I don't think

[GitHub] spark issue #20580: [SPARK-23388][SQL] Support for Parquet Binary DecimalTyp...

2018-02-11 Thread jamesthomp
Github user jamesthomp commented on the issue: https://github.com/apache/spark/pull/20580 Yeah I believe it will add support for the array type too. Spark actually previously supported these types but the support was removed in this PR: https://github.com/apache/spark/commit

[GitHub] spark pull request #20580: [SPARK-23388][SQL] Support for Parquet Binary Dec...

2018-02-11 Thread jamesthomp
Github user jamesthomp commented on a diff in the pull request: https://github.com/apache/spark/pull/20580#discussion_r167459070 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java --- @@ -691,11 +696,6 @@ public

[GitHub] spark pull request #20580: [SPARK-23388][SQL] Support for Parquet Binary Dec...

2018-02-11 Thread jamesthomp
GitHub user jamesthomp opened a pull request: https://github.com/apache/spark/pull/20580 [SPARK-23388][SQL] Support for Parquet Binary DecimalType in VectorizedColumnReader ## What changes were proposed in this pull request? Re-add support for parquet binary DecimalType in