[GitHub] spark pull request: [SPARK-6937][MLLIB] Fixed bug in PICExample in...

2015-04-15 Thread javadba
GitHub user javadba opened a pull request: https://github.com/apache/spark/pull/5531 [SPARK-6937][MLLIB] Fixed bug in PICExample in which the radius were not being accepted on c... Tiny bug in PowerIterationClusteringExample in which radius not accepted from command line You can

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-11 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24521887 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,149 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-11 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24521948 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,149 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-11 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24519073 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,149 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-11 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24519062 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,149 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-11 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24518027 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,149 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-11 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24517979 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,149 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-11 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24518800 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,149 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-11 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24518861 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,149 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-11 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24518525 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,149 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-10 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24471635 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,149 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-10 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24471616 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,149 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-10 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24471723 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,149 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-10 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24394701 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24392886 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24393348 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24394006 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24393968 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24393995 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24394002 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24393130 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24393254 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24393498 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24393834 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24393018 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24393918 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24394635 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24393289 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4495#discussion_r24393317 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala --- @@ -0,0 +1,176 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-5503][MLLIB] Example code for Power Ite...

2015-02-09 Thread javadba
GitHub user javadba opened a pull request: https://github.com/apache/spark/pull/4495 [SPARK-5503][MLLIB] Example code for Power Iteration Clustering You can merge this pull request into a Git repository by running: $ git pull https://github.com/Huawei-Spark/spark picexamples

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23803786 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23808251 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/clustering/PowerIterationClusteringSuite.scala --- @@ -0,0 +1,317 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23807937 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23807026 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23801499 --- Diff: docs/mllib-clustering-pic.md --- @@ -0,0 +1,30 @@ +--- --- End diff -- OK --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23802807 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23808004 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23807925 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23807487 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23807503 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23807540 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23802566 --- Diff: docs/mllib-clustering-pic.md --- @@ -0,0 +1,30 @@ +--- +layout: global +title: Clustering - MLlib +displayTitle: a href=mllib

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23802606 --- Diff: mllib/pom.xml --- @@ -103,6 +108,13 @@ typetest-jar/type scopetest/scope /dependency +!--dependency

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23807449 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23802691 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23807660 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23802882 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23802897 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23818389 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23819495 --- Diff: data/mllib/pic_data.txt --- @@ -0,0 +1,299 @@ +1000 0.000.0001250.380.012684 0.000638

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23811947 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-29 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23818325 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-28 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/4254#issuecomment-71947549 I have moved out the Gaussian / Affinity matrix calculations. It is not clear where their new home / if they have a new home. Presently the testcases rely upon them

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-28 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23728755 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PIClustering.scala --- @@ -0,0 +1,433 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-28 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23728797 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PIClustering.scala --- @@ -0,0 +1,433 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-28 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/4254#issuecomment-71929175 RE: Is it possible to do Gaussian similarity in another PR? It should be part of the feature transformation but not within PIC. It would be easier for code

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-28 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23728909 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/clustering/PIClusteringSuite.scala --- @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-28 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/4254#issuecomment-71932032 Hi, We have suggestion here: to separate the creation/definition of the input graph from the PIC: val G = PIC.createGaussianAffinityMatrix(sc, vertices

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-28 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23728804 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/clustering/PIClusteringSuite.scala --- @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-28 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23728761 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PIClustering.scala --- @@ -0,0 +1,433 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-4259][MLlib]: Add Power Iteration Clust...

2015-01-28 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/4254#discussion_r23728918 --- Diff: mllib/src/test/resources/log4j.mllib.properties --- @@ -0,0 +1,41 @@ +# --- End diff -- OK --- If your project is set up

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2015-01-15 Thread javadba
Github user javadba closed the pull request at: https://github.com/apache/spark/pull/1586 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-12-17 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-67383303 OK Michael thanks for the update. 2014-12-17 11:21 GMT-08:00 Michael Armbrust notificati...@github.com: Hey @javadba https://github.com/javadba, thanks

[GitHub] spark pull request: [Spark-4060] [MLlib] exposing special rdd func...

2014-10-28 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/2907#issuecomment-60875650 RE: use case. We are considering to use the treeAggregate function within the implementation of SpectralClustering. In addition it was noted

[GitHub] spark pull request: Merge pull request #1 from apache/master

2014-08-14 Thread javadba
GitHub user javadba opened a pull request: https://github.com/apache/spark/pull/1954 Merge pull request #1 from apache/master Syncing to upstream You can merge this pull request into a Git repository by running: $ git pull https://github.com/javadba/spark master Alternatively

[GitHub] spark pull request: Merge pull request #1 from apache/master

2014-08-14 Thread javadba
Github user javadba closed the pull request at: https://github.com/apache/spark/pull/1954 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: Merge pull request #1 from apache/master

2014-08-14 Thread javadba
GitHub user javadba opened a pull request: https://github.com/apache/spark/pull/1955 Merge pull request #1 from apache/master Syncing to upstream You can merge this pull request into a Git repository by running: $ git pull https://github.com/javadba/spark master Alternatively

[GitHub] spark pull request: Merge pull request #1 from apache/master

2014-08-14 Thread javadba
Github user javadba closed the pull request at: https://github.com/apache/spark/pull/1955 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: Merge pull request #1 from apache/master

2014-08-14 Thread javadba
GitHub user javadba reopened a pull request: https://github.com/apache/spark/pull/1955 Merge pull request #1 from apache/master Syncing to upstream You can merge this pull request into a Git repository by running: $ git pull https://github.com/javadba/spark master

[GitHub] spark pull request: Merge pull request #1 from apache/master

2014-08-14 Thread javadba
Github user javadba closed the pull request at: https://github.com/apache/spark/pull/1955 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-08 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51614247 I have been waiting here for @ueshin and @marmbrus to decide on next steps. Please be clear what are the next steps at this point. --- If your project is set up

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-08 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51640101 @marmbrusI am fine with delays on this - I just was unclear as to whether there some expectation on action on my part.Overall this is a minor enhancement

[GitHub] spark pull request: Fix tiny bug (likely copy and paste error) in ...

2014-08-05 Thread javadba
GitHub user javadba opened a pull request: https://github.com/apache/spark/pull/1792 Fix tiny bug (likely copy and paste error) in closing jdbc connection I inquired on dev mailing list about the motivation for checking the jdbc statement instead of the connection in the close

[GitHub] spark pull request: SPARK-2869 - Fix tiny bug in JdbcRdd for closi...

2014-08-05 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/1792#discussion_r15849947 --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala --- @@ -106,7 +106,7 @@ class JdbcRDD[T: ClassTag]( case e: Exception

[GitHub] spark pull request: SPARK-2638 MapOutputTracker concurrency improv...

2014-08-04 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1542#issuecomment-51022369 Thanks for commenting Josh. I will see about putting together something on this including solid testcases. ETA later in the coming week. --- If your project is set up

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-04 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51065193 Hi, For some reason the CORE module testing has ballooned in overall testing time: it took over 7.5 hours to run. There was one timeout error out of 736 tests

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-04 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51146419 @ueshinI repeatably verified that simply changing OCTET_LEN to OCTET_LENGTH ended up causing SOF. By repeatably I mean: Set the 'constant' val

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-04 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51149151 @ueshin I have git clone'd to a completely new area, and I reverted my last commit. git clone https://github.com/javadba/spark.git strlen2

[GitHub] spark pull request: SPARK-2712 - Add a small note to maven doc tha...

2014-08-03 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1615#issuecomment-50994967 Apologies for the long delay - it was induced by a moderately arduous process of learning git workflows/rebase-ing. --- If your project is set up for it, you can

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-03 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51016510 The following division test in HiveQueryTest is failing with StackOverflowError. I have no idea why given there is no obvious connection to the added code in this PR

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-03 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51016969 I have narrowed the problem down to the SQLParser. I will update when the precise cause is determined, likely within the hour. --- If your project is set up for it, you

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-03 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51017366 This is strange. The change that causes that SOF is just renaming OCTET/CHAR_LEN to OCTET/CHAR_LENGTH Working protected val CHAR_LEN = Keyword

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-03 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51018296 Surprising result here: the following change makes this work: StackOverflowError: protected val OCTET_LENGTH = Keyword(OCTET_LENGTH) Works

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-03 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51020150 The rename change was committed/pushed and the most germane tests pass. I am re-running full regression. One thing I have noticed already: the flume-sink external

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-50856746 @ueshin I mostly agree except: let us keep the length which can be used for non-strings e.g. length(12345678) = 8 Then since length does handle

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-50858453 @marmbrus OK fine with that. Then given the inputs from ueshin, we are presently at: len(gth)/char_length : take a single string argument and use

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-50858624 @marmbrusRE: Charlength for the expression - also fine, will do. (btw how did you highlight in the comment?) --- If your project is set up for it, you can reply

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-50923836 I am delayed in providing the next implementation, due to continuing investigation here. 1) The default encoding seems to have changed in jdk 6 (ISO-8859-1

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-50936508 Hi, I have updated the codebase to match our present level of discussions - and to include the merge from upstream. Takuya's test cases have been

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-50936636 grrr.. My push got some other extraneous changes of mine. I will fix that now. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-50946925 Cleaned up now. Re-ran the affected tests - and now re-running all tests. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-50947836 @ueshin Actually after re-checking it appears that my results match the ones you had placed in your comment. --- If your project is set up for it, you can reply

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/1586#discussion_r15726383 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -208,6 +211,96 @@ case class EndsWith(left

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/1586#discussion_r15726388 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -208,6 +211,96 @@ case class EndsWith(left

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/1586#discussion_r15726391 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -208,6 +211,96 @@ case class EndsWith(left

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-50951491 BTW I am seeing testing errors in core for MapOutputTracker involving OOME. I had to restart testing a few times already. This is not anything to do with the code

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-50951617 Ran the tests again and got same Error communicating with MapOutputTracker but in a different test: this time: ImplicitOrderingSuite: - basic

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-50951779 I ran another time and get an OOME this time. ImplicitOrderingSuite: *** RUN ABORTED *** java.lang.OutOfMemoryError: unable to create

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/1586#discussion_r15726702 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -208,6 +211,96 @@ case class EndsWith(left

[GitHub] spark pull request: SPARK-2686 Add Length and Strlen support to Sp...

2014-08-01 Thread javadba
Github user javadba commented on a diff in the pull request: https://github.com/apache/spark/pull/1586#discussion_r15726780 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -208,6 +211,96 @@ case class EndsWith(left

  1   2   >