[GitHub] spark issue #16083: [SPARK-18097][SQL] Add exception catch to handle corrupt...

2017-02-10 Thread jayadevanmurali
Github user jayadevanmurali commented on the issue: https://github.com/apache/spark/pull/16083 Hi @HyukjinKwon , I tried to corrupt the metadata by editing files under spark/warehouse directory. But it is not working. Do you have any idea to corrupt metadata manually. Thanks

[GitHub] spark issue #16635: [SPARK-19059] [SQL] Unable to retrieve data from parquet...

2017-01-18 Thread jayadevanmurali
Github user jayadevanmurali commented on the issue: https://github.com/apache/spark/pull/16635 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16635: [SPARK-19059] [SQL] Unable to retrieve data from parquet...

2017-01-18 Thread jayadevanmurali
Github user jayadevanmurali commented on the issue: https://github.com/apache/spark/pull/16635 @cloud-fan Incorporated code review comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #16635: [SPARK-19059] [SQL] Unable to retrieve data from ...

2017-01-18 Thread jayadevanmurali
Github user jayadevanmurali commented on a diff in the pull request: https://github.com/apache/spark/pull/16635#discussion_r96790387 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2513,4 +2513,18 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request #16635: [SPARK-19059] [SQL] Unable to retrieve data from ...

2017-01-18 Thread jayadevanmurali
Github user jayadevanmurali commented on a diff in the pull request: https://github.com/apache/spark/pull/16635#discussion_r96790264 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2513,4 +2513,18 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request #16635: [SPARK-19059] [SQL] Unable to retrieve data from ...

2017-01-18 Thread jayadevanmurali
Github user jayadevanmurali commented on a diff in the pull request: https://github.com/apache/spark/pull/16635#discussion_r96790238 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2513,4 +2513,18 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark issue #16635: [SPARK-19059] [SQL] Unable to retrieve data from parquet...

2017-01-18 Thread jayadevanmurali
Github user jayadevanmurali commented on the issue: https://github.com/apache/spark/pull/16635 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16635: [SPARK-19059] [SQL] Unable to retrieve data from parquet...

2017-01-18 Thread jayadevanmurali
Github user jayadevanmurali commented on the issue: https://github.com/apache/spark/pull/16635 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #16635: [SPARK-19059] [SQL] Unable to retrieve data from ...

2017-01-18 Thread jayadevanmurali
GitHub user jayadevanmurali opened a pull request: https://github.com/apache/spark/pull/16635 [SPARK-19059] [SQL] Unable to retrieve data from parquet table whose name startswith underscore ## What changes were proposed in this pull request? The initial shouldFilterOut() method

[GitHub] spark pull request #16083: [SPARK-18097][SQL] Add exception catch to handle ...

2016-11-30 Thread jayadevanmurali
Github user jayadevanmurali commented on a diff in the pull request: https://github.com/apache/spark/pull/16083#discussion_r90372901 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -189,14 +189,18 @@ case class DropTableCommand

[GitHub] spark pull request #16083: [SPARK-18097][SQL] Add exception catch to handle ...

2016-11-30 Thread jayadevanmurali
GitHub user jayadevanmurali opened a pull request: https://github.com/apache/spark/pull/16083 [SPARK-18097][SQL] Add exception catch to handle corrupted metadata scenario while dropping the table ## What changes were proposed in this pull request? Add exception catch to handle

[GitHub] spark pull request #15613: merge to master

2016-10-24 Thread jayadevanmurali
Github user jayadevanmurali closed the pull request at: https://github.com/apache/spark/pull/15613 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #15613: merge to master

2016-10-24 Thread jayadevanmurali
GitHub user jayadevanmurali opened a pull request: https://github.com/apache/spark/pull/15613 merge to master ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain

[GitHub] spark pull request: [SPARK-12941][SQL][MASTER] Spark-SQL JDBC Orac...

2016-02-25 Thread jayadevanmurali
Github user jayadevanmurali commented on a diff in the pull request: https://github.com/apache/spark/pull/11306#discussion_r54210286 --- Diff: docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala --- @@ -0,0 +1,80

[GitHub] spark pull request: [SPARK-12941][SQL][MASTER] Spark-SQL JDBC Orac...

2016-02-24 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/11306#issuecomment-188159399 @SparkQA Seems to be the build failed due kmeans error. I think this is not related to this PR. Could you please check --- If your project is set up

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-182760091 @hvanhovell Thanks for the quick fix, I think we can retest this PR now. What you think ? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-182884877 @hvanhovell I think, you may comment "ok to test" for triggering the build --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-182942391 Ok. I think something missing in our test request, lot test started now which all requested after our PR --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-182964460 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-10 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-182452861 @hvanhovell Why this much delay for test ? Anything required from my side ? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-10 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-182461950 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-10 Thread jayadevanmurali
Github user jayadevanmurali commented on a diff in the pull request: https://github.com/apache/spark/pull/11051#discussion_r52527852 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1291,4 +1291,16 @@ class DataFrameSuite extends QueryTest

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-10 Thread jayadevanmurali
Github user jayadevanmurali commented on a diff in the pull request: https://github.com/apache/spark/pull/11051#discussion_r52526270 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1291,4 +1291,16 @@ class DataFrameSuite extends QueryTest

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-09 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-181957359 @SparkQA Could you please retest the changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-08 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-181266259 Thanks @hvanhovell for this info --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-08 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-181260259 @SparkQA Could you please do a test again @hvanhovell @davies Incorporated review comments in test case. Could you please review the same

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-08 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-181269499 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-08 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-181265819 @hvanhovell I will make that change now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-08 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-181701118 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-04 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/10983#issuecomment-179886072 Created new pr with latest code for this issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-04 Thread jayadevanmurali
Github user jayadevanmurali closed the pull request at: https://github.com/apache/spark/pull/10983 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-04 Thread jayadevanmurali
Github user jayadevanmurali commented on a diff in the pull request: https://github.com/apache/spark/pull/11051#discussion_r51973903 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1291,4 +1291,14 @@ class DataFrameSuite extends QueryTest

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-04 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-179964614 @SparkQA Could you please test again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-03 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/10983#issuecomment-179270485 @hvanhovell I have created a new PR for this issue with latest code. https://github.com/apache/spark/pull/11051. Could you please review the same. --- If your

[GitHub] spark pull request: Merge pull request #1 from apache/master

2016-02-03 Thread jayadevanmurali
Github user jayadevanmurali closed the pull request at: https://github.com/apache/spark/pull/11049 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: Merge pull request #1 from apache/master

2016-02-03 Thread jayadevanmurali
GitHub user jayadevanmurali opened a pull request: https://github.com/apache/spark/pull/11049 Merge pull request #1 from apache/master Update from original You can merge this pull request into a Git repository by running: $ git pull https://github.com/jayadevanmurali/spark

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-03 Thread jayadevanmurali
GitHub user jayadevanmurali opened a pull request: https://github.com/apache/spark/pull/11051 [SPARK-12982][SQL] Add table name validation in temp table registration Add the table name validation at the temp table creation You can merge this pull request into a Git repository

[GitHub] spark pull request: Merge pull request #1 from apache/master

2016-02-03 Thread jayadevanmurali
Github user jayadevanmurali closed the pull request at: https://github.com/apache/spark/pull/11049 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: Merge pull request #1 from apache/master

2016-02-03 Thread jayadevanmurali
GitHub user jayadevanmurali reopened a pull request: https://github.com/apache/spark/pull/11049 Merge pull request #1 from apache/master Update from original You can merge this pull request into a Git repository by running: $ git pull https://github.com/jayadevanmurali/spark

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-03 Thread jayadevanmurali
Github user jayadevanmurali commented on a diff in the pull request: https://github.com/apache/spark/pull/11051#discussion_r51762232 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1291,4 +1291,14 @@ class DataFrameSuite extends QueryTest

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-03 Thread jayadevanmurali
Github user jayadevanmurali commented on a diff in the pull request: https://github.com/apache/spark/pull/11051#discussion_r51766868 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1291,4 +1291,14 @@ class DataFrameSuite extends QueryTest

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-03 Thread jayadevanmurali
Github user jayadevanmurali commented on a diff in the pull request: https://github.com/apache/spark/pull/11051#discussion_r51766777 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1291,4 +1291,14 @@ class DataFrameSuite extends QueryTest

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-01 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/10983#issuecomment-177969053 @hvanhovell, Yea I tried to merge my branch (https://github.com/jayadevanmurali/spark/tree/branch-0.1-SPARK-SPARK-12982) with apache spark master. But I cant

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-01 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/10983#issuecomment-177942271 @hvanhovell the current pull request is based on an outdated code. So I would like to create a new pull request on the latest code. Hope that is fine

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-01-31 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/10983#issuecomment-177447251 Thanks @hvanhovell, Working on test case --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-01-31 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/10983#issuecomment-177540750 @hvanhovell yes sure, no problem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-01-30 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/10983#issuecomment-177109715 @hvanhovell I was able to replicate this in spark 2.0.0. Steps ayadevan@Satellite-L640:~/spark$ ./bin/spark-shell Using Spark's default

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-01-30 Thread jayadevanmurali
Github user jayadevanmurali commented on a diff in the pull request: https://github.com/apache/spark/pull/10983#discussion_r51342667 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -747,7 +747,7 @@ class SQLContext private[sql]( * only during

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-01-30 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/10983#issuecomment-177392588 Thanks @hvanhovell , Got your point. I updated my code and repeat the steps. I was able to replicate this. Please check the steps jayadevan@Satellite

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-01-29 Thread jayadevanmurali
GitHub user jayadevanmurali opened a pull request: https://github.com/apache/spark/pull/10983 [SPARK-12982][SQL] Add table name validation in temp table registration Add the table name validation at the temp table creation You can merge this pull request into a Git repository

[GitHub] spark pull request: [SPARK-11137][Streaming] Make StreamingContext...

2016-01-20 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/10807#issuecomment-173197159 @srowen Thanks for the detailed comment. Can you merge the changes to master branch --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: Update StreamingContext.scala [SPARK-11137]

2016-01-18 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/10807#issuecomment-172595828 Exceptions are handled for each of the operations in the stop method, so that any exceptions does not abort rest of the statements --- If your project is set

[GitHub] spark pull request: [SPARK-11137][Streaming] Make StreamingContext...

2016-01-18 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/10807#issuecomment-172609322 @srowen sure and updated the the title --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Update StreamingContext.scala [SPARK-11137]

2016-01-18 Thread jayadevanmurali
GitHub user jayadevanmurali opened a pull request: https://github.com/apache/spark/pull/10807 Update StreamingContext.scala [SPARK-11137] Make StreamingContext.stop() exception-safe You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] spark pull request: [SPARK-12438][SQL] hiveContext.table() throws ...

2016-01-01 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/10529#issuecomment-168314723 I think, there would be a reference update in Analyzer.scala as we discussed @thomastechs --- If your project is set up for it, you can reply to this email