Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19659
No, I'm not working on this one, the feature seems to lack any real
interest. We can close it, if you like
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19671
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19671#discussion_r163477899
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1322,33 +1322,55 @@ class BlockManagerSuite extends SparkFunSuite
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19671
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19671#discussion_r163476983
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1322,33 +1322,55 @@ class BlockManagerSuite extends SparkFunSuite
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19671#discussion_r163298390
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1322,33 +1322,55 @@ class BlockManagerSuite extends SparkFunSuite
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19671#discussion_r163297550
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1322,33 +1322,55 @@ class BlockManagerSuite extends SparkFunSuite
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19879
Fixed the style check problems of the documentation comments. Unfortunately
I did not find a way to make Jenkins re-run the tests
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19879
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19879
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19879
Jenkins, re-test this, please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19879
By the way, are these contributions valuable, or should the focus be 2.12?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19879
This one has a "Major" priority; but otherwise yes, it should be resolved
in Scala 2.12 version.
---
-
To unsubscri
GitHub user mpetruska opened a pull request:
https://github.com/apache/spark/pull/19879
[SPARK-20706][SPARK-SHELL] Spark-shell not overriding method/variable
definition
## What changes were proposed in this pull request?
[SPARK-20706](https://issues.apache.org/jira/browse
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19846
@HyukjinKwon : Hi, yes: this is the "retrofitting" of the original bug fix,
which never made it to Scala 2.11. Instead of copy-pasting the original
discussion, let me link the [or
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19846
@srowen Yes, exactly. Tried to minimize the risks of any problems caused by
this change.
---
-
To unsubscribe, e-mail
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19846
Sorry, could not refactor the code better; since it makes heavy use of
path-dependent types.
---
-
To unsubscribe, e-mail
GitHub user mpetruska opened a pull request:
https://github.com/apache/spark/pull/19846
[SPARK-22393][SPARK-SHELL] spark-shell can't find imported types in class
constructors, extends clause
## What changes were proposed in this pull request?
[SPARK-22393](https
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19791#discussion_r152504268
--- Diff: repl/src/test/scala/org/apache/spark/repl/ReplSuite.scala ---
@@ -217,4 +218,13 @@ class ReplSuite extends SparkFunSuite
GitHub user mpetruska opened a pull request:
https://github.com/apache/spark/pull/19791
[SPARK-22572] [Spark shell] spark-shell does not re-initialize on :replay
## What changes were proposed in this pull request?
Ticket: [SPARK-22572](https://issues.apache.org/jira/browse
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19671
@jiangxb1987 : Well, I ran the `BlockManagerSuite` with `testOnly` and did
not encounter any failures, passed 10 out of 10. Then, as a benchmark, I
checked out the version without my changes
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19671
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19671#discussion_r151371494
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1322,33 +1322,55 @@ class BlockManagerSuite extends SparkFunSuite
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19744
Closing in favour of #19470.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user mpetruska closed the pull request at:
https://github.com/apache/spark/pull/19744
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19744#discussion_r151092639
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala ---
@@ -278,4 +286,93 @@ class OrcSourceSuite extends OrcSuite
GitHub user mpetruska opened a pull request:
https://github.com/apache/spark/pull/19744
[SPARK-22267][SQL] [WIP] Spark SQL incorrectly reads ORC file when column
order is different
## What changes were proposed in this pull request?
Ticket: [SPARK-22267](https
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19659
Also, will this work in SparkR, or do I need to add some code/configuration
to expose the functionality to [R
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19659
@holdenk : Thanks for the review.
Fixed/addressed your comments, can you please have another look?
Also I'd like some help with regards to the `@Since` attributes; how should
I fill them
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19659#discussion_r149696337
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/extensions/seq/package.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19659#discussion_r149690477
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/NGram.scala ---
@@ -42,11 +42,22 @@ class NGram @Since("1.5.0") (@Since("1.5.0&
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19659#discussion_r149600715
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/extensions/seq/package.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
GitHub user mpetruska opened a pull request:
https://github.com/apache/spark/pull/19671
[SPARK-22297][CORE TESTS] Flaky test: BlockManagerSuite "Shuffle
registration timeout and maxAttempts conf"
## What changes were proposed in this pull request?
[Tic
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19659#discussion_r148930762
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/NGram.scala ---
@@ -57,10 +68,22 @@ class NGram @Since("1.5.0") (@Since("1.5.0&
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19659#discussion_r148930750
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/extensions/seq/package.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19659#discussion_r148930766
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/NGram.scala ---
@@ -57,10 +68,22 @@ class NGram @Since("1.5.0") (@Since("1.5.0&
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19659#discussion_r148930761
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/NGram.scala ---
@@ -42,11 +42,22 @@ class NGram @Since("1.5.0") (@Since("1.5.0&
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19659#discussion_r148930753
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/extensions/seq/package.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19659#discussion_r148930742
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/extensions/seq/package.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
GitHub user mpetruska opened a pull request:
https://github.com/apache/spark/pull/19659
[SPARK-19668][ML] Multiple NGram sizes
## What changes were proposed in this pull request?
[Jira ticket](https://issues.apache.org/jira/browse/SPARK-19668):
- implements extraction
40 matches
Mail list logo
