[GitHub] spark issue #21316: [SPARK-20538][SQL] Wrap Dataset.reduce with withNewRddEx...
Github user sohama4 commented on the issue: https://github.com/apache/spark/pull/21316 @kiszk @jaceklaskowski @rxin @zsxwing @maropu can we move forward here? Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21316: [SPARK-20538][SQL] Wrap Dataset.reduce with withN...
Github user sohama4 commented on a diff in the pull request: https://github.com/apache/spark/pull/21316#discussion_r188143976 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1607,7 +1607,9 @@ class Dataset[T] private[sql]( */ @Experimental @InterfaceStability.Evolving - def reduce(func: (T, T) => T): T = rdd.reduce(func) + def reduce(func: (T, T) => T): T = withNewExecutionId { --- End diff -- Thanks, that makes sense when I looked at the code for `foreach` and `foreachPartition`; I put up a new version with this change. It however wasn't clear immediately how the new function `withNewRDDExecutionId` would be beneficial over `withNewExecutionId`, can you elaborate a little when you get the chance? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21316: [SPARK-20538][SQL] Wrap Dataset.reduce with withNewExecu...
Github user sohama4 commented on the issue: https://github.com/apache/spark/pull/21316 Thanks for the approval @jaceklaskowski! Can you leave a comment so that Jenkins can get testing underway? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21316: [SPARK-20538][SQL] Wrap Dataset.reduce with withN...
Github user sohama4 commented on a diff in the pull request: https://github.com/apache/spark/pull/21316#discussion_r187832727 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1607,7 +1607,9 @@ class Dataset[T] private[sql]( */ @Experimental @InterfaceStability.Evolving - def reduce(func: (T, T) => T): T = rdd.reduce(func) + def reduce(func: (T, T) => T): T = withNewExecutionId { --- End diff -- I believe so. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21316: [SPARK-20538][SQL] Wrap Dataset.reduce with withNewExecu...
Github user sohama4 commented on the issue: https://github.com/apache/spark/pull/21316 @vanzin @maropu @gatorsmile @jaceklaskowski can someone take a look at this? I'd appreciate it! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21316: [SPARK-20538][SQL] Wrap Dataset.reduce with withN...
GitHub user sohama4 opened a pull request: https://github.com/apache/spark/pull/21316 [SPARK-20538][SQL] Wrap Dataset.reduce with withNewExecutionId. ## What changes were proposed in this pull request? Wrap Dataset.reduce with `withNewExecutionId`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sohama4/spark dataset_reduce_withexecutionid Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/21316.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21316 commit 9b507bc4312e0cadd84a6436a0311e739ae22d18 Author: Soham Aurangabadkar <sohama4@...> Date: 2018-05-13T22:19:05Z Wrap Dataset.reduce with withNewExecutionId. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org