[GitHub] [spark] dongjoon-hyun commented on issue #25741: [SPARK-29032][CORE] Simplify Prometheus support by adding PrometheusServlet/Resource
dongjoon-hyun commented on issue #25741: [SPARK-29032][CORE] Simplify Prometheus support by adding PrometheusServlet/Resource URL: https://github.com/apache/spark/pull/25741#issuecomment-530646672 Sorry for this change~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #25741: [SPARK-29032][CORE] Simplify Prometheus support by adding PrometheusServlet/Resource
dongjoon-hyun commented on issue #25741: [SPARK-29032][CORE] Simplify Prometheus support by adding PrometheusServlet/Resource URL: https://github.com/apache/spark/pull/25741#issuecomment-530646516 Although this is not a long PR, but I decided to split this into two PRs because `PrometheusResource` is a new feature aligned with SPARK-23429 (which is added at 3.0.0). That will make the review easier. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #25741: [SPARK-29032][CORE] Simplify Prometheus support by adding PrometheusServlet
dongjoon-hyun commented on issue #25741: [SPARK-29032][CORE] Simplify Prometheus support by adding PrometheusServlet URL: https://github.com/apache/spark/pull/25741#issuecomment-529840219 Oops. I missed the task metrics. I'll update this PR later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #25741: [SPARK-29032][CORE] Simplify Prometheus support by adding PrometheusServlet
dongjoon-hyun commented on issue #25741: [SPARK-29032][CORE] Simplify Prometheus support by adding PrometheusServlet URL: https://github.com/apache/spark/pull/25741#issuecomment-529817472 Also, cc @skonto . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #25741: [SPARK-29032][CORE] Simplify Prometheus support by adding PrometheusServlet
dongjoon-hyun commented on issue #25741: [SPARK-29032][CORE] Simplify Prometheus support by adding PrometheusServlet URL: https://github.com/apache/spark/pull/25741#issuecomment-529814420 Hi, @vanzin and @srowen . Could you review this please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org