iRakson commented on pull request #26901:
URL: https://github.com/apache/spark/pull/26901#issuecomment-643876875
@dongjoon-hyun Its behaviour is pretty confusing. But yeah, if this is
breaking branch again then we should not keep it. Yes, this patch failed twice
so we must move on.
iRakson commented on pull request #26901:
URL: https://github.com/apache/spark/pull/26901#issuecomment-643816792
#28254 has been closed.
This is an automated message from the Apache Git Service.
To respond to the message,
iRakson commented on pull request #26901:
URL: https://github.com/apache/spark/pull/26901#issuecomment-643815823
> Hi, @iRakson . So, this is your final decision and are you going to close
#28254 ?
> This PR looks like to be reverted into the original patch. In that case,
we don't need
iRakson commented on pull request #26901:
URL: https://github.com/apache/spark/pull/26901#issuecomment-643811881
@dongjoon-hyun @vanzin Can we get this in 2.4 ?
I think now this is fine. It should not break the code.
I have already tested this multiple times.
iRakson commented on pull request #26901:
URL: https://github.com/apache/spark/pull/26901#issuecomment-643065456
cc @srowen
This is an automated message from the Apache Git Service.
To respond to the message, please log on
iRakson commented on pull request #26901:
URL: https://github.com/apache/spark/pull/26901#issuecomment-642632099
@dongjoon-hyun @vanzin I have tested this a couple of times, older approach
of adding shutdownhook is working fine. Last failure is unrelated to this. Also
about the other
iRakson commented on pull request #26901:
URL: https://github.com/apache/spark/pull/26901#issuecomment-642627305
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
iRakson commented on pull request #26901:
URL: https://github.com/apache/spark/pull/26901#issuecomment-642560682
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
iRakson commented on pull request #26901:
URL: https://github.com/apache/spark/pull/26901#issuecomment-642456239
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
